Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-28
15:15:03 yikun and I'm going to complete it in tomorrow, : )
15:15:59 yikun now time for me to back home, hah, 11:15 PM, :(
15:16:49 yikun have a good day! :) and have a good night for me. :D
15:17:02 mriedem yikun: np, ttyl
15:22:45 openstackgerrit Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
15:24:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Update xenapi_disable_agent config option usage in docs https://review.openstack.org/578848
15:25:29 efried stephenfin: have a look at https://review.openstack.org/#/c/534382/ if you please. If I'm full of malarkey, let me know and I'll flip to +2.
15:26:33 stephenfin efried: Looks good. Lemme try it
15:26:46 efried k
15:32:34 edmondsw efried looking
15:35:08 stephenfin efried: Yeah, Can't
15:35:15 efried stephenfin: Boo, how come?
15:35:20 stephenfin *Yeah, can't do that as that only works for explicitly defined things
15:35:29 stephenfin Not implicitly defined
15:35:52 stephenfin So I could manually set envdir for the environments I'm inheriting from but then what's the point
15:36:43 efried I see. I mean, it would still have the same dedup-ish effect. You'd only be defining it for what, three, four envs?
15:36:56 efried and then sharing it for the rest.
15:37:31 stephenfin So defining '[testenv] envdir' and overriding where I need it?
15:38:56 efried stephenfin: Oh, I thought like defining envdir in [testenv:{venv|doc|py27|py35}], not overriding it anywhere, and then using the suggested syntax wherever you want to share it.
15:39:23 efried (which is overriding, I suppose - not sure if we're talking the same terms here)
15:40:40 stephenfin Is there any difference, in that case? Those unclear attributes are still going to be there, there'll just be less of them
15:40:55 stephenfin Unclear attributes being e.g. 'envdir = {toxworkdir}/venv'
15:41:24 efried stephenfin: Well, except {toxworkdir}/venv will be defined in the [testenv:venv] env, which seems pretty clear.
15:41:55 efried anyway, you're right, this certainly reduces the usefulness of the suggestion. So I'm fine if you want to do it or skip it.
15:42:25 efried stephenfin: were you wanting to respin to add those two missed ones anyway?
15:42:30 stephenfin I might skip it, if that's OK. It's not any shorter and, IMO, is probably less clear
15:42:37 stephenfin Yup, working at that atm
15:42:37 efried okay
15:42:40 efried k
15:42:50 edmondsw efried I added a couple comments on https://review.openstack.org/#/c/578840 that you might want to squeeze into that, but could also be a follow-on
15:43:00 edmondsw burgerk would be a good source for information / reviewer
15:44:50 openstackgerrit Eric Fried proposed openstack/nova master: Mention PowerVM support of config drive https://review.openstack.org/578840
15:45:20 efried added him.
15:48:07 mdbooth mriedem: This is a WIP, but you had a (now abandoned) patch up for this bug a couple of years ago: https://review.openstack.org/#/c/578846/
15:48:12 mdbooth cfriesen: You killed it :)
15:53:40 mriedem mdbooth: you kind of left me hanging here https://review.openstack.org/#/c/572790/
15:53:43 mriedem so you're in my doghouse
15:54:21 mriedem and yeah looks like my failed attempt was https://review.openstack.org/#/c/288109/
15:57:54 mdbooth mriedem: Sorry, thought we were good on the other patch. I'll pick it up again.
16:03:02 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646
16:03:03 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647
16:03:04 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819
16:03:05 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Transactionally update allocations (v1.13) https://review.openstack.org/546674
16:03:06 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675
16:03:07 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043
16:03:08 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
16:03:27 mriedem gibi: i think the bottom of that series is good now ^
16:03:34 mriedem i just cleaned up some leftovers from the command split
16:08:56 efried gibi: IIRC, the func test failure here https://review.openstack.org/#/c/560317/17/nova/tests/functional/libvirt/test_report_cpu_traits.py looks similar to a race you debugged... somewhere else. Do you remember offhand what the fix was?
16:15:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree https://review.openstack.org/578878
16:15:57 mriedem would be nice to get this in so we don't burn nodes on docs-only changes ^
16:18:34 stephenfin mriedem: Any idea is zuul supports YAML roles/anchors, like we use for the API samples (I think)?
16:18:40 stephenfin https://anil.io/blog/symfony/yaml/using-variables-in-yaml-files/
16:20:03 mriedem no idea
16:20:10 mriedem to define irrelevant-files?
16:20:15 stephenfin aye
16:20:22 mriedem ask in -infra
16:20:26 stephenfin Will do
16:32:13 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Reuse envdirs https://review.openstack.org/534382
16:32:19 stephenfin efried: ^
16:32:26 efried ...
16:33:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree https://review.openstack.org/578878
16:33:50 mriedem stephenfin: ^ mostly copied from how i see we do that in api-ref parameters.yaml
16:34:01 stephenfin ack
16:34:32 mriedem maybe i should split that out into it's own change...
16:34:32 efried stephenfin: +2, added notes for future me.
16:34:42 stephenfin probably not a bad idea
16:34:53 stephenfin unless you're backporting, in which case meh
16:34:54 mriedem zuul already barfed on it
16:34:58 mriedem i am backporting
16:35:29 stephenfin Hmm, wonder if zuul has an local linter
16:35:41 mriedem no i think i just copied an example incorrectly
16:36:23 mriedem so i think i'm going to revert to PS1 and then do the dedupe in a non-backportable follow up
16:36:29 stephenfin ack
16:37:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree https://review.openstack.org/578878
16:42:04 stephenfin exit
16:42:10 stephenfin whoops
16:42:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Define common variables for irrelevant-files https://review.openstack.org/578882
16:43:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Define common variables for irrelevant-files https://review.openstack.org/578882
17:00:00 efried stephenfin: Where can I find a real os_vif plugin?
17:01:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove file injection from config drive sample docs https://review.openstack.org/578888
17:04:08 openstackgerrit Merged openstack/os-traits master: Add COMPUTE_TRUSTED_CERTS trait https://review.openstack.org/576595
17:08:57 efried mriedem: Do you know where I can find a real os_vif plugin?
17:09:47 mriedem efried: yeah
17:09:58 openstackgerrit Matt Riedemann proposed openstack/nova master: More config drive docs updates https://review.openstack.org/578890
17:10:06 mriedem https://github.com/Juniper/contrail-nova-vif-driver
17:10:08 mriedem efried: ^
17:10:17 efried mriedem: Thanks
17:15:17 efried jangutter: Still lurking?
17:17:18 jangutter efried: yaaaaaas.
17:17:51 efried jangutter: I'm looking at the Juniper contrail os-vif plugin and wanted to confirm what I think I'm seeing.
17:18:14 jangutter efried: actually, the real "reference" plugins are in the os-vif repo for vif_plug_ovs
17:18:27 jangutter efried : and linuxbridge I think.
17:18:51 efried jangutter: First of all, I'm not particularly well-versed on libvirt. But IIUC, plugging a vif entails 1) creating some kind of device thingy on the host, and then 2) modifying the instance's XML to make it show up in the instance. Do I have this right?
17:18:56 jangutter efried: go ahead. it really is as bad as you think.
17:20:11 jangutter efried: the ones I've seen work like this: the xml for libvirt sometimes goes above and beyond. Spawining the VM (which creates the thingy) and plugging the thingy into another thingy in one fell swoop.
17:20:12 efried jangutter: Well, my question is more generic ^
17:20:57 jangutter efried: the trick is, only the very first few bridges were built like that, then people started building their own.
17:21:38 jangutter efried: which means that, in libvirt you can _also_ say, spawn the VM and leave the thingy dangling, then, call the os-vif plugin to plug the thingy into the thingy.
17:22:05 jangutter efried: and I'm not 100% sure of the order. in theory the order should be independent.

Earlier   Later