Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-26
21:37:44 mriedem urlparse thinks they are invalid ipv6 urls
21:39:28 mriedem this is the thing we use in map_cell0 https://github.com/zzzeek/sqlalchemy/blob/15ea75981305fdad8286f6803671b864ccda13f2/lib/sqlalchemy/engine/url.py#L203
21:53:25 openstackgerrit Dan Smith proposed openstack/nova master: Allow templated cell_mapping URLs https://review.openstack.org/578163
21:53:36 dansmith I think I got all the actionable feedback ^ but I gotta run off for a bit now
21:57:21 mriedem just noticed something weird, but surely i can't be the first...
21:57:29 mriedem we move instance groups and instance group members from the cell to api db yeah
21:57:47 mriedem and when we delete an instance, the instance_destroy db api code used to also remove the instance group member table entry for the deleted instance
21:57:59 melwitt yeah instance group stuff moved to api db
21:58:03 mriedem we don't have anything like that with deleting an instance, from what i can tell, when deleting an instance and the members are now in the api db
21:58:37 mriedem so if i create an instance in a group, then delete the instance, and show members on the group, will it show the deleted instance uuid?
21:58:57 melwitt hm
21:59:13 mriedem ah _get_not_deleted
21:59:36 mriedem that seems pretty inefficient
22:00:05 mriedem but,
22:00:20 mriedem if you delete the group membership in the api when deleting the instance, if we fail to delete the instance in the cell then we're hosed
22:00:28 mriedem similar to deleting request specs and instance mappings
22:00:45 mriedem seems we should clean up old instance group members during archive like we do for mappings and request specs
22:01:15 melwitt ah, yeah
22:01:45 mriedem although _get_not_deleted also relies on instance mappings, so if we're correctly deleting instance mappings for deleted / purged instances, maybe it's not a problem
22:01:57 melwitt I was trying to think why we didn't go ahead and delete the group member at instance_destroy time but it must be like you said
22:04:04 mriedem looks like we'd add something here if we wanted to https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L553
22:05:20 mriedem this is where the api does the filtering https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_groups.py#L48
22:05:54 mriedem so, we could potentially avoid passing more uuids into the cell db query https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_groups.py#L75
22:09:40 openstack Launchpad bug 1778804 in OpenStack Compute (nova) "instance_group_member records not purged from nova_api DB for deleted instances" [Low,Triaged]
22:09:40 mriedem ah well, can track it as low priority https://bugs.launchpad.net/nova/+bug/1778804
22:21:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused DB API instance_group_delete method https://review.openstack.org/578223
#openstack-nova - 2018-06-27
00:08:18 openstackgerrit karim proposed openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498
00:39:45 openstackgerrit karim proposed openstack/nova master: Update scheduler to use image-traits https://review.openstack.org/576054
02:12:09 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505
02:55:32 openstackgerrit Merged openstack/nova master: [placement] Add test demonstrating bug 1778743 https://review.openstack.org/578126
02:55:33 openstack bug 1778743 in OpenStack Compute (nova) "When POSTing to /allocations with multiple consumers it is possible violate inventory capacity constraints" [Medium,In progress] https://launchpad.net/bugs/1778743 - Assigned to Chris Dent (cdent)
03:01:00 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542
03:08:36 deepak_mourya efried: Hi, what should be the good string to use here according to you https://review.openstack.org/#/c/577726/6/nova/api/openstack/placement/handlers/resource_provider.py
03:09:11 efried deepak_mourya: Yeah, sorry, I didn't leave a lot of detail on that. Are you familiar with the framework for defining the error codes?
03:10:23 deepak_mourya efried: It's ok, any example for the same in the nova before ?
03:10:32 efried deepak_mourya: You want to define it in nova/api/openstack/placement/errors.py, and then look at how the other consts therein are being used.
03:10:46 efried deepak_mourya: But you can do that in a followon patch. The -1 is just for the failing functional test.
03:16:43 deepak_mourya CONCURRENT_UPDATE = 'placement.concurrent_update'
03:16:43 deepak_mourya INVENTORY_INUSE = 'placement.inventory.inuse'
03:16:43 deepak_mourya DEFAULT = 'placement.undefined_code'
03:16:43 deepak_mourya ok so what exactly these things are
03:16:43 deepak_mourya efried: ok, i didn't understand much from here nova/api/openstack/placement/errors.py
03:17:02 deepak_mourya Do i need to create another consts for the same?
03:17:40 efried deepak_mourya: Yes. It's explained in this spec: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/placement-api-error-handling.html
03:18:01 efried deepak_mourya: But again, don't try to do it in this same patch. Submit a separate one on top of this one.
03:19:17 deepak_mourya efried: ok i will go through with it first, thanks for the reply and help
03:19:54 efried deepak_mourya: Thanks for the fix!
03:29:32 openstackgerrit xulei proposed openstack/nova master: Disable limits if force_hosts or force_nodes is set https://review.openstack.org/576693
03:52:28 openstackgerrit Yikun Jiang (Kero) proposed openstack/python-novaclient master: WIP: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/578261
04:27:07 gmann melwitt: can you approve this BP (queens continue work). I have started the coding on this and should be able to finish soon- https://blueprints.launchpad.net/nova/+spec/api-extensions-merge-rocky
04:27:48 gmann melwitt: do not want to bring this for reviewer untill BP is approved.
04:59:37 openstackgerrit Merged openstack/nova master: [placement] Demonstrate bug in consumer generation handling https://review.openstack.org/577914
05:59:47 gmann nova api office hour time
06:00:22 gmann #startmeeting nova api
06:00:23 openstack Meeting started Wed Jun 27 06:00:22 2018 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot.
06:00:24 openstack Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
06:00:27 openstack The meeting name has been set to 'nova_api'
06:00:31 gmann who all here?
06:01:03 gmann might be many china folks are in linuxcon as alex_xu mentioned
06:02:06 gmann just checking if someone here so we can start the API things and from next week we can have office hour with more people
06:09:26 gmann ok seems no one available today so we can skip today. i will send the update i collected from bugs etc over email.
06:09:38 gmann #endmeeting
06:09:40 openstack Meeting ended Wed Jun 27 06:09:38 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
06:09:41 openstack Minutes: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-06-27-06.00.html
06:09:42 openstack Minutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-06-27-06.00.txt
06:09:43 openstack Log: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-06-27-06.00.log.html
06:28:09 openstackgerrit jiang wei proposed openstack/nova master: Add action initiator attribute to the instance payload https://review.openstack.org/536243
06:50:54 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019
06:53:27 openstackgerrit Merged openstack/nova master: Remove mox in test_conductor.py (2) https://review.openstack.org/564659
07:20:57 openstackgerrit Deepak Mourya proposed openstack/nova master: Handle CannotDeleteParentResourceProvider to 409 Conflict https://review.openstack.org/577726
08:03:53 tssurya good morning gibi: regarding the handling the cell down spec, I wanted to know your take on these concerns you specified (https://review.openstack.org/#/c/557369/4/specs/rocky/approved/handling-down-cell.rst@85): since we are anyways going for a new microversion, I was thinking if its better to just skip all these keys totally or put up 'UNKNOWN' values for those keys. do you have a strong take?
08:44:08 gibi tssurya: I prefer not including the keys we dont now the value at all as that is a bit harder to missunderstood than a field with some unknown value. I don't have this as a strong take as the microversion bump can be used to precisely define the behavior anyhow.
08:49:44 tssurya gibi: yea thanks,
08:50:01 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for config drive extension https://review.openstack.org/578329
09:03:02 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for keypair extension https://review.openstack.org/578332
09:16:32 openstackgerrit Deepak Mourya proposed openstack/nova master: Handle CannotDeleteParentResourceProvider to 409 Conflict https://review.openstack.org/577726
09:19:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for multiple create extension https://review.openstack.org/578338
09:25:30 openstackgerrit Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/578261
09:34:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for scheduler hint extension https://review.openstack.org/578343
09:41:19 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for security group extension https://review.openstack.org/578345
10:04:56 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for BDM v2 extension https://review.openstack.org/577185
10:05:04 openstackgerrit Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262
10:08:55 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Fix capacity tracking in POST /allocations https://review.openstack.org/578133
10:12:16 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Fix capacity tracking in POST /allocations https://review.openstack.org/578133
10:15:05 openstack bug 1778591 in OpenStack Compute (nova) "GET /allocations/{uuid} on a consumer with no allocations provides no generation" [Medium,Triaged] https://launchpad.net/bugs/1778591
10:15:05 openstackgerrit Chris Dent proposed openstack/nova master: [placement] demonstrate part of bug 1778591 with a gabbi test https://review.openstack.org/578139
10:15:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for user data extension https://review.openstack.org/578349
10:24:01 openstackgerrit Merged openstack/nova master: placement: Make API history doc more consistent https://review.openstack.org/477478
10:24:08 openstackgerrit Merged openstack/nova master: Fix API reference for os-floating-ips-bulk https://review.openstack.org/578106
10:24:16 openstackgerrit Merged openstack/nova master: Fix API reference for os-floating-ip-dns https://review.openstack.org/578107
10:24:25 openstackgerrit Merged openstack/nova master: Update API reference for os-floating-ip-pools https://review.openstack.org/578108
11:09:32 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832
11:09:33 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628
11:09:34 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375
11:09:35 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401
11:09:36 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy https://review.openstack.org/571166
11:09:37 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465
11:09:38 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534
11:34:57 melen Guys, anyone knows what service calls the procedure of creating ssh-keys, distribute them among compute nodes - for migration use?
13:05:42 openstackgerrit Deepak Mourya proposed openstack/nova master: Handle CannotDeleteParentResourceProvider to 409 Conflict https://review.openstack.org/577726

Earlier   Later