Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-25
20:58:29 mnaser lols
20:59:05 mriedem so NEWTON_ONE must have been the one that didn't follow the release date,
20:59:07 mriedem but the others do yeah https://releases.openstack.org/
20:59:44 mriedem idk, if we stuck to our CD guns we'd require at least a delta, like 1 day after ROCKY(_ONE)
21:00:00 mnaser seem a bit wild
21:00:02 mnaser lol
21:00:34 mriedem note the note from mikal in there
21:00:37 mriedem # from EC2, which this needs to be compatible with.
21:00:37 mriedem # required for testing purposes. We know this isn't great, but its inherited
21:00:37 mriedem # hidden from the listing, but can still be requested explicitly, which is
21:00:37 mriedem # release bundled into a single version. Note that versions in the future are
21:00:37 mriedem # correlate with OpenStack release dates, with all the changes for a given
21:00:37 mriedem # NOTE(mikal): think of these strings as version numbers. They traditionally
21:00:56 mriedem if we go by that, then you'd just add your thing to ROCKY and CD be damned
21:01:18 mnaser technically means no api bump
21:01:39 mriedem yeah, sure, like i said, we aren't real strict or good about the metadata api
21:01:47 mriedem IT SHOULD BE ITS OWN SERVICE!
21:02:02 mriedem er, project
21:02:03 mriedem repo
21:02:39 mriedem mnaser: just patch it up and send to the ML for discussion i gues
21:07:03 cfriesen the number of hoops metadata jumps through between neutron and nova is nuts
21:11:36 mriedem cfriesen: do you have suggestions for improvements?
21:18:30 mriedem dansmith: http://lists.openstack.org/pipermail/openstack-dev/2018-June/131803.html
21:20:43 efried mriedem: Would you please have a look at https://review.openstack.org/#/c/576877/ -- it's a followon to https://review.openstack.org/#/c/576588/ where mgoddard pointed out an oopsie I made.
21:21:27 mriedem sure
21:24:39 openstackgerrit Mohammed Naser proposed openstack/nova master: Add hostId to metadata service https://review.openstack.org/577933
21:27:48 dansmith mriedem: looks right to me
21:29:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Make nova list and migration-list ignore down cells https://review.openstack.org/575734
21:29:19 mnaser mriedem: ^ + http://lists.openstack.org/pipermail/openstack-dev/2018-June/131804.html for/if whenever you want to comment about that
21:39:15 openstackgerrit Mohammed Naser proposed openstack/nova master: Add hostId to metadata service https://review.openstack.org/577933
21:42:22 efried mnaser: I'll refrain from using the ML for what may be a stupid question, but...
21:42:57 mriedem efried: questions for clarification https://review.openstack.org/#/c/576877/2
21:43:03 efried mnaser: Might the hostId be omitted from metadata because it could pose a security hole? And/or because it breaks the Principle Of Cloudiness?
21:43:09 efried mriedem: thx, looking...
21:43:27 mriedem efried: hostId is in the GET /servers/{id} rest api already
21:43:40 mriedem https://developer.openstack.org/api-ref/compute/#show-server-details
21:43:41 efried Is that accessible from within the VM, though?
21:43:50 mriedem no, but it's accessible by the tenant
21:43:57 efried so that's the point, innit?
21:43:58 mnaser efried: i mean, we expose the az. hostid is just a more dug-down version of it
21:44:15 mriedem "An ID string representing the host. This is a hashed value so will not actually look like a hostname, and is hashed with data from the project_id, so the same physical host as seen by two different project_ids, will be different. It is useful when within the same project you need to determine if two instances are on the same or different physical hosts for the purposes of availability or performance."
21:44:34 mnaser yeah and because it's hashed, nothing to worry about in terms of exposing anything
21:44:36 efried Oh, yeah, it's obfuscate...
21:44:38 efried d
21:44:46 mriedem efried: i could create my server, then get the hostId from the compute rest api, post that into the servers user metadata, and then get it into the guest via the metadata api
21:44:56 mriedem so this is all possible today, just in an annoying roundabout way
21:45:19 efried mriedem: Right, but that would again be a thing you would have to do from outside. Rather than it being always available from within the VM without any choice in the matter.
21:45:27 efried like a conf option to say whether to expose it or not.
21:45:33 mnaser well, vms also have access to the instance type they are, the az they sit in
21:45:53 efried I really have no skin in this game, just blabbing a thing that came to mind when I saw this.
21:46:34 mnaser oh yeah i totally thought about that, but i just don't see too much of an issue
21:50:32 efried mriedem: responded on https://review.openstack.org/#/c/576877/
21:52:26 openstackgerrit Merged openstack/nova master: Add instance.lock notification https://review.openstack.org/576702
21:52:42 mriedem efried: ok +W
21:53:27 efried mriedem: tbc, prior to the preceding patch where I f'ed up, ironic was "broken" in that they would strip out any traits set outside of ironic. Then I broke it differently (and arguably worse) by the preceding patch to where we would only ever *add* traits, never take them away. This is restoring the previous less-broken behavior. Eventually we will (probably) unbreak this by making logic that only adds+removes traits the
21:53:29 efried mriedem: Thanks.
21:54:03 mriedem yup
21:54:14 mriedem following the update_traits mention in the RT from the commit message clarified that for me
21:54:27 efried cool
21:56:20 cfriesen mriedem: RE: the metadata thing...not sure of a way to simplify it while still letting it work like it does now. For newish libvirt something like virtio-vsock would be simpler.
21:56:37 cfriesen But it'd require guest support
21:57:18 mriedem cfriesen: pretty sure dansmith and artom have talked about that a few times
21:57:31 mriedem also, note that libvirt isn't our only virt driver...
21:57:39 cfriesen yeah, I know. :)
22:00:10 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (1) https://review.openstack.org/572018
22:00:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (2) https://review.openstack.org/573481
22:01:49 mriedem efried: replied in https://review.openstack.org/#/c/577905/
22:01:55 efried ...
22:02:07 mriedem i.e. those changes are separate on purpose
22:02:29 mriedem i'm trying to leave heal_allocations as backportable as possible for now
22:03:22 efried I figured it was something like that. But no current plans to backport the bottom patch (else it would have a bug etc.) right?
22:14:55 mriedem nothing immediate from me no
22:15:39 mriedem but i wouldn't be totally opposed if some operators wanted some of this stuff on stable
23:01:14 openstackgerrit Merged openstack/nova master: Add instance.unlock notification https://review.openstack.org/576703
23:46:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104
23:46:56 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106
23:47:10 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110
#openstack-nova - 2018-06-26
00:22:18 wwriverrat efried
01:34:57 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113
01:35:17 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974
01:51:52 openstackgerrit Vu Cong Tuan proposed openstack/os-vif master: Add py36 testenv https://review.openstack.org/577686
02:30:00 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311
02:30:13 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581
04:06:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017
04:06:53 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018
04:07:13 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019
05:07:39 openstackgerrit Merged openstack/nova master: Make nova list and migration-list ignore down cells https://review.openstack.org/575734
05:44:53 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020
05:45:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027
05:45:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031
05:46:15 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299
06:15:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344
06:15:57 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673
06:16:09 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676
06:16:21 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689
06:16:34 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709
06:35:26 openstackgerrit Deepak Mourya proposed openstack/nova master: [WIP] Handle CannotDeleteParentResourceProvider to 409 Conflict https://review.openstack.org/577726
06:40:48 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712
06:52:43 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add TODO note for mox removal https://review.openstack.org/576758
06:54:47 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add TODO note for mox removal https://review.openstack.org/576758

Earlier   Later