Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-25
16:19:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170
16:19:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947
16:19:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333
16:19:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334
16:19:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423
16:19:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add VIFMigrateData.get_dest_vif https://review.openstack.org/566931
16:19:22 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: factor out pre_live_migration plug_vifs call https://review.openstack.org/566932
16:19:23 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: use dest host port bindings during pre_live_migration https://review.openstack.org/566933
16:19:24 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370
16:19:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager https://review.openstack.org/551371
16:19:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870
16:19:27 openstackgerrit Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537
16:36:30 openstackgerrit YAMAMOTO Takashi proposed openstack/os-vif master: Fix docstrings to work with Sphinx 1.7.4 https://review.openstack.org/577028
16:40:49 openstackgerrit Merged openstack/nova stable/pike: Metadata-API fails to retrieve avz for instances created before Pike https://review.openstack.org/571320
16:40:54 openstackgerrit Merged openstack/nova master: Switch to oslo_messaging.ConfFixture.transport_url https://review.openstack.org/573046
16:50:13 mnaser for those who were interested in the whole discussion around multi-cell + glance.. cloudnull brought up this tool which could probably be refactored to use glance_store to sync glance servers.. https://github.com/rcbops/glance-image-sync
16:51:30 mnaser mriedem: if you are around, i proposed https://review.openstack.org/#/c/576944/ to help with OSA upgrades (and probably other tools).. i'd appreciate your feedback (i didnt fix lint stuff cause i figured it'll need revisions anyways)
16:54:40 mriedem very interesting
17:19:07 openstackgerrit Merged openstack/nova master: objects: Remove legacy '_to_dict' functions https://review.openstack.org/537413
17:19:13 openstackgerrit Merged openstack/nova master: network: Unchain '_get_phynet_info' from '_get_port_vnic_info' https://review.openstack.org/564443
17:23:26 dansmith stephenfin: did you see my comments here? https://review.openstack.org/#/c/564444/7..9/nova/network/neutronv2/api.py
17:25:03 stephenfin dansmith: I did and I think I've addressed them all, though I didn't leave replies. Will do so now. Let me know if there's something I did miss and I'll address it asap
17:27:51 dansmith stephenfin: okay I guess it doesn't seem like anything is really different from the original
17:28:17 dansmith oh, wait, I see you don't actually split it in this one
17:28:31 dansmith I was thinking you'd split first, so I was looking for this to be the split patch
17:33:00 stephenfin dansmith: Caught rotten. I meant to actually do it but got my ordering mixed up and didn't want to go through the misery of another rebase :D I can if it would be preferable though
17:33:31 dansmith it's okay I just had in my head that the split was (would be) first, and so I wasn't noticing that it wasn't actually a split
17:41:50 openstackgerrit Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317
18:04:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Heal allocations with incomplete consumer information https://review.openstack.org/574488
18:20:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Heal allocations with incomplete consumer information https://review.openstack.org/574488
18:20:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor _heal_instances_in_cell https://review.openstack.org/577896
19:07:38 efried stephenfin: do you happen to have a patch that depends-on the driver-notes patch? If not Ima throw one together to see it in action.
19:08:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance https://review.openstack.org/577905
19:25:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add instance.unlock notification https://review.openstack.org/576703
19:27:27 openstackgerrit Merged openstack/nova stable/pike: placement: Fix HTTP error generation https://review.openstack.org/571218
19:28:43 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Testing driver-notes https://review.openstack.org/577908
19:29:04 efried stephenfin: FYI: ^
19:34:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Heal allocations with incomplete consumer information https://review.openstack.org/574488
19:34:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor _heal_instances_in_cell https://review.openstack.org/577896
19:34:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance https://review.openstack.org/577905
19:51:13 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Demonstrate bug in consumer generation handling https://review.openstack.org/577914
19:51:14 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Fix bug in consumer generation handling https://review.openstack.org/577915
20:16:33 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Use instance project/user when creating RequestSpec during resize reschedule https://review.openstack.org/577918
20:17:54 mriedem dansmith: i assume there was no cells v2 meeting last week since mel and i were out? did surya talk to you about the handling a down cell stuff at all?
20:18:11 dansmith mriedem: we did, but not in the meeting
20:18:23 dansmith mriedem: I put some details in the spec review
20:18:30 mriedem ok
20:22:43 dansmith mriedem: you reading that now such that I can expect some follow-on discussion here shortly?
20:22:52 mriedem just opened it
20:23:03 dansmith aight
20:23:11 mriedem heh, i did ask for super user / ops input in the ML but got crickets
20:23:26 dansmith ack
20:23:42 dansmith well, in the absence of anything from them, this is the biggest data point we have I think
20:27:33 mriedem "DELETE would "succeed" and never happen, like it does today for lots of things"
20:27:42 mriedem not sure about that - i think we'd get an error looking up the instance to delete
20:27:57 dansmith yeah, I think I waffled about that
20:28:00 mriedem we'd find the instance mapping and then try to pull the instance from the cell and that would 500-
20:28:03 dansmith yeah
20:28:42 dansmith I think he was also hoping that delete would be queued, which it wouldn't, IIRC
20:33:04 mriedem right you'd get a 500 and have to wait until the cell is back up
20:33:09 mriedem or a 503 or something
20:33:51 mriedem the main issues gibi and i had was w/o a new microversion, we'd be returning these shells with a bunch of bogus field data, and a lot of the fields aren't simple strings where we can just say UNKNOWN
20:34:09 mriedem paging and filtering is also a problem in the spec, i think i said we ignore down cells if we're paging and filtering
20:34:18 mriedem *we should
20:34:35 mriedem if i'm following this irc log conversation, it sounds like we're saying:
20:34:38 mriedem 1. new microversion
20:34:53 mriedem 2. if < new microversion and there are down cells, we omit those instances when listing
20:35:02 dansmith mriedem: right
20:35:10 dansmith which is what we do now once her patch merges
20:35:13 dansmith just omit things,
20:35:21 mriedem 3. if >= new microversion, we return what we can, but for missing instances, we don't try to return a full instance, just the uuid and project_id (what we can get from instance_mappings)
20:35:26 dansmith and then the new microversion will be opting into "I've read the contract that says values can be null now"
20:35:34 mriedem oh and status=UNKNOWN
20:35:42 dansmith yes
20:35:48 tssurya are the values going to be NULL, or are the keys going to be totally missing ?
20:35:53 dansmith and maybe "anything we can get from reqspec"
20:36:01 dansmith tssurya: either, missing would be better
20:36:08 mriedem i wouldn't really want to hit reqspec while listing 1000 instances
20:36:17 mriedem GET /servers/{id} hitting reqspec would be ok with me
20:36:18 dansmith mriedem: hence the "and maybe"
20:36:24 tssurya dansmith: ack
20:36:25 dansmith mriedem: he really wanted instance name, as you saw
20:36:38 dansmith mriedem: so we may come across something where it's worth the hit (even though not name, obviously)
20:36:43 mriedem i didn't read the entire irc log
20:36:51 tssurya mriedem: I thought we decided on going with 503 if we do a nova show on a down cell
20:37:17 mriedem i can't remember
20:37:19 dansmith yeah, 50x on show probably makes sense
20:37:22 mriedem also,
20:37:27 tssurya and for a simple start, we should just stick to uuid maybe and status and leave the rest out ?
20:37:28 mriedem the name from the reqspec could be old
20:37:34 dansmith name'
20:37:37 dansmith isn't in there
20:37:37 mriedem you can update and rename a server, and that doesn't update the reqspec
20:37:48 tssurya we don't have info on the name anywhere
20:38:00 mriedem ok
20:38:00 mriedem oh yeah
20:38:12 dansmith mriedem: so you're okay with this it sounds like?
20:38:22 dansmith and gibi seemed okay with it barring a couple more questions
20:38:29 mriedem it's a compromise
20:38:46 dansmith anything is a compromise when we're talking about how to handle missing info :)

Earlier   Later