Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-21
07:54:54 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465
07:54:55 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534
07:56:47 belmoreira I'm trying to add a custom_resource class (GPU) to a resource_provider but the resource tracker overwrites the inventory and removes it. I'm missing something?
08:22:37 tssurya good morning gibi! there is an update on the handling the down cell spec (https://review.openstack.org/#/c/557369/) so dansmith and mordred gave their views last evening , they were suggesting its better to just bump microversion saying there may be missing values for keys, than introducing the new top level key ; dansmith has put this as a comment on the spec, me personally I don't mind going wither ways, let me know your view whenever
08:23:43 tssurya either*
08:49:54 openstackgerrit Vladyslav Drok proposed openstack/nova master: ironic: Report resources as reserved when needed https://review.openstack.org/517921
08:51:39 openstackgerrit Gergely Csatari proposed openstack/nova master: Adding oslo.service to test-requirements https://review.openstack.org/577095
09:27:07 openstackgerrit Chris Dent proposed openstack/nova master: Cleanup nits in placement database changes https://review.openstack.org/577107
09:31:01 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240
09:41:14 openstackgerrit Vishakha Agarwal proposed openstack/nova master: No requirement of –all-tenants while listing servers https://review.openstack.org/577111
09:45:45 gibi tssurya: ack. I have to read back then I will go and read the review
09:49:31 tssurya gibi: thanks so much for your time
10:10:39 openstackgerrit Vishakha Agarwal proposed openstack/nova master: No requirement of –all-tenants while listing servers https://review.openstack.org/577111
10:16:11 gibi tssurya: left my view in https://review.openstack.org/#/c/557369
10:17:08 gibi tssurya: basically I'm OK with the summary from dansmith
10:17:31 gibi tssurya: some details like sorting, filtering and pagination behavior needs to be defined still
10:58:07 tssurya gibi: I agree, thanks a lot I will update the spec
10:58:18 tssurya based on all the comments
11:45:01 gibi tssurya: thank you for keeping this discussion alive
12:25:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge extended availability zone controller https://review.openstack.org/502859
13:08:29 openstackgerrit jiang wei proposed openstack/nova master: Add action initiator attribute to the update payload https://review.openstack.org/536243
13:09:11 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for legacy BDM extension https://review.openstack.org/577152
13:14:44 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Tighten up ReportClient use of generation https://review.openstack.org/556669
13:15:22 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge extended availability zone controller https://review.openstack.org/502859
13:17:05 gibi do we have any cellsv1 functional tests in nova?
13:42:11 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Log breadcrumb for known encryption bug https://review.openstack.org/577164
14:07:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840
14:07:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267
14:07:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847
14:07:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268
14:07:23 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding https://review.openstack.org/569459
14:07:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317
14:18:11 openstackgerrit Eric Fried proposed openstack/nova master: placement: s/None/null/ in consumer conflict msg https://review.openstack.org/577171
14:38:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for BDM v2 extension https://review.openstack.org/577185
14:40:51 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for BDM v2 extension https://review.openstack.org/577185
14:49:30 openstackgerrit Chris Dent proposed openstack/nova master: WIP: [placement] Add /reshaper handler for POST https://review.openstack.org/576927
14:49:31 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Extract create_allocation_list https://review.openstack.org/577200
15:24:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding https://review.openstack.org/569459
15:24:47 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317
15:58:46 Guest88320 zcorneli: did you see there are a few more nits from mriedem in the original (merged) patch to throw into your nit cleanup?
15:58:48 lyarwood kashyap: https://review.openstack.org/#/c/577164/1/nova/tests/unit/virt/libvirt/test_driver.py - why is that 8 important here?
15:59:23 lyarwood kashyap: http://lists.openstack.org/pipermail/openstack-dev/2018-June/131653.html the report on the ML had 57
15:59:34 zcorneli dansmith: Yep, should have those added in soon, running tests locally right now
15:59:46 kashyap lyarwood: Not important; that's why I didn't "-1". :-) I thought the padding error always comes down to '56'
15:59:50 dansmith zcorneli: okay i was going to +W but saw his comment
16:00:25 dansmith zcorneli: sounds like if we can get the discard patch merged we can kick you out of the runway and call it a success yeah?
16:00:36 lyarwood kashyap: kk
16:00:39 zcorneli dansmith: I think so, definitely seems like it
16:00:42 dansmith sweet
16:01:18 dansmith I bet stephenfin would help me with that to get his patches one step higher in the queue ;)
16:01:33 kashyap lyarwood: Since you were using literal error message, thought it might "matter".
16:01:59 kashyap But the patch itself is fine to me.
16:02:07 stephenfin dansmith: Ever consider a life of crime? Extortion would be right up your alley
16:02:09 stephenfin ;)
16:02:18 dansmith more like collusion
16:02:25 kashyap lyarwood: Seems like LM job failure.
16:02:27 stephenfin dansmith: I can take a look, soon as I finish the numa-aware-vswitch rework
16:02:30 stephenfin any time now...
16:03:12 dansmith stephenfin: I was going to ask if you were going to rev that, but I see some "done" comments I assume means we're about to get another rev?
16:03:33 stephenfin Yup, rev coming shortly. I've pushed mostly all the conf/object changes to the end
16:03:43 stephenfin which I think is what was requested
16:03:56 dansmith cool, I think we can cut the size down by merging some of those refactors up front
16:11:04 gibi stephenfin, dansmith: I have interests to get some of those refactors merged as I need them for the bandwidth series. So I will try to review the latest rev tomorrow morning
16:11:15 openstackgerrit Eric Fried proposed openstack/nova master: Address nits from consumer generation https://review.openstack.org/577227
16:11:54 stephenfin gibi: Cool. Just running them through fast8 one-by-one now to catch silly errors and they'll be on their way to you
16:15:10 dansmith gibi: sweet
16:28:33 openstackgerrit Eric Fried proposed openstack/nova master: WIP: deduplicate {placement|api}_database help text https://review.openstack.org/577229
16:38:22 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove NUMATopologyLimits.obj_from_db_obj https://review.openstack.org/537412
16:38:23 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_to_dict' functions https://review.openstack.org/537413
16:38:24 openstackgerrit Stephen Finucane proposed openstack/nova master: network: Unchain '_get_phynet_info' from '_get_port_vnic_info' https://review.openstack.org/564443
16:38:25 openstackgerrit Stephen Finucane proposed openstack/nova master: network: Rename 'create_pci_requests_for_sriov_ports' https://review.openstack.org/575488
16:38:26 openstackgerrit Stephen Finucane proposed openstack/nova master: network: Always retrieve network information if available https://review.openstack.org/564444
16:38:27 openstackgerrit Stephen Finucane proposed openstack/nova master: network: Retrieve tunneled status in '_get_network_info' https://review.openstack.org/564445
16:38:28 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add NUMACell.network_info https://review.openstack.org/564439
16:38:29 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add NUMATopologyLimits.networks https://review.openstack.org/575486
16:38:30 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Start accounting for networks in NUMA placement https://review.openstack.org/564448
16:38:31 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add RequestSpec.numa_networks https://review.openstack.org/564442
16:38:32 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.numa_networks https://review.openstack.org/564452
16:38:33 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440
16:38:34 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_info field https://review.openstack.org/564441
16:38:35 openstackgerrit Stephen Finucane proposed openstack/nova master: network: Rename '_get_phynet_info' to '_get_network_info' https://review.openstack.org/577233
16:45:36 openstackgerrit Eric Fried proposed openstack/nova master: WIP: deduplicate {placement|api}_database help text https://review.openstack.org/577229
16:45:48 openstackgerrit Zack Cornelius proposed openstack/nova master: Fix nits from change I676291ec0faa1dea0bd5050ef8e3426d171de4c6 https://review.openstack.org/576985
16:45:49 openstackgerrit Zack Cornelius proposed openstack/nova master: Implement discard for file backed memory https://review.openstack.org/576994
16:46:08 zcorneli dansmith: stephenfin: ^
16:47:42 stephenfin zcorneli: ack
17:04:11 stephenfin zcorneli, dansmith: Any reason we don't enable discard by default and simply require libvirt 4.4.0 instead of 4.0.0?
17:04:27 dansmith stephenfin: because 4.4.0 was _just_ releases
17:04:31 dansmith like a week ago or something
17:04:48 dansmith and, discard is just a shutdown-time perf optimization
17:05:00 dansmith so it'd limit who can use this for quite a while for a small optimization
17:05:13 zcorneli what he said ^
17:05:25 zcorneli Beat me to it
17:06:45 stephenfin dansmith, zcorneli: It's just that we're going to be carrying this stuff ad infinitum. Seems like a lot for an optimization https://review.openstack.org/#/c/576994/2/nova/objects/migrate_data.py
17:07:09 stephenfin But I guess we can just ignore it once the minimum reaches that in like 5 years time :)
17:07:53 zcorneli stephenfin: We should be able to ignore it down the line, once the minimum for all supported versions is 4.4
17:07:55 dansmith stephenfin: we could rev that object without too much trouble once we raise the minimum enough to make it worth it
17:08:34 stephenfin dansmith: Yeah, it's more an irritation than a serious concern. +2/+Wd now
17:09:07 stephenfin Spotted a few nits but again, nothing technically off
17:09:46 stephenfin zcorneli: That must be the smallest amount of revisions required for a substantial patch that I've ever seen. Give yourself a clap on the back

Earlier   Later