| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-20 | |||
| 12:21:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 13:10:34 | openstackgerrit | Merged openstack/nova master: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001 | |
| 13:13:21 | gibi | yikun: left some comments in the lock/unlock notification patches. Thanks for picking this work up. | |
| 13:17:01 | efried | stephenfin: Beautiful! | |
| 13:18:20 | mnaser | a fun one for this morning... we had a user resize a vm, status was "Confirm or Revert Resize/Migrate" inside horizon (so I assume the API status was the same) | |
| 13:18:32 | mnaser | when they confirm or revert the resize: "HTTP exception thrown: Instance has not been resized." | |
| 13:18:39 | stephenfin | fwiw, that was a series of lovely commits but they used GitHub's "helpful" squash on merge feature to work around the usually terrible commits allowed by GitHub's "helpful" pull request model | |
| 13:19:11 | mnaser | the user deleted the vm so i cant reproduce unfortunately.. but i thought i'd bring it up if anyone seens something like this.. | |
| 13:20:44 | bauzas | mnaser: can't see the instance actions API ? | |
| 13:20:56 | mnaser | oh is that kept after the instance is deleted? | |
| 13:21:05 | mnaser | good idea | |
| 13:21:07 | bauzas | mnaser: IIRC, yes | |
| 13:21:12 | mnaser | if not i can look it up in the db | |
| 13:21:39 | mnaser | interesting | |
| 13:21:53 | mnaser | start, resize, two confirmResize's and delete | |
| 13:22:11 | mnaser | let me check the request id | |
| 13:22:11 | bauzas | mnaser: tbc, using this API could be giving you the request numbrer | |
| 13:22:19 | mnaser | yep it does give the request id | |
| 13:22:24 | bauzas | yup | |
| 13:23:10 | mnaser | 204 for the confirmResize | |
| 13:23:25 | bauzas | mnaser: https://developer.openstack.org/api-ref/compute/#list-actions-for-server | |
| 13:23:30 | bauzas | "Action information of deleted instances can be returned for requests starting with microversion 2.21." | |
| 13:23:44 | bauzas | so, you should get them | |
| 13:23:56 | bauzas | mnaser: Queens for you, right? | |
| 13:24:00 | mnaser | yep | |
| 13:24:05 | bauzas | cool | |
| 13:24:19 | bauzas | so yeah, try to see the req-id and look at the compute log | |
| 13:24:32 | bauzas | (for the resize, I mean) | |
| 13:25:01 | efried | stephenfin: So I'm clear, this considers it a conflict even if the basepython is "inherited" from [testenv] ? | |
| 13:25:14 | stephenfin | Yup | |
| 13:25:56 | efried | stephenfin: And when you say it'll be changed from warning to error in the future - will that config option still be available to ignore that error? | |
| 13:26:08 | mnaser | bauzas: interesting, looks like i twas looping on "Updating from migration 309e439d-0936-4363-ac36-e783fa7afc2b" | |
| 13:26:28 | bauzas | mmmm | |
| 13:27:09 | efried | stephenfin: I assume so; otherwise it winds up having not accomplished anything. So, /me happy. Thank you very much for working that. | |
| 13:27:15 | bauzas | mnaser: you mean the server status or what? | |
| 13:27:23 | bauzas | or the logs? | |
| 13:27:42 | stephenfin | efried: Yeah, setting the option to True will allow you to ignore the override, so using 'py27' with '[testenv] basepython = python3' will still run 'python2.7' | |
| 13:27:51 | efried | beaut | |
| 13:28:12 | stephenfin | efried: If you leave the option at False (default), that will raise a warning and then error out in the next major version | |
| 13:28:16 | bauzas | mnaser: ha, nevermind, found the log | |
| 13:28:28 | bauzas | that's a RT log | |
| 13:28:31 | mnaser | yep | |
| 13:28:36 | efried | Guess I should get used to saying "schöne" | |
| 13:28:39 | mnaser | so it's almost like the migratios was never marked complete | |
| 13:28:44 | mnaser | yeah it just looped that non-stop, let me try to check logs on the source machine | |
| 13:28:47 | stephenfin | efried: and np. It's nice to work on other stuff in the Python ecosystem ever now and then, heh | |
| 13:29:29 | bauzas | mnaser: given it's a RT log, you should get it every periodic time (default is 60 secs) | |
| 13:29:45 | bauzas | mnaser: until you confirm the resize | |
| 13:30:27 | mnaser | it looks like the resize confirm just never reached the compute node | |
| 13:33:40 | mnaser | "Found an unconfirmed migration during delete, id: 14157, status: confirming" | |
| 13:34:40 | mnaser | weird | |
| 13:36:14 | deepak_mourya | hi, in this bug https://bugs.launchpad.net/nova/+bug/1770636 | |
| 13:36:15 | deepak_mourya | Do we need to add exception for CannotDeleteParentResourceProvider only in https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/resource_provider.py#L130-L140 and write test case or something else ? | |
| 13:36:15 | openstack | Launchpad bug 1770636 in OpenStack Compute (nova) "placement API not translating CannotDeleteParentResourceProvider to 409 Conflict" [Low,Triaged] - Assigned to Deepak Mourya (mourya007) | |
| 13:36:41 | bauzas | mnaser: not really weird, we just confirm the resize before deleting an instance | |
| 13:36:58 | mnaser | bauzas: yes, but the status was 'confirming' | |
| 13:37:04 | bauzas | mnaser: but you're right, that means the confirm never reached | |
| 13:37:07 | mnaser | which further goes to the theory that i guess somehow the message was lost | |
| 13:37:12 | bauzas | agreed | |
| 13:37:33 | bauzas | the migration possibly went fine, but then the confirm didn't | |
| 13:37:42 | mnaser | i guess the bug here is once it goes into confirming, if something happens in the compute node, that vm is stuck forever | |
| 13:44:18 | openstackgerrit | Chen proposed openstack/nova master: Specify periodic task interval in configurations https://review.openstack.org/576864 | |
| 14:17:23 | efried | mgoddard: you around to discuss https://review.openstack.org/#/c/576588/3/nova/virt/ironic/driver.py@806 ? | |
| 14:17:45 | efried | jroll, dtantsur: also ^ ? | |
| 14:21:15 | jroll | efried: what about it? :) | |
| 14:21:28 | efried | jroll: I just left a response (sorry for the async) | |
| 14:21:45 | jroll | oh, I only saw the first comment thread | |
| 14:22:45 | jroll | blah | |
| 14:23:08 | jroll | efried: I would vote to blow them away to maintain the current behavior | |
| 14:23:12 | jroll | see if people start yelling | |
| 14:23:16 | mgoddard | efried: just in a meeting, finishing shortly | |
| 14:23:24 | jroll | and then tell them to set them on the ironic node instead :P | |
| 14:24:02 | efried | jroll: I think I agree that's the right approach for now. I'll submit a followon asap. Unless you think this is busted enough that I should try to yank it out of the gate. | |
| 14:24:39 | jroll | efried: probably fine | |
| 14:28:38 | mgoddard | efried: IMO we should stick with the current broken behaviour then fix it, rather than changing to a different broken behaviour before fixing it | |
| 14:29:13 | efried | mgoddard: Okay, that's what jroll said too; I agree that sounds like the right approach. | |
| 14:29:18 | efried | mgoddard: Good spot btw. | |
| 14:29:31 | efried | mgoddard: Do you think a followon patch is sufficient or should I yank this one? | |
| 14:29:50 | mgoddard | efried: I think a follow on would be fine | |
| 14:29:53 | efried | k | |
| 14:30:00 | efried | thanks y'all. | |
| 14:30:09 | mgoddard | efried: thanks for following up | |
| 14:32:53 | openstackgerrit | Eric Fried proposed openstack/nova master: Ironic update_provider_tree: restore traits override https://review.openstack.org/576877 | |
| 14:36:36 | dansmith | stephenfin: can haz? https://review.openstack.org/#/c/576580 | |
| 15:28:31 | openstackgerrit | Eric Fried proposed openstack/nova master: Ironic update_provider_tree: restore traits override https://review.openstack.org/576877 | |
| 15:28:44 | efried | jroll, mgoddard, dtantsur: ^ | |
| 15:28:49 | openstackgerrit | Matthew Booth proposed openstack/nova master: Comment proposed ironic fix for removal of ironic driver workaround https://review.openstack.org/576892 | |
| 15:29:05 | mdbooth | dansmith: ^^^ tacks on the comment I mentioned, btw | |
| 15:29:08 | zcorneli | limitations | |
| 15:29:09 | zcorneli | Ach. search, not send... | |
| 15:31:21 | openstackgerrit | Eric Fried proposed openstack/nova master: Comment proposed ironic fix for removal of ironic driver workaround https://review.openstack.org/576892 | |
| 15:31:43 | efried | mdbooth: I added the reference from the other patch. +2, thanks for the followup. | |
| 15:54:42 | openstackgerrit | Eric Fried proposed openstack/nova master: RT stats deepcopy 1x/node instead of 1x/instance https://review.openstack.org/576591 | |
| 16:25:56 | openstackgerrit | Zack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876 | |
| 16:26:23 | zcorneli | mreidem: dansmith: ^ | |
| 16:26:50 | dansmith | zcorneli: I think mriedem is on vacay fwiw | |
| 16:27:54 | dansmith | maybe stephenfin can look at this with me though, since I think he's been through it a couple times at least | |
| 16:28:05 | zcorneli | Yep, I think he's been through it at least once. | |
| 16:28:11 | zcorneli | Heading off for lunch, should be back soon(ish) | |
| 16:28:21 | stephenfin | zcorneli, dansmith: I have and I can | |