Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-15
15:23:36 finucannot Sections of docs do get moved around too, though I guess that's not a concern here
15:23:42 finucannot Yeah, use latest so
15:23:52 openstackgerrit Eric Fried proposed openstack/os-vif master: doc: Fix arg specs and object types in docs https://review.openstack.org/575151
15:24:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add full traceback to ExceptionPayload in versioned notifications https://review.openstack.org/564092
15:24:18 giblet mriedem, finucannot: ^^ done
15:24:22 mriedem ack
15:25:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/561284
15:25:41 mriedem i'll trade you or anyone for ^ which is a security related issue (B1 classification) that's been sitting for a couple of months, and we know is impacting public clouds
15:26:02 giblet mriedem: looking
15:26:10 finucannot mriedem: I can take that if you can offer insight on https://review.openstack.org/#/c/575487/
15:26:43 finucannot tl;dr: Without that patch, I find the RequestSpec.numa_networks field is unset when I get it at the scheduler (after being sent over RPC, I assume)
15:27:13 finucannot I assume something is off in the prior patch but I can't figure out what
15:27:40 mriedem is conductor converting the request spec to a primitive and back?
15:27:44 mriedem or legacy format and back?
15:27:48 mriedem there is some of that old cruft in conductor
15:28:25 giblet finucannot: could it be that you missing a similar piece than this https://review.openstack.org/#/c/567267/15/nova/objects/request_spec.py@486 ?
15:28:46 finucannot giblet: Oh, that could be it
15:29:03 finucannot *after* reviewing mriedem's patch
15:29:22 giblet finucannot: when RequestSpec.create() or RequestSpec.save() is called the code rewrites the RequestSpec object based on the db data
15:29:39 giblet finucannot: and your field is missing from the db data obviously
15:29:58 mriedem yeah my guess is _from_db_object is setting it to None
15:31:04 mriedem yup, that's it
15:31:10 mriedem RequestSpec.save() calls _from_db_object which nulls it out
15:31:14 mriedem pretty sure that's it
15:31:36 mriedem so follow this pattern i guess https://review.openstack.org/#/c/567267/15/nova/objects/request_spec.py@486
15:32:37 giblet mriedem, finucannot: and when both feautre merges we can refactor RequestSpec to have a list of non persisted field names that automatically behave this way
15:33:20 giblet so the third developer introducing a non persisted field won't lose hair on this
15:43:55 finucannot mriedem: Done and yup, that was it. Cheers :)
15:44:24 finucannot giblet: agreed. I'll add mine as a list to ease that
15:47:01 giblet mriedem: I'm done with https://review.openstack.org/#/c/561284 as well. Overall +2 but both of us found small nits.
15:47:52 mriedem giblet: finucannot: question in https://review.openstack.org/#/c/564092/
15:50:24 mriedem finucannot: giblet: thanks will respin that policy patch quick
15:52:22 openstackgerrit Merged openstack/nova master: Remove max_size parameter from fake_libvirt_utils.fetch_*image methods https://review.openstack.org/574911
15:52:40 giblet mriedem: thanks for the review on the traceback in notification patch.
15:53:09 giblet mriedem: you have good points
15:53:13 mriedem np, Kevin_Zheng will string me up internally if i don't anyway :)
15:53:49 giblet mriedem: I don't have the time any more today to respin. Is it OK to let Kevin_Zheng respin it on Monday?
15:54:02 mriedem sure
15:56:38 mriedem finucannot: i'm not sure that .. warning:: works in the rendered policy docs
15:56:41 mriedem they aren't rst
15:58:00 mriedem giblet: are you ok with finucannot +Wing my change as a proxy to your +2 on that policy patch if i've addressed your comments?
15:58:02 finucannot mriedem: Oh, possible not. I guess I need to implement the same thing for that as I did for oslo.config so https://github.com/openstack/oslo.config/commit/03ff144f0
15:58:08 giblet mriedem: sure
15:58:13 mriedem cool thanks
15:58:15 giblet mriedem: does are just nits
15:58:25 finucannot mriedem: ignore that comment, in that case
15:59:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/561284
15:59:08 mriedem done ^
16:02:48 melwitt giblet: is https://blueprints.launchpad.net/nova/+spec/bandwidth-resource-provider stuck behind nested resource providers or no? (working on this etherpad https://etherpad.openstack.org/p/nova-rocky-blueprint-status)
16:03:17 melwitt kashyap: is https://blueprints.launchpad.net/nova/+spec/libvirt-cpu-model-extra-flags complete? it seems like all related changes have landed
16:03:37 melwitt kashyap: nevermind sorry, missed your reply in the logs
16:14:16 melwitt mriedem: noticed this bp is approved https://blueprints.launchpad.net/nova/+spec/servers-ips-non-unique-network-names but the spec isn't approved https://review.openstack.org/558125
16:16:45 melwitt I *think* we have all of the approved blueprints on here now, if I've missed any please let me know or add it if you don't mind https://etherpad.openstack.org/p/nova-rocky-blueprint-status
16:20:09 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add RequestSpec.numa_networks https://review.openstack.org/564442
16:20:10 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.numa_networks https://review.openstack.org/564452
16:20:11 openstackgerrit Stephen Finucane proposed openstack/nova master: network: Remove 'create_pci_requests_for_sriov_ports' https://review.openstack.org/575488
16:20:12 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440
16:20:13 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_info field https://review.openstack.org/564441
16:37:31 openstackgerrit Merged openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
16:47:06 openstackgerrit Surya Seetharaman proposed openstack/nova master: Make nova list ignore down cells https://review.openstack.org/575734
16:51:54 openstackgerrit Merged openstack/nova master: Add PLACEMENT_DB_ENABLED=True to the nova-next job https://review.openstack.org/564067
16:58:46 openstackgerrit Merged openstack/nova master: Fix nits from trusted certs notification change https://review.openstack.org/575521
17:34:29 openstackgerrit Mathieu Gagné proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.openstack.org/523559
18:02:27 openstackgerrit Merged openstack/python-novaclient master: Remove doc/build when building docs https://review.openstack.org/575753
18:02:28 openstackgerrit Merged openstack/python-novaclient master: Add CLI docs reference for flavor-update https://review.openstack.org/575754
19:37:28 openstackgerrit Eric Fried proposed openstack/nova master: Handle agg generation conflict in report client https://review.openstack.org/556669
20:06:53 openstackgerrit Eric Fried proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601
20:40:51 openstackgerrit Maciej Kucia proposed openstack/nova-specs master: Fix Non-unique network names in Servers IPs API response https://review.openstack.org/558125
20:46:03 openstackgerrit Eric Fried proposed openstack/nova master: PCPU: Define numa dedicated CPU resource class https://review.openstack.org/561770
20:49:37 openstackgerrit Eric Fried proposed openstack/nova master: Nix unused raise_if_custom_resource_class_pre_v1_1 https://review.openstack.org/575847
20:50:53 mriedem melwitt: yeah https://blueprints.launchpad.net/nova/+spec/servers-ips-non-unique-network-names is approved, the spec amendment https://review.openstack.org/#/c/558125/ was following up on something missed in the original revision
20:51:05 mriedem and looks like https://review.openstack.org/#/c/558125/ was just finally updated
20:56:48 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Fix Non-unique network names in Servers IPs API response https://review.openstack.org/558125
20:57:12 mriedem fixed, just need another specs core to approve that amendment at some point, but it shouldn't hold up the blueprint
20:57:25 mriedem although they don't have any code patches posted yet...
21:01:46 mriedem zcorneli: it worked http://logs.openstack.org/66/575766/1/check/legacy-grenade-dsvm-neutron-multinode-live-migration/2bd7d1f/logs/screen-n-cpu.txt.gz#_Jun_15_17_06_09_888053
21:01:50 mriedem superdan: ^
21:04:51 openstackgerrit Eric Fried proposed openstack/nova master: Enforce placement minimum in nova.cmd.status https://review.openstack.org/568965
21:06:14 mriedem if we can get https://review.openstack.org/#/c/500396/ in then we can close out the trusted certs blueprint i think
21:10:21 openstackgerrit Eric Fried proposed openstack/nova master: Use placement.inventory.inuse in report client https://review.openstack.org/568639
21:10:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/561284
21:31:18 zcorneli mriedem: Woo!
21:35:16 openstackgerrit Matt Riedemann proposed openstack/nova master: unquiesce instance after quiesce failure https://review.openstack.org/550865
22:45:54 openstackgerrit Merged openstack/nova master: Fix execute mock for test_convert_image_with_errors https://review.openstack.org/575305
22:46:08 openstackgerrit Merged openstack/nova master: Ignore UserWarning for scope checks during test runs https://review.openstack.org/575237
22:49:44 openstackgerrit Zack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876
22:49:45 openstackgerrit Zack Cornelius proposed openstack/nova master: DNM: Libvirt file backed memory https://review.openstack.org/575766
23:10:33 openstackgerrit Eric Fried proposed openstack/nova master: DNM: try to fix lower-constraints https://review.openstack.org/575872
23:11:15 openstackgerrit Eric Fried proposed openstack/nova master: DNM: try to fix lower-constraints https://review.openstack.org/575872
23:14:08 fried_rice That may be the first time I've created and submitted a patch 100% from gerrit ^
23:49:30 openstackgerrit Eric Fried proposed openstack/nova master: Handle agg generation conflict in report client https://review.openstack.org/556669
#openstack-nova - 2018-06-16
00:14:01 openstackgerrit Merged openstack/nova master: Update the disk_cachemodes to mention an rbd detail https://review.openstack.org/575740
00:24:57 zcorneli efried: Wasn't sure if to be scared or impressed at the patch 100% in gerrit.
00:45:02 openstackgerrit Merged openstack/nova master: [placement] replace deprecated accept.best_match https://review.openstack.org/575127
00:54:21 openstackgerrit Merged openstack/nova master: Add supplementary info for simple_cell_setup cmd https://review.openstack.org/575599
01:41:42 openstackgerrit Merged openstack/nova master: Enforce placement minimum in nova.cmd.status https://review.openstack.org/568965
03:52:24 openstackgerrit Merged openstack/nova master: Fix nits in nested provider allocation candidates(2) https://review.openstack.org/573475
08:11:06 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480
08:11:07 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add microversion for nested allocation candidate https://review.openstack.org/565487
08:11:08 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Fix nits in placement-return-all-resources series https://review.openstack.org/573604

Earlier   Later