| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-15 | |||
| 13:50:34 | fried_rice | hm, how tf does cyborg get access to the device to configure it? That's gotta be platform-specific code. | |
| 13:51:36 | superdan | they will need an agent per compute, like neutron | |
| 13:51:48 | superdan | unless they embed all the programming (and image acquisition) code in os-acc, but I wouldn't expect they would | |
| 13:52:13 | bhagyashris | finucannot: thank you :) | |
| 13:52:16 | superdan | the latter is the cinder approach.. brick knows how to configure iscsi and fc and .. | |
| 13:54:40 | mriedem | superdan: +2ed it long long ago | |
| 13:54:56 | mriedem | superdan: the docs i copied into there came from some ibm doc on that stuff, and then i think kashyap added some edits | |
| 13:54:58 | superdan | heh okay | |
| 13:55:03 | superdan | mriedem: which are gone now btw | |
| 13:55:17 | kashyap | Just noticed it; it looks good. | |
| 13:55:38 | giblet | mriedem: in the trusted cert nova client patch. Is there any particular reason why the create() has a formal trusted_image_certificates param while rebuild() expect it via kwargs? | |
| 13:55:42 | giblet | mriedem: https://review.openstack.org/#/c/500396/49/novaclient/v2/servers.py | |
| 13:55:57 | mriedem | giblet: because with rebuild you can unset the trusted certs, | |
| 13:56:09 | mriedem | so if we have a named kwarg defaulting to None, it could be confused as the user intentionally trying to unset the cert ids | |
| 13:56:17 | mriedem | giblet: see my comments in the previous patch set on that same thing | |
| 13:56:33 | giblet | mriedem: thanks | |
| 14:01:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add full traceback to ExceptionPayload in versioned notifications https://review.openstack.org/564092 | |
| 14:02:55 | giblet | mriedem: btw I think ^^ is good to go now | |
| 14:03:16 | giblet | mriedem: Kevin_Zheng made a good job I've just enhance the reno a bit | |
| 14:04:11 | mriedem | ack | |
| 14:08:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_info field https://review.openstack.org/564441 | |
| 14:11:56 | mriedem | finucannot: are you aware of a sphinx extension for doing a nice .. since:: <version> in CLI docs? | |
| 14:16:00 | finucannot | mriedem: It's in core http://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-versionadded | |
| 14:17:49 | mriedem | ooo yeah father's day came early! https://photos.app.goo.gl/Ha2JZFZmTo5EETC8A | |
| 14:18:24 | melwitt | noyce | |
| 14:25:40 | giblet | mriedem: what would it mean if the client send [] as trusted_image_certificates in rebuild? | |
| 14:25:56 | mriedem | finucannot: thanks | |
| 14:26:10 | giblet | mriedem: from shell you cannot do that but from python binding or from curl you can | |
| 14:26:10 | mriedem | giblet: via the python API binding? | |
| 14:26:54 | mriedem | giblet: you can't pass [] to the api | |
| 14:27:01 | mriedem | it must be minlength 1 if it's a list, or None | |
| 14:28:01 | mriedem | giblet: https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L482 | |
| 14:28:04 | giblet | mriedem: cool | |
| 14:28:18 | giblet | mriedem: I was affraid that it would mean trust nothing | |
| 14:28:48 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add CLI docs reference for flavor-update https://review.openstack.org/575754 | |
| 14:28:48 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove doc/build when building docs https://review.openstack.org/575753 | |
| 14:29:22 | giblet | mriedem: I left some comments in https://review.openstack.org/#/c/500396 nothing serious | |
| 14:30:36 | mriedem | giblet: ok i can address those quick | |
| 14:37:20 | openstackgerrit | Eric Fried proposed openstack/nova master: Enforce placement minimum in nova.cmd.status https://review.openstack.org/568965 | |
| 14:40:28 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.63 - Add trusted_image_certificates https://review.openstack.org/500396 | |
| 14:40:29 | mriedem | giblet: done ^ | |
| 14:41:09 | mriedem | giblet: if you're ok with that now, can you also go back to the support matrix docs change which is now dependent on the novaclient change and i'm using the nova boot CLI instead of OSC CLI https://review.openstack.org/#/c/574890/ | |
| 14:42:54 | openstackgerrit | Merged openstack/nova stable/queens: mock utils.execute() in qemu-img unit test https://review.openstack.org/574255 | |
| 14:44:26 | fried_rice | Looks like I may need a second opinion on https://review.openstack.org/#/c/575277/ -- am I being a dick asking for UT there? | |
| 14:45:11 | superdan | without looking, no. | |
| 14:47:32 | giblet | mriedem: looking | |
| 14:47:36 | giblet | mriedem: at both | |
| 14:48:31 | melwitt | fried_rice: I think the author just doesn't understand the request for test coverage, is my guess | |
| 14:48:42 | melwitt | and I agree test coverage is definitely needed | |
| 14:48:58 | fried_rice | melwitt: Okay, thanks for sanity checking me. | |
| 14:49:17 | fried_rice | superdan also :) | |
| 14:49:26 | melwitt | I might be able to help with the test later | |
| 14:54:56 | zcorneli | mriedem, superdan: I think https://review.openstack.org/#/c/567876 should be ready for review now (after passing the tests yesterday) | |
| 14:55:42 | mriedem | zcorneli: have you started tinkering with a devstack change to enable / fake out file-backed memory? | |
| 14:55:51 | superdan | I have that | |
| 14:55:56 | superdan | and it's passing some things but failing others | |
| 14:56:02 | superdan | I haven't had a chance to look | |
| 14:56:15 | superdan | but we need to run a nova change against it to get the grenade live migration job yeah? | |
| 14:56:21 | superdan | https://review.openstack.org/#/c/574792/ | |
| 14:56:47 | mriedem | yeah i figured we could just put a DNM nova patch on top of https://review.openstack.org/#/c/567876 which depends on the devstack change | |
| 14:56:57 | superdan | yep | |
| 14:57:14 | superdan | I just got that devstack change passing that much yesterday | |
| 14:57:28 | superdan | the grenade multinode job passed all the test, but reported failure for some reason | |
| 14:57:29 | giblet | mriedem: I'm +2 on both. Thanks for your updates | |
| 14:57:35 | mriedem | giblet: thanks | |
| 14:58:20 | mriedem | superdan: this is the failure http://logs.openstack.org/92/574792/5/check/neutron-grenade/7ec989c/logs/screen-n-cpu.txt.gz?level=TRACE#_Jun_14_16_51_14_918632 | |
| 14:58:23 | superdan | oh, it never ran the new side | |
| 14:58:28 | mriedem | yeah | |
| 14:58:39 | superdan | ack | |
| 14:58:41 | superdan | zcorneli: ^ | |
| 14:58:48 | mriedem | so....queens / old side is not using the queens UCA... | |
| 14:58:49 | superdan | mriedem: so I thought you said we had new enough stuff? | |
| 14:58:55 | mriedem | we do, in rocky | |
| 14:58:57 | mriedem | so, | |
| 14:59:05 | mriedem | we can also do a dnm backport of the queens uca devstack patch | |
| 14:59:06 | mriedem | sec | |
| 14:59:10 | superdan | heh | |
| 15:00:12 | zcorneli | The check did its job? | |
| 15:00:19 | superdan | yup | |
| 15:00:59 | mriedem | done | |
| 15:01:40 | mriedem | zcorneli: can you roll up the DNM nova patch on top of yours that depends on https://review.openstack.org/#/c/574792/ ? | |
| 15:01:47 | mriedem | zcorneli: do those words mean anything? | |
| 15:02:31 | mriedem | just need a nova patch on top of yours that has a depends-on in the commit message to https://review.openstack.org/#/c/574792/ - see how the depends-on in that change itself work | |
| 15:03:24 | zcorneli | The words mean things, not sure yet what the patch would contain. | |
| 15:03:36 | mriedem | just change a comment in nova/compute/manager.py to trigger tests | |
| 15:03:51 | mriedem | it's just a patch to link other changes together in the CI system | |
| 15:03:59 | mriedem | since devstack itself doesn't run the job we need | |
| 15:05:43 | zcorneli | Ah, so no real content to the patch, just a token change to trigger tests, with a depends-on the Use Queens UCA patch here: https://review.openstack.org/#/c/575764/ ? | |
| 15:06:15 | zcorneli | With a depends-on my patch as well? | |
| 15:07:24 | zcorneli | (I think I had it, and now I'm pretty sure I've confused myself. Not enough caffeine yet.) | |
| 15:09:29 | mriedem | wrong devstack change | |
| 15:09:44 | mriedem | zcorneli: depend on this https://review.openstack.org/#/c/574792/ | |
| 15:09:48 | mriedem | which depends on that other one | |
| 15:10:09 | mriedem | the dnm on top of your change doesn't require a depends-on to your change since they are in the same series / topic branch | |
| 15:10:34 | zcorneli | Ah. Got it now. | |
| 15:10:44 | zcorneli | Will do. | |
| 15:16:39 | openstackgerrit | Zack Cornelius proposed openstack/nova master: DNM: Libvirt file backed memory https://review.openstack.org/575766 | |
| 15:16:48 | zcorneli | mriedem: ^ | |
| 15:19:22 | giblet | finucannot: I replied in https://review.openstack.org/#/c/564092 | |
| 15:19:38 | finucannot | giblet: You sure? :) | |