| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-07 | |||
| 20:10:46 | melwitt | (by looking at the only place create_image is called) | |
| 20:10:56 | mnaser | melwitt: thanks.. i've switched between "rip this apart and implement it cleanly and sanely" and "... just make it work" a few times now | |
| 20:11:05 | melwitt | mnaser: heh. yeah. | |
| 20:11:51 | melwitt | I have a feeling that "prepare_template" might have been something else at first and morphed into the fetch function. I dunno | |
| 20:12:09 | mnaser | i was thinking of creating a concept of 'storage pools' in nova, storage pool has many volumes, all the operations for the pool are there depending on the driver | |
| 20:12:28 | mnaser | with a common function for downloading images from glance into said storage pool | |
| 20:13:05 | mnaser | like download_from_glance (using whatever best efficent way to download), with it calling write_to_backend with the data | |
| 20:13:14 | mriedem | mnaser: what you're saying has all been said by mdbooth at least a dozen times | |
| 20:13:31 | mriedem | and a few others re: "re-implement" | |
| 20:13:35 | mnaser | i guess they havent had the time to get aronud it | |
| 20:13:46 | jmlowe | mriedem: chock a block full of those errors | |
| 20:13:47 | mriedem | i don't know if we have the time to tell the tale | |
| 20:14:22 | openstackgerrit | Merged openstack/nova master: Follow up changes to granular placement policy reviews https://review.openstack.org/570588 | |
| 20:14:30 | melwitt | mnaser: if that could be a subclass of backend and then have rbd derive from that, that might work? unless you think the storage pool thing could apply to all drivers? | |
| 20:14:41 | melwitt | I know I'm majorly oversimplifying this | |
| 20:14:50 | mriedem | jmlowe: hmm, not really sure; we have a test case that does this same scenario and asserts the allocations before and after the live migration across 2 computes are what we'd expect | |
| 20:15:11 | mriedem | jmlowe: if you have 4 bad instances, maybe we just need to get those cleaned up, upgrade to queens and forget this ever happened | |
| 20:15:24 | jmlowe | mriedem: I'm down with that | |
| 20:15:24 | mriedem | w/o a clear recreate it's hard to say what the fix is | |
| 20:15:32 | mnaser | melwitt: something that can be applied to all drivers, leveraging the 'Backend' class that exists in imagebackend.py and the existing implemented backends | |
| 20:15:44 | melwitt | k | |
| 20:15:50 | openstackgerrit | Merged openstack/nova master: Support nested alloc cands with sharing providers https://review.openstack.org/567508 | |
| 20:15:58 | openstackgerrit | Merged openstack/nova master: Use list instead of set for duplicate check https://review.openstack.org/569720 | |
| 20:16:02 | mnaser | but again that's like the 6th solution i've thought of so far | |
| 20:16:32 | melwitt | jmlowe: you'll need to install osc-placement (it's a plugin for openstackclient) and use the CLI to clean up the stale allocations after confirming the instances are all good on the destination | |
| 20:16:38 | melwitt | if you want to go that route | |
| 20:16:50 | jmlowe | melwitt: way ahead of you there | |
| 20:16:55 | melwitt | hah, cool | |
| 20:23:05 | melwitt | mnaser: fwiw, if there's a minimalistic way we could add the stuff for ceph that isn't fugly, I'd go that route. and maybe try to work backward to make it nicer and more general for other drivers. just MHO | |
| 20:23:58 | mnaser | melwitt: that's what i'm thinking.. like adding some extra code before `clone` and `create_image` for caching.. | |
| 20:24:54 | melwitt | yeah, something. maybe an intermediate layer that does the caching part | |
| 20:35:20 | efried | mriedem, jmlowe: It's not consistent? | |
| 20:50:07 | melwitt | nova meeting in 10 min | |
| 20:51:01 | dansmith | melwitt: I have a thing distracting me right now - can you just summarize the cells meeting for me? | |
| 20:51:11 | melwitt | sure | |
| 20:51:41 | mnaser | melwitt: thinking this through a bit more.. i'm thinking maybe glance image cache could be a cleaner way... if glance adds locations when it caches things.. this little bit here .. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/imagebackend.py#L923-L926 | |
| 20:52:05 | mnaser | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/storage/rbd_utils.py#L199-L225 | |
| 20:52:18 | mnaser | would just skip the ones with different fsid and do the normal cow for the one matching | |
| 20:54:00 | melwitt | oh, hm | |
| 20:54:49 | melwitt | have to think about it more, I'm not _that_ familiar with these | |
| 20:55:00 | mnaser | yeah, i'm still kinda hoping from one possible solutino to another | |
| 20:56:44 | mnaser | https://bugzilla.redhat.com/show_bug.cgi?id=1225775 | |
| 20:56:45 | openstack | bugzilla.redhat.com bug 1225775 in openstack-glance "[RFE] Glance should be able to manage multiple Ceph clusters as backends" [Urgent,Assigned] - Assigned to akekane | |
| 20:57:10 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | |
| 20:57:54 | mriedem1 | another pretty trivial spec ^ | |
| 20:58:02 | mriedem1 | pass through more volume qos specs to the guest | |
| 20:58:10 | mriedem | probably didn't need a spec actually | |
| 21:26:32 | openstackgerrit | Merged openstack/nova master: Fix issues in nova-show-usage-statistics-for-hosts-instances.rst https://review.openstack.org/573077 | |
| 21:26:39 | openstackgerrit | Merged openstack/nova master: Fix bug to doc:nova-status https://review.openstack.org/573149 | |
| 21:26:46 | openstackgerrit | Merged openstack/nova master: Delete duplicate functions in placement test https://review.openstack.org/573193 | |
| 21:26:55 | openstackgerrit | Merged openstack/nova master: Enhance api-guide general info some updates https://review.openstack.org/561773 | |
| 21:36:09 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_compute_api.py (3) https://review.openstack.org/568184 | |
| 21:36:31 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_compute_api.py (4) https://review.openstack.org/568462 | |
| 21:36:45 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (4) https://review.openstack.org/570750 | |
| 21:37:11 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5) https://review.openstack.org/570842 | |
| 21:37:38 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6) https://review.openstack.org/571330 | |
| 21:38:19 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992 | |
| 21:38:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993 | |
| 21:39:09 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in nova/tests/unit/virt/xenapi/stubs.py https://review.openstack.org/568412 | |
| 21:39:24 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153 | |
| 21:39:36 | openstackgerrit | Merged openstack/nova-specs master: Proposes Multiple GPU types https://review.openstack.org/557065 | |
| 21:39:39 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (1) https://review.openstack.org/564658 | |
| 21:39:55 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (2) https://review.openstack.org/564659 | |
| 21:40:16 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | |
| 21:40:32 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | |
| 21:41:56 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (1) https://review.openstack.org/572018 | |
| 21:44:59 | jangutter | Apologies for a final spec review request: https://review.openstack.org/#/c/567148 It's a network $thingy, hopefully low impact, and will rip out some legacy VIF code. | |
| 22:08:14 | melwitt | mriedem: novaclient release proposed https://review.openstack.org/573453 bumped minor version for microversion 2.62 support | |
| 22:12:46 | melwitt | looks like adding traits to os-traits isn't considered adding a feature, so that one will be a patch release | |
| 22:12:51 | melwitt | https://review.openstack.org/480989 | |
| 22:14:28 | mriedem | efried: thanks for https://review.openstack.org/#/c/572583/ - some comments/questions inline | |
| 22:15:50 | efried | mriedem: ack. Ima wait until cdent, dansmith, and jaypipes have had an initial crack at it, then address everything together. | |
| 22:15:59 | melwitt | mriedem: os-traits release proposed https://review.openstack.org/573454 | |
| 22:16:56 | openstackgerrit | Merged openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | |
| 22:21:31 | melwitt | mriedem: for os-traits I would have thought adding new traits would be a feature thus a minor version bump but saw the last release that did that only did a patch bump | |
| 22:21:52 | melwitt | so beware that | |
| 22:21:54 | mriedem | efried: yup makes sense | |
| 22:21:59 | mriedem | melwitt: ok | |
| 22:22:13 | efried | I'll throw a couple responses in there anyway. | |
| 22:23:51 | mriedem | melwitt: os-traits is really just a collection of enums | |
| 22:23:55 | mriedem | so semver rules on that are...weird | |
| 22:24:01 | mriedem | i guess we'd do minor or major if we ever REMOVED traits | |
| 22:24:02 | mriedem | but idk | |
| 22:24:04 | melwitt | yeah, I was seeing that | |
| 22:25:44 | mriedem | efried: if you are able to actually birth this migrator, | |
| 22:25:55 | mriedem | are you going to consider it your 5th and most beautiful child? | |
| 22:25:59 | efried | ooo ooo, another shiny nickel? | |
| 22:26:01 | efried | oh | |
| 22:26:17 | efried | Well, I guess that would be an acceptable alternative. | |
| 22:26:18 | mriedem | i still have that nickel in my backpack, i forgot in dublin *and* in vancouver | |
| 22:26:31 | mriedem | and every time i get home and i'm cleaning my bag out i'm wondering "wtf is this nickel doing in .... oh" | |
| 22:27:48 | melwitt | mriedem: osc-placement https://review.openstack.org/573456 | |
| 22:35:46 | mriedem | ETOOMANYRELEASES | |
| 22:36:04 | melwitt | oof, sounds like monday might be "fun", files and irrelevant-files behavior changing | |
| 22:36:24 | melwitt | yeah, we have too many libs | |
| 22:37:05 | mriedem | don't forget os-vif! | |
| 22:37:14 | melwitt | gonna wait till later to propose the nova release since at least one thing is in the gate right now https://review.openstack.org/558045 | |
| 22:37:31 | melwitt | I didn't! it again didn't have any release-able changes | |
| 22:37:40 | melwitt | just some tox changes and such | |
| 22:37:44 | mriedem | https://github.com/openstack/os-vif/compare/1.10.0...master | |