| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-01 | |||
| 14:12:11 | fried_rice | giblet: ack | |
| 14:12:12 | hansmoleman | superdan: good questions, i dropped my +2 and left some replies, finucannot fyi | |
| 14:12:20 | PapaOurs | leakypipes: that was your second concern in my spec, and we could somehow *do* that, but looks to me that's just going to be a hecking thing to update | |
| 14:12:24 | finucannot | hansmoleman: (y) | |
| 14:12:43 | leakypipes | PapaOurs: "heck of a thing"? :) | |
| 14:13:00 | PapaOurs | leakypipes: I can imagine a shit number of nvidia folks coming by nova and asking us to merge their change just for updating that module | |
| 14:13:10 | leakypipes | hehe | |
| 14:13:13 | PapaOurs | leakypipes: we could do a lib tho | |
| 14:13:21 | PapaOurs | but the problem remains | |
| 14:13:27 | leakypipes | PapaOurs: I hope you know I'm just "pulling your chain" on your English phrases. :) | |
| 14:13:33 | leakypipes | it's Friday after all. | |
| 14:13:49 | PapaOurs | leakypipes: and yeah, I don't disagree with you on the poor abstraction that only relies on strings that are defined by the vendor, hence not versioned | |
| 14:14:03 | PapaOurs | leakypipes: I don't take any offense here, no worries ;) | |
| 14:14:18 | PapaOurs | and again, I now officially claim the French verbage | |
| 14:14:27 | leakypipes | :) | |
| 14:15:00 | PapaOurs | leakypipes: so, yeah, I can't argue with you on the fact types are just poorly defined by vendors | |
| 14:15:34 | PapaOurs | the best of that is that's a mandate for keeping those type names identical across releases | |
| 14:16:03 | PapaOurs | so, say, if nvidia wants to rename nvidia-35 type name into something like "M60-8G-MY_SUPER-TYPE", they would be able | |
| 14:16:20 | leakypipes | PapaOurs: well, since they only started doing any of this back in like April last year, we'll just have to wait and see if they completely change the interface here in the next year or so. My bet is, of course they will. | |
| 14:16:29 | PapaOurs | because the kernel directly takes the names straight for the kernel module... | |
| 14:16:38 | PapaOurs | froù | |
| 14:16:40 | PapaOurs | from* | |
| 14:16:46 | leakypipes | I liked frou better. | |
| 14:17:10 | PapaOurs | so, yeah, you can see me sometimes ranting on that btw. | |
| 14:17:43 | PapaOurs | but back to the spec, the only abstraction we have is that poorly-defined-tho-mandatory-and-alone interface that we call 'mdev_supported_types' | |
| 14:17:57 | PapaOurs | good luck with that | |
| 14:18:20 | leakypipes | "standardized pointer to randomness". | |
| 14:19:30 | PapaOurs | leakypipes: that quote is awesome | |
| 14:19:51 | fried_rice | giblet: +1, nice. | |
| 14:19:57 | giblet | fried_rice: thanks | |
| 14:19:58 | ralphlauren | Where did I see a hard_dict? | |
| 14:20:08 | PapaOurs | leakypipes: and now, you guess why QEMU folks push back the nvidia implementation for live migration | |
| 14:20:27 | ralphlauren | I definitely saw a hard_dict somewhere | |
| 14:20:35 | PapaOurs | leakypipes: b/c nvidia just wants to live migrate based on foobar capabilities they solely define and expose | |
| 14:22:23 | PapaOurs | anyway, I need to drop | |
| 14:30:21 | hansmoleman | leakypipes: dan akroyd had a bag-o-glass, i've got a bag-o-dicts | |
| 14:32:23 | openstackgerrit | Merged openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820 | |
| 14:56:32 | openstackgerrit | Tsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols https://review.openstack.org/567472 | |
| 15:05:24 | PapaOurs | leakypipes: hmmm, so I looked at some GVT-g links and that one looks good https://01.org/igvt-g/blogs/wangbo85/2017/gvt-g-new-architecture-introduction-update | |
| 15:05:49 | PapaOurs | they say they still use "mdev_supported_types" | |
| 15:06:14 | PapaOurs | leakypipes: so, I'll modify my spec for saying which hardware vendors support mdevs | |
| 15:06:18 | hansmoleman | woot another one bites the dust https://blueprints.launchpad.net/nova/+spec/sriov-trusted-vfs | |
| 15:06:27 | PapaOurs | ie. Intel and Nvidia | |
| 15:07:28 | fried_rice | Do "we" have any interest in, or strong objections to, allowing unicode characters in metadata/extra_specs keys? | |
| 15:12:26 | fried_rice | hansmoleman, superdan: ^ ? | |
| 15:13:15 | leakypipes | fried_rice: 💩 | |
| 15:13:25 | superdan | I thought we already said no unicode there, | |
| 15:13:33 | superdan | but allowed it in things like name and tag | |
| 15:13:50 | fried_rice | superdan: Okay, where did we say that? | |
| 15:13:54 | superdan | long ago | |
| 15:14:03 | superdan | during the post-v3 API strictification | |
| 15:14:09 | superdan | aka "the nova dark ages" | |
| 15:15:18 | fried_rice | superdan: I just reviewed https://review.openstack.org/#/c/536236/ (bug 1737711). It's not right atm, but if we're never going to allow it, I'd like to be able to shut it down so they don't go off and do a bunch of work to get it right. | |
| 15:15:20 | openstack | bug 1737711 in OpenStack Compute (nova) "nova boot failed when use the chinese metadata key and value" [Undecided,In progress] https://launchpad.net/bugs/1737711 - Assigned to wanghongtao (hongtao.wang) | |
| 15:15:41 | fried_rice | superdan: But to get it shut down, I'd like to be able to point to something that says we don't want it, and ideally, why. | |
| 15:15:44 | superdan | fried_rice: ask hansmoleman I bet he remembers more (correctly) than I do | |
| 15:15:54 | superdan | or maybe leakypipes does | |
| 15:16:04 | superdan | hence my "I thought" hedging | |
| 15:18:04 | leakypipes | superdan: unfortunately, I don't remember much about that decision either, sorry :( | |
| 15:20:47 | hansmoleman | i don't either | |
| 15:20:56 | hansmoleman | sdague likely might, but | |
| 15:21:01 | superdan | yeah | |
| 15:21:07 | hansmoleman | or alex or ken'ichi | |
| 15:21:16 | hansmoleman | or gmann | |
| 15:21:18 | superdan | am I remembering correctly that we made a point of not allowing unicode there though? | |
| 15:22:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847 | |
| 15:22:21 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | |
| 15:22:23 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding https://review.openstack.org/569459 | |
| 15:22:45 | superdan | or do ya'll not remember one way or the other? | |
| 15:23:14 | hansmoleman | i don't really remember | |
| 15:23:31 | hansmoleman | could have been related to how we stored that stuff in the db, but not sure | |
| 15:24:07 | hansmoleman | i'm not sure why we'd have unicode in flavor extra specs, | |
| 15:24:14 | hansmoleman | those are system-defined things that the code needs to understand | |
| 15:24:34 | hansmoleman | user metadata is fuzzy | |
| 15:25:00 | hansmoleman | auggy had a spec related to this also i think... | |
| 15:25:06 | hansmoleman | maybe that was just case sensitivity in the db | |
| 15:26:23 | hansmoleman | https://review.openstack.org/#/c/350843/ | |
| 15:26:26 | hansmoleman | that was case, not unicode | |
| 15:26:59 | hansmoleman | smcginnis: does cinder allow unicode in volume type extra specs? | |
| 15:27:02 | hansmoleman | or volume metadata? | |
| 15:27:37 | smcginnis | hansmoleman: Hmm, I believe the values but not the keys that are set in the extra specs. | |
| 15:27:53 | smcginnis | hansmoleman: And I believe it is fine the the volume metadata. | |
| 15:29:27 | hansmoleman | are you sure? https://github.com/openstack/cinder/blob/master/cinder/api/validation/parameter_types.py#L147 | |
| 15:29:29 | hansmoleman | doesn't look like it does | |
| 15:29:52 | hansmoleman | https://github.com/openstack/cinder/blob/master/cinder/api/schemas/volume_metadata.py#L35 | |
| 15:29:53 | fried_rice | hansmoleman: The *key* doesn't, but the *value* does. | |
| 15:30:16 | hansmoleman | oh right yeah | |
| 15:30:22 | hansmoleman | just a 255 character string | |
| 15:30:36 | fried_rice | okay, so cinder is using the same regex as nova for the key. | |
| 15:31:38 | fried_rice | I don't have a sense of how these things get sprayed around in a real deploy. Does this mean that we can't have one of those regexes be a superset of the other, because chars outside the smaller set would then break when they cross that boundary? | |
| 15:31:43 | hansmoleman | for extra specs, i would ask which specific flavor extra specs do they need unicode values | |
| 15:31:49 | hansmoleman | or is it just out of tree enablement | |
| 15:31:54 | hansmoleman | if it's the latter, then i care much less about this | |
| 15:32:34 | jgwentworth | fwiw I don't remember any discussion about unicode metadata keys | |
| 15:32:39 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Refactor _build_device_metadata https://review.openstack.org/533804 | |
| 15:32:40 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Consider hostdev devices when building metadata https://review.openstack.org/533805 | |
| 15:33:34 | superdan | for extra_specs I think the case to be made is super weak regardless of what they way | |
| 15:33:42 | ralphlauren | finucannot, ^^^ if you want to re-review | |
| 15:33:44 | superdan | for metadata I can imagine more realistic scenarios | |
| 15:34:02 | jgwentworth | it makes sense to me that someone might want that, to be able to set keys/names in their own language | |