Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-05-30
15:29:46 melwitt okay, I saw the link in the review comments on the spec for the original
15:30:22 mriedem we could amend the spec to add it as a separate work item
15:30:49 jaypipes stephenfin: hmm, getting a doc error...
15:30:52 mriedem i've been meaning to go over the spec anyway
15:31:34 dansmith mriedem: it was commented on the spec, just left out because it's not critical and isn't in released libvirt yet
15:31:36 melwitt discussed here https://review.openstack.org/#/c/563704/8/specs/rocky/approved/libvirt-file-backed-memory.rst@170
15:31:58 jaypipes stephenfin: any ideas? http://paste.openstack.org/show/722356/
15:32:04 efried bhagyashris: Second approach?
15:32:10 dansmith a tiny spec revision when it becomes available would be plenty, and/or just an extra patch tagged against the bp
15:32:42 mriedem when is libvirt 4.4.0 going to get released?
15:32:50 mriedem within the next month or so?
15:33:25 stephenfin jaypipes: Oops. I sent you the wrong way. That's for headers :(
15:33:32 melwitt I was thinking maybe we should just approve the follow on bp since it's already been created?
15:33:33 stephenfin jaypipes: Try `foo <bar>`_
15:34:20 mriedem it's just as easy to obsolete the blueprint
15:34:42 mriedem if it doesn't happen in rocky, then yeah i'd make it a separate blueprint in stein
15:36:11 dansmith mriedem: I dunno, 4.4.0 is out, so the version might not be right
15:36:19 stephenfin jaypipes: Hmm, that doesn't work either. Maybe ignore that one for now. I was sure :ref: would do it
15:36:22 dansmith mriedem: but they do monthly releases I think, so should be soon if not now
15:37:04 mriedem just say that kubevirt really needs this like yesterday
15:37:27 stephenfin jaypipes: Got it. `foo <bar_>`_ (the underscore after 'bar' is the important bit)
15:37:51 jaypipes stephenfin: bingo, that got it. thx for your help! :)
15:39:46 melwitt this page says libvirt v4.4.0 is unreleased https://libvirt.org/news.html
15:40:30 dansmith I found a package for it, hang on
15:40:31 dansmith https://launchpad.net/ubuntu/+source/linux/4.4.0-121.145
15:40:36 dansmith maybe that's built from master or something
15:40:43 dansmith oh danh
15:40:54 dansmith that's the kernel, google turned it up instead
15:40:58 dansmith so yeah nevermind :D
15:41:05 melwitt ah okay. last version was released v4.3.0 (2018-05-02) so if monthly then it will be any day now
15:41:24 dansmith https://imgur.com/a/effQ3Gn
15:41:27 dansmith thanks a lot google
15:41:39 melwitt you got googled
15:41:47 dansmith apparently
15:42:38 melwitt okay, I'll mark the bp as Obsolete with a note that libvirt 4.4.0 is soon and that the addition of the discard feature can be rolled into the original bp
15:42:48 dansmith cool
15:43:22 openstackgerrit Chris Friesen proposed openstack/nova master: add parameter docstring for 'params' to libvirt.guest.Guest.migrate() https://review.openstack.org/571236
15:43:37 cfriesen kashyap: ^
15:43:59 zcorneli Works for me. I'll look into what it'll take to add that to the code (particularly the migration segments)
15:44:08 kashyap cfriesen: Thanks; will review tomm; heading to my Dutch class :-)
15:45:18 cfriesen kashyap: no rush
15:50:42 melwitt zcorneli: cool, thanks. to be clear, it's also fine for sahid to work on it if you want, authors can work together on one blueprint, just link the blueprint in the commit message of the new patches when libvirt 4.4.0 is out
15:51:10 melwitt we're just organizing the patches on one blueprint as one feature altogether
15:51:48 openstackgerrit Chris Friesen proposed openstack/nova master: add parameter docstring for 'params' to libvirt.guest.Guest.migrate() https://review.openstack.org/571236
15:52:16 sahid melwitt: ok i saw you comment on the bp as the one from matt, it makes sense to have only one bp yes
15:52:58 melwitt coolness
15:53:04 sahid i was not sure if it was something we wanted to do, so i tried to be proactive ;)
15:53:29 melwitt yeah, I wasn't sure either, so no worries there :)
15:53:49 zcorneli Works for me either way. Definitely agreed on having it all under the one bp.
16:03:36 cfriesen dansmith: any chance you could take a look at mriedem's patch at https://review.openstack.org/#/c/465787/ ? It's a noticeable improvement for instances that have many vifs, we've been using it for a year now.
16:04:35 dansmith cfriesen: I'll add it to my queue, but in the middle of something else atm
16:04:44 cfriesen no worries, it's waited this long. :)
16:13:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Use instance project/user when creating RequestSpec during resize reschedule https://review.openstack.org/571245
16:18:08 melwitt I saw that mriedem suggested another spec review day earlier and thought it sounds like a good idea. what does everyone think of a spec review day next tuesday jun 5 ahead of the spec freeze jun 7?
16:21:14 mriedem wfm
16:26:57 mriedem jaypipes: https://review.openstack.org/#/c/571245/ is part 1 in my multi-part novella about request spec + AggregateMultiTenancyIsolation + cold migrate
16:27:18 mriedem "it was a dark and stormy night, and we had an incomplete request spec causing much gastric distress"
16:27:21 openstackgerrit Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081
16:27:27 jaypipes stephenfin: ^^
16:27:54 jaypipes mriedem: worst. plotline. ever.
16:27:56 jaypipes :P
16:28:14 mriedem ha
16:28:19 stephenfin jaypipes: Sweet. It's nearly 5:30 and super sunny outside so I'm going to go roll around in the grass or something. I'll tackle that in the morning though
16:29:07 stephenfin jaypipes: In the interim, the NUMA aware vSwitch spec has been updated per comments from dansmith and mriedem (plus gibi). Would appreciate another look over
16:29:52 jaypipes stephenfin: rock on.
16:30:00 jaypipes stephenfin: will do.
16:33:13 openstackgerrit Zack Cornelius proposed openstack/nova master: Refactor libvirt get_memory_used_mb() https://review.openstack.org/571030
16:33:14 openstackgerrit Zack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876
16:36:36 dansmith mriedem: wassup with this? https://bugs.launchpad.net/nova/+bug/1675607
16:36:38 openstack Launchpad bug 1675607 in OpenStack Compute (nova) "test_list_migrations_in_flavor_resize_situation fails with NoValidHost - AvailabilityZoneFilter returned 0 hosts" [High,Fix released] - Assigned to Dan Smith (danms)
16:38:34 mriedem dansmith: that i changed the severity
16:38:35 mriedem ?
16:38:41 mriedem see https://bugs.launchpad.net/nova/+bug/1774205
16:38:42 dansmith mriedem: yeah
16:38:42 openstack Launchpad bug 1774205 in OpenStack Compute (nova) "AggregateMultiTenancyIsolation uses wrong tenant_id during cold migrate" [High,In progress] - Assigned to Matt Riedemann (mriedem)
16:38:55 mriedem the problem that was reported in the ops list was fixed by you via that bug in pike,
16:39:16 dansmith oh I see
16:39:16 mriedem but there are still some issues like the patch above, plus i'm going to add a functional test for the AggregateMultiTenancyIsolation scenario in the ops list
16:39:23 dansmith okay
16:44:15 openstackgerrit Chris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111
16:45:38 openstackgerrit Jay Pipes proposed openstack/nova master: mirror nova host aggregate members to placement https://review.openstack.org/553597
16:45:39 jaypipes efried: ^
16:56:02 dansmith mriedem: are you intentionally keeping this unified for a backport or something? https://review.openstack.org/#/c/465787/7/nova/network/neutronv2/api.py@2406
16:56:26 dansmith that does seem a bit like a "if special case, do thing, then bail" hack in the middle of a function
16:57:42 mriedem not necessarily for a backport, but to keep the scope of the change down
16:57:57 mriedem splitting it out into a separate function means it has to pass back a sentinel to tell the caller what to do
16:58:49 mriedem i can do that, i just figured it was easier in a follow up so it doesn't confuse the original fix
17:07:36 mriedem i can never remember if a cold migrate puts the server in VERIFY_RESIZE status
17:07:51 mriedem it's all the same code so i assume it does
17:08:09 dansmith afaik it does
17:08:20 melwitt last time I used it in devstack it does
17:08:31 mriedem our api ref doesn't mention any post-conditions on cold migrate
17:08:32 melwitt have to confirm or revert the resize after that
17:08:34 mriedem so i always have to look
17:11:08 mriedem low-hanging-fruit for anyone that cares https://bugs.launchpad.net/nova/+bug/1774234
17:11:09 openstack Launchpad bug 1774234 in OpenStack Compute (nova) "api-ref: cold migrate reference doesn't mention asynchronous post conditions" [Medium,Triaged]
17:11:29 melwitt noyce
17:31:21 openstackgerrit Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
17:31:22 openstackgerrit Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
17:31:23 openstackgerrit Brianna Poulos proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158

Earlier   Later