Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-05-29
22:07:25 mriedem i could write a functional test to make sure, but...
22:07:37 efried wait, maybe I misunderstood. You're asking about a *whitelist* entry of foo=bar+
22:07:38 efried ?
22:09:25 efried mriedem: The super simplified version, IIRC, is that we take whitelist, intersect it with what's reported by get_available_resource, and then look for the requested dev in that intersection. If not found, that host is filtered out.
22:09:56 efried And it's pretty easy for that first intersection to wind up empty
22:11:07 mriedem yeah, for context, i'm reviewing sahid's trusted VF series, which links up a port whose binding profile can have a "trusted" key in it, and that goes into the InstancePCIRequest if trusted is truthy
22:11:22 mriedem now if we have all non-libvirt, or all queens computes,
22:11:37 mriedem there are not going to be any hosts that understand what that trusted tag is in in the pci request via the port binding profile,
22:11:45 mriedem and i wanted to know if the scheduler will kick that request out
22:11:58 mriedem since none of the computes would have the matching 'trusted' tag in their pci whitelist yet
22:17:30 efried mriedem: Oh, okay. I'm pretty sure we ignore keys we don't recognize.
22:18:15 efried mriedem: So adding a random key on an old compute wouldn't cause things to be kicked out where they were previously accepted.
22:18:20 efried I *think*.
22:18:33 mriedem i don't think so, looking at https://review.openstack.org/#/c/565808/4/nova/pci/utils.py
22:18:53 mriedem pci_dev comes from the pci whitelist right?
22:19:00 mriedem and specs is from the InstancePCIRequest.specs
22:19:11 efried you're going to make me look at this code, aren't you
22:19:25 mriedem pci_dev_v != v
22:19:25 mriedem so if the key was in specs but not the pci whitelist, i think we'd reject it because
22:20:08 mriedem pci_dev_v != v
22:20:08 mriedem also
22:20:10 mriedem oops
22:20:17 mriedem 'spec': fields.ListOfDictOfNullableStringsField(),
22:20:20 mriedem NICE!
22:20:33 mriedem ListOfSchmorgazboard
22:27:02 efried mriedem: Okay, so the stuff on L53-6 does what I said, I think. That is, if you ask for k=v in the spec, the dev in the (intersected whitelist + virt-reported) dev list must have that k=v. But any k in the dev list that's not present in the spec is ignored.
22:28:02 efried ...and I believe pci_dev is the (intersected) thingy.
22:33:38 mriedem oh yeah, extra garbage in the pci passthrough_whitelist is ignored,
22:33:44 mriedem but stuff that's in the spec must be in the whitelist
22:33:48 mriedem which is what i want
22:36:07 openstackgerrit Matt Riedemann proposed openstack/nova master: pci: don't consider case when match tags specs https://review.openstack.org/565808
22:36:08 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: configure trust mode for vfs https://review.openstack.org/458514
22:36:09 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: add vf_trusted field for network metadata https://review.openstack.org/566343
22:36:10 openstackgerrit Matt Riedemann proposed openstack/nova master: metadata: add vf_trusted field to device metadata https://review.openstack.org/566344
22:36:11 openstackgerrit Matt Riedemann proposed openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820
22:53:26 mriedem so, are the pci passthrough_whitelist entries supposed to be lists, or dicts, or either as long as they are serialized json?
22:54:49 mriedem i guess each entry is a serialized dict and we convert it into a list
22:55:29 mriedem er, list or dict, and can be multiples of them
23:03:56 efried mriedem: Yeah, it can be any of those things. It's super confusing.
#openstack-nova - 2018-05-30
01:14:20 openstackgerrit Merged openstack/nova master: Fix doc mistakes https://review.openstack.org/570894
02:28:17 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832
02:28:18 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375
02:28:19 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401
03:42:11 openstackgerrit tianhui proposed openstack/nova master: Fix doc mistakes https://review.openstack.org/571082
05:54:42 openstackgerrit Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802
06:55:30 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401
07:11:59 openstackgerrit Chris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111
07:18:13 openstackgerrit zhaodan7597 proposed openstack/nova master: fix a bug, when creating a vmware instance from a volume,and it goes to error state, the volume still in "in use" state. https://review.openstack.org/571112
08:56:29 openstackgerrit zhaodan7597 proposed openstack/nova master: fix a bug, when creating a vmware instance from a volume,and it goes to error state, the volume still in "in use" state. Closes-Bug:#1774137 Change-Id: I987d9b46c82b66ecc0ef2453bdd7fce6d3a7810d https://review.openstack.org/571112
09:23:52 openstackgerrit tianhui proposed openstack/nova master: Fix doc mistakes https://review.openstack.org/571147
09:26:48 openstackgerrit zhaodan7597 proposed openstack/nova master: when creating a vmware instance from volume failed ,detach the volume Closes-Bug:#1774137 Change-Id: I987d9b46c82b66ecc0ef2453bdd7fce6d3a7810d https://review.openstack.org/571112
09:32:53 openstackgerrit hyunsik Yang proposed openstack/nova master: support pxe boot between the VM https://review.openstack.org/570685
10:00:44 openstackgerrit Merged openstack/nova stable/queens: Avoid unnecessary joins in HostManager._get_instances_by_host https://review.openstack.org/570083
10:01:52 openstackgerrit zhaodan7597 proposed openstack/nova master: Unable to delete volume when a vmware instance bfv is failed. https://review.openstack.org/571112
10:34:02 openstackgerrit sahid proposed openstack/nova master: pci: don't consider case when match tags specs https://review.openstack.org/565808
10:34:03 openstackgerrit sahid proposed openstack/nova master: libvirt: configure trust mode for vfs https://review.openstack.org/458514
10:34:04 openstackgerrit sahid proposed openstack/nova master: libvirt: add vf_trusted field for network metadata https://review.openstack.org/566343
10:34:05 openstackgerrit sahid proposed openstack/nova master: metadata: add vf_trusted field to device metadata https://review.openstack.org/566344
10:34:06 openstackgerrit sahid proposed openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820
10:39:44 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy https://review.openstack.org/571166
10:51:32 openstackgerrit Merged openstack/nova stable/pike: Document how to disable notifications https://review.openstack.org/563254
11:03:43 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375
11:03:44 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401
11:03:45 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy https://review.openstack.org/571166
11:47:30 nguyenhai_ hi guys, how can I enable again nova-compute after it is disable by "Auto-disabled due to 10 build failures"
12:04:30 Tahvok Hey guys! On Ocata here. I've enable auto-convergence on all my nova computes, and since then, doing a live migration will shutdown the instance and start it on the destination node
12:04:57 Tahvok I'm pretty sure that's not what should be happening. How should I investigate such issue?
12:22:19 openstackgerrit Merged openstack/nova master: Remove mox in tests/unit/api/openstack/compute https://review.openstack.org/566528
13:22:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Set scope for remaining placement policy rules https://review.openstack.org/571201
13:25:37 openstackgerrit hyunsik Yang proposed openstack/nova master: support pxe boot between the VM https://review.openstack.org/570685
13:25:47 stephenfin bauzas: Friendly reminder to take a look at https://review.openstack.org/#/c/540887/, if you can :)
13:25:55 stephenfin Also, no API meeting today?
13:26:24 bauzas stephenfin: LOL
13:26:44 bauzas stephenfin: I should give you a t-shirt saying 'I love RST'
13:27:00 stephenfin bauzas: And I would wear that t-shirt :)
13:31:20 efried stephenfin: Does :program: render the same as ``double backticks`` ? (It appears to under sphinx build, anyway.)
13:31:43 stephenfin efried: Sure does, but it also has the benefits of rendering in the glossary
13:31:43 efried Just wondering why that was used vs using double backticks.
13:31:56 stephenfin Which we currently ignore :(
13:31:59 efried oh, a glossary...
13:32:01 stephenfin But I'm planning to fix that
13:32:10 efried as in we don't build the glossary?
13:33:06 stephenfin We do but we don't include it anywhere, to the best of my knowledge
13:33:10 efried Looking forward to seeing what that looks like. And wondering how e.g. https://review.openstack.org/#/c/540887/3/doc/source/cli/nova-rootwrap.rst@42 will fold into it.
13:41:51 openstackgerrit Merged openstack/nova master: doc: Don't use single backticks in man pages https://review.openstack.org/540887
13:43:56 stephenfin bauzas: Ta!
13:44:12 stephenfin That was a fast merge. Guess they fixed that ignore-files rule thing for zuul.conf
13:45:05 bauzas stephenfin: you know my opinion on docs reviews
13:45:37 bauzas efried: have you seen my thread on upgrade concerns for n-rp ?
13:46:23 bauzas probably only VGPU resource class is impacted, but I guess the upgrade concern can be there for any RC once we work on NUMA
13:46:37 bauzas at least VCPU and MEMORY_MB
13:49:32 bhagyashris efried: Hi,
13:51:50 bhagyashris efried: I am still struggling to write the that functional test case as per our discussion I have made the FakeLibvirtDriver class as *subclass* of LibvirtDriver but still i am gertting the issue as File "nova/virt/fake.py", line 754, in __init__
13:51:51 bhagyashris File "/opt/stack/nova/.tox/functional/local/lib/python2.7/site-packages/oslo_utils/importutils.py", line 73, in import_module
13:51:51 bhagyashris libvirt = importutils.import_module('libvirt')
13:51:51 bhagyashris File "nova/virt/libvirt/driver.py", line 314, in __init__
13:51:51 bhagyashris super(FakeLibvirtDriver, self).__init__(virtapi, read_only)
13:51:54 bhagyashris __import__(import_str)
13:51:56 bhagyashris ImportError: No module named libvirt
13:55:23 jichen hi dansmith sorry to disturb , could you please help to approve this spec https://review.openstack.org/#/c/562154/ as it's mostly address the questions in the ML?

Earlier   Later