| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-18 | |||
| 13:40:16 | Shilpa | ERROR (NotFound): (http://10.232.48.204/identity/tokens): The resource could not be found. (HTTP 404) | |
| 13:40:53 | andreykurilin | Shilpa: link to a patch? so I can see the modified code | |
| 13:41:50 | Shilpa | as of now not uploaded any patch | |
| 13:42:00 | Shilpa | will create paste docuemnt for you, wait | |
| 13:43:53 | Shilpa | http://paste.openstack.org/show/721234/, here diff is added | |
| 13:51:28 | gibi | mriedem: hi!, you marked https://bugs.launchpad.net/placement-osc-plugin/+bug/1771761 as affecting stable/queens but it seems that the trait tests does not existing there | |
| 13:51:29 | openstack | Launchpad bug 1771761 in placement-osc-plugin "trait functional tests fail due to changed error message from placement" [Medium,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 13:51:50 | mriedem | oh right, good point | |
| 13:51:54 | mriedem | removed | |
| 13:53:55 | kashyap | melwitt: Sorry, was occupied yesterday, I see you've sorted out the disk limit discussion with DanPB | |
| 13:54:03 | kashyap | 17:55 < kashyap> fetch = +refs/heads/*:refs/remotes/cgit/* | |
| 13:54:03 | kashyap | 17:55 < kashyap> url = https://git.openstack.org/openstack/nova | |
| 13:54:03 | kashyap | 17:55 < kashyap> [remote "cgit"] | |
| 13:54:13 | kashyap | Urgh, wrong copy / paste | |
| 13:54:27 | kashyap | I meant this: https://rwmj.wordpress.com/2017/04/25/how-many-disks-can-you-add-to-a-virtual-linux-machine/ | |
| 13:58:10 | andreykurilin | Shilpa: I never worked with custome auth plugins, so I can just guess what is happening. Possibly, you have keystone v2 disabled (it sounds ok), but your checks for auth_url contain error and instead of calling v3 endpoint, it tries to use v2. Another possible option is that https://github.com/openstack/python-novaclient/blob/master/novaclient/shell.py#L603-L604 returns the default auth plugin for some reason and not your custom one | |
| 13:58:40 | dansmith | kashyap: yeah, I think it's well-understood that you can technically attach a bunch | |
| 13:59:07 | kashyap | But I see we were looking for a sensible upper limit in Nova's context | |
| 13:59:25 | dansmith | kashyap: I'm kinda dubious on the reasoning for nova, and the current silly limitation _does_ prevent you from having a large tenant with a lot of volume quota attaching a large number to a single guest and completely killing the host machine | |
| 14:00:15 | kashyap | dansmith: Current limitation is 26, right? | |
| 14:00:18 | Shilpa | andreykurilin: Thank you for explaination here, will go through again and get back to you next week | |
| 14:00:33 | dansmith | mriedem: that skipping of the extra weigh/filter step is breaking a regression test in a strange way, because of the server group filter | |
| 14:00:36 | kashyap | dansmith: Yeah, I do agree with that; and I had a chuckle when I first saw a version of the upstream patch adding 2 billion as the limit! | |
| 14:00:40 | dansmith | mriedem: when I'm off my next call I'd like to discuss | |
| 14:02:24 | mriedem | ok, i'm on a call now too | |
| 14:14:21 | openstackgerrit | Eric Berglund proposed openstack/nova stable/pike: Stringify instance UUID https://review.openstack.org/569421 | |
| 14:24:27 | gibi | stephenfin: would it be possible to do the refactoring in https://review.openstack.org/#/c/564444/ separately from the main implementation series? I would need to do something similar to resolve the uglyness of https://review.openstack.org/#/c/567268/5/nova/compute/api.py@811 | |
| 14:26:46 | mriedem | dansmith: oh on https://review.openstack.org/#/c/569127/ i gotcha | |
| 14:27:07 | dansmith | yah | |
| 14:56:14 | dansmith | mriedem: yeah, so I removed the index>0 check and replaced it with a num_alts check, | |
| 14:56:32 | dansmith | which makes sense I think.. even if we have num_instances=3, if we aren't getting alts, we don't need to re-sort even if index=2 | |
| 14:56:54 | dansmith | but if I do that, it breaks your reschedule regression test for server groups, only because the reschedule filters those out | |
| 14:57:08 | mriedem | s/your/mel's/ | |
| 14:57:12 | dansmith | which I think means we had a bug already, but didn't notice it because we wouldn't re-sort the host list for that test where we only had one | |
| 14:57:13 | mriedem | but yeah, i just left some comments | |
| 14:57:16 | mriedem | and was looking at the failing test | |
| 14:57:18 | dansmith | oh, heh, I expected it was you | |
| 14:57:35 | bauzas | gibi: stephenfin is already traveling AFAIK | |
| 14:57:38 | mriedem | so that test doesn't do multi-create, and it doesn't mess with max attempts, | |
| 14:57:45 | mriedem | only triggers a reschedule | |
| 14:57:46 | bauzas | and me is about to disappear now | |
| 14:57:50 | gibi | bauzas: thanks for the info | |
| 14:58:03 | mriedem | dansmith: is this 100% fail or intermittent | |
| 14:58:18 | bauzas | folks visiting YVR, see you next week | |
| 14:58:41 | dansmith | mriedem: 100% | |
| 14:58:47 | mriedem | dansmith: ok, reading back on https://review.openstack.org/#/c/513931/ | |
| 14:58:53 | bauzas | gibi: that's why I bail out earlier | |
| 14:58:58 | gibi | bauzas: safe travell | |
| 14:59:07 | gibi | bauzas: see you in YVR | |
| 14:59:08 | bauzas | easy one, just one hop | |
| 14:59:16 | gibi | bauzas: lucky you :) | |
| 14:59:29 | dansmith | mriedem: I'm about to reply to a few of your things which might be relevant | |
| 15:00:46 | dansmith | well, one of your things | |
| 15:03:45 | dansmith | mriedem: I wonder if this is just an artifact of the server group filter thinking our second filter step is a schedule of the next instance in line, and needs to be clamped to the same host | |
| 15:03:55 | dansmith | because before, the only way we'd filter again would be for the next instance | |
| 15:04:57 | dansmith | I'm thinking maybe we really should be doing that second pass as just a sort and not a filter/sort | |
| 15:08:51 | mriedem | ok so with that test, we have a single instance in an affinity group, | |
| 15:09:10 | mriedem | we go through filters once and pick host1 and 'claim' it in _consume_selected_host | |
| 15:09:27 | mriedem | spec_obj.instance_group.hosts.append(selected_host.host) | |
| 15:09:27 | mriedem | which does if spec_obj.instance_group is not None: | |
| 15:09:47 | dansmith | yeah | |
| 15:09:48 | mriedem | then we re-filter and go through the affinity filter again, | |
| 15:10:43 | dansmith | ...and throw out everything but the primary host | |
| 15:10:48 | mriedem | return host_state.host in group_hosts | |
| 15:10:48 | mriedem | and | |
| 15:10:54 | dansmith | yup | |
| 15:10:54 | mriedem | it will accept host1 | |
| 15:10:56 | mriedem | and reject host2 | |
| 15:12:05 | mriedem | i'm not sure why you changed the logic to ignore the multicreate case though, | |
| 15:12:08 | dansmith | I was trying to think if this is already broken in some other case, where we would re-sort currently, but I don't think there are any legit cases | |
| 15:12:13 | dansmith | mriedem: see my reply? | |
| 15:12:14 | mriedem | if we're just scheduling a single instance, we don't need to re-filter/sort the hosts | |
| 15:12:17 | mriedem | yeah | |
| 15:12:30 | dansmith | mriedem: if you do num_instances=2,max_attempts=1 we would re-sort there for no reason | |
| 15:12:54 | mriedem | sure, i expected the logic to be if index > 0 and num_alts: | |
| 15:13:06 | dansmith | right, but that's the case I just said | |
| 15:13:07 | mriedem | num_alts will be 0 if max_attempts=1 | |
| 15:13:19 | dansmith | oh | |
| 15:13:24 | mriedem | you changed the code to | |
| 15:13:24 | mriedem | if num_alts > 0: | |
| 15:13:27 | mriedem | which i think is wrong | |
| 15:13:27 | dansmith | I know | |
| 15:13:28 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova stable/queens: libvirt: Lift the restriction of choices for `cpu_model_extra_flags` https://review.openstack.org/569442 | |
| 15:13:36 | dansmith | mriedem: how is it wrong? | |
| 15:13:53 | mriedem | because it essentially reverts https://review.openstack.org/#/c/513931/ | |
| 15:14:04 | mriedem | and we'll re-filter/sort the hosts that we already filtered/sorted for the single instance | |
| 15:14:07 | mriedem | which we don't need to do | |
| 15:14:22 | mriedem | we just need to pick alternates in _get_alternate_hosts from the pool of already filtered/sorted hosts | |
| 15:14:34 | dansmith | okay, I guess I was focused on the max_attempts=1 case, | |
| 15:14:57 | dansmith | and wasn't thinking about num_instances=1,max_attempts=2 | |
| 15:15:23 | dansmith | so this is what I originally had (which is why that comment is the way it is), but had ruled out needing to look at index at all | |
| 15:16:49 | mriedem | we probably crossed wires at https://review.openstack.org/#/c/569127/3/nova/scheduler/filter_scheduler.py@338 | |
| 15:17:18 | dansmith | no, I knew you meant and there, | |
| 15:17:23 | dansmith | and that's what I started with, | |
| 15:17:42 | dansmith | but then was trying to reason about why I still needed index and was just missing the full inverse of the thing I was focusing on | |
| 15:20:14 | mriedem | ok | |
| 15:21:06 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 15:24:55 | openstackgerrit | Eric Fried proposed openstack/nova master: Normalize inventory from update_provider_tree https://review.openstack.org/569132 | |
| 15:24:56 | openstackgerrit | Eric Fried proposed openstack/nova master: libvirt: get_inventory => update_provider_tree https://review.openstack.org/560444 | |
| 15:24:57 | openstackgerrit | Eric Fried proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing https://review.openstack.org/560459 | |