Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-05-17
20:37:33 openstackgerrit Merged openstack/nova master: Cleanup ugly stub in TestLocalDeleteAllocations https://review.openstack.org/561997
20:37:35 dansmith I mean,
20:37:41 dansmith it nicely punishes them hard,
20:37:45 dansmith but probably not the best thing to do :P
20:38:03 mriedem i just sent to the ML btw
20:38:34 mriedem efried: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130624.html
20:38:47 efried mriedem: ack
20:39:25 mriedem also related, we probably no longer need to default join on security_groups since that would only ever be populated for nova-network
20:40:43 mriedem dansmith: if you want, what i do need right now is to handle the NOTE in InstanceList.v
20:40:44 mriedem *get_uuids_by_host
20:41:28 dansmith hah
20:41:33 dansmith yeah I can do that too
20:41:54 dansmith there has to be some animated gif that applies well to that
20:42:15 mriedem i've been meaning to do that since https://review.openstack.org/#/c/563234/1/nova/api/openstack/compute/services.py@222
20:42:42 dansmith ooh, yessss, I made unit tests fail with infinite recursion
20:47:10 dansmith heh, instance will trigger a double lazy load on itself apparently, which I uncovered by removing this check
20:47:13 dansmith that's nice
20:48:02 mriedem you also have a note in that exact code
20:48:05 mriedem about recursion
20:48:20 edmondsw any stable cores around to review https://review.openstack.org/#/c/567599 ?
20:48:33 dansmith I know
20:49:11 edmondsw been out there a while, and it's an easy review
20:56:26 openstackgerrit Merged openstack/nova master: Remove mox in test_xenapi.py (3) https://review.openstack.org/564645
21:11:53 dansmith mriedem: funny thing happened on the way to the forum: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2596-L2607
21:12:40 mriedem edmondsw: easy for me to -1
21:14:06 mriedem ha
21:14:13 edmondsw esberglu ^
21:14:27 mriedem dansmith: one difference with that,
21:14:33 mriedem the project_only=False kwarg to model_query
21:14:42 dansmith aww
21:14:46 mriedem yup
21:15:17 dansmith well, I'll show you
21:16:29 dansmith er,
21:16:36 dansmith project_only=False by default on mode_query
21:17:24 edmondsw mriedem this fixes a PowerVM CI breakage. If we regressed, the PowerVM CI would blow up. And the regression would have to be a change in powervm code, so reviewers better be checking the powervm ci. Is that not sufficient?
21:17:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Trim the fat on HostState.instances https://review.openstack.org/569247
21:18:05 mriedem damn you smith
21:20:00 mriedem edmondsw: it'll be a cold day in hell before i...
21:20:04 openstackgerrit Eric Fried proposed openstack/nova-specs master: update add-consumer-generation to focus on API https://review.openstack.org/565565
21:20:07 efried mriedem: ^
21:21:21 efried and dansmith ^
21:21:28 openstackgerrit Merged openstack/nova master: Remove unnecessary 'to_primitive' call https://review.openstack.org/568532
21:21:53 openstackgerrit Merged openstack/nova master: Fakelibvirt migrateToURI3 should provide args according to libvirt doc https://review.openstack.org/569047
21:27:23 mriedem efried: left a comment also
21:30:40 openstackgerrit Dan Smith proposed openstack/nova master: Make instance able to lazy-load almost everything https://review.openstack.org/569267
21:30:41 openstackgerrit Dan Smith proposed openstack/nova master: Expose instance_get_all_uuids_by_host() from DB API and use it https://review.openstack.org/569268
21:31:56 dansmith mriedem: ^
21:33:45 dansmith mriedem: we had pretty anal testing of the load behaviors for various special cases,
21:34:01 dansmith so keeping those tests unchanged and allowing the new case makes me fairly confident in that
21:35:18 efried dansmith: The "sentinel proj/user conf option" business was your idea, right? You wanna post a delta on the spec accordingly?
21:35:36 efried Maybe if we get enough hands on this spec, there'll be nobody left to approve it.
21:35:57 dansmith efried: (a) I don't like calling it a sentinel, but (b) I really wish we could just update the spec afterwards, because we've already wandered around a bunch of times
21:36:19 efried dansmith: But Matt will make fun of your haircut if we do that.
21:36:32 dansmith if people really need it then I will, but..
21:36:37 efried mriedem: your call ^
21:36:58 dansmith maybe I should so I can put "it's not an effing senintel people" in bold
21:37:05 dansmith that spec will be really yelly at that point
21:37:11 dansmith the angst is well codified
21:43:13 mriedem since i haven't gotten into the code yeah i'd like that
21:46:46 efried Either of y'all have any idea how allocation_ratio values are ending up 0.0 here? http://logs.openstack.org/32/569132/2/check/openstack-tox-py35/0ad1d4e/testr_results.html.gz
21:47:25 efried this test passes for me locally.
21:49:52 efried okay, I think I figured it out. There's another test *somewhere* stomping on those values. Just gotta track it down...
21:56:53 mriedem "gifts-for-mriedem"
21:56:55 mriedem that's nice
21:59:09 dansmith heh
22:02:37 openstackgerrit Dan Smith proposed openstack/nova master: Fix interpretation of max_attempts for scheduling alternates https://review.openstack.org/569127
22:05:37 mriedem dansmith: you missed a question i had in the earlier PS in ^
22:05:39 dansmith apparently I broke unit tests on that base one
22:05:46 mriedem there might still be an optimization to be made in the multicreate case
22:06:22 dansmith mriedem: I thought you were answering your own question below
22:06:23 dansmith let me re-read
22:06:55 dansmith oh, I see because we're weighing there between them
22:08:06 dansmith er, re-weighing I should say
22:10:02 dansmith I guess I'm not sure why we need to re-weigh there
22:10:09 mriedem per the comment,
22:10:20 mriedem we "claim" from the selected hosts before we start looking for alternates
22:10:28 dansmith right
22:10:39 mriedem so we want to cleanup the alternate hosts before selecting them
22:10:40 dansmith does re-filtering dump out the ones we've claimed or something?
22:10:44 mriedem it might
22:10:50 mriedem if they were filled up
22:12:53 dansmith oh, I see, I thought that was handled by consume?
22:13:03 dansmith otherwise it's no different for the primaries if we have a lot of those
22:13:04 dansmith or..
22:13:13 dansmith is that why we stripe across hosts when doing num_instances>1?
22:13:17 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (1) https://review.openstack.org/564658
22:13:51 dansmith oh jeez, I'm failing like all the functional tests
22:14:19 mriedem https://www.youtube.com/watch?v=gGrNAB45CtY
22:15:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Trim the fat on HostState.instances https://review.openstack.org/569247
22:15:46 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (2) https://review.openstack.org/564659
22:24:58 openstackgerrit Dan Smith proposed openstack/nova master: Make instance able to lazy-load almost everything https://review.openstack.org/569267
22:24:59 openstackgerrit Dan Smith proposed openstack/nova master: Expose instance_get_all_uuids_by_host() from DB API and use it https://review.openstack.org/569268
22:29:26 openstackgerrit Takashi NATSUME proposed openstack/nova stable/queens: Fix auth_url example in hypervisor-hyper-v.rst https://review.openstack.org/569284
22:40:06 openstackgerrit Eric Fried proposed openstack/nova master: Normalize inventory from update_provider_tree https://review.openstack.org/569132
22:40:07 openstackgerrit Eric Fried proposed openstack/nova master: libvirt: get_inventory => update_provider_tree https://review.openstack.org/560444
22:40:08 openstackgerrit Eric Fried proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing https://review.openstack.org/560459
22:46:57 openstackgerrit Merged openstack/nova stable/queens: Stringify instance UUID https://review.openstack.org/567599
23:03:00 openstackgerrit Dan Smith proposed openstack/nova master: Fix interpretation of max_attempts for scheduling alternates https://review.openstack.org/569127
23:31:01 openstackgerrit Matt Riedemann proposed openstack/nova master: Avoid unnecessary joins in HostManager._get_instances_by_host https://review.openstack.org/569218
23:31:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Trim the fat on HostState.instances https://review.openstack.org/569247

Earlier   Later