| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-16 | |||
| 16:22:55 | mriedem | right? | |
| 16:23:49 | lbragstad | yes.. that's what you need, but sometimes it's easier to just ask oslo.policy to check that the token is scoped to the proper entity and leave the context.project_id == query_param.project_id check to the nova code | |
| 16:24:04 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | |
| 16:24:05 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 16:24:08 | lbragstad | oslo.policy should make sure the token used matches the scope_types and that the check_str passes | |
| 16:24:42 | mriedem | "leave the context.project_id == query_param.project_id check to the nova code" | |
| 16:24:46 | esberglu | mriedem: Added the abstract tags and responded to your other comments ^ | |
| 16:24:48 | mriedem | i don't know that we explicitly do that in our apis | |
| 16:24:57 | lbragstad | right... and that's fine | |
| 16:25:03 | lbragstad | because openstack always kinda operated like that | |
| 16:25:03 | mriedem | we probably do enforce that in things like DB APIs that query based on the context | |
| 16:25:04 | mriedem | model_query | |
| 16:25:16 | mriedem | esberglu: thanks | |
| 16:25:28 | lbragstad | ideally, in the future, you might want to consider a layer that does some validation like that | |
| 16:25:31 | stephenfin | mriedem, dansmith: Posted updates to that numa-aware-vswitch spec. Think I might need some input regarding how I'm storing the information for use in the scheduler and resource tracker | |
| 16:25:53 | lbragstad | making sure the resource controlled by nova falls within the authorization context set by the token | |
| 16:25:58 | mriedem | stephenfin: we might want to jump on a hangout for that | |
| 16:26:10 | mriedem | need to understand your work items to know how we should store data and pass it around | |
| 16:26:27 | stephenfin | mriedem, dansmith: It's probably best to look at what I have done and suggest why I shouldn't have done that https://review.openstack.org/#/c/564449/3 https://review.openstack.org/#/c/564452/3 | |
| 16:26:52 | stephenfin | mriedem: Yeah, that wouldn't be a bad idea. I can't do this evening though :( | |
| 16:27:06 | mriedem | stephenfin: tomorrow morning after the nova meeting? | |
| 16:27:09 | mriedem | well, evening for you | |
| 16:28:01 | stephenfin | mriedem: dansmith and I have our team meeting then. I can do any time before | |
| 16:28:08 | dansmith | I can't do before | |
| 16:28:13 | dansmith | but could do after-after | |
| 16:28:46 | mriedem | i'm free tomorrow, depends on stephen's hard drop everything and leave the office time :) | |
| 16:28:47 | stephenfin | Heh, and I can't do after-after (tag rugby game to play) | |
| 16:28:53 | mriedem | see! | |
| 16:29:11 | dansmith | we'll all also be in YVR | |
| 16:29:20 | stephenfin | aaaand I'm gone to Vancouver Friday AM | |
| 16:29:26 | mriedem | stephenfin, see, you need to start a family, give up on friends, and confine yourself to your desk | |
| 16:29:39 | stephenfin | dansmith: That would work. Don't imagine it'll take long | |
| 16:29:40 | mriedem | start working on your sweet sweet paunch | |
| 16:29:49 | mriedem | yeah we can punt to YVR... | |
| 16:30:38 | stephenfin | Aye, but if efried_rollin can fit in 8 sessions a week, I should probably try fit in a tag game | |
| 16:30:46 | stephenfin | mriedem: Sweet | |
| 16:34:27 | mriedem | efried_rollin: esberglu: +2 on https://review.openstack.org/#/c/549053/ | |
| 16:36:41 | esberglu | mriedem: ack, tx for review | |
| 16:36:57 | cfriesen | stephenfin: tag rugby? that's not as much fun. :) | |
| 16:39:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add granular policy rules for usages https://review.openstack.org/568706 | |
| 17:00:16 | lbragstad | mriedem: let me know if this helps https://review.openstack.org/#/c/568901/ | |
| 17:02:08 | lbragstad | it's rough - but it might also be beneficial to add in a section on how the service is responsible for checking the scope of the resource in the request against the token being used, and how that differs from the scope_types check | |
| 17:09:07 | mriedem | lbragstad: thanks, in a tab, will look in a bit | |
| 17:10:36 | lbragstad[m] | mriedem: cool, thanks for bringing it up | |
| 17:48:30 | melwitt | dansmith: would you please update the topic with the new runways https://etherpad.openstack.org/p/nova-runways-rocky | |
| 17:48:38 | melwitt | *channel topic | |
| 17:48:38 | mriedem | jaypipes: dansmith: i went over the mirror aggregates to placement change https://review.openstack.org/#/c/553597/ - think we just need to determine what to do about safe_connect usage in there and how idempotent we should be | |
| 17:48:40 | dansmith | yeah sorry | |
| 17:48:57 | melwitt | thanks mriedem for swarpping the runways | |
| 17:49:03 | melwitt | swapping | |
| 17:49:10 | mriedem | np | |
| 17:49:38 | dansmith | um which is the powervm one? | |
| 17:49:43 | dansmith | looks like multiple specs | |
| 17:49:49 | dansmith | but just powervm-localdisk now? | |
| 17:50:13 | melwitt | it's multiple blueprints. they used to be in one and were asked to split them into specless bps, IIRC | |
| 17:50:30 | melwitt | one for each parity thing. so it's a little weird | |
| 17:50:43 | jaypipes | thx mriedem | |
| 17:51:49 | mriedem | i'll also push a docs change for the rocky requirement in nova-api to have placement configured for things like local delete and deleting compute services | |
| 17:52:06 | mriedem | those are idempotent today but you'll get warnings in the logs if placement isn't configured for nova-api | |
| 17:53:37 | melwitt | oh and powervm-vscsi is blocked on CI coverage so powervm-localdisk is the only one left | |
| 17:53:39 | melwitt | derp | |
| 17:58:24 | mriedem | esberglu: powervm ci seems to be unwell http://184.172.12.213/00/549300/27/check/nova-in-tree-pvm/03c26c0/logs/console.txt.gz | |
| 17:58:41 | mriedem | m echo 'Didn'\''t find service registered by hostname after 60 seconds' | |
| 17:59:03 | mriedem | i believe that timeout is configurable now if you need to bump it | |
| 17:59:45 | mriedem | http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/nova#n1066 | |
| 18:02:47 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use RequestSpec.user_id in scheduler.utils.claim_resources https://review.openstack.org/568917 | |
| 18:06:29 | esberglu | mriedem: Not a timeout, legit failure for the service to come up http://184.172.12.213/53/549053/18/check/nova-in-tree-pvm/9c1c445/logs/n-cpu.txt.gz | |
| 18:07:00 | mriedem | oh nice | |
| 18:07:26 | esberglu | mriedem: I thought https://review.openstack.org/#/c/549053/18/nova/virt/powervm/disk/driver.py@64 should make @abstractproperty accessible? | |
| 18:07:34 | esberglu | What am I missing | |
| 18:07:48 | mriedem | @abc.abstractproperty | |
| 18:07:55 | mriedem | https://docs.python.org/2/library/abc.html#abc.abstractproperty | |
| 18:07:56 | mriedem | i think anyway | |
| 18:08:51 | esberglu | mriedem: I guess I misunderstood add_metaclass. New patch incoming | |
| 18:09:08 | mriedem | yeah unit tests and pep8 failed in https://review.openstack.org/#/c/549053/ | |
| 18:14:05 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | |
| 18:14:06 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 18:23:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update nova-status and docs for required placement 1.24 https://review.openstack.org/568923 | |
| 18:25:04 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update nova-status and docs for required placement 1.24 https://review.openstack.org/568923 | |
| 18:31:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update placement upgrade docs for nova-api dependency on placement https://review.openstack.org/568925 | |
| 18:33:05 | mriedem | esberglu: hmm http://logs.openstack.org/53/549053/19/check/openstack-tox-py27/c882f7f/testr_results.html.gz | |
| 18:33:47 | esberglu | mriedem: Guess it's time to figure out why I can't run tox locally | |
| 18:34:41 | mriedem | self.st_adpt = disk_dvr.DiskAdapter(None, None) | |
| 18:34:46 | mriedem | your test is trying to instantiate the abc | |
| 18:36:28 | mriedem | so either just leave that in the test for SSPDiskAdapter, | |
| 18:36:45 | mriedem | or make a little fake DiskAdapter subclass for your generic base class tests? | |
| 18:54:54 | openstackgerrit | Merged openstack/nova master: Debug logs for allocation_candidates filters https://review.openstack.org/568712 | |
| 19:00:24 | dansmith | mriedem: melwitt: cells meeting? I've got nothing and tssurya isn't around | |
| 19:00:35 | melwitt | I don't have anything either | |
| 19:01:22 | mriedem | nope | |
| 19:01:25 | dansmith | woot | |
| 19:14:43 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add additional information for z/VM spec. https://review.openstack.org/562154 | |
| 19:15:28 | mriedem1 | dansmith: +2 on ^ - barring some english / grammar stuff in there, it sounds like that reflects the ML thread which i think you know more about than i do | |
| 19:39:34 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | |
| 19:39:35 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 19:44:29 | mriedem | can we remove the 'build_instance' hook yet? https://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L2209 | |
| 19:44:41 | mriedem | hooks have been officially deprecated for a couple of years now | |
| 19:45:31 | mriedem | "will be removed in a future release")) | |
| 19:45:31 | mriedem | LOG.warning(_LW("Hooks are deprecated as of Nova 13.0 and " | |
| 19:46:23 | mriedem | the issue being, because _do_build_and_run_instance has the hook, we return the build_results enum, which means when we are checking to see if the compute should be auto-disabled due to consecutive failures, we don't have any context on why the build failed https://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L1679 | |