| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-11 | |||
| 14:26:18 | stephenfin | sean-k-mooney: oh hai | |
| 14:26:38 | sean-k-mooney | i litrally just got to my desk so have no idea what you are talking about | |
| 14:26:55 | stephenfin | sean-k-mooney: I'm not sure if I've been very clever or very dumb in patch. Could you have a look, if you have time? https://review.openstack.org/#/c/565471/ | |
| 14:27:03 | melwitt | fried_rice: done | |
| 14:27:12 | fried_rice | melwitt: Thank you | |
| 14:27:18 | stephenfin | Also | |
| 14:27:24 | sean-k-mooney | stephenfin: oh generic vhost-user | |
| 14:27:37 | sean-k-mooney | in os-vif i was ment to create a new plugin for that | |
| 14:27:37 | finucannot | Yeah, is that a thing? | |
| 14:28:03 | sean-k-mooney | finucannot: ya generic vhost user is used by vpp and snabb switch | |
| 14:29:08 | sean-k-mooney | finucannot: in both cases they dont need any plug operation because teh backeds watch for the sockets thems selves and conect. | |
| 14:29:41 | sean-k-mooney | finucannot: they get the socket info from there neutron ml2 drivers instead of nova | |
| 14:32:14 | sean-k-mooney | finucannot: do you want me to create the generic vhost-user plugin in os-vif so you can delete the get_config_vhostuser stuff? | |
| 14:33:42 | finucannot | Yup, that sounds like a good idea. I'd been looking at snabb switch alright http://blog.allenx.org/2015/07/13/the-new-feature-vhost-user-in-qemu | |
| 14:35:09 | sean-k-mooney | finucannot: i was talking to superdan about this a week or two ago but i was then on vacation so havent done it yet | |
| 14:36:53 | superdan | needsleep: why would that need a reno? it's just internal plumbing right? | |
| 14:37:18 | needsleep | superdan: Just asking because dtantsur suggested that it might. | |
| 14:37:35 | superdan | needsleep: okay I don't really think so. I'll comment | |
| 14:37:43 | needsleep | I suspect it would be noise, tbh | |
| 14:37:45 | needsleep | superdan: ack | |
| 14:39:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: MIN_LIBVIRT_VHOSTUSER_MQ https://review.openstack.org/565472 | |
| 14:39:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PF_WITH_NO_VFS_CAP_VERSION https://review.openstack.org/565517 | |
| 14:49:59 | openstackgerrit | Merged openstack/nova stable/queens: Update docs for [keystone_authtoken] changes since Queens https://review.openstack.org/564336 | |
| 14:52:09 | openstack | Launchpad bug 1633033 in OpenStack Compute (nova) "live migration with encrypted volume fails" [Undecided,In progress] - Assigned to Lee Yarwood (lyarwood) | |
| 14:52:09 | jgwentworth | lyarwood: I've been meaning to ask you, would you consider native qemu luks decryption to be the resolution for this bug? or is it still a bug to keep open? https://bugs.launchpad.net/nova/+bug/1633033 | |
| 14:53:12 | lyarwood | jgwentworth: yeah not directly, there was an earlier change in the series that fixed this, I was sure I commented on that bug a few weeks ago sorry! | |
| 14:53:52 | lyarwood | jgwentworth: https://review.openstack.org/#/c/460243/ | |
| 14:54:23 | jgwentworth | lyarwood: a-ha, thanks. so with that, the bug can be marked Fix Released? someone was asking about it last week I think | |
| 14:55:39 | lyarwood | jgwentworth: yeah I think so | |
| 14:56:03 | jgwentworth | lyarwood: cool, thanks. I'll update it as such | |
| 14:59:02 | sean-k-mooney | finucannot: ill have a basic noop plugin up for review in the next hour or so. just need to add docs and unit tests working but have a scrum meeting in 2 minutes | |
| 14:59:21 | sean-k-mooney | finucannot: ill comment back on your patch when its ready | |
| 15:00:08 | finucannot | sean-k-mooney: Sounds good to me :) | |
| 15:06:48 | vdrok | mriedem: hrm, it seems like images_type is being overridden somewhere http://logs.openstack.org/60/567860/1/check/legacy-grenade-dsvm-neutron-multinode-live-migration/73d8b8a/logs/etc/nova/nova.conf.txt.gz | |
| 15:07:47 | mriedem | vdrok: the live migration job runs first w/o ceph and then with ceph | |
| 15:08:08 | mriedem | https://github.com/openstack/nova/blob/master/nova/tests/live_migration/hooks/ceph.sh#L79 | |
| 15:08:25 | mriedem | but the first run before ceph should fail | |
| 15:08:41 | mriedem | https://github.com/openstack/nova/blob/master/nova/tests/live_migration/hooks/run_tests.sh#L27 | |
| 15:14:38 | openstackgerrit | Zack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876 | |
| 15:16:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: xenapi: drop deprecated vif_driver config option https://review.openstack.org/567877 | |
| 15:16:34 | mriedem | naichuans: hi, i'll probably need some help with fixing the unit tests in ^ because of the way the fake / stubs are setup to trace xenserver session records | |
| 15:16:46 | mriedem | that entire fake/stub structure is a bit weird if you're not used to it | |
| 15:21:43 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Metadata-API fails to retrieve avz for instances created before Pike https://review.openstack.org/567878 | |
| 15:22:11 | mriedem | vdrok: although something else is up, because in the run before rbd, it uses 'default' which defaults to qcow2, not raw http://logs.openstack.org/60/567860/1/check/nova-live-migration/90babb9/logs/screen-n-cpu.txt.gz#_May_11_14_04_55_065852 | |
| 15:23:12 | mriedem | i'll just override the config option defaults in code rather than mess with setting the values in the CI run | |
| 15:24:45 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Metadata-API fails to retrieve avz for instances created before Pike https://review.openstack.org/567878 | |
| 15:26:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test raw image live migration with vfat config drive https://review.openstack.org/567860 | |
| 15:29:27 | cfriesen_ | sean-k-mooney: sriov question for you. according to the docs at https://docs.openstack.org/neutron/pike/admin/config-sriov.html, if we have both PFs and VFs on the host and pass the PF through to the guest, the VF number stored in "sriov_numvfs" is lost. how do we restore that when we detach the PF from the guest and return it to the host? | |
| 15:30:35 | sean-k-mooney | cfriesen_: udev rules is the only way i have found really | |
| 15:31:11 | sean-k-mooney | you could perhaps use a systemd service and a filepath trigger | |
| 15:31:37 | sean-k-mooney | cfriesen_: somthing needs to echo it back into sysfs | |
| 15:32:33 | cfriesen_ | sean-k-mooney: yeah, that's what we found. the docs talk about setting it in "ifup", but that didn't sound right | |
| 15:33:12 | sean-k-mooney | cfriesen_: you can use ifcfg or /etc/network/interfaces files | |
| 15:33:17 | sean-k-mooney | cfriesen_: they only work for nics | |
| 15:33:34 | sean-k-mooney | and the require the nic to be bound back to a driver other then vfio-pci | |
| 15:34:06 | sean-k-mooney | the udev/systemd approch works for GPUs or QAT devices too | |
| 15:34:30 | cfriesen_ | sean-k-mooney: makes sense, thanks | |
| 15:41:17 | mriedem | jgwentworth: superdan: looking at tssurya's online data migration here https://review.openstack.org/#/c/567878/ - i realize that it, and the one before it for populating BDM uuids, aren't multi-cell aware, so anyone running multiple cells has to run this manually per-cell database config, which kind of sucks | |
| 15:41:42 | mriedem | we could probably easily pull the non-cell0 cells from the api db and iterate those doing the online data migration | |
| 15:42:29 | jgwentworth | well, if we do that, we'd also want to make db sync multi-cell too right? because those are usually run side-by-side | |
| 15:42:37 | mriedem | there is a patch for that | |
| 15:42:39 | jgwentworth | or is it already | |
| 15:42:41 | jgwentworth | okay | |
| 15:43:05 | mriedem | https://review.openstack.org/#/c/519275/ | |
| 15:44:05 | jgwentworth | nice | |
| 15:58:06 | sean-k-mooney | fyi if people have ATC codes and are planning to go to the summit in in a week they expire today. also im now going to the summit | |
| 15:59:10 | mriedem | jgwentworth: ah crap, | |
| 15:59:23 | mriedem | the in-tree live migration job won't run when we've only made changes to nova/tests/* | |
| 15:59:28 | mriedem | https://review.openstack.org/#/c/567860/ | |
| 15:59:55 | mriedem | https://github.com/openstack/nova/blob/master/.zuul.yaml#L22 | |
| 16:00:05 | mriedem | er https://github.com/openstack/nova/blob/master/.zuul.yaml#L49 | |
| 16:00:39 | jgwentworth | is that not what we wanted? I copied it from the nova base job I thought | |
| 16:01:03 | mriedem | the nova-live-migration setup is in nova/tests/live-migration | |
| 16:01:45 | mriedem | i can post a fix i think for the regex | |
| 16:04:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix irrelevant-files in nova-dsvm-multinode-base https://review.openstack.org/567884 | |
| 16:04:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test raw image live migration with vfat config drive https://review.openstack.org/567860 | |
| 16:05:40 | mriedem | yup that fixed it, https://review.openstack.org/#/c/567860/ is queued up to run nova-live-migration onw | |
| 16:05:41 | mriedem | *now | |
| 16:12:25 | openstackgerrit | Zack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876 | |
| 16:12:57 | jgwentworth | mriedem: oh I see | |
| 16:28:12 | jgwentworth | we have a review for increasing the max number of attached volumes to a single instance from 26 https://review.openstack.org/567472 | |
| 16:29:15 | jgwentworth | mdbooth or lyarwood: would appreciate your review on that ^ | |
| 16:30:29 | lyarwood | jgwentworth: ack yeah will have to be early next week now | |
| 16:30:47 | jgwentworth | np, no rush. just a heads up | |
| 16:31:30 | mdbooth | jgwentworth: Have you tested it, btw? What's the limit on the default storage controller? | |
| 16:32:55 | jgwentworth | mdbooth: uh, I have no idea? | |
| 16:34:13 | jgwentworth | I need to do some research to find out what makes sense there. I didn't know we currently limit to 26 until that patch | |
| 16:35:11 | jgwentworth | and I'm aware that sahid did some work with virtio-scsi to allow 256 devices. but that must be somehow separate from this, maybe those aren't volumes | |
| 16:35:57 | sean-k-mooney | finucannot: still around? | |
| 16:36:09 | finucannot | yup | |
| 16:36:25 | openstackgerrit | Merged openstack/nova master: XenAPI: deprecate the config for image handler class path https://review.openstack.org/497201 | |
| 16:36:34 | sean-k-mooney | notice anything wrong with this https://github.com/openstack/os-vif/blob/master/tox.ini#L26 | |
| 16:37:33 | sean-k-mooney | ill give you a hint look at the python 3 tests below it | |
| 16:37:36 | finucannot | I'm assuming '.tests' shouldn't be in the regex? | |
| 16:37:47 | finucannot | (or we should drop 'test-path') | |
| 16:38:07 | sean-k-mooney | yep we are not running the unit test for the plugins in python 2 | |
| 16:38:16 | sean-k-mooney | for the last 10 months... | |
| 16:38:38 | finucannot | Boo, ralonsoh. Booooo | |
| 16:38:45 | sean-k-mooney | im going to fix this. this is is why i was not able to run the tests for the noop plugin | |
| 16:39:31 | sean-k-mooney | speaking of which ill finish that before i leave today but im guess you will be gone | |