| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-09 | |||
| 13:11:18 | jaypipes | stephenfin: no worries, it's not a huge deal really. | |
| 13:11:41 | mdbooth | The issue is that you added is_volume, which is a property, to the inherited list | |
| 13:11:46 | efried | mdbooth: The change itself is (was intended to be) a no-op. It was only supposed to get rid of the need to ask that @property through a private member of the outer bdm. | |
| 13:12:01 | stephenfin | jaypipes: I don't think I'm conflating those things. The main difference is whether it's an L2 network (uses physnets) or L3 network (uses a tunnel endpoint). tbh, the whole section on tenant networks and provider networks could be dropped | |
| 13:12:09 | mdbooth | So it breaks when something attempts to write to it | |
| 13:12:25 | efried | mdbooth: Write to what, .is_volume ? | |
| 13:12:29 | mdbooth | Yeah | |
| 13:12:34 | stephenfin | I'll probably do that as a follow-up. At this point I just want to get the spec in so I can grab a runway :) | |
| 13:12:37 | efried | mdbooth: Who was doing that, and where? | |
| 13:12:44 | efried | and why? | |
| 13:13:07 | efried | and based on what source info, if not _bdm_obj.is_volume itself? | |
| 13:13:18 | efried | mdbooth: sounds like we need a fup to remove... whatever that was. | |
| 13:13:26 | efried | mriedem: see email | |
| 13:13:34 | mdbooth | efried: Let me reload that context, but it broke my patch https://review.openstack.org/#/c/528362/ | |
| 13:13:57 | mdbooth | efried: I believe the issue is due to something iterating over properties to initialise the object | |
| 13:14:02 | mdbooth | Let me just remind myself... | |
| 13:14:10 | mriedem | nothing like an immediate pounce | |
| 13:14:23 | efried | mriedem: No hurry, just responding to your question about the granular bp | |
| 13:14:37 | efried | I suppose I didn't need to pounce for that. Sorry. | |
| 13:14:55 | ShilpaSD | stephenfin: Hi | |
| 13:14:59 | efried | mdbooth: Okay, so it kicked your patch out of the gate, didn't like melt CERNs supercollider, that's a relief anyway. | |
| 13:15:23 | mdbooth | efried: My patch is more important than somebody's magnet set. | |
| 13:15:29 | efried | clearly | |
| 13:17:59 | jaypipes | stephenfin: understood. | |
| 13:25:06 | mdbooth | efried: Ok, so I think I can unpick this from my end. | |
| 13:25:23 | mdbooth | efried: However, the point about is_volume being redundant in that context still stands | |
| 13:25:43 | efried | mdbooth: Okay. From what I've been able to tell so far, it's not clear that we should be setting things on _bdm_obj rather than on the outer object itself. | |
| 13:25:47 | mdbooth | Which, as I say, would be obvious if we called 'block_device_mappings' 'volumes' | |
| 13:26:18 | mriedem | lyarwood: can you poke this regression fix for queens? https://review.openstack.org/#/c/564461/ we're going to do a release soon for another regression fix | |
| 13:26:19 | efried | mdbooth: I'll be on the lookout for that review :) | |
| 13:26:32 | mriedem | this one https://review.openstack.org/#/q/If9e1581db9c1ae14340b787d03c815d243d5a50c | |
| 13:26:54 | mdbooth | efried: Meh, I can't be arsed renaming things I'm not actively hitting. It's painful and nobody cares. | |
| 13:27:09 | lyarwood | mriedem: yeah np, looking now | |
| 13:27:33 | efried | mdbooth: Just so. Also, that's a slippery slope, as I mentioned before. Once we start "fixing" the block device code, there'll be no stopping. | |
| 13:28:55 | jmccarthy | mriedem: Morning ! I checked this out and it worked out great https://review.openstack.org/#/c/566367 ! | |
| 13:32:42 | openstackgerrit | Jay Pipes proposed openstack/nova master: add consumer.generation/create missing consumers https://review.openstack.org/557958 | |
| 13:32:43 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add Project, User and Consumer objects https://review.openstack.org/565403 | |
| 13:32:44 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add create() methods to Project, User and Consumer https://review.openstack.org/565404 | |
| 13:32:45 | openstackgerrit | Jay Pipes proposed openstack/nova master: move consumer ensure to API layer https://review.openstack.org/565405 | |
| 13:32:47 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604 | |
| 13:32:47 | openstackgerrit | Jay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict() https://review.openstack.org/565407 | |
| 13:33:10 | mdbooth | efried: Added a comment to the PowerVM patch. Not really worth a -1, tbh, but I figure somebody's going to have to touch it anyway. | |
| 13:34:00 | lyarwood | mriedem: right, so this is a stable/queens cherry-pick of a revert of a bugfix that only ever landed on master, fun. | |
| 13:35:06 | lyarwood | mriedem: it's valid as bugfix on stable/queens AFAICT, do we have enough time to drop the `This reverts commit` line? | |
| 13:36:45 | mriedem | lyarwood: which one? https://review.openstack.org/#/c/564461/ ? | |
| 13:36:49 | mriedem | it's not really a revert, it's a redo | |
| 13:37:02 | mriedem | jmccarthy: great, thanks | |
| 13:37:12 | lyarwood | mriedem: yeah the revert line just confused me | |
| 13:37:19 | mriedem | jaypipes: i think you have some context on this https://review.openstack.org/#/c/566367 | |
| 13:37:27 | mriedem | would be good to get that fixed since we backported the regression to ocata | |
| 13:37:57 | mriedem | lyarwood: right, so we revert the one workaround hack to remove the instance dir after the by_name init thing | |
| 13:38:12 | mriedem | because if we don't do that hack, we don't need to remove the dir, and that was the original bug anyway | |
| 13:39:07 | mriedem | lyarwood: https://review.openstack.org/#/c/524208/ landed when queens was master | |
| 13:39:11 | lyarwood | mriedem: right, ignore me, the fscking gerrit UI didn't list it as in Queens | |
| 13:39:23 | mriedem | "included in" dropdown | |
| 13:39:26 | mriedem | is what i check | |
| 13:39:41 | mriedem | lyarwood: you and mdbooth might also be interested in https://review.openstack.org/#/c/566367 | |
| 13:39:42 | lyarwood | mriedem: yeah it didn't display correctly, checked it again and there it is | |
| 13:39:45 | mriedem | dealing with libvirt imagebackend fun | |
| 13:42:14 | efried | mdbooth: ack, and thanks. | |
| 13:46:25 | mdbooth | mriedem: Somebody should clean that thing up ;) | |
| 13:52:22 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix detach_volume calls when rolling back a failed attach https://review.openstack.org/563213 | |
| 13:52:23 | mriedem | efried: gibi: test fixed, ^ - nice catch gibi | |
| 13:52:31 | mriedem | that's one that also needs to go back to queens as a regression fix | |
| 13:53:29 | mriedem | dansmith: can you hit this queens backport? https://review.openstack.org/#/c/564461/ | |
| 13:54:04 | dansmith | mriedem: yeah | |
| 13:54:48 | mriedem | thanks | |
| 13:55:07 | kashyap | Matt, when you can: https://review.openstack.org/#/c/565242/ ("libvirt: Deprecate support for monitoring Intel CMT `perf` events") | |
| 13:55:20 | kashyap | The unit test is "fixed", but in the most robust way. | |
| 13:55:31 | kashyap | (But that's dead code anyway, and we will remove it in Stein.) | |
| 13:55:54 | kashyap | If there are any better ways I can rewrite the new unit test, welcome. | |
| 13:57:12 | mriedem | lyarwood: this would also be good for cern https://review.openstack.org/#/c/566288/ | |
| 14:00:46 | jaypipes | mriedem: sure thing. gimme a few, though. trying to rebase a nasty. | |
| 14:00:51 | gibi | mriedem: +2+A on https://review.openstack.org/563213 | |
| 14:06:07 | mriedem | gibi: thanks | |
| 14:08:12 | wolverineav | mriedem: i've updated the patch with changes as suggested (https://review.openstack.org/#/c/534371/) please take a look when you have a moment :) | |
| 14:08:48 | mriedem | dansmith: pretty sure this is going to be a no-no backport given the object version changes yeah? https://review.openstack.org/#/c/563797/ | |
| 14:10:16 | mriedem | wolverineav: ack, lgtm, just waiting on zuul | |
| 14:11:19 | mriedem | actually +2; stephenfin - mind hitting https://review.openstack.org/#/c/534371/ again? | |
| 14:11:26 | wolverineav | mriedem: thanks! i wanted to proactively get that looked at. its been in review quite some time. | |
| 14:11:52 | mriedem | wolverineav: yup, i know, thanks for your patience | |
| 14:11:56 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix detach_volume calls when rolling back a failed attach https://review.openstack.org/567232 | |
| 14:12:13 | mriedem | lyarwood: dansmith: ^ we'll want to get that in the queens release we do this week | |
| 14:12:33 | dansmith | mriedem: yeah, if it had been done non-remotable it would have been okay, but.. | |
| 14:13:22 | dansmith | mriedem: okay doesn't look like the master one has landed yet | |
| 14:15:11 | mriedem | dansmith: re that pike list_hosts one, -2 since they still have the nova-manage host list command in pike | |
| 14:15:18 | mriedem | so they can just run that with --config-file pointed at the cell db | |
| 14:16:16 | dansmith | ack | |
| 14:19:18 | openstackgerrit | Matthew Booth proposed openstack/nova master: Expose driver_block_device fields consistently https://review.openstack.org/528362 | |
| 14:19:19 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | |
| 14:21:11 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Unmap compute nodes when deleting host mappings in delete cell operation https://review.openstack.org/553829 | |
| 14:22:50 | dansmith | mriedem: melwitt tssurya: Do we have content for a cells meeting today? I got feedback on my patches to work on, which was my only thing. tssurya said maybe belmiro would have some things to discuss this week I think? | |
| 14:23:13 | mriedem | lyarwood: are you still working on this pike backport? https://review.openstack.org/#/c/561015/ | |
| 14:24:15 | openstack | Launchpad bug 1746863 in OpenStack Compute (nova) "scheduler affinity doesn't work with multiple cells" [High,In progress] - Assigned to melanie witt (melwitt) | |
| 14:24:15 | mriedem | dansmith: i don't really have anything; i created a todo for myself to write some kind of functional regression test for https://bugs.launchpad.net/nova/+bug/1746863 - separate from the one i think mel was going to write | |
| 14:24:23 | mriedem | for a separate but related bug we talked about the other day | |
| 14:24:26 | dansmith | ack | |
| 14:24:43 | lyarwood | mriedem: nope that dropped off my list, I can take another look at it in the next hour or so | |
| 14:24:44 | mriedem | he other cell, so it will think it's fine. " | |
| 14:24:44 | mriedem | "TODO: We need a new bug and test for the multi-cell affinity scenario where two instances are scheduled at the same time in the same affinity group. We need 2 cells with 1 host each, with exactly enough capacity to fit just one instance so that placement will fail the first request and throw it into the other host in the other cell. The late affinity check in the compute won't fail because it can't see the other member | |