Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-05-09
08:28:21 tetsuro ^ jauypipes, efried, bauzas: started nested allocation candidates branch in a different way.
08:31:34 kashyap stephenfin: Hey, when you can, see what's wrong with my test here: https://review.openstack.org/#/c/565242/5/nova/tests/unit/virt/libvirt/test_driver.py
08:33:27 openstackgerrit Merged openstack/nova master: Remove unused methods in nova/compute/utils.py https://review.openstack.org/566855
08:36:11 kashyap Merci!
08:36:38 kashyap stephenfin: It is mostly just me not being good with the unit tests. The change is quite simple, if you see the commit message.
08:36:44 kashyap (And the driver.py code)
08:49:58 openstackgerrit Merged openstack/nova master: Convert certificate generation to processutils. https://review.openstack.org/564146
09:09:23 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add tests for sharing rps in test_common_rc() https://review.openstack.org/566842
09:11:03 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add tests for alloc cands with poor local disk https://review.openstack.org/566842
09:11:28 stephenfin kashyap: Done
09:11:44 kashyap stephenfin: Thanks; will look
09:12:46 kashyap stephenfin: About actually being supported by the processor or not change. I first thought to remove it completely because, regardless of it, it's useless
09:12:49 kashyap But ...
09:13:11 kashyap Since the first change is to deprecate the support, I should retain it
09:15:33 stephenfin kashyap: No, you can remove it but call that out and fix the test accordingly
09:15:46 stephenfin No point keeping dead code around
09:16:04 kashyap stephenfin: Right. So the plan is: Deprecate it in Rocky; delete support for it in Stein.
09:16:22 kashyap I have it locally as you indicated
09:24:50 openstackgerrit lei zhang proposed openstack/python-novaclient master: Fix the incorrect cirros default password https://review.openstack.org/567170
09:28:25 openstackgerrit jichenjc proposed openstack/nova master: [Doc]Link policies file into api https://review.openstack.org/561503
09:30:27 kashyap stephenfin: With the 'assert_has_calls', you meant:
09:30:28 kashyap ])
09:30:28 kashyap mock.call(...),
09:30:28 kashyap mock_warn.assert_has_calls([
09:30:33 kashyap ?
09:30:36 stephenfin yup
09:31:12 kashyap Maybe I should consider that.
09:31:38 openstackgerrit jichenjc proposed openstack/nova master: Enhance api-guide general info some updates https://review.openstack.org/561773
09:37:10 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
09:37:11 openstackgerrit Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435
09:37:12 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857
09:37:29 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job https://review.openstack.org/564067
09:44:40 openstackgerrit jichenjc proposed openstack/nova master: [doc] Add soft_deleted flag https://review.openstack.org/562897
09:53:52 openstackgerrit Jan Gutter proposed openstack/nova stable/queens: Add plumbing for Contrail/Tungsten Fabric offloads https://review.openstack.org/567177
09:59:06 liuzz_ hello everyone, Who can help me? i want to create a new role and only allow it to manage keystone resource, can't manager other reources(instances, volumes, ...),What should I do？
10:01:24 kashyap stephenfin: How about I just assert that the warning has happened N number of times for each event?
10:01:44 kashyap Like: self.assertEquals(N, mock_warn.call_count)
10:03:27 stephenfin I'm not sure. I'd just do what you've done there
10:03:57 kashyap No problem; I'll tinker a bit
10:04:32 kashyap (Calling the exact warning message isn't nice.)
10:04:47 kashyap Anyhow, disregard me for now
10:06:06 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Deprecate support for monitoring Intel CMT `perf` events https://review.openstack.org/565242
10:26:42 openstackgerrit Stephen Finucane proposed openstack/nova master: Simplify instance name generation https://review.openstack.org/516573
10:29:17 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Add mypy target https://review.openstack.org/538221
10:29:18 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Store list of converted files https://review.openstack.org/538222
10:29:19 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.openstack.org/538224
10:29:20 openstackgerrit Stephen Finucane proposed openstack/nova master: zuul: Add 'mypy' job https://review.openstack.org/539168
10:31:46 openstackgerrit Chris Dent proposed openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116
10:32:05 cdent johnthetubaguy: there's a spec and real ci behind that ^ now
10:32:12 cdent (it's got your -2 on it)
10:37:45 andreas_s melwitt: Hi, I'm facing an issue with the following devstack patch you commited a few days ago: https://github.com/openstack-dev/devstack/commit/12579c3db7b28381c8ec97945aa23ee02d54d22b
10:38:23 stephenfin bauzas: If you're about today, could you take a look at https://review.openstack.org/#/c/541290/ ?
10:38:40 andreas_s melwitt: It seems like this patch is moving the console configurtion (vnc, spice, serial) from nova.conf into the nova-cell config
10:39:12 andreas_s melwitt: but the n-cpu systemd service is not consuming the nova_cell config - with the result, that the console setting is being ignored
10:40:44 stephenfin andreas_s: I was thinking the exact same thing but chose to ignore my intuition https://review.openstack.org/#/c/550141/1/
10:41:07 stephenfin (vs. https://review.openstack.org/#/c/550141/2/)
10:41:36 andreas_s stephenfin: ah good to know
10:43:22 andreas_s stephenfin: but the challenge is still that devstack seems to specify the cell_config file as input parameter to configure_console_proxies, doesn't it?
10:43:55 andreas_s at least in our thirdparty CI the config landed in the cell config file: http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/510897/13/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/3e67649/logs/etc/nova/
10:44:57 stephenfin andreas_s: Yup. I'm still trying to figure out which specific setting the conductors (which I think are the only services to use those files) need configured
10:45:24 stephenfin because I thought most/all of them are only used by nova-compute
10:45:59 andreas_s yeah, nova-compute needs this config in definitively!
10:47:52 stephenfin andreas_s: I'd file a bug, personally. I'll take a look at it after lunch and see if we can come up with something
10:49:01 jmccarthy mriedem: Thanks for the update on https://review.openstack.org/#/c/566367 ! I tested this out, and patchest2 worked great for me
10:49:38 andreas_s stephenfin: that would be great. thanks. Can you subscribe me to this bug once opened (andreas scheuring)? thx. If you need any more input, let know...
10:50:24 stephenfin andreas_s: "I would file a bug, personally", e.g. I suggest _you_ file a bug :)
10:50:33 stephenfin I could do it, but you probably have the most context
10:50:36 stephenfin and logs
10:50:41 andreas_s ok, will do
10:50:57 andreas_s stephenfin: just was not sure how to interpret "I would" ;)
10:51:13 stephenfin That's an Irish'ism. Sorry :)
10:51:55 andreas_s hehe, enjoy your lunch!
10:53:58 openstackgerrit Merged openstack/nova master: Remove [scheduler]/host_manager config option https://review.openstack.org/565806
11:02:53 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Deprecate support for monitoring Intel CMT `perf` events https://review.openstack.org/565242
11:04:38 openstackgerrit Rajat Sharma proposed openstack/nova master: Imposing restrictions on resource providers create uuid https://review.openstack.org/567191
11:06:18 openstack Launchpad bug 1770143 in devstack "Nova Console setup broken" [Undecided,New]
11:06:18 andreas_s stephenfin, melwitt: opened the bug against devstack: https://bugs.launchpad.net/devstack/+bug/1770143
11:11:05 ShilpaSD dansmith: hi
11:29:25 openstackgerrit Naichuan Sun proposed openstack/nova master: XenAPI: deprecate the config for image handler class path https://review.openstack.org/497201
12:09:29 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
12:09:30 openstackgerrit Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435
12:09:31 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857
12:10:03 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job https://review.openstack.org/564067
12:19:31 openstackgerrit Balazs Gibizer proposed openstack/nova master: Followup for multiple member_of qparams support https://review.openstack.org/567209
12:30:39 openstackgerrit Radoslav Gerganov proposed openstack/nova stable/queens: Handle PortNotFoundClient exception when getting ports https://review.openstack.org/567211
12:41:34 openstackgerrit Jan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads https://review.openstack.org/567148
13:01:15 mdbooth efried: Morning! https://review.openstack.org/#/c/564017/
13:01:51 mdbooth That's causing me a problem, and I considering proposing a revert. However, I think it only exists due to bad naming.
13:02:15 efried mdbooth: stand by.
13:02:30 efried mdbooth: Okay, do tell.
13:02:47 mdbooth efried: I see you proposed it because of the loop in the ironic driver
13:03:13 efried mdbooth: Well, actually because of [2] (in the commit message), but [1] was a good excuse.
13:03:25 mdbooth efried: Sec, lemme check 2
13:03:26 openstackgerrit Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371
13:03:50 efried mdbooth: TL;DR, we were checking for volume-ness in a different (and apparently wrong
13:03:55 efried ) way in the powervm driver.
13:04:15 mdbooth efried: Thing is, the ironic driver doesn't need that check
13:04:16 efried mdbooth: mriedem pointed out that we should be using is_volume... which led us to find out that it didn't exist.
13:04:38 efried mdbooth: Well, is the new version of the check doing something the old one wasn't?
13:04:47 mdbooth Because, confusingly, block_device_info_get_mapping() should actually be called block_device_info_get_volumes()

Earlier   Later