| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-04 | |||
| 19:31:13 | mriedem | easiest -1 ever | |
| 19:31:28 | eandersson | haha | |
| 19:31:29 | eandersson | omg | |
| 19:31:39 | eandersson | was too fixated on the translation | |
| 19:31:48 | eandersson | good, get to fix that missing e in computes | |
| 19:32:20 | kashyap | mriedem: This is largely code deletion, should be easy for you: https://review.openstack.org/#/c/565242/ | |
| 19:32:27 | openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/nova master: Changing scheduler sync event from INFO to DEBUG https://review.openstack.org/566392 | |
| 19:33:59 | mriedem | eandersson: off the top of your head, what's the average number of cpus in your compute hosts? | |
| 19:34:01 | mriedem | 16? 32? | |
| 19:35:03 | eandersson | 32 probably | |
| 19:35:23 | mriedem | ok. so you wouldn't run something like 132 concurrent live migrations on a compute host like that would you. | |
| 19:35:28 | mriedem | 32 * 5 | |
| 19:35:53 | eandersson | Yea unlikely | |
| 19:36:06 | mriedem | cool, fyi https://docs.python.org/3.5/library/concurrent.futures.html#concurrent.futures.ThreadPoolExecutor | |
| 19:39:21 | mriedem | your logging change is sane btw, check out a 24 hour CI run for that log message http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Successfully%20synced%20instances%20from%20host%5C%22%20AND%20tags%3A%5C%22screen-n-sch.txt%5C%22&from=1d | |
| 19:39:31 | mriedem | ~16K hits | |
| 19:55:26 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add columns for generation to consumers https://review.openstack.org/557958 | |
| 19:55:27 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add Project, User and Consumer objects https://review.openstack.org/565403 | |
| 19:55:28 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add create() methods to Project, User and Consumer https://review.openstack.org/565404 | |
| 19:55:29 | openstackgerrit | Jay Pipes proposed openstack/nova master: move consumer ensure to API layer https://review.openstack.org/565405 | |
| 19:55:30 | openstackgerrit | Jay Pipes proposed openstack/nova master: remove Allocation.project_id & Allocation.user_id https://review.openstack.org/565406 | |
| 19:55:31 | openstackgerrit | Jay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict() https://review.openstack.org/565407 | |
| 19:55:32 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604 | |
| 20:01:21 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Add InstanceNUMATopology to LibvirtLiveMigrateData https://review.openstack.org/566398 | |
| 20:03:50 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Add InstanceNUMATopology to LibvirtLiveMigrateData https://review.openstack.org/566398 | |
| 20:15:30 | arvindn05 | mriedem: question on tests cases within conductor | |
| 20:17:11 | arvindn05 | ||
| 20:17:11 | arvindn05 | why are we running few tests multiple times? ConductorTaskAPITestCase,ConductorTaskRPCAPITestCase extend from _BaseTaskTestCase and test_compute.BaseTestCase | |
| 20:18:45 | arvindn05 | they both run test_unshelve_instance_on_host for example...which is defined under the BaseTaskTestCase. i dont see any differences in the test setup either... | |
| 20:19:54 | mriedem | one hits the rpcapi and one doesn't | |
| 20:23:34 | arvindn05 | ahh...noticed the difference in setups now...the difference is very subtle...will add a line comment on top of self.conductor so it draws the difference for future contributors | |
| 20:25:52 | arvindn05 | btw i investigated further on code changes...wanted to confirm something with you | |
| 20:26:26 | arvindn05 | mriedem: i would need to add an else condition here as well correct? to handle rebuild with image remaining the samehttps://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L913 | |
| 20:29:08 | arvindn05 | see http://paste.openstack.org/show/720407/ for how i think the code would need to look....let me know if this is not consistent with your idea and i can rework as needed | |
| 20:31:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | |
| 20:31:09 | mriedem | superdan: huzzah ^ that's not too bad | |
| 20:31:29 | mriedem | arvindn05: i said else after the elif here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L943 | |
| 20:31:46 | mriedem | arvindn05: idk, do we need to re-validate the host/image for rebuild if the image doesn't change? | |
| 20:32:02 | mriedem | i guess that's just to catch a case that the traits on the compute node resource provider changed even though the image didn't? | |
| 20:32:38 | arvindn05 | yup...melwitt suggested we use the same approach as imageproperties filter....which i beleive has the same behavior | |
| 20:32:46 | arvindn05 | we run even though image hasnt changed | |
| 20:34:14 | arvindn05 | i added the else as well @943 see http://paste.openstack.org/show/720407 - line58 | |
| 20:35:26 | arvindn05 | briefly tested the approach...it works...adding more unit tests | |
| 20:36:38 | superdan | mriedem: looks weird to index by migration uuid instead of instance, is that because of how the cancel migration call works? | |
| 20:37:56 | mriedem | i think it could go either way, live_migration_abort gets the instance and migration | |
| 20:38:22 | mriedem | kevin just doesn't have that patch up yet | |
| 20:39:35 | superdan | okay I'll make a half-assed comment about it | |
| 20:40:50 | mriedem | quarter cheek friday please | |
| 20:44:03 | mriedem | arvindn05: that's not correct, | |
| 20:44:17 | mriedem | for rebuild, if the image doesn't change, we don't run through the scheduler, so we don't run the ImagePropertiesFilter | |
| 20:44:34 | mriedem | see https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L898 | |
| 20:44:48 | mriedem | if host != instance.host: will be False in that block for rebuild | |
| 20:45:55 | mriedem | so, idk, that's new validation in the rebuild + same image case, i don't know if we need to revalidate the image in that case, we didn't before, but i also don't really care all that much | |
| 20:46:29 | arvindn05 | ok...i guess it can be handled as part of CR | |
| 20:50:33 | mriedem | arvindn05: +2 on the spec amendment | |
| 20:50:39 | mriedem | time for you to pop a bottle | |
| 20:50:45 | mriedem | of pills | |
| 20:50:48 | arvindn05 | awesome...thanks! :) | |
| 20:54:07 | arvindn05 | mriedem: see here on melwitt comments http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-05-03.log.html#t2018-05-03T20:48:55 | |
| 20:55:57 | arvindn05 | i think if we are not running imageproperties filter now when image does not change we might want to be consistent...i can raise a bug to state that we dont run image properties filter if image hasnt changed(even though image properties on that image could have changed) | |
| 20:57:40 | arvindn05 | and when its fixed...they can fix to handle traits as well....another way is if i just need to call schedule instances for running the image properties filter...i can do that as part of this change | |
| 21:04:53 | mriedem | please no | |
| 21:05:14 | mriedem | i think if we don't call the scheduler (ImagePropertiesFilter) today, we should just continue to not do the validation | |
| 21:05:24 | mriedem | i.e. image doesn't change | |
| 21:07:03 | arvindn05 | sounds like a plan....although a bug might be warranted at that point.... | |
| 21:07:26 | mriedem | i don't know that it's a bug | |
| 21:07:35 | mriedem | but it's 4pm on a friday, so i also don't care to think about this right now | |
| 21:07:59 | arvindn05 | in case of rebuild with a trait like Trusted host...if the host is no longer trusted we should prevent rebuild...might be a security issue | |
| 21:08:34 | arvindn05 | but like you said...its friday...we can figure it out in the CR :) | |
| 21:08:39 | mriedem | is trusted host a standard trait? | |
| 21:08:40 | arvindn05 | any plans for the weekend? | |
| 21:08:54 | mriedem | yardwork, mexican food and avoiding little girls | |
| 21:09:12 | mriedem | i.e. my daughters annoying friends, not pervy stuff | |
| 21:09:23 | arvindn05 | nope....its a custom trait...but traits could be used for security things as well | |
| 21:09:45 | arvindn05 | lol....good job with the quick clarification :P | |
| 21:09:59 | openstackgerrit | Jay Pipes proposed openstack/nova master: rework how we pass candidate request information https://review.openstack.org/566166 | |
| 21:10:00 | mriedem | if an external service says this host is trusted or not and there are instances using an image that requires a trusted host, then i'd expect that external service to migrate those instances before saying it's no longer trusted | |
| 21:10:06 | mriedem | not waiting for the user to rebuild and find out | |
| 21:10:19 | mriedem | the instance user is not an admin so they can't see what the traits are on the node RP anyway | |
| 21:11:38 | arvindn05 | i guess there are 2 models...there is just a trust attestation piece which does not do any active managment...but more for reporting...another could be with active management like you mentioned | |
| 21:12:20 | arvindn05 | anyway...will leave you to enjoy your friday and the weekend :) | |
| 21:12:44 | mriedem | i would personally prefer that nova doesn't grow a bunch of side effect code to handle random traits-related what-if kind of conditionals because of the ability of external services to monkey with traits on compute node providers | |
| 21:13:02 | mriedem | and with that, i'm out also, ttyl | |
| 21:13:18 | arvindn05_away | ttyl | |
| #openstack-nova - 2018-05-05 | |||
| 00:38:29 | openstackgerrit | Merged openstack/nova stable/queens: Handle @safe_connect returns None side effect in _ensure_resource_provider https://review.openstack.org/566161 | |
| 00:38:37 | openstackgerrit | Merged openstack/nova master: Use test_base symbols directly https://review.openstack.org/564592 | |
| 01:11:30 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Added ability to configure default architecture for ImagePropertiesFilter https://review.openstack.org/566425 | |
| 01:58:01 | openstackgerrit | Merged openstack/nova master: Use helpers in test_resource_provider (func) https://review.openstack.org/564638 | |
| 14:45:31 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604 | |
| #openstack-nova - 2018-05-06 | |||
| 07:22:23 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Consider nested RPs in get_all_with_shared https://review.openstack.org/556450 | |
| 07:22:24 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates https://review.openstack.org/556514 | |
| 07:22:25 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support nested alloc cands without shared RPs https://review.openstack.org/561842 | |
| 07:22:26 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries https://review.openstack.org/558045 | |
| 07:22:27 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480 | |
| 07:22:28 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories https://review.openstack.org/559554 | |
| 07:22:29 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support nested allocation candidates in placement https://review.openstack.org/565487 | |
| 08:49:59 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support nested allocation candidates in placement https://review.openstack.org/565487 | |
| 18:32:57 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add scheduling notification https://review.openstack.org/566470 | |
| 19:48:15 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473 | |
| 22:23:31 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix the policy argument in server-group-create https://review.openstack.org/564699 | |