| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-05-02 | |||
| 19:41:56 | arvindn05 | thanks! | |
| 19:42:00 | melwitt | mriedem: it might have been. I can't think of any other way this makes sense but I didn't find that yet. tbh I don't remember where to find the skip list for ceph | |
| 19:43:03 | mriedem | i don't think it ever landed, i remember cleaning up something about this recently | |
| 19:43:49 | mriedem | https://review.openstack.org/#/c/550497/ | |
| 19:46:40 | melwitt | so both skip list changes are abandoned ... does that mean there's no skip list? I'm confused | |
| 19:47:08 | melwitt | so that implies that test is new? *looks* | |
| 19:47:18 | mriedem | it's not new | |
| 19:47:23 | mriedem | it's only recently been renamed | |
| 19:47:31 | mriedem | but the idempotent id hasn't changed | |
| 19:47:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add nova-manage placement heal_allocations CLI https://review.openstack.org/565886 | |
| 19:47:51 | melwitt | hrm | |
| 19:47:54 | mriedem | mgagne: dansmith: ^ here is my start, sans tests and docs and lots of todos/notes | |
| 19:48:16 | mriedem | melwitt: this is the job definition, and no it doesn't have a skip list http://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/playbooks/legacy/tempest-dsvm-py35-full-devstack-plugin-ceph/run.yaml#n2 | |
| 19:48:26 | mriedem | jbernard was working on one but as you can see those patches were all abandoned | |
| 19:48:27 | melwitt | doubleyew tee eff | |
| 19:48:31 | mriedem | so for awhile the job was just totally broken | |
| 19:48:52 | melwitt | I don't know how this test could ever pass with ceph | |
| 19:49:45 | melwitt | and the job hasn't been broken for _that_ long, I didn't think | |
| 19:49:52 | melwitt | anywho | |
| 19:50:01 | mriedem | melwitt: could be that it wasn't using DEVSTACK_GATE_TEMPEST_FULL | |
| 19:51:09 | mriedem | tempest tox -e full runs tempest api tests concurrently and then scenario tests serially | |
| 19:51:12 | mriedem | and this is a scenario tes | |
| 19:51:13 | mriedem | *test | |
| 19:51:22 | efried | arvindn05: Do we always have access to the old image metadata during a rebuild? | |
| 19:51:26 | melwitt | okay, I'll take a look for that | |
| 19:51:48 | mriedem | if DEVSTACK_GATE_TEMPEST_* isn't specified, it looks like it should just be running smoke tests | |
| 19:52:05 | arvindn05 | nope...we have the old image ref though....we can load the image meta from that | |
| 19:52:49 | mriedem | efried: arvindn05: you should, it's in the request spec | |
| 19:52:56 | efried | okay | |
| 19:53:12 | mriedem | https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L49 | |
| 19:53:33 | mriedem | melwitt: maybe this https://github.com/openstack/devstack-plugin-ceph/commit/430fff8313a364f951423768d9ee8fdba4e79a27 | |
| 19:53:42 | mriedem | nvm that's just manila | |
| 19:54:20 | arvindn05 | for rebuild at the api level a request spec is not created yet i think | |
| 19:54:29 | arvindn05 | compute.api.API#rebuild | |
| 19:54:46 | arvindn05 | i am looking at that method to add the validation...is it the right place? | |
| 19:54:59 | mriedem | the request spec is from when the instance was created | |
| 19:55:53 | mriedem | also, instance.image_meta is the current instance image meta for the instance | |
| 19:56:02 | mriedem | so you don't even need the request spec | |
| 19:56:40 | arvindn05 | great | |
| 19:57:11 | arvindn05 | i would just need to load the new image meta then to compare each other | |
| 19:58:29 | mriedem | you have the new image here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3013 | |
| 20:00:04 | arvindn05 | btw is there an instance.image_meta? i dont see it under objects.instance.Instance | |
| 20:02:46 | mriedem | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L238 | |
| 20:03:43 | arvindn05 | ahh..its not a field...but a property got it | |
| 20:07:34 | melwitt | mriedem: indeed, here's a job pass on stable/queens from today http://logs.openstack.org/68/565668/1/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/b6047e4/job-output.txt.gz#_2018-05-02_09_46_32_680582 | |
| 20:08:11 | mriedem | hmm, tempest and devstack-plugin-ceph are branchless, | |
| 20:08:20 | mriedem | so whatever is broken must be in master only for nova or cinder | |
| 20:08:39 | melwitt | yeah, exactly. odd. going to see if I can find what's different | |
| 20:10:13 | mriedem | melwitt: my money is on that schema change in the cinder api which is queens only, merged in march | |
| 20:10:30 | melwitt | you mean rocky only? | |
| 20:10:32 | mriedem | before that, the api would just pass attachment_id=None down to the volume manager which handled it https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L1296 | |
| 20:10:40 | mriedem | yeah, i'll never adapt to rocky | |
| 20:10:49 | melwitt | QueensMan | |
| 20:11:00 | melwitt | okay, I think I missed where you pointed out the schema change. *scrolls back* | |
| 20:13:26 | melwitt | ah yep, so there used to be no schema validation I guess? agreed that has to be the reason for the failure now | |
| 20:15:48 | mriedem | melwitt: https://bugs.launchpad.net/cinder/+bug/1768650 | |
| 20:15:48 | openstack | Launchpad bug 1768650 in Cinder "POST /volumes/{volume_id}/action os-detach incorrectly requires attachment_id is not None" [Undecided,New] | |
| 20:15:59 | mriedem | i'll push a patch to cinder | |
| 20:16:37 | melwitt | sounds great | |
| 20:41:41 | mriedem | yeehaw http://paste.openstack.org/show/720250/ | |
| 20:42:32 | melwitt | old school, email it | |
| 20:42:52 | mriedem | heh, i thought about it | |
| 21:29:15 | cfriesen | has anyone ever looked at supporting "-cpu host,migratable=no,+invtsc" in order to get the "nonstop_tsc" flag in the guest? The tricky bit seems to be that nova might want to block attempts to migrate or snapshot the instance if it's enabled since it's going to fail down in qemu. | |
| 22:07:54 | dansmith | melwitt: HEY. This country was built with patch-on-ML! | |
| 22:08:15 | melwitt | ;D | |
| 22:12:45 | lbragstad | melwitt: o/ johnthetubaguy was telling me that you are a quota expert | |
| 22:14:43 | melwitt | lbragstad: o/ an accidental one, maybe | |
| 22:15:35 | lbragstad | :) i was working with john on documenting CERN's usecase for hierarchical quotas/limit with the unified limit approach | |
| 22:15:55 | lbragstad | i think i got it all out on paper now, https://review.openstack.org/#/c/565412/ | |
| 22:16:14 | lbragstad | but figured you'd be pretty good at poking holes in what we have so far | |
| 22:16:38 | lbragstad | (there are a ton of diagrams, but the rendered version isn't bad- http://logs.openstack.org/12/565412/3/check/build-openstack-sphinx-docs/22ea042/html/specs/keystone/rocky/strict-two-level-enforcement-model.html ) | |
| 22:17:10 | melwitt | a-ha, very cool. I will definitely take a look | |
| 22:17:56 | lbragstad | thanks melwitt | |
| 22:18:49 | melwitt | oh, heh, so failed == excluded from the output entirely. that's helpful of it :P | |
| 22:19:37 | melwitt | lbragstad: np, thanks for linking me | |
| 22:20:21 | lbragstad | no problem - latest patch set should render the python example for service to incorporate the limit usage | |
| 22:20:35 | melwitt | excellent | |
| 22:22:46 | openstackgerrit | Eric Fried proposed openstack/nova master: Get anchors for sharing providers https://review.openstack.org/565279 | |
| 22:22:47 | openstackgerrit | Eric Fried proposed openstack/nova master: placement: Object changes for granular https://review.openstack.org/564351 | |
| 22:22:48 | openstackgerrit | Eric Fried proposed openstack/nova master: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | |
| 22:25:56 | openstackgerrit | karim proposed openstack/nova master: Pushing image traits to ironic node https://review.openstack.org/565620 | |
| 22:51:10 | efried | mriedem: Good job distancing yourself from the image traits rebuild issue. | |
| 22:52:10 | efried | That lasted, what, four hours? | |
| 22:52:47 | mriedem | almost 9 | |
| 22:55:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add nova-manage placement heal_allocations CLI https://review.openstack.org/565886 | |
| 22:55:20 | mriedem | mgagne: now with functional tests ^ | |
| 22:56:37 | mgagne | mriedem: cool stuff! are there multiple cells in the test? | |
| 22:57:03 | mriedem | yes, except that doesn't currently work b/c there is a bug in our fixtures, i need to test it with https://review.openstack.org/#/c/524264/ or https://review.openstack.org/#/c/558160/ underneath | |
| 22:57:14 | mriedem | but, in-laws are here and i'm going to get yelled at soon | |
| 22:58:45 | mgagne | mriedem: there is no rush, have a good one ;) | |
| 23:11:22 | openstackgerrit | Hongbin Lu proposed openstack/nova master: Use revision_number on adding/removing security group https://review.openstack.org/535510 | |
| 23:15:51 | melwitt | guh, all that hacking on CellDatabases that I was trying to fix with https://review.openstack.org/508432 makes me sad | |
| 23:21:01 | arvindn05 | melwitt: thanks for the reply on the rebuild thread....wanted to get your thoughts on whether the approach is easy to maintain going forward | |
| 23:21:58 | arvindn05 | melwitt: my main concern is if we decide to support forbidden/granular traits etc for images at some point, this part of the logic will need to be updated | |
| 23:22:02 | melwitt | well, rejecting a valid request doesn't seem correct and would likely require later maintenance too | |
| 23:22:08 | arvindn05 | aand maintained going forward... | |
| 23:22:36 | melwitt | meaning, the placement queries would have to be updated? | |
| 23:24:56 | arvindn05 | not just that....the current approach is to get allocations for current instance and then match them in the conductor | |
| 23:25:46 | arvindn05 | the matching happens in the conductor for required traits for now...but if we need to handle granular/forbidden traits etc this matching logic will need to be updated | |
| 23:27:00 | melwitt | can you point me to the code you're referring to? | |