| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-26 | |||
| 21:22:11 | edleafe | efried: I think that the virt driver would be the "creator", since it reports its presence | |
| 21:22:22 | edleafe | Cyborg would be an outside agent in this case | |
| 21:23:03 | Sundar | efried: Yes, I'd prefer using nRPs. But edleafe has advised us not to rely upon that in Rocky. So, we are creating a backup plan to apply the traits on the compute node RP instead. That in turn has consequences for supporting multiple device types on the same node. It is getting a bit complicated. | |
| 21:23:14 | efried | edleafe: Yes, but we decided to allow merging of traits supplied by outside parties. | |
| 21:23:57 | efried | Sundar: Yeah, the only way you could reliably support multiple device types on the same provider would be via custom resource classes. And you would then have to unwind that model when nrp is in place. | |
| 21:26:24 | edleafe | efried: that was why I advised Cyborg to wait until NRP was working. | |
| 21:26:58 | edleafe | efried: do you have an educated guess as to how much of NRP will make it into Rocky? | |
| 21:27:44 | efried | edleafe: It's really binary: will nrp-in-alloc-cands make it or not. | |
| 21:28:48 | edleafe | efried: ok, then, rephrasing. Do you think NRP will make it into Rocky? | |
| 21:29:05 | efried | edleafe: I can't answer that. Question for jaypipes | |
| 21:31:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix tox -e docs https://review.openstack.org/564631 | |
| 21:32:21 | arvindn0_ | mriedem: quick clarification. conductor.manager.ComputeTaskManager#rebuild_instance already expects and handles no valid host exception | |
| 21:32:22 | lbragstad | mriedem: added a couple comments to your placement patch | |
| 21:33:58 | mriedem | lbragstad: already replied :) | |
| 21:34:14 | mriedem | arvindn0_: yes, but that's already after nova-api rpc cast to nova-conductor | |
| 21:34:18 | mriedem | and returned a 202 to the user | |
| 21:34:20 | arvindn0_ | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L953 | |
| 21:34:25 | mriedem | arvindn0_: yes i realize | |
| 21:34:49 | mriedem | it's best, imo, if we can fail fast in the API with a 400 - if we're going to do that | |
| 21:34:58 | mriedem | like trying to rebuild a volume-backed instance with a new image | |
| 21:35:22 | arvindn0_ | yea...makes sense | |
| 21:35:30 | mriedem | i don't like the idea of making this an error condition though, because i think that's just technical debt we'll eventually have to fix | |
| 21:35:37 | mriedem | but, like i said, i need to read the rest of the ML thread | |
| 21:36:11 | arvindn0_ | when you say the api do you mean near the API entry point? | |
| 21:36:45 | arvindn0_ | or still in the conductor API conductor.api.ComputeTaskAPI#rebuild_instance | |
| 21:37:07 | arvindn0_ | not sure where the volume backed instance example is | |
| 21:37:30 | mriedem | nova.compute.api.API.rebuild_instance | |
| 21:40:27 | arvindn0_ | found it... | |
| 21:41:42 | arvindn0_ | my main concern is that if we extend image properties in future to allow granular/forbidden etc traits in future...this logic will need to be updated to handle all of those cases | |
| 21:43:37 | arvindn0_ | for granular traits for example, the code we need to add would be as complicated if not more incase we need to handle rebuild taking all those into account | |
| 21:46:53 | jaypipes | mriedem: "the great placement schism of 2018" lol :) | |
| 21:48:07 | mriedem | lance stepped right into a big pile of it | |
| 22:27:53 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use helpers in test_resource_provider (func) https://review.openstack.org/564638 | |
| 22:31:02 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (1) https://review.openstack.org/564639 | |
| 22:40:29 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Add consumer generation checking logic https://review.openstack.org/564641 | |
| 22:45:45 | melwitt | mriedem: did you mention sort of recently that we had a new dbdeadlock somewhere? | |
| 22:46:59 | openstack | Launchpad bug 1642537 in OpenStack Compute (nova) "finish_resize fails with DBDeadlock on migrations table" [Undecided,Confirmed] | |
| 22:46:59 | mriedem | yeah, but now i don't remember if i opened a bug for it, since i only see https://bugs.launchpad.net/nova/+bug/1642537 | |
| 22:47:06 | melwitt | yeah, same | |
| 22:47:22 | melwitt | logstashin it | |
| 22:49:15 | melwitt | lots in neutron | |
| 22:50:14 | mriedem | neutron has a lot of retry_on_deadlock decorators | |
| 22:50:32 | mriedem | you likely need to add: AND tags:"screen-n-cpu.txt" | |
| 22:50:49 | melwitt | thanks, was about to try that | |
| 22:51:20 | melwitt | [instance: 6dcdb60e-e398-43c0-a6c0-21d0494185c1] RemoteError: Remote error: DBDeadlock (pymysql.err.InternalError) (1213, u'Deadlock found when trying to get lock; try restarting transaction') [SQL: u'UPDATE migrations SET updated_at=%(updated_at)s, status=%(status)s WHERE migrations.id = %(migrations_id)s'] [parameters: {'status': u'post-migrating', 'migrations_id': 4, 'updated_at': datetime.datetime(2018, 4, 26, 21, 16, 31, 790833)}] | |
| 22:52:58 | melwitt | 8 hits in the last 7 days but all on the same change and all in the ceph job. seems weird | |
| 22:53:23 | melwitt | hah, it's my backport https://review.openstack.org/564615 | |
| 22:55:01 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (2) https://review.openstack.org/564643 | |
| 22:57:09 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vmops.py https://review.openstack.org/561846 | |
| 23:07:32 | melwitt | how does DBDeadlock work if there's already a @oslo_db_api.wrap_db_retry(max_retries=5, retry_on_deadlock=True) decorator on the method? does that mean it tried 5 times already and still got deadlocked? | |
| 23:10:51 | mriedem | i think so | |
| 23:11:42 | melwitt | okay. seeing it on an internal bug in queens during the service record report_count update by the conductor service (service heartbeat) | |
| 23:12:08 | melwitt | not sure what could be clashing with that | |
| 23:14:39 | melwitt | although, this is a scale test situation and seeing messaging timeouts, so maybe it's just all of the various service heartbeats being affected by that | |
| 23:17:59 | mriedem | lbragstad: hitting something weird in a test for placement policy; it's a fake token / user context, but it has the 'admin' role in the context, and the rule it's checking against is "role:admin", and these are the policy values from the context: | |
| 23:18:01 | mriedem | {'is_admin_project': True, 'user_id': 'admin', 'service_project_id': None, 'project_domain_id': None, 'service_user_domain_id': None, 'service_user_id': None, 'roles': ['admin'], 'service_project_domain_id': None, 'user_domain_id': None, 'project_id': 'admin', 'service_roles': []} | |
| 23:18:08 | mriedem | is there something obvious i might not be thinking of? | |
| 23:18:16 | mriedem | i figured 'roles': ['admin'] would be enough | |
| 23:19:11 | mriedem | oh sorry, it's actually using this rule: rule:admin_api | |
| 23:19:19 | mriedem | which is defined as: is_admin:True | |
| 23:19:44 | mriedem | and i'm guessing that's failing because the policy creds don't have an is_admin key? | |
| 23:19:49 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (3) https://review.openstack.org/564645 | |
| 23:20:14 | mriedem | i think this might be due to that goofy context_is_admin middleware thing | |
| 23:20:22 | mriedem | which i'm not using in the placement policy stuff | |
| 23:23:24 | mriedem | ah yes, nova.context.RequestContext overrides to_policy_values to add is_admin https://github.com/openstack/nova/blob/master/nova/context.py#L263 | |
| 23:46:52 | mriedem | yup that was it, got it fixed now | |
| 23:47:18 | mriedem | melwitt: would be sweet if we could build docs locally again https://review.openstack.org/#/c/564631/ | |
| 23:51:08 | melwitt | +2 | |
| 23:54:44 | mriedem | danke | |
| 23:55:22 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Implement granular policy rules for placement https://review.openstack.org/524425 | |
| #openstack-nova - 2018-04-27 | |||
| 00:24:34 | openstackgerrit | Dinesh Bhor proposed openstack/nova master: PCPU: Define numa dedicated CPU resource class https://review.openstack.org/561770 | |
| 00:31:31 | openstackgerrit | Sam Morrison proposed openstack/nova master: Allow ability for non admin users to use all filters on server list. https://review.openstack.org/526558 | |
| 00:59:02 | yikun_ | @mriedem, @melwitt I will complete the novaclient change for micover 2.62 today. : ) thanks! | |
| 01:06:22 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in tests/unit/api/*/test_volumes.py https://review.openstack.org/564655 | |
| 01:17:18 | lbragstad[m] | Figure it out mriedem? | |
| 01:18:19 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_live_migrate.py https://review.openstack.org/564656 | |
| 01:34:32 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (1) https://review.openstack.org/564658 | |
| 01:54:59 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (2) https://review.openstack.org/564659 | |
| 02:09:34 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466 | |
| 04:01:14 | openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802 | |
| 04:15:41 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.62 - Add host/hostId to instance action event https://review.openstack.org/564667 | |
| 04:20:26 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.62 - Add host/hostId to instance action event https://review.openstack.org/564667 | |
| 06:53:38 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add unit tests for alloc_cands with member_of https://review.openstack.org/561399 | |
| 06:53:39 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix member_of with shared providers https://review.openstack.org/561400 | |
| 07:21:00 | giblet | ehh somebody registered the giblet nick :/ | |
| 07:38:04 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.62 - Add host/hostId to instance action event https://review.openstack.org/564667 | |
| 08:10:45 | openstackgerrit | Martin Midolesov proposed openstack/nova master: vmware:Validation video ram against the max video ram allowed. https://review.openstack.org/564193 | |
| 08:26:47 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix the policy argument in server-group-create https://review.openstack.org/564699 | |
| 08:39:07 | openstackgerrit | Takahito Hirose proposed openstack/python-novaclient master: modified novaclient/api_versions.py When using python 3.5.0, [- 4] can not take information. Necessary information is in the [-5]. Because it better is using 'for loops'. https://review.openstack.org/564702 | |
| 09:03:16 | gameon | Hi all - I am running Pike, and have set 'osapi_compute_unique_server_name_scope = "global"' in nova.conf across all Nova nodes and scheduler containers, but I can still attempt to create two instances with the same name. The second will sit in a scheduling state, the expected 'InstanceExists' isn't produced. Does anyone have any advise, please? | |
| 10:17:58 | openstackgerrit | Takahito Hirose proposed openstack/python-novaclient master: modified novaclient/api_versions.py When using python 3.5.0, [- 4] can not take information. Necessary information is in the [-5]. Because it better is using 'for loops'. https://review.openstack.org/564722 | |
| 10:33:03 | openstackgerrit | Takahito Hirose proposed openstack/python-novaclient master: api_version decorator becomes an error in Python 3.5.0. https://review.openstack.org/564722 | |
| 10:38:07 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags` https://review.openstack.org/563926 | |
| 11:04:58 | openstackgerrit | Takahito Hirose proposed openstack/python-novaclient master: api_version decorator becomes an error in Python 3.5.0. https://review.openstack.org/564731 | |
| 11:32:05 | sean-k-mooney | stephenfin: impresive http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-04-26.log.html#t2018-04-26T10:23:28 ill add them to my review queue but it could take a while to get to all of them. is it working end ot end? | |
| 11:34:00 | openstackgerrit | Martin Midolesov proposed openstack/nova master: vmware:Validation video ram against the max video ram allowed. https://review.openstack.org/564193 | |
| 11:59:45 | fried_rice | ō/ | |
| 12:00:23 | sean-k-mooney | fried_rice: o/ | |
| 12:01:37 | sean-k-mooney | fried_rice: am i correct in assuming that you are currently targeting Rocky 2 to complete the granular resouce request now that we are past rocky 1 | |
| 12:02:03 | fried_rice | sean-k-mooney: I hadn't really considered a "target" tbh | |