| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-26 | |||
| 19:15:04 | mriedem | like off broadway? | |
| 19:15:11 | melwitt | yes exactly like that | |
| 19:15:17 | mriedem | fwiw i always waited to complete a bp when the novaclient changes were done | |
| 19:15:30 | mriedem | helped remind me to pester people to do them | |
| 19:15:49 | melwitt | makes sense | |
| 19:21:27 | openstackgerrit | Eric Fried proposed openstack/nova master: Base test module/class for functional placement db https://review.openstack.org/564590 | |
| 19:21:28 | openstackgerrit | Eric Fried proposed openstack/nova master: Use test_base symbols directly https://review.openstack.org/564592 | |
| 20:15:06 | Sundar | Hi edleafe | |
| 20:15:18 | mordred | efried: I just pushed up an update to https://review.openstack.org/#/c/564299/ that should make it work - and also the previous patch has been updated with a co-authored-by for you :) | |
| 20:16:08 | efried | mordred: I already +1'd the latter. Thanks for that. | |
| 20:16:18 | mordred | \o/ | |
| 20:16:58 | mordred | efried: thanks, btw, for your excellent tests of the version normalization code - theymade adding testing here much easier | |
| 20:17:12 | efried | oh, good. | |
| 20:17:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Make service all-cells min version helper use scatter-gather https://review.openstack.org/539590 | |
| 20:17:14 | openstackgerrit | Dan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617 | |
| 20:18:34 | jaypipes | stephenfin: fyi, finally getting around to reviewing the numa-aware-vswitches spec again. | |
| 20:30:27 | efried | mordred: Reviewed | |
| 20:33:05 | mordred | efried: thank you sir | |
| 20:36:46 | edleafe | Sundar: hi - was away from my desk for a bit | |
| 20:38:56 | Sundar | edlefe, NP. Thanks for reaching out | |
| 20:39:01 | Sundar | *edleafe | |
| 20:39:43 | Sundar | I am trying to understand why nested Resource Provider support is not usable for Cyborg in Rocky. I understand it is incomplete. But could you give me some details or pointers? | |
| 20:41:06 | edleafe | Sundar: here's the current work for getting NRPs in allocation candidates: https://review.openstack.org/#/q/topic:bp/nested-resource-providers-allocation-candidates+(status:open+OR+status:merged) | |
| 20:42:01 | openstackgerrit | Merged openstack/nova master: Handle deprecation of inspect.getargspec https://review.openstack.org/530777 | |
| 20:42:09 | openstackgerrit | Merged openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | |
| 20:43:10 | edleafe | Sundar: so until that series is complete, we can't really begin to use it | |
| 20:47:19 | Sundar | edleafe: It seems to me that https://review.openstack.org/#/c/554529/ is the key one. Others relate to nested+shared RPs etc., which may not be of immediate relevance to Cyborg. Does that sound right? | |
| 20:47:28 | melwitt | takashin: hi, have you seen this ML thread about your blueprint bp/list-show-all-server-migration-types http://lists.openstack.org/pipermail/openstack-dev/2018-April/129736.html ? your response would be appreciated | |
| 20:48:32 | edleafe | Sundar: it's difficult to say which will impact Cyborg. | |
| 20:49:05 | edleafe | Sundar: is 1400 UTC a good time for you? We have the scheduler subteam meeting then | |
| 20:49:13 | edleafe | Sundar: on Mondays | |
| 20:50:15 | melwitt | nova meeting in 10 minutes | |
| 20:50:30 | Sundar | edleafe: Sure, I can make it at 7 am PDT Monday (I am in SF Bay Area). | |
| 20:50:46 | takashin | melwitt: Yes. | |
| 20:51:19 | Sundar | edleafe: Also, this series does not seem to address nested RPs + granular resource requests. Where is that tracked? | |
| 20:53:10 | edleafe | Sundar: hmmm... efried, are you around? | |
| 20:53:24 | melwitt | takashin: okay, cool. if you could send a response to the mailing list, it would be helpful | |
| 20:53:31 | edleafe | Sundar: https://wiki.openstack.org/wiki/Meetings/NovaScheduler | |
| 20:53:48 | takashin | melwitt: okay. | |
| 20:53:54 | melwitt | thanks | |
| 20:59:25 | Sundar | edleafe: Thanks! | |
| 21:02:37 | efried | edleafe: sup | |
| 21:03:43 | edleafe | Can you shed some light on Sundar's question above about nested RPs and granular requests? | |
| 21:05:34 | efried | Sundar: https://review.openstack.org/#/c/554529/ is the first step in getting nested to work in GET /allocation_candidates. Without it, nested resource providers aren't usable. | |
| 21:06:11 | efried | Sundar: Granular will happen here: https://review.openstack.org/#/q/topic:bp/granular-resource-requests+status:open | |
| 21:06:59 | efried | Sundar: There are some who think granular should wait until nested is done. I don't necessarily agree, but we'll see how it shakes out. | |
| 21:07:25 | Sundar | efried: Got it. Thanks! | |
| 21:12:55 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Deprecate rule:context_is_admin https://review.openstack.org/564349 | |
| 21:16:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: General policy sample file for placement https://review.openstack.org/524425 | |
| 21:17:07 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Deprecate rule:context_is_admin https://review.openstack.org/564349 | |
| 21:17:43 | lbragstad | mriedem: two tests are still failing and i'm not quite sure why, it seems unrelated but that's probably not the case ^ | |
| 21:17:59 | lbragstad | otherwise - i attempted to simplify it a bit more | |
| 21:18:24 | Sundar | edleafe, efried: Apparently there is a convention/agreement that only the entity that created an RP can publish traits on it (apart from administrators). If so, Cyborg cannot publish traits on the compute node RP, as Nova created it. Can you throw some light on this? | |
| 21:18:37 | lbragstad | i think nova was just using rule:context_is_admin to set is_admin on the context object (which makes sense given the name) | |
| 21:18:49 | lbragstad | so - in order to deprecate it, that has to live somewhere | |
| 21:18:56 | openstackgerrit | Adam Harwell proposed openstack/nova stable/pike: Add support for listing hosts in cellv2 https://review.openstack.org/563797 | |
| 21:18:57 | mriedem | lbragstad: ok, i've made progress on the granular placement policy patch, except it breaks all placement-related tests now... | |
| 21:19:07 | lbragstad | so i put it in the context object itself | |
| 21:19:26 | lbragstad | and i have it checking for roles set by keystonemiddleware, which should hopefully make things more clear | |
| 21:20:20 | efried | Sundar: That convention/agreement was reversed on Friday in Dublin. | |
| 21:20:48 | efried | Sundar: You can put traits on the compute node RP if you want, as long as they're not traits that compute thinks it "owns". | |
| 21:21:10 | efried | Sundar: but... why would you want to do that? I would have expected you to want to put traits on the child providers representing your devices. | |
| 21:22:11 | edleafe | efried: I think that the virt driver would be the "creator", since it reports its presence | |
| 21:22:22 | edleafe | Cyborg would be an outside agent in this case | |
| 21:23:03 | Sundar | efried: Yes, I'd prefer using nRPs. But edleafe has advised us not to rely upon that in Rocky. So, we are creating a backup plan to apply the traits on the compute node RP instead. That in turn has consequences for supporting multiple device types on the same node. It is getting a bit complicated. | |
| 21:23:14 | efried | edleafe: Yes, but we decided to allow merging of traits supplied by outside parties. | |
| 21:23:57 | efried | Sundar: Yeah, the only way you could reliably support multiple device types on the same provider would be via custom resource classes. And you would then have to unwind that model when nrp is in place. | |
| 21:26:24 | edleafe | efried: that was why I advised Cyborg to wait until NRP was working. | |
| 21:26:58 | edleafe | efried: do you have an educated guess as to how much of NRP will make it into Rocky? | |
| 21:27:44 | efried | edleafe: It's really binary: will nrp-in-alloc-cands make it or not. | |
| 21:28:48 | edleafe | efried: ok, then, rephrasing. Do you think NRP will make it into Rocky? | |
| 21:29:05 | efried | edleafe: I can't answer that. Question for jaypipes | |
| 21:31:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix tox -e docs https://review.openstack.org/564631 | |
| 21:32:21 | arvindn0_ | mriedem: quick clarification. conductor.manager.ComputeTaskManager#rebuild_instance already expects and handles no valid host exception | |
| 21:32:22 | lbragstad | mriedem: added a couple comments to your placement patch | |
| 21:33:58 | mriedem | lbragstad: already replied :) | |
| 21:34:14 | mriedem | arvindn0_: yes, but that's already after nova-api rpc cast to nova-conductor | |
| 21:34:18 | mriedem | and returned a 202 to the user | |
| 21:34:20 | arvindn0_ | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L953 | |
| 21:34:25 | mriedem | arvindn0_: yes i realize | |
| 21:34:49 | mriedem | it's best, imo, if we can fail fast in the API with a 400 - if we're going to do that | |
| 21:34:58 | mriedem | like trying to rebuild a volume-backed instance with a new image | |
| 21:35:22 | arvindn0_ | yea...makes sense | |
| 21:35:30 | mriedem | i don't like the idea of making this an error condition though, because i think that's just technical debt we'll eventually have to fix | |
| 21:35:37 | mriedem | but, like i said, i need to read the rest of the ML thread | |
| 21:36:11 | arvindn0_ | when you say the api do you mean near the API entry point? | |
| 21:36:45 | arvindn0_ | or still in the conductor API conductor.api.ComputeTaskAPI#rebuild_instance | |
| 21:37:07 | arvindn0_ | not sure where the volume backed instance example is | |
| 21:37:30 | mriedem | nova.compute.api.API.rebuild_instance | |
| 21:40:27 | arvindn0_ | found it... | |
| 21:41:42 | arvindn0_ | my main concern is that if we extend image properties in future to allow granular/forbidden etc traits in future...this logic will need to be updated to handle all of those cases | |
| 21:43:37 | arvindn0_ | for granular traits for example, the code we need to add would be as complicated if not more incase we need to handle rebuild taking all those into account | |
| 21:46:53 | jaypipes | mriedem: "the great placement schism of 2018" lol :) | |
| 21:48:07 | mriedem | lance stepped right into a big pile of it | |
| 22:27:53 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use helpers in test_resource_provider (func) https://review.openstack.org/564638 | |
| 22:31:02 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (1) https://review.openstack.org/564639 | |
| 22:40:29 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Add consumer generation checking logic https://review.openstack.org/564641 | |
| 22:45:45 | melwitt | mriedem: did you mention sort of recently that we had a new dbdeadlock somewhere? | |
| 22:46:59 | openstack | Launchpad bug 1642537 in OpenStack Compute (nova) "finish_resize fails with DBDeadlock on migrations table" [Undecided,Confirmed] | |
| 22:46:59 | mriedem | yeah, but now i don't remember if i opened a bug for it, since i only see https://bugs.launchpad.net/nova/+bug/1642537 | |