| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-25 | |||
| 19:06:16 | mriedem | i think we (nova) have to decide some stuff like would we have /etc/nova/policy.yaml include placement stuff, or /etc/placement/policy.yaml | |
| 19:06:21 | mriedem | i'd prefer the latter | |
| 19:06:26 | mriedem | but not sure how possible that is when the code is in the same repo | |
| 19:06:45 | mriedem | should just be extra data files for the setup.cfg so i don't know why it would be a problem | |
| 19:10:15 | edmondsw | mriedem separate policy.yaml for placement should be doable | |
| 19:10:24 | melwitt | edmondsw, mriedem, dansmith: I think the volume tests should be enabled in CI. is there some reason they aren't? | |
| 19:10:37 | dansmith | melwitt: "it's hard" | |
| 19:10:58 | dansmith | I'll also say I think that tempest validation being disabled is a problem, | |
| 19:11:07 | dansmith | related but not strictly to volume CI | |
| 19:11:12 | melwitt | the ssh validation? that should be enabled too | |
| 19:11:16 | dansmith | no idea how that got ignored | |
| 19:11:20 | dansmith | yeah, ssh validation | |
| 19:11:41 | lbragstad | mriedem: i think there is a way to split up policy data across multiple configs | |
| 19:11:44 | dansmith | without ssh validation, I think working CI is mostly a charade | |
| 19:12:03 | dansmith | "oh look, we can create instances that may or may not be steaming piles of unworking sh*t" | |
| 19:12:26 | edmondsw | melwitt with our current hardware, it just wouldn't work. If we can get more hardware, there are still some technical challenges with the way that hardware works (limited simultaneous connections, how to detect and cleanup stale volumes from previous runs) | |
| 19:12:43 | openstack | Launchpad bug 1766953 in oslo.policy "Lacking documentation for new projects using oslo.policy" [Undecided,New] | |
| 19:12:43 | lbragstad | mriedem: https://bugs.launchpad.net/oslo.policy/+bug/1766953 | |
| 19:12:52 | melwitt | with regard to a virt driver, yeah, lack of ssh validation is just testing that nothing prevents the instance from being built, not whether the instance actually works | |
| 19:13:10 | mriedem | edmondsw: "limited simultaneous connections" can be solved with (1) run tempest tests in serial and (2) limit the set of tests you run and (3) make it an on-demand job to start | |
| 19:13:33 | edmondsw | mriedem I meant across simultaneous CI runs | |
| 19:13:51 | dansmith | nova is about self-service dynamic resources.. if you can't do that, then, uh... | |
| 19:13:53 | edmondsw | but yeah, on-demand job would address that | |
| 19:14:21 | edmondsw | going into a mtg... | |
| 19:14:38 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Make sure that we have usable input for graphical console https://review.openstack.org/564320 | |
| 19:14:39 | mriedem | lbragstad: thanks | |
| 19:15:55 | melwitt | yeah, I guess I don't think we should have something in-tree that doesn't have CI covering its basic functionality | |
| 19:18:21 | edmondsw | so esberglu I think we need to rebase the rest of the PowerVM commits, moving vSCSI to the end of the series, so this doesn't block everything | |
| 19:18:27 | edmondsw | efried ^ | |
| 19:18:40 | dansmith | melwitt: agree | |
| 19:19:11 | edmondsw | esberglu and we need to start working on an on-demand CI job for testing vSCSI FC | |
| 19:19:27 | esberglu | edmondsw: ok | |
| 19:19:38 | lbragstad | jaypipes: re the oslo.context stuff you reviewed - https://review.openstack.org/#/c/564072/ should make that easier for nova to consume | |
| 19:20:09 | melwitt | I think y'all also need to get the CI running with [validation]run_validation = True in tempest.conf, unrelated to the volumes stuff | |
| 19:22:31 | edmondsw | melwitt I'm not sure we can. It will take minutes, probably close to 10, for the VM to ping. | |
| 19:23:13 | melwitt | :\ | |
| 19:23:17 | edmondsw | yeah | |
| 19:23:41 | esberglu | edmondsw: melwitt: Yeah this is something we've discussed for CI many times, but the runtimes will explode | |
| 19:23:55 | dansmith | edmondsw: minutes to bring up an instance to pingable state? | |
| 19:24:05 | edmondsw | dansmith yes | |
| 19:24:21 | dansmith | edmondsw: how is that useful for an elastic sort of situation? :) | |
| 19:25:21 | edmondsw | to Power customers, 10 minutes sounds very fast :) | |
| 19:25:41 | dansmith | edmondsw: hah, yeah, I know about power, remember, but doesn't stop me from making fun | |
| 19:25:50 | dansmith | especially in an "is this relevant at all" sort of situation | |
| 19:25:50 | edmondsw | sure :) | |
| 19:26:04 | edmondsw | again, I don't like it, but... | |
| 19:26:25 | mriedem | again, you could have a separate job that just runs something like scenario tests in serial | |
| 19:26:35 | edmondsw | fair | |
| 19:26:36 | mriedem | i don't think the scenario tests even use the run_validation flag | |
| 19:26:43 | mriedem | they just assume that you can ssh into the guest | |
| 19:26:51 | mriedem | otherwise they aren't useful scenarios | |
| 19:27:02 | edmondsw | I don't know that we've considered on-demand CI jobs before | |
| 19:27:15 | mriedem | the scenario-based one might not need to be on-demand | |
| 19:27:37 | mriedem | you'd have to see which tests make sense, and if you only run like 6 tests, then it's not bad | |
| 19:27:47 | edmondsw | mriedem I'm not quite following... what scenario do you have in mind? | |
| 19:28:00 | mriedem | https://github.com/openstack/tempest/tree/master/tempest/scenario | |
| 19:28:03 | melwitt | this is the basic functionality scenario test that verifies ssh and config drive https://github.com/openstack/tempest/blob/master/tempest/scenario/test_server_basic_ops.py#L51 | |
| 19:28:09 | mriedem | stuff like test_minimum_basic | |
| 19:28:22 | edmondsw | will look | |
| 19:28:25 | edmondsw | esberglu fyi ^ | |
| 19:28:25 | mriedem | test_server_basic_ops | |
| 19:28:49 | mriedem | for stuff in that requires volumes, we could fix those in tempest if the env doesn't have cinder | |
| 19:29:22 | mriedem | actually that's already handled https://github.com/openstack/tempest/blob/master/tempest/scenario/test_minimum_basic.py#L102 | |
| 19:29:26 | mriedem | @utils.services('compute', 'volume', 'image', 'network') | |
| 19:29:35 | mriedem | so if the volume service isn't enabled in tempest.conf, that test is skipped | |
| 19:29:55 | mriedem | should totally be able to do this though https://github.com/openstack/tempest/blob/master/tempest/scenario/test_server_basic_ops.py#L125 | |
| 19:30:20 | mriedem | create a server with a keypair and config drive, ssh into it, done | |
| 19:33:58 | lbragstad | mriedem: was this the policy+placement patch you were talking about? | |
| 19:33:59 | lbragstad | https://review.openstack.org/#/c/524425/ | |
| 19:34:12 | melwitt | yeah. I'd personally want to hold off on merging the new driver patches until test_server_basic_ops is running in CI | |
| 19:34:27 | melwitt | with ssh validation enabled | |
| 19:36:04 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot https://review.openstack.org/543023 | |
| 19:36:05 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | |
| 19:36:06 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 19:36:13 | edmondsw | melwitt even things that wouldn't have anything to do with that, like snapshot? | |
| 19:37:01 | melwitt | edmondsw: yeah, it seems like verifying the booted instances was missed for whatever reason in the past, should fix that before adding more stuff I would think | |
| 19:37:36 | dansmith | we hold everyone else to that bar, not sure why it should be a surprise, | |
| 19:37:40 | dansmith | nor why it was skipped | |
| 19:37:44 | esberglu | edmondsw: efried: ^ Commit chain is up without vSCSI. You're votes are still on DiskAdapter and Localdisk. Snapshot lost them in a previous manual rebase | |
| 19:37:53 | esberglu | your | |
| 19:37:57 | mriedem | lbragstad: yeah | |
| 19:43:27 | efried | esberglu: snapshot re-reviewed. | |
| 19:55:11 | openstackgerrit | Julia Kreger proposed openstack/nova master: ironic: add instance_uuid before any other spawn activity https://review.openstack.org/563722 | |
| 19:58:11 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: resource requests for nested providers https://review.openstack.org/554529 | |
| 20:00:52 | openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | |
| 20:14:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use inspect.signature in nova.utils.expects_func_args https://review.openstack.org/564333 | |
| 20:14:04 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use inspect.signature in nova.network.base_api.refresh_cache https://review.openstack.org/564334 | |
| 20:22:12 | mriedem | yikun_: at this point, you should probably just incorporate https://review.openstack.org/#/c/563802/ into https://review.openstack.org/#/c/561819/ and https://review.openstack.org/#/c/557145/ respectively | |
| 20:22:31 | openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | |
| 20:22:36 | mriedem | rather than a never-ending series of "address nits" patches at the end | |
| 20:25:05 | openstackgerrit | Merged openstack/nova master: Update docs for [keystone_authtoken] changes since Queens https://review.openstack.org/562812 | |
| 20:25:14 | openstackgerrit | Merged openstack/nova master: Make accept-language tests work with webob 1.8.x https://review.openstack.org/564255 | |
| 20:26:10 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Update docs for [keystone_authtoken] changes since Queens https://review.openstack.org/564336 | |
| 20:27:20 | melwitt | yikun_: seconded, especially the reno update. seems kinda weird to split that up | |
| 20:28:00 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: resource requests for nested providers https://review.openstack.org/554529 | |
| 20:28:31 | efried | mriedem: Is there a way to elevate the getargspec deprecation warning to error in py3, to prove those two patches you just proposed? | |
| 20:30:39 | mriedem | lbragstad: do you know the answer to this? https://review.openstack.org/#/c/524425/1/nova/api/openstack/placement/policies/base.py | |
| 20:31:00 | mriedem | efried: yeah i think so | |
| 20:31:12 | mriedem | https://docs.python.org/2/library/warnings.html#the-warnings-filter | |
| 20:33:00 | mriedem | https://docs.python.org/2/library/warnings.html#warnings.filterwarnings | |