| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-23 | |||
| 15:35:47 | bauzas | so, I'm out of ideas | |
| 15:35:53 | sean-k-mooney | bauzas: ah ok ya so like the pci alais with out all the other symantics that is layered on that | |
| 15:35:58 | bauzas | except sealing in the nova codebase something I don't want | |
| 15:36:23 | bauzas | because that's just libvirtd isn't mature enough on that feature to provide CLIs for that | |
| 15:36:55 | bauzas | so a config option is just a 'mid-term' solution until, I hope, something comes up that allows to specify that outside of nova | |
| 15:37:24 | sean-k-mooney | bauzas: you can find the vgpu types in virsh capablitites or virsh nodedev-list though right? | |
| 15:37:57 | bauzas | sean-k-mooney: sure, but then I need to say which type is for which pGPU | |
| 15:37:59 | sean-k-mooney | bauzas: one of those should expose the mdev types that correstpond the the different vgpus | |
| 15:38:07 | bauzas | sean-k-mooney: context is https://review.openstack.org/#/c/557065/2/specs/rocky/approved/vgpu-rocky.rst | |
| 15:38:27 | bauzas | sean-k-mooney: sure, but each pGPU supports multiple types | |
| 15:38:54 | bauzas | Xen doesn't have that problem, because the xen CLI allows to provide such tool out of nova | |
| 15:39:04 | bauzas | I don't have that in my bucket, so I'm doomed | |
| 15:39:32 | sean-k-mooney | bauzas: yes but form a config type we need to seperate things. a whitelist to declare what pGPUs can be used and a mapping that allows you to name the types and use that in the flavor | |
| 15:39:43 | bauzas | sean-k-mooney: we already have the former | |
| 15:39:50 | bauzas | sean-k-mooney: what we miss is the latter | |
| 15:40:16 | bauzas | again, we can technically have a StrOpt and do some magical JSON import | |
| 15:40:27 | bauzas | just because oslo.config misses that | |
| 15:40:27 | sean-k-mooney | bauzas: the pci whitelist is the former right. and your looking for a clean way to lable the diferent types so we dont leak the host implemtaiton details via the api | |
| 15:40:30 | bauzas | no | |
| 15:40:55 | bauzas | sean-k-mooney: we currently have enabled_vgpu_types that lists all the supported types accepted by that compute | |
| 15:41:26 | bauzas | sean-k-mooney: what I miss is a way to say for each of those types, which pGPU(s) is/are associated with | |
| 15:41:53 | sean-k-mooney | bauzas: ah ok. | |
| 15:42:47 | bauzas | jaypipes: if we say here that a dict opt isn't the best match, it only allows us some kind of dynamic import, or some external file that'd be out of oslo.config | |
| 15:43:11 | bauzas | jaypipes: I'm not super happy with the second option that carries a lot of misunderstandings | |
| 15:44:16 | sean-k-mooney | bauzas: i belive stephenfin is looking at reusing how cindier does dynmaic config for the numa aware vswitch spec | |
| 15:44:26 | sean-k-mooney | bauzas: could we use the same approch here or is that overkill | |
| 15:44:50 | bauzas | I think that's the only option I have tbh, if we still care about nova.conf | |
| 15:46:32 | sean-k-mooney | bauzas: well if you have a config var that listed all the phyciscal gpus and then had a dynmic section for each that listed the allowed types i think that would be resonably clean | |
| 15:47:25 | jaypipes | bauzas: I'm not sure if you're asking me a question. I think dansmith would like to see you use a strategy similar to stephenfin's code that adds a config section to nova.conf for each physical device? So, something like [gpu_<some identifier>] and then have CONF options inside that group? | |
| 15:47:38 | bauzas | ok, I can try then | |
| 15:49:36 | dansmith | jaypipes: yeah | |
| 15:49:50 | openstackgerrit | Margarita Shakhova proposed openstack/nova master: Do not skip migrations in _destroy_evacuated_instances() https://review.openstack.org/563623 | |
| 16:05:26 | openstackgerrit | sahid proposed openstack/nova master: add mtu to libvirt xml for ethernet and bridge types https://review.openstack.org/553072 | |
| 16:06:19 | sahid | sean-k-mooney: I updated you patch ^ based on matt comments and i also have updated a point with the mtu function to update libvirt configure xml I hope that was ok for you | |
| 16:08:03 | sean-k-mooney | sahid: ya no worries sorry i had ment to get back to that patch sooner | |
| 16:11:13 | sean-k-mooney | sahid: the real answer to matts question is when os-vif actully plug the interface it does set teh mtu but there are still a few code paths where libvirt plugs the interfaces and then nothing set the mtu which is what that patch fixes | |
| 16:11:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove explicit instance.info_cache.delete() https://review.openstack.org/563689 | |
| 16:12:55 | openstack | Launchpad bug 1747496 in OpenStack Compute (nova) "MTUs are not set for VIFs if using kernel ovs + hybrid plug = false" [Medium,In progress] | |
| 16:12:55 | sahid | sean-k-mooney: launchpad updated the bug report to assign myself, i'm not able to re-assign you, so when you have a moment, please do https://bugs.launchpad.net/nova/+bug/1747496 | |
| 16:14:50 | sean-k-mooney | sahid: done :) thanks for adressing the comment. to your backport point im also hopping we can backport this change. i would like to move this to os-vif also in a seperate patch but that would chage the xml we generate so that is not back portable hence the current approch. | |
| 16:21:03 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/563692 | |
| 16:27:32 | openstackgerrit | Merged openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | |
| 16:32:08 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | |
| 16:33:45 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | |
| 16:52:21 | mriedem | melwitt: the next runway slot is open since https://review.openstack.org/#/c/553288/ is done. i'm not sure, however, if the zvm stuff is ready to go back into the runway (i haven't been following the ML thread), | |
| 16:52:51 | mriedem | if not, the next one is https://blueprints.launchpad.net/nova/+spec/list-show-all-server-migration-types and i have reservations about even supporting that now (i think i always did but got tired of pushing against it) | |
| 16:53:01 | mriedem | so i left some notes in the etherpad | |
| 16:57:04 | openstackgerrit | Surya Seetharaman proposed openstack/nova stable/queens: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/563698 | |
| 17:01:41 | jaypipes | lbragstad: some comments inline on your set scope_types for admin password policies patch. | |
| 17:01:49 | jaypipes | lbragstad: comments and questions that is... | |
| 17:05:52 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/563700 | |
| 17:08:42 | lbragstad | jaypipes: awesome - checking | |
| 17:16:54 | openstackgerrit | Zack Cornelius proposed openstack/nova-specs master: Libvirt file backed memory https://review.openstack.org/563704 | |
| 17:22:47 | openstackgerrit | Merged openstack/nova master: libvirt: fix wrong driver name for vhostuser interface https://review.openstack.org/561562 | |
| 17:31:00 | jaypipes | lbragstad: thx for the answers. so what does the 'all' in system={'all': True} refer to? | |
| 17:38:18 | artom | dansmith, https://review.openstack.org/#/c/563704/ you're some sort of ninja dude | |
| 17:38:48 | dansmith | artom: um, what? | |
| 17:39:18 | artom | 20 minutes since patch posted, 13 comments, that's close to 1 comment per minute :) | |
| 17:39:59 | dansmith | artom: only 14 between post and comment.. don't sell me short | |
| 17:40:40 | artom | Gomen, senpai | |
| 17:40:51 | artom | (Sincere apologies to all Japanese speakers here) | |
| 17:41:10 | dansmith | heh | |
| 17:42:30 | openstackgerrit | Julia Kreger proposed openstack/nova master: DNM: Test: Ironic: Lock the instance if plug vifs https://review.openstack.org/563714 | |
| 17:44:46 | dansmith | artom: when you're right you're right | |
| 17:45:09 | artom | I shall speak of this moment to my grandchildren | |
| 17:47:59 | melwitt | mriedem: ack | |
| 17:49:07 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/563719 | |
| 17:52:38 | openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | |
| 17:54:11 | openstackgerrit | Jim Rollenhagen proposed openstack/nova master: WIP: ironic: add instance_uuid before any other spawn activity https://review.openstack.org/563722 | |
| 17:58:26 | lbragstad | jaypipes: it's supposed to refer to the entire deployment system | |
| 17:59:30 | lbragstad | jaypipes: following the documentation here - http://specs.openstack.org/openstack/keystone-specs/specs/keystone/queens/system-scope.html#authenticating-for-a-system-scoped-token | |
| 17:59:32 | jaypipes | lbragstad: ok. so the string 'all' is special? | |
| 17:59:38 | lbragstad | yeah | |
| 17:59:42 | jaypipes | gotcha | |
| 17:59:47 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: add note about xenapi aggregate upcall being resolved https://review.openstack.org/563724 | |
| 18:00:23 | lbragstad | our intention was to build it so that eventually we could do something like system: {$service: $id} | |
| 18:00:43 | lbragstad | but that would be relayed in the token | |
| 18:06:59 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: mark block_device_mapping_v2.boot_index as required https://review.openstack.org/563728 | |
| 18:07:52 | mriedem | alex_xu: see ^ i don't know if we should revert https://review.openstack.org/#/c/524208/ or not | |
| 18:08:04 | mriedem | i tend to think we should | |
| 18:35:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix dropped check for boot_index 0 in _validate_bdm https://review.openstack.org/563732 | |
| 18:41:43 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | |
| 18:48:33 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | |
| 18:49:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: docs: link to volume multi-attach demo recording https://review.openstack.org/563734 | |
| 18:51:56 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Set scope_types for admin password policies https://review.openstack.org/553613 | |
| 18:53:27 | mriedem | jackie-truong: can you post a spec amendment per L68 https://etherpad.openstack.org/p/nova-runways-rocky ? | |
| 18:54:50 | jackie-truong | mriedem: Yep, Peter Hamilton from our team is working on it | |
| 18:55:07 | mriedem | ok, thanks | |
| 18:55:16 | jackie-truong | In the mean time, Brianna has started a WIP patch for notifications: https://review.openstack.org/#/c/563269/ | |
| 19:11:12 | mriedem | arvindn05: i kind of think we should remove https://blueprints.launchpad.net/nova/+spec/glance-image-traits from the runways queue until there is agreement on the direction in https://review.openstack.org/#/c/560718/ | |
| 19:12:09 | mriedem | melwitt: do you want me to send something to the ML re https://blueprints.launchpad.net/nova/+spec/list-show-all-server-migration-types and if we should still do it? | |
| 19:13:06 | mriedem | of the 5 things next in line, i think https://review.openstack.org/#/q/topic:bp/add-host-to-instance-action-events+status:open is the only one that's really ready to go | |
| 19:18:15 | mriedem | esberglu: are you updating https://review.openstack.org/#/c/526094/ / | |
| 19:18:16 | mriedem | ? | |
| 19:19:44 | esberglu | mriedem: Yep working on it right now | |
| 19:25:18 | arvindn0_ | mriedem: does the runway queue allow for closure on the specs? | |
| 19:26:27 | arvindn0_ | mriedem: i was thinking we can discuss the spec in the runway if thats the case. Also, we are trying to make progress on other patches which hopefully can also be reviewed in the runway | |
| 19:28:32 | mriedem | arvindn0_: my understanding is that runways are for things that are ready to go | |
| 19:28:37 | mriedem | and i wouldn't consider this ready to go | |
| 19:28:59 | mriedem | btw, i'm trying to summarize alternatives for this in the ML to get some visibility | |