| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-23 | |||
| 14:54:10 | efried | Yeah, I'm sorry too. | |
| 14:54:10 | kashyap | (Nod) | |
| 14:54:23 | efried | It didn't need to be that confusing. | |
| 14:54:28 | efried | But you know branding/marketing folk. | |
| 14:54:42 | kashyap | Hehe, totally | |
| 14:54:55 | kashyap | efried: The KVM author still regrets the name of it, I hear... | |
| 14:55:20 | kashyap | https://en.wikipedia.org/wiki/KVM_switch vs. https://en.wikipedia.org/wiki/Kernel-based_Virtual_Machine | |
| 14:57:11 | efried | gibi, mriedem: FYI: https://review.openstack.org/#/c/561724/ | |
| 14:59:26 | kashyap | mriedem: Hmm, you gave +2, but you noted a whitespace nit & the needless comment. Respinning to remove the needless cruft. | |
| 15:02:44 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | |
| 15:02:45 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Drop MIN_LIBVIRT_SET_ADMIN_PASSWD https://review.openstack.org/562312 | |
| 15:05:07 | efried | gibi: That last low-priority bug with the abandoned patches - I didn't look deeply, but does that qualify as low-hanging fruit? | |
| 15:07:45 | kashyap | Remind me again, if I update the commit message, will I "lose" the +2? | |
| 15:08:49 | kashyap | (Only one spurious comma this time, though) | |
| 15:09:19 | stephenfin | kashyap: You will, yup | |
| 15:09:37 | kashyap | Okay, I'll leave it as is, not worth to bother reviewers about it | |
| 15:09:38 | stephenfin | If it's not a bigger issue, you're usually better of just leaving it unless someone else comments on that or something else | |
| 15:09:53 | stephenfin | (If it was a bigger issue, you wouldn't have got the +2) | |
| 15:09:54 | kashyap | Yeah, it's not an issue all, only OCD. | |
| 15:10:58 | kashyap | stephenfin: Okido; sorry for the bait, but since you like clean-up patches, you might be the second +2er: https://review.openstack.org/#/c/558783/ | |
| 15:11:38 | sahid | dansmith: the intel ci just finished, that looks to be OK | |
| 15:16:10 | stephenfin | kashyap: Ooh, for sure | |
| 15:16:16 | bauzas | stephenfin: jaypipes: dansmith: efried: FWIW, given all the convos we had about https://review.openstack.org/#/c/557065/2/specs/rocky/approved/vgpu-rocky.rst, I'm about to write a patch that'd show some dynamic group usage | |
| 15:16:22 | kashyap | Gracias | |
| 15:16:25 | stephenfin | bauzas: I've it done | |
| 15:16:40 | bauzas | stephenfin: where ? I could do the same | |
| 15:16:41 | stephenfin | :) | |
| 15:16:45 | stephenfin | sec | |
| 15:16:58 | bauzas | or make it generic | |
| 15:16:58 | stephenfin | bauzas: https://github.com/stephenfin/nova/commit/58b53e888feb146123087f2e3f54f677f1fdccdc | |
| 15:17:33 | stephenfin | (I haven't pushed it to Gerrit yet because it's not end-to-end tested and I don't want to swamp the CI as I iterate) | |
| 15:17:34 | dansmith | sahid: yep, cool | |
| 15:18:20 | bauzas | stephenfin: I'm not sure we should dynamicall add the groups in nova/config | |
| 15:18:43 | bauzas | stephenfin: rather closer to the caller | |
| 15:19:20 | bauzas | stephenfin: my thoughts was to use devices.enabled_vgpu_types as the ListOpt value for knowing which opt groups to check | |
| 15:19:21 | stephenfin | bauzas: I wanted it to be done at startup so I could quickly fail. However, that's really good feedback for when it's on Gerrit :) | |
| 15:19:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove vestigial system_metadata param from info_from_instance() https://review.openstack.org/561724 | |
| 15:19:51 | bauzas | stephenfin: or use MultiStrOpt for that | |
| 15:19:53 | stephenfin | bauzas: Aye, I used 'CONF.neutron.physnets' for that | |
| 15:20:02 | stephenfin | https://github.com/stephenfin/nova/commit/58b53e888feb146123087f2e3f54f677f1fdccdc#diff-bf484fde349b127980f9341543ce3c9aR38 | |
| 15:20:27 | stephenfin | so '[neutron] physnets = foo, bar' | |
| 15:20:37 | bauzas | right | |
| 15:20:50 | bauzas | stephenfin: see the context in https://review.openstack.org/#/c/557065/2/specs/rocky/approved/vgpu-rocky.rst@86 | |
| 15:20:57 | bauzas | stephenfin: for MultiStrOpt | |
| 15:21:11 | stephenfin | I guess I could use prefixed attribute names but someone (jaypipes or dansmith, I think) thought that was eewy | |
| 15:21:35 | dansmith | jaypipes: we've validated this with the nfv ci, if you want to have another look at it and the one below: https://review.openstack.org/#/c/484997/ | |
| 15:22:16 | jaypipes | dansmith: ack, will do. | |
| 15:23:01 | jaypipes | ah, this is the one I'd asked sahid to combine the first two patches. yeah... one minute. | |
| 15:23:21 | sahid | dansmith: it was a really nice idea your DNM patch, i'm going to reuse it a lot :) | |
| 15:24:07 | dansmith | jaypipes: yep | |
| 15:24:11 | dansmith | sahid: :) | |
| 15:25:46 | bauzas | stephenfin: you're better than me on oslo.config, do you know if we can have a MultiStrOpt where two lines would have the same key but different values ? | |
| 15:26:34 | stephenfin | bauzas: Got an example? | |
| 15:26:39 | bauzas | sec | |
| 15:26:40 | stephenfin | They have the same key by definition | |
| 15:28:41 | jaypipes | dansmith: off to the test pits it goes. | |
| 15:28:45 | efried | gibi: Ready for you: https://review.openstack.org/#/c/561724/ self.NotificationEmail().AndRemove(bug_1764390) | |
| 15:29:13 | dansmith | jaypipes: the test pits ahead won't really test it, but it came back from other test pits that did recently, so.. thanks :) | |
| 15:29:17 | bauzas | stephenfin: actually, what I want is a MultiDictOpt | |
| 15:30:10 | jaypipes | bauzas: you do *not* want a MultiDictOpt. | |
| 15:30:18 | bauzas | I don't know | |
| 15:30:20 | jaypipes | bauzas: dansmith might kill you if you used that. | |
| 15:30:23 | bauzas | what I want is a pony | |
| 15:30:26 | jaypipes | heh | |
| 15:30:47 | jaypipes | bauzas: your dog is as big as a pony. | |
| 15:30:54 | stephenfin | kashyap: One question before I send that on it's way: how come you didn't use the "NEXT" libvirt/qemu values already specified by berrange? | |
| 15:30:55 | bauzas | I just want a fucking easy way to describe a transitive relationship between a thing and a list of other things | |
| 15:31:32 | bauzas | jaypipes: not as big as a pony, I saw taller yesterday when I was in a dog show | |
| 15:31:38 | jaypipes | bauzas: relational DBs are pretty good at storing relations :P | |
| 15:31:46 | bauzas | jaypipes: I know | |
| 15:32:06 | bauzas | jaypipes: I have a crazy idea to just add a new nova-manage helper if you want my own thoughhts | |
| 15:32:19 | bauzas | just for something super specific like that | |
| 15:32:20 | stephenfin | bauzas: s/in a dog show/at a dog show/ ;) | |
| 15:32:27 | bauzas | because libvirtd doesn't help me with that | |
| 15:32:48 | bauzas | so, things are, we know we're doomed with defining that relationship elsewhere but nova | |
| 15:32:51 | jaypipes | stephenfin: an important clarification :) | |
| 15:32:52 | jroll | stephenfin: "in" was correct, bauzas was a contestant :P | |
| 15:32:56 | bauzas | but I want to make it the less painful | |
| 15:33:46 | sean-k-mooney | bauzas: whay are the entities you are trying to define the relationship of? | |
| 15:34:12 | bauzas | x8kAufXHD_RF1-sfVGt6FEMv2MOY7Y2WH5d4MhvFQT3WF37ZLRJxAxXXmhloPjqF6qh374jvsopMPVaKykwW9zuTiZ87CNcQbfXeGze46RC_CAPmccFyYeA84_y7t0TIJOzStqFXA5LvLivtFfxJtGq06ZRD_P0ZSHcw_cdigRN84R-jDPXGRxnbuAkm5f16HfyLzxARcz1OPfVdUBFliYvHR4h8vZ9VI2ajmprFcxZp2mxIhuvD8FC6lzAwyRLayjnfn4ElfZSPVcm8zVJ9VBFnSwBL5xSq6ZaayKfdL1KEPAYgpQYIj0bdLk6w=w1689-h950-no | |
| 15:34:12 | bauzas | jaypipes: stephenfin: jroll: if you care https://lh3.googleusercontent.com/fFHAwwIKjuW9uKAYkPrsTjsw_bOO6gQgA7xw-B0d2-gmC24J8Z1DUpSzKHwkIJesK_aTGeKGQ8ts1P67SZhmsxUiVEEABuFv7Hg4CvQ-ROw8TNcOgKOgw7HjUqL6ZMsLPYgLee8mDkyj0PpCTRUiD936luaHuThLkW__s1Ym9UAXmMPqXo7J1cBv1GkYjyunJfWbJTUBklcJHd6zwTz51M1DhIMRd0zYpr9xm8kCG3Qbn0NnzVK6jt7ppA00jqUbl-NfReOZyCirPZvrMLJyrtm9nza7AwwOuCm0NGYrVBMZlpnGKQ8VmmlG3r8wz9uPKvUjREitqqN4WgTjhDgRrIomD6Oe9bCMRnRX2 | |
| 15:34:16 | sean-k-mooney | bauzas: you can use somthing like ovo in somecases also | |
| 15:34:40 | bauzas | sean-k-mooney: I just want to say "that GPU type is for those PCI devices" | |
| 15:34:45 | bauzas | period | |
| 15:35:15 | bauzas | but oslo.config doesn't give me a good way to express that except something dumb like we merged for pci whitelist, and which I dislike at most | |
| 15:35:47 | bauzas | so, I'm out of ideas | |
| 15:35:53 | sean-k-mooney | bauzas: ah ok ya so like the pci alais with out all the other symantics that is layered on that | |
| 15:35:58 | bauzas | except sealing in the nova codebase something I don't want | |
| 15:36:23 | bauzas | because that's just libvirtd isn't mature enough on that feature to provide CLIs for that | |
| 15:36:55 | bauzas | so a config option is just a 'mid-term' solution until, I hope, something comes up that allows to specify that outside of nova | |
| 15:37:24 | sean-k-mooney | bauzas: you can find the vgpu types in virsh capablitites or virsh nodedev-list though right? | |
| 15:37:57 | bauzas | sean-k-mooney: sure, but then I need to say which type is for which pGPU | |
| 15:37:59 | sean-k-mooney | bauzas: one of those should expose the mdev types that correstpond the the different vgpus | |
| 15:38:07 | bauzas | sean-k-mooney: context is https://review.openstack.org/#/c/557065/2/specs/rocky/approved/vgpu-rocky.rst | |
| 15:38:27 | bauzas | sean-k-mooney: sure, but each pGPU supports multiple types | |
| 15:38:54 | bauzas | Xen doesn't have that problem, because the xen CLI allows to provide such tool out of nova | |
| 15:39:04 | bauzas | I don't have that in my bucket, so I'm doomed | |
| 15:39:32 | sean-k-mooney | bauzas: yes but form a config type we need to seperate things. a whitelist to declare what pGPUs can be used and a mapping that allows you to name the types and use that in the flavor | |
| 15:39:43 | bauzas | sean-k-mooney: we already have the former | |
| 15:39:50 | bauzas | sean-k-mooney: what we miss is the latter | |