| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-23 | |||
| 14:40:02 | kashyap | stephenfin: efried: Thanks for the quick review (commit: 880f628)! | |
| 14:40:20 | efried | kashyap: yahyoubetcha. Easy one. | |
| 14:41:19 | kashyap | efried: More context on that is - before that commit, it was incredibly difficult to tell if that migrate() method has run or not | |
| 14:41:31 | efried | I get it. | |
| 14:42:23 | efried | kashyap: Mainly, I get credit for a libvirt review I can point to so people don't accuse me of being PowerVM/IBM-centric. | |
| 14:42:25 | kashyap | Although there's a comment snuck in to Eventlet schedule a new thread, but that's too subtle | |
| 14:42:33 | kashyap | efried: Hehe | |
| 14:43:01 | efried | kashyap: I'm counting on major brownie points from this series: https://review.openstack.org/560444 | |
| 14:43:02 | kashyap | efried: Don't worry, I'll send more your way; mechanical clean up of constants :P | |
| 14:43:20 | mnaser | mriedem: nice patch, is there a way we can track things like "things to do for next release" ? | |
| 14:43:24 | kashyap | Until you might get sick of it :P (Once Matt merges the earlier MIN_ bump) | |
| 14:43:51 | mriedem | mnaser: we don't have anything formal for that besides the TODOs in the code | |
| 14:45:14 | mnaser | i see | |
| 14:45:44 | kashyap | efried: Interesting. Have to still educate myself on that (ProviderTree stuff) | |
| 14:46:36 | efried | kashyap: Let me know if you want help there. We wrote a nice contributor doc - maybe since you claim to be fresh, you could scan it and let me know if it gives you what you need... | |
| 14:46:46 | kashyap | efried: I don't claim to be fresh :P | |
| 14:47:14 | kashyap | efried: But yeah, got a URL to that doc? | |
| 14:47:29 | efried | kashyap: working on that (I pretty much suck at searching the docs) | |
| 14:47:45 | kashyap | Aah, I see. The past tense word "wrote" made me think it's already in tree | |
| 14:48:31 | efried | kashyap: It is. | |
| 14:48:37 | efried | kashyap: Mahbad, it's a reference doc: https://docs.openstack.org/nova/latest/reference/update-provider-tree.html | |
| 14:49:17 | efried | kashyap: So yeah, in recompense for that two-line review, you get to read my doc and give me feedback. | |
| 14:49:25 | efried | kashyap: No mistake, you got the raw end of that deal. | |
| 14:50:28 | kashyap | efried: Hehe, oh on the first look, I appreciate the structure & detail. This needs a bit of concentration to read cover-to-cover; queued it. | |
| 14:50:57 | efried | kashyap: thanks in advance | |
| 14:51:59 | kashyap | efried: A quick question -- do you also do "hypervisor stuff" with PowerVM / IBM (z)? | |
| 14:52:44 | kashyap | (This bit: https://www-03.ibm.com/systems/power/software/linux/powerkvm/) | |
| 14:52:46 | efried | kashyap: I know nothing from z. | |
| 14:52:57 | efried | kashyap: And PowerKVM != PowerVM. I know nothing about the former. | |
| 14:53:53 | efried | kashyap: And depending what you mean by "hypervisor" - I get kinda close. I at least have first-order contact with people who do the nuts and bolts. | |
| 14:54:02 | kashyap | Oops, sorry for the mix-up | |
| 14:54:10 | efried | Yeah, I'm sorry too. | |
| 14:54:10 | kashyap | (Nod) | |
| 14:54:23 | efried | It didn't need to be that confusing. | |
| 14:54:28 | efried | But you know branding/marketing folk. | |
| 14:54:42 | kashyap | Hehe, totally | |
| 14:54:55 | kashyap | efried: The KVM author still regrets the name of it, I hear... | |
| 14:55:20 | kashyap | https://en.wikipedia.org/wiki/KVM_switch vs. https://en.wikipedia.org/wiki/Kernel-based_Virtual_Machine | |
| 14:57:11 | efried | gibi, mriedem: FYI: https://review.openstack.org/#/c/561724/ | |
| 14:59:26 | kashyap | mriedem: Hmm, you gave +2, but you noted a whitespace nit & the needless comment. Respinning to remove the needless cruft. | |
| 15:02:44 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | |
| 15:02:45 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Drop MIN_LIBVIRT_SET_ADMIN_PASSWD https://review.openstack.org/562312 | |
| 15:05:07 | efried | gibi: That last low-priority bug with the abandoned patches - I didn't look deeply, but does that qualify as low-hanging fruit? | |
| 15:07:45 | kashyap | Remind me again, if I update the commit message, will I "lose" the +2? | |
| 15:08:49 | kashyap | (Only one spurious comma this time, though) | |
| 15:09:19 | stephenfin | kashyap: You will, yup | |
| 15:09:37 | kashyap | Okay, I'll leave it as is, not worth to bother reviewers about it | |
| 15:09:38 | stephenfin | If it's not a bigger issue, you're usually better of just leaving it unless someone else comments on that or something else | |
| 15:09:53 | stephenfin | (If it was a bigger issue, you wouldn't have got the +2) | |
| 15:09:54 | kashyap | Yeah, it's not an issue all, only OCD. | |
| 15:10:58 | kashyap | stephenfin: Okido; sorry for the bait, but since you like clean-up patches, you might be the second +2er: https://review.openstack.org/#/c/558783/ | |
| 15:11:38 | sahid | dansmith: the intel ci just finished, that looks to be OK | |
| 15:16:10 | stephenfin | kashyap: Ooh, for sure | |
| 15:16:16 | bauzas | stephenfin: jaypipes: dansmith: efried: FWIW, given all the convos we had about https://review.openstack.org/#/c/557065/2/specs/rocky/approved/vgpu-rocky.rst, I'm about to write a patch that'd show some dynamic group usage | |
| 15:16:22 | kashyap | Gracias | |
| 15:16:25 | stephenfin | bauzas: I've it done | |
| 15:16:40 | bauzas | stephenfin: where ? I could do the same | |
| 15:16:41 | stephenfin | :) | |
| 15:16:45 | stephenfin | sec | |
| 15:16:58 | bauzas | or make it generic | |
| 15:16:58 | stephenfin | bauzas: https://github.com/stephenfin/nova/commit/58b53e888feb146123087f2e3f54f677f1fdccdc | |
| 15:17:33 | stephenfin | (I haven't pushed it to Gerrit yet because it's not end-to-end tested and I don't want to swamp the CI as I iterate) | |
| 15:17:34 | dansmith | sahid: yep, cool | |
| 15:18:20 | bauzas | stephenfin: I'm not sure we should dynamicall add the groups in nova/config | |
| 15:18:43 | bauzas | stephenfin: rather closer to the caller | |
| 15:19:20 | bauzas | stephenfin: my thoughts was to use devices.enabled_vgpu_types as the ListOpt value for knowing which opt groups to check | |
| 15:19:21 | stephenfin | bauzas: I wanted it to be done at startup so I could quickly fail. However, that's really good feedback for when it's on Gerrit :) | |
| 15:19:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove vestigial system_metadata param from info_from_instance() https://review.openstack.org/561724 | |
| 15:19:51 | bauzas | stephenfin: or use MultiStrOpt for that | |
| 15:19:53 | stephenfin | bauzas: Aye, I used 'CONF.neutron.physnets' for that | |
| 15:20:02 | stephenfin | https://github.com/stephenfin/nova/commit/58b53e888feb146123087f2e3f54f677f1fdccdc#diff-bf484fde349b127980f9341543ce3c9aR38 | |
| 15:20:27 | stephenfin | so '[neutron] physnets = foo, bar' | |
| 15:20:37 | bauzas | right | |
| 15:20:50 | bauzas | stephenfin: see the context in https://review.openstack.org/#/c/557065/2/specs/rocky/approved/vgpu-rocky.rst@86 | |
| 15:20:57 | bauzas | stephenfin: for MultiStrOpt | |
| 15:21:11 | stephenfin | I guess I could use prefixed attribute names but someone (jaypipes or dansmith, I think) thought that was eewy | |
| 15:21:35 | dansmith | jaypipes: we've validated this with the nfv ci, if you want to have another look at it and the one below: https://review.openstack.org/#/c/484997/ | |
| 15:22:16 | jaypipes | dansmith: ack, will do. | |
| 15:23:01 | jaypipes | ah, this is the one I'd asked sahid to combine the first two patches. yeah... one minute. | |
| 15:23:21 | sahid | dansmith: it was a really nice idea your DNM patch, i'm going to reuse it a lot :) | |
| 15:24:07 | dansmith | jaypipes: yep | |
| 15:24:11 | dansmith | sahid: :) | |
| 15:25:46 | bauzas | stephenfin: you're better than me on oslo.config, do you know if we can have a MultiStrOpt where two lines would have the same key but different values ? | |
| 15:26:34 | stephenfin | bauzas: Got an example? | |
| 15:26:39 | bauzas | sec | |
| 15:26:40 | stephenfin | They have the same key by definition | |
| 15:28:41 | jaypipes | dansmith: off to the test pits it goes. | |
| 15:28:45 | efried | gibi: Ready for you: https://review.openstack.org/#/c/561724/ self.NotificationEmail().AndRemove(bug_1764390) | |
| 15:29:13 | dansmith | jaypipes: the test pits ahead won't really test it, but it came back from other test pits that did recently, so.. thanks :) | |
| 15:29:17 | bauzas | stephenfin: actually, what I want is a MultiDictOpt | |
| 15:30:10 | jaypipes | bauzas: you do *not* want a MultiDictOpt. | |
| 15:30:18 | bauzas | I don't know | |
| 15:30:20 | jaypipes | bauzas: dansmith might kill you if you used that. | |
| 15:30:23 | bauzas | what I want is a pony | |
| 15:30:26 | jaypipes | heh | |
| 15:30:47 | jaypipes | bauzas: your dog is as big as a pony. | |
| 15:30:54 | stephenfin | kashyap: One question before I send that on it's way: how come you didn't use the "NEXT" libvirt/qemu values already specified by berrange? | |
| 15:30:55 | bauzas | I just want a fucking easy way to describe a transitive relationship between a thing and a list of other things | |
| 15:31:32 | bauzas | jaypipes: not as big as a pony, I saw taller yesterday when I was in a dog show | |
| 15:31:38 | jaypipes | bauzas: relational DBs are pretty good at storing relations :P | |