| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-19 | |||
| 20:50:50 | jaypipes | zzzeek_: fresh master checkout, nothing to do with my local changes. | |
| 20:50:57 | melwitt | *gasp* | |
| 20:51:00 | zzzeek_ | jaypipes: it's not related to your changes it's related to existing code in nova | |
| 20:51:22 | jaypipes | zzzeek_: ok. where we are calling query.update() or query.delete()? | |
| 20:51:30 | edmondsw | mriedem jackie-truong so I don't reallly have a strong opinion between 1) os_compute_api:servers:trusted_certs and 2) both os_compute_api:servers:create:trusted_certs and os_compute_api:servers:rebuild:trusted_certs | |
| 20:51:33 | edmondsw | at least not today :) | |
| 20:51:54 | mriedem | alright | |
| 20:51:57 | zzzeek_ | jaypipes: i dunno. maybe turn those warnigs into error raises and stacktrace will show | |
| 20:52:08 | zzzeek_ | jaypipes: unless nova is calling some other ORM-related application | |
| 20:52:14 | edmondsw | I'd probably go granular, but there are pros and cons | |
| 20:52:14 | jackie-truong | edmondsw: Np. I went with option 2 | |
| 20:52:20 | edmondsw | cool | |
| 20:52:35 | melwitt | gmann has a spec proposed for making policy more granular | |
| 20:52:59 | edmondsw | oh? | |
| 20:53:07 | edmondsw | I'll have to go find that | |
| 20:53:19 | melwitt | or consistently granular https://review.openstack.org/#/c/547850 | |
| 20:53:36 | melwitt | more granular | |
| 20:54:27 | mriedem | melwitt: hmm, how is https://review.openstack.org/#/c/539013/ passing if https://review.openstack.org/#/c/562739/ isn't merged yet? | |
| 20:54:40 | melwitt | mriedem: hah, good question | |
| 20:54:58 | edmondsw | melwitt tx, added to my queue | |
| 20:55:09 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: WIP Revert "Proper error handling by _ensure_resource_provider" https://review.openstack.org/562739 | |
| 20:55:36 | mriedem | melwitt: unless it's a race | |
| 20:55:49 | melwitt | yeah, might be. that would make more sense | |
| 20:57:32 | melwitt | ugh, hit the same on the ceph job on stable/ocata http://logs.openstack.org/30/511230/1/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/819c5da/logs/screen-n-cpu.txt.gz?level=TRACE | |
| 20:57:49 | melwitt | well, in trying to fix the ceph job on stable/ocata | |
| 20:58:15 | melwitt | that patch is what I thought would fix it, but then ran into the AttributeError: 'NoneType' object has no attribute 'generation' afterward | |
| 21:05:44 | mriedem | ok that would explain how it slipped through the gate too | |
| 21:06:03 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Revert "Proper error handling by _ensure_resource_provider" https://review.openstack.org/562739 | |
| 21:10:15 | jackie-truong | mriedem: Do you just want the rules. Or also to enforce it when booting from volume? Or are we just relying on the fail message when booting from volume? | |
| 21:11:06 | mriedem | jackie-truong: the policy rule is separate from boot from volume | |
| 21:11:18 | mriedem | bfv is a flat out 400 when used with trusted_certs because it's not supported | |
| 21:11:33 | mriedem | the policy rule is for disabling the feature if your cloud can't support it, regardless of bfv | |
| 21:11:43 | jackie-truong | got it | |
| 21:11:53 | jackie-truong | And should the policy rule be a separate patch? | |
| 21:11:59 | jackie-truong | Or can I just plug it into the API patch? | |
| 21:15:57 | openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: fix a typo https://review.openstack.org/556455 | |
| 21:17:31 | dansmith | jackie-truong: kinda has to be in the api patch no? | |
| 21:17:42 | dansmith | otherwise you'd open it to everyone in one and then close it off in the next one | |
| 21:18:04 | jackie-truong | dansmith: mmm yeah good point | |
| 21:18:39 | openstack | Launchpad bug 1761062 in OpenStack Compute (nova) " clean source instance directory failed in _cleanup_resize when images_type is rbd" [Undecided,New] | |
| 21:18:39 | mriedem | this is a fun bug https://bugs.launchpad.net/nova/+bug/1761062 | |
| 21:18:51 | mriedem | you red hat people might enjoy that one | |
| 21:18:55 | dansmith | doubtful | |
| 21:19:42 | mriedem | you will enjoy it | |
| 21:20:44 | zzzeek_ | jaypipes: a simple grep is not finding it nova seems to use query.update() a lot with a bunch of abstraction on top of it | |
| 21:20:59 | zzzeek_ | jaypipes: would need to get a stack trace | |
| 21:21:20 | zzzeek_ | jaypipes: pdb into it and look for an unattached Column(), i have a feeling this might be local to the test suite | |
| 21:24:10 | melwitt | nooo not more ceph bugs | |
| 21:39:37 | jaypipes | zzzeek_: k, will try a bit later. | |
| 21:43:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: xenapi: handle InstanceNotFound in detach_interface() https://review.openstack.org/562838 | |
| 22:01:00 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Mention that users need noVNC >= 0.6 https://review.openstack.org/562847 | |
| 22:04:21 | openstackgerrit | Merged openstack/nova stable/pike: libvirt: Report the allocated size of preallocated file based disks https://review.openstack.org/562077 | |
| 22:20:16 | openstackgerrit | Merged openstack/python-novaclient stable/pike: Correct typo in deprecation for floating-ip commands https://review.openstack.org/562392 | |
| 22:20:43 | openstackgerrit | Merged openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 22:22:29 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | |
| 22:25:21 | openstackgerrit | Merged openstack/nova stable/pike: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560145 | |
| 22:25:31 | openstack | Launchpad bug 1670627 in OpenStack Compute (nova) ocata "quota is always in-use after delete the ERROR instances " [Critical,Fix released] - Assigned to Matt Riedemann (mriedem) | |
| 22:25:31 | melwitt | hm, was just looking at this for our bug meeting tomorrow and noticed someone commented a couple of months ago that this was not fixed for them in ocata after all https://bugs.launchpad.net/nova/+bug/1670627 | |
| 22:27:30 | mriedem | hmm | |
| 22:27:32 | mriedem | well | |
| 22:27:38 | mriedem | they also didn't really give any details | |
| 22:28:23 | mriedem | left a comment | |
| 22:29:03 | melwitt | yeah, I know. I just meant it sucks that there's still the bug after all those fixes we did. at least two people have run into it. I'll be able to get more detail from the internal bug too | |
| 22:29:13 | mriedem | well | |
| 22:29:23 | mriedem | how do we know that those people applied fixes correctly | |
| 22:29:28 | mriedem | or didn't hit something else | |
| 22:29:43 | mriedem | if they have 3 nova-apis running and only patched one... | |
| 22:30:03 | melwitt | maybe. in the internal bug case they're running ocata 15.0.8 | |
| 22:30:36 | melwitt | but yeah, not guaranteed it's really a problem, just looks like it is so far | |
| 22:30:48 | mriedem | i refuse to believe there are bugs | |
| 22:30:55 | melwitt | okay :) | |
| 22:32:12 | melwitt | I could dust off my ocata devstack maybe | |
| 22:32:30 | melwitt | for a sanity check | |
| 22:33:33 | melwitt | I wonder if it might be something like, instances in ERROR state that were *not* in cell0. like, if the instance ERRORed for a reason other than failing to schedule | |
| 22:36:31 | openstackgerrit | Eric Fried proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | |
| 22:37:36 | mriedem | yeah maybe, | |
| 22:37:49 | mriedem | like that one you fixed, instance in error with no host b/c it failed to build in a cell | |
| 22:40:57 | melwitt | yeah, I wonder if it's that actually | |
| 22:41:32 | melwitt | if that fix is needed to make things take the path that will decrement quota usage | |
| 23:02:54 | melwitt | nah, instance in ERROR state after failing to build on a compute host should take this path, which would decrement usage https://github.com/openstack/nova/blob/stable/ocata/nova/compute/api.py#L1788-L1825 | |
| 23:11:43 | melwitt | (because the instance.host is set to None if build fails on compute) | |
| 23:28:15 | openstackgerrit | Merged openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | |
| 23:59:40 | openstackgerrit | Merged openstack/nova master: Improve check capacity sql https://review.openstack.org/561862 | |
| 23:59:50 | openstackgerrit | Merged openstack/nova stable/queens: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/557930 | |
| #openstack-nova - 2018-04-20 | |||
| 00:17:49 | TheJulia | Out of curiosity, is anyone aware of any cases where vifs might be attempted to be plugged more than one for a deploying node? | |
| 00:17:57 | TheJulia | s/deploying node/deploying instance/ | |
| 00:33:15 | openstackgerrit | Merged openstack/nova stable/ocata: unquiesce instance on volume snapshot failure https://review.openstack.org/545973 | |
| 00:33:23 | openstackgerrit | Merged openstack/nova master: Provide framework for setting placement error codes https://review.openstack.org/546177 | |
| 00:49:29 | phuongnh | TheJulia, could you please confirm this is a bug: https://storyboard.openstack.org/#!/story/2001824 | |
| 00:51:43 | TheJulia | phuongnh: we need the `openstack baremetal volume target show` output | |
| 00:52:16 | phuongnh | I see, I will add it soon. Thanks | |
| 00:52:25 | phuongnh | is there any more do you need? | |
| 00:58:18 | openstack | Launchpad bug 1670628 in os-vif queens "nova-compute will try to re-plug the vif even if it exists for vhostuser port." [High,Fix committed] - Assigned to sahid (sahid-ferdjaoui) | |
| 00:58:18 | melwitt | TheJulia: not really, the only thing remotely related I can think of was this bug https://bugs.launchpad.net/os-vif/+bug/1670628 which sounds different than plugging more than once during a deploy | |
| 00:59:38 | TheJulia | phuongnh: If there is any way you can grab the rendered /httpboot/uuid/config file and post it, naturally edited to remove any sensitive details, that would help us tremendously | |
| 01:00:02 | TheJulia | phuongnh: Also, I take it the machine just hangs correct? never boots? | |
| 01:01:03 | TheJulia | melwitt: I think it is the block device stuff we have that might trigger for bdm mapping data Looks like ironic might be returning the wrong thing as it is functionally a race so the virt driver code doesn't handle it correclty :( | |
| 01:01:09 | phuongnh | TheJulia: I will check again and reply all to you within today, thanks | |
| 01:06:21 | phuongnh | TheJulia: I would like to propose a property for CPU_FPGA to os-traits | |
| 01:06:54 | TheJulia | Seems reasonable if it is a coprosssor | |