Posted	Nick	Remark
#openstack-nova - 2018-04-19
06:23:32	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748
06:23:40	bauzas	melwitt: ack
06:38:35	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Documents update for XAPI pool shared SR migration https://review.openstack.org/562482
06:51:45	yikun_	@gmann, hey, I saw your reply in link:
06:51:51	yikun_	https://review.openstack.org/#/c/557145/12/nova/tests/functional/api_sample_tests/test_instance_actions.py@127
06:51:57	yikun_	and I want to sure your means is:
06:52:04	yikun_	1. we need put a sample file in common dir.
06:52:26	yikun_	2. create a hard code python map to record the version section and sample maping
06:52:33	yikun_	3. set the use_common_server_api_samples to true when I call the req func
06:52:38	yikun_	right?
06:59:20	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288
07:02:22	gmann	yikun_: kind of but those cannot be in common dir as they are specific to microversion. server samples are commonly used in other tests so they were in common dir
07:03:10	gmann	yikun_: i need to think more that what can be more optimized and not too magic way
07:04:04	gmann	yikun_: but for your change let's go back to the PS where you had 2.58 tests as base
07:07:52	yikun_	gmann, yes, sure, I will update soon.
07:08:06	yikun_	and I will think about it too, and if you have some idea or I can offer you some help, don't hesitate to ping me. : )
07:09:18	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient stable/pike: Use generic user for both zuul v2 and v3 https://review.openstack.org/562500
07:12:57	gmann	yikun_: sure thanks.
07:13:31	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient stable/pike: Use generic user for both zuul v2 and v3 https://review.openstack.org/562500
07:13:56	Mr_Smurf	I have some strange issues with live migration.. The instance is moved to the other hypervisor but ends up in error state and in the database it is on the wrong hypervisor.
07:14:37	Mr_Smurf	Anyone experienced something like this?
07:14:54	Mr_Smurf	(openstack newton)
07:15:43	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145
07:31:31	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Documents update for XAPI pool shared SR migration https://review.openstack.org/562482
07:41:36	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Documents update for XAPI pool shared SR migration https://review.openstack.org/562482
07:55:44	gibi	Kevin_Zheng: hi! I left some comments in https://review.openstack.org/#/c/553288/20
07:57:45	Kevin_Zheng	gibi, Thanks I will fix them
07:58:33	Kevin_Zheng	very good comments :)
07:59:36	gibi	Kevin_Zheng: just ping me when you push the fix and I will quickly re-review as this patch is really close now
08:00:01	Kevin_Zheng	gibi, sure thanks
08:00:22	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: deprecate the config for image handler class path https://review.openstack.org/497201
08:03:12	kashyap	takashin: Just FYI, I'll abandon this change: https://review.openstack.org/#/c/560365/ ("libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION"), and the other two existing "Drop" constant series
08:03:25	kashyap	takashin: As they're now merged into the top-level change: https://review.openstack.org/#/c/558783/
08:08:55	openstackgerrit	Merged openstack/nova-specs master: Handle nested providers for allocation candidates https://review.openstack.org/556873
08:14:01	takashin	kashyap: Than you for your notice.
08:28:53	kashyap	stephenfin: Morning, when you get a sec —
08:29:35	kashyap	stephenfin: I think I can simply delete the "test_invalid_libvirt_version()" test now, post MIN libvirt / QEMU version bump: https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_rt_servers.py#L71,L95
08:29:47	kashyap	Given the failure here: http://logs.openstack.org/83/558783/10/check/nova-tox-functional/ac56391/testr_results.html.gz
08:31:53	openstackgerrit	Merged openstack/nova master: conf: Remove deprecated 'multi_instance_display_name_template' opt https://review.openstack.org/499612
08:42:48	openstackgerrit	Balazs Gibizer proposed openstack/nova-specs master: Suggest when to propose notification changes https://review.openstack.org/562265
08:53:15	openstackgerrit	Chen Hanxiao proposed openstack/nova master: _cleanup_resize: remove rbd swap disk if resize to flavor without swap https://review.openstack.org/534711
09:31:34	maciejjozefczyk	Hey :)
09:34:27	openstackgerrit	Chris Dent proposed openstack/nova master: Add root and parent provider uuid to group by clause https://review.openstack.org/562379
10:01:36	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
10:07:06	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783
10:07:07	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: Drop MIN_LIBVIRT_SET_ADMIN_PASSWD https://review.openstack.org/562312
10:07:08	openstackgerrit	Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PARALLELS_SET_ADMIN_PASSWD https://review.openstack.org/562313
10:17:02	ygl	hi all
10:17:34	ygl	can anyone explain to me how to find out the flavor id for an instance from the nova database ?
10:26:58	openstackgerrit	zhangyangyang proposed openstack/nova master: Deprecate auth_uri option https://review.openstack.org/562537
10:30:00	ygl	can anyone help me please with my query
10:30:21	ygl	I want to find out the flavor id for an instance from the nova database
10:50:54	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Support inherit api samples in ApiSampleTestBase https://review.openstack.org/562547
10:58:25	yikun_	^ @gmann I'm not sure it's a best solution or not, but it is a way to solve our problem at least.
10:59:09	yikun_	gmann, you could take a look when u have time. :) https://review.openstack.org/562547
11:17:32	Kevin_Zheng	gibi are you around?
11:20:38	gibi	Kevin_Zheng: yes
11:21:24	Kevin_Zheng	I almost done the coding, but again, there are some problems with the tests
11:22:32	gibi	Kevin_Zheng: you can push the patch up then I can take a look at it and might be able to help with the test
11:22:39	Kevin_Zheng	as you guys left in the comments, I suppose to adding req_id for instance update notifications and not include it for periodic tasks
11:23:07	Kevin_Zheng	which matt suggested using the judgement of whether context.auth_token is present
11:23:21	Kevin_Zheng	since we use noauth middleware
11:23:36	Kevin_Zheng	there will always be no context.auth
11:23:50	Kevin_Zheng	https://github.com/openstack/nova/blob/324899c621ee02d877122ba3412712ebb92831f2/nova/api/openstack/auth.py#L57
11:24:27	Kevin_Zheng	I will put it up if I cannot come up with ideas before I go
11:24:46	gibi	Kevin_Zheng: your understanding seems correct to me
11:25:55	Kevin_Zheng	maybe we shouldn't judge by authtoken
11:26:31	Kevin_Zheng	because if someone is actually using Noauth middleware, he will always got no req_id in the notification
11:26:32	gibi	Kevin_Zheng: then we have to find another way to distinguish between context from a periodic task and another normal context
11:26:47	gibi	Kevin_Zheng: let me dig a bit
11:26:56	Kevin_Zheng	Thanks
11:31:53	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries https://review.openstack.org/558045
11:31:54	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480
11:31:55	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories https://review.openstack.org/559554
11:34:49	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288
11:36:51	kashyap	Are others hitting these IBM zVM CI failures too: http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-16984/console.html
11:37:17	kashyap	It is all: "Exceeded maximum number of retries. Exhausted all hosts available for retrying build failures for instance"
11:41:20	Kevin_Zheng	gibi Hi, I got it, maybe I should use (context.is_admin and not context.auth_token) rather than just context.auth_token
11:43:23	gibi	Kevin_Zheng: I think that is a partial solution. If the deployer use NoAuth and the user is an admin or the non admin context is elevated somewhere in the code path then your condition will be true
11:43:53	Kevin_Zheng	yeah
11:50:03	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Support inherit api samples in ApiSampleTestBase https://review.openstack.org/562547
11:51:49	gibi	the NoAuth set user_id and project_id but the get_admin_context() call used by the periodic task set them to None
11:52:31	Kevin_Zheng	Hmm
11:52:32	gibi	Kevin_Zheng: so instead of checking for the auth_token you can check the project_id and user_id
11:52:43	Kevin_Zheng	Let me try
11:54:02	openstackgerrit	Merged openstack/osc-placement master: RP list: member_of and resources parameters (v1.3, v1.4) https://review.openstack.org/511183
12:02:36	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288
12:02:58	Kevin_Zheng	gibi ^ done
12:03:17	gibi	Kevin_Zheng: thanks, looking
12:05:05	mriedem	lyarwood: bauzas: today is rocky-1 and i think melwitt wanted to do some stable branch releases too - stable/ocata has a bunch of patches which need a final +2 if you can go through those https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/ocata
12:05:55	gibi	Kevin_Zheng: you have to update the comment in https://review.openstack.org/#/c/553288/22/nova/notifications/objects/instance.py@124
12:06:30	bauzas	mriedem: yup, I reviewed the queens branch this morning and I was about to look at the pike and ocata branches this afternoon ;)
12:08:36	Kevin_Zheng	gibi maybe shouldn't write about auth_token anymore?
12:09:46	gibi	Kevin_Zheng: I'm OK with that too
12:10:01	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288
12:10:05	gibi	Kevin_Zheng: but then we have to explain in the commit message that we could not simply use the auth_token as Matt suggested
12:10:40	Kevin_Zheng	...really? just updated
12:13:59	gibi	Kevin_Zheng: or we can tell mriedem on IRC so he will know why we not used context.auth_token ;)
12:15:38	Kevin_Zheng	gibi I like this one
12:15:49	mriedem	i don't think anyone uses NoAuthMiddleware in production fwiw

Earlier   Later