Earlier  
Posted Nick Remark
#openstack-nova - 2018-04-17
17:45:12 melwitt I know, but I've run into issues with that in the past
17:52:54 melwitt Kevin_Zheng: your blueprint "Add request_id to instance action notifications [END DATE: 2018-05-01]" has been added to a review runway. please let us know if the next two weeks are not a good time for fast iteration on review https://etherpad.openstack.org/p/nova-runways-rocky
17:53:38 dansmith I assume we won't hear back on that until later this afternoon yeah?
17:54:07 melwitt maybe not. I didn't know what time zone he is
17:55:27 openstackgerrit Chris Dent proposed openstack/nova-specs master: Update forbidden spec to reflect chosen nova-side format https://review.openstack.org/562012
17:55:30 dansmith melwitt: china
17:55:41 melwitt a-ha, cool
17:55:59 melwitt the series is half approved already and currently actively reviewed/responded so I expect it's going to be okay
18:07:39 imacdonn mriedem dansmith efried: need to decide what to do with https://review.openstack.org/#/c/558089/ - I'm leaning back towards just removing the check in init_host(). If it needs something more than that, I probably need to let it go to someone else
18:07:58 openstackgerrit Merged openstack/python-novaclient master: Fix comments in novaclient/tests/unit/fakes.py https://review.openstack.org/561772
18:08:48 efried imacdonn: I thought we decided to basically leave the old check as is but switch to checking auth_type instead of region
18:09:07 imacdonn efried: I tried that, but it gets all complicated with unit testing again
18:09:33 efried You can't just replace os_region_name with auth_type throughout?
18:10:38 imacdonn efried: no, because all the tests that create a compute service try to actually use placement if auth_type is set, and we're back to messing around with fixtures (and it needs a valid auth_url, etc.)
18:10:59 efried eek, really? Hum, okay.
18:14:13 mriedem so zvm was moved out of runways? i don't see a log note for it
18:14:41 dansmith mriedem: there was ML traffic about it
18:15:02 mriedem sure but
18:15:06 mriedem sherbit
18:15:12 dansmith not in the lo because it's back in the queue I guess
18:15:13 mriedem sorbet?
18:15:37 dansmith sherbert
18:16:47 mriedem ok, haircut time it is
18:19:12 melwitt yeah, I didn't think to put log notes because it's back in the queue. but I'll add log notes to it now, I think that's a good idea
18:19:58 dansmith I did it
18:20:00 dansmith with a link to the ML
18:20:12 melwitt you rock, thanks
18:38:39 openstackgerrit Merged openstack/nova-specs master: Update forbidden spec to reflect chosen nova-side format https://review.openstack.org/562012
18:40:54 openstackgerrit Merged openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299
18:41:05 openstackgerrit Merged openstack/nova master: Deduplicate notification samples Rocky - 3 https://review.openstack.org/560727
18:41:21 openstackgerrit Merged openstack/nova master: doc: BFV instances and IsolatedHostsFilter https://review.openstack.org/543494
18:42:18 sean-k-mooney anyone know where the people that work on diskimage-builder hang out on irc? #openstack-infra?
18:42:44 dansmith probs
18:42:59 imacdonn sean-k-mooney: there's supposed to be a #openstack-dib , according to https://wiki.openstack.org/wiki/IRC
18:43:17 sean-k-mooney imacdonn: ah thanks :)
18:43:54 sean-k-mooney i need to bookmark that wiki
18:47:23 dansmith lyarwood: on this https://review.openstack.org/#/c/561704 -- are we sure that the bit you're getting from qemu-img is the allocated part and not the would-be-allocated part?
18:50:53 lyarwood dansmith: it's the allocated part, virtual size is the potential allocation but thats the same for preallocated files like the example in the commit
18:51:44 dansmith lyarwood: yeah, I'm poking around with qemu-img right now
18:53:13 dansmith the fallocate command you have doesn't work for me,
18:53:27 dansmith but the neckbeard way of making a sparse file does show:
18:53:37 dansmith disk size: 1.0M
18:53:37 dansmith virtual size: 1.0G (1074790400 bytes)
18:53:37 dansmith dan@eagle:~$ qemu-img info -f raw testsparse.img | grep size
18:55:00 lyarwood dansmith: ah on osx? fallocate -n is odd and tbh I had no idea about it until this came up
18:55:07 dansmith lyarwood: nope, linux
18:55:21 dansmith fallocate: fallocate failed: keep size mode is unsupported
18:55:41 lyarwood dansmith: try -l 1M
18:56:04 dansmith it doesn't matter, I created a sparse file with dd
18:56:13 lyarwood dansmith: but anyway, it's weird as it leaves the EOF at the start of the file but allocates blocks past that.
18:56:22 dansmith because I'm old school cool
18:56:51 dansmith oh I see, a little different than sparse
18:56:58 dansmith that seems fairly evil
18:57:30 dansmith but, doesn't matter for what I was looking for
18:57:37 lyarwood kk
19:02:23 dansmith jaypipes: wanna send that ^ ?
19:02:28 dansmith pretty easy
19:03:57 openstackgerrit iain MacDonnell proposed openstack/nova master: Remove placement config check https://review.openstack.org/558089
19:13:35 jaypipes dansmith: sorry, send what?
19:13:48 dansmith jaypipes: https://review.openstack.org/#/c/561704
19:14:05 dansmith quick fix to look at the actual allocated size of a disk instead of just what the dumb ol' operating system thinks
19:14:11 dansmith (i.e. accounting for sparse files)
19:14:13 jaypipes ack. on itr.
19:23:55 jaypipes dansmith: /me wondering what "crudini" is...
19:24:10 dansmith eh?
19:24:11 openstackgerrit Merged openstack/nova master: Remove mox in test_serversV21.py (1) https://review.openstack.org/560821
19:25:00 jaypipes dansmith: +W'd it.
19:25:32 lyarwood jaypipes: ^_^ https://pypi.org/project/crudini/ aka openstack-config
19:26:02 lyarwood well, downstream at least, no idea if that wrapper was upstream at any point
19:26:50 dansmith jaypipes: pre-allocation of an image (even qcow) is for performance
19:27:59 jaypipes lyarwood: ah, cool. thx :)
19:28:45 jaypipes dansmith: oh? wasn't aware of that. is the performance due to contiguous blocks being grouped together?
19:28:56 dansmith jaypipes: allocation takes time and effort
19:29:17 dansmith jaypipes: on a busy system preallocation won't even get you contiguous bits,
19:29:36 dansmith but if you want predictable disk performance, you don't want to write to a hole and take a hit waiting for the allocation and _then_ the write
19:29:41 dansmith and of course,
19:29:42 jaypipes dansmith: so pre-allocating speeds up VM start times?
19:29:49 dansmith no
19:29:55 dansmith this would be performance after it's running
19:30:01 jaypipes ah, ok.
19:30:12 jaypipes sorry, out of my depth with block device stuff :(
19:30:23 dansmith before it has hit every page on its own disk at least once
19:30:24 dansmith s'all good
19:46:42 openstackgerrit Merged openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API https://review.openstack.org/561520
19:53:51 openstackgerrit Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
19:53:52 openstackgerrit Jackie Truong proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262
19:53:53 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
19:53:54 openstackgerrit Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
20:03:58 openstackgerrit Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315
20:04:58 melwitt jackie-truong: hey, just wanted to say please feel free to add notes on how the runway time went for your blueprint in the log area (L123 https://etherpad.openstack.org/p/nova-runways-rocky)
20:05:47 jackie-truong melwitt: Absolutely, will do!
20:06:53 openstackgerrit Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315
20:10:42 openstackgerrit Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262
20:13:58 mriedem GAH
20:14:28 mriedem why does this hard-coded read_deleted='no'? https://github.com/openstack/nova/blob/54dc7048a48799ed980138e3524e4ebfc544eb8c/nova/db/sqlalchemy/api.py#L473
20:14:32 mriedem *hard-code
20:15:33 cfriesen so do a bunch of the other service_get_by_* routines
20:15:37 mriedem yes
20:15:46 mriedem glad i stepped away for awhile to come back and figure this out
20:16:14 melwitt because no one would ever want to read deleted service records or use context to override read_deleted. duh!

Earlier   Later