| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-17 | |||
| 14:03:51 | sahid | mriedem: ok thanks i will take a look and see whether i can help sean if he does not have time to update the code | |
| 14:04:26 | bhagyashris | efried: Hi, | |
| 14:04:28 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API https://review.openstack.org/561520 | |
| 14:04:32 | efried | bhagyashris: Howdy! | |
| 14:07:02 | mriedem | bauzas: trade for you https://review.openstack.org/#/q/topic:bug/1746483+branch:stable/ocata | |
| 14:07:19 | bauzas | mriedem: roger, ack this | |
| 14:07:39 | bauzas | mriedem: you freed me from some internal blackhole, I can pay you off | |
| 14:08:39 | bauzas | oooooh I remember that nasty bug with IsolatedHosts :) | |
| 14:09:05 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Document how to disable notifications https://review.openstack.org/561954 | |
| 14:09:36 | sean-k-mooney | dansmith: ya i would prefer not to set teh driver name element if we dont need too however im fine with it for now | |
| 14:10:02 | dansmith | sean-k-mooney: yep, thanks for that review | |
| 14:17:43 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: doc: BFV instances and IsolatedHostsFilter https://review.openstack.org/543494 | |
| 14:18:07 | bauzas | mriedem: FWIW, just made the amendment you asked me 2 months ago https://review.openstack.org/#/c/543494/ | |
| 14:20:51 | openstackgerrit | Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925 | |
| 14:21:33 | mriedem | ok | |
| 14:22:06 | mriedem | bauzas: also, gerrit UI won't add the cherry-picked from line in the commit message unless the change you're cherry picking *from* is merged | |
| 14:22:39 | bauzas | I see, in case of a merge commit | |
| 14:25:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: BFV instances and IsolatedHostsFilter https://review.openstack.org/543494 | |
| 14:29:48 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: libvirt: Block swap volume attempts with encrypted volumes prior to Queens https://review.openstack.org/543569 | |
| 14:39:26 | openstackgerrit | Merged openstack/python-novaclient master: Stop printing flavor details on successful flavor-delete https://review.openstack.org/561634 | |
| 14:43:57 | kashyap | Folks, when someone gets time, can you beat some sense into my (broken) test and me: http://paste.openstack.org/show/719390/ | |
| 14:44:27 | kashyap | This is the last of the two unit test failures I need to fix for the "first batch" of the version bump clean-ups | |
| 14:44:36 | efried | kashyap: Which line is the exception hitting on? | |
| 14:45:09 | kashyap | efried: Line-56, that's what I'm messing up | |
| 14:45:21 | kashyap | efried: For context, this is the original: https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L9171,L9219 | |
| 14:46:03 | kashyap | I am replacing the usage of the migrateToURI2() with migrateToURI3() in that test, as a result of post version bump clean-up. | |
| 14:46:29 | efried | ? | |
| 14:46:29 | efried | mock_updated_guest_xml.return_value = '' | |
| 14:46:29 | efried | kashyap: Uh, the exception hits when you say | |
| 14:46:40 | kashyap | In the original: target_xml is supplied to mock object to validate return value - test_mock.XMLDesc.return_value = target_xml | |
| 14:47:30 | kashyap | efried: Can't pin-point to that, but I know that's a mistake there. Still haven't ran PDB on that to narrow down, but was duking around other bits | |
| 14:48:21 | kashyap | efried: For context, this is the other local change that I've fixed for a different test: https://kashyapc.fedorapeople.org/0001-tests-unit-Fix-test_live_migration_update_graphics_x.patch | |
| 14:48:39 | kashyap | It's (the current broken test: 'test_live_migration_with_valid_target_connect_addr') in the same vein | |
| 14:48:53 | efried | kashyap: Is there code change behind this, or are you just tweaking the test case? | |
| 14:48:56 | kashyap | We're not doing any Mox stuff in this current test, though. | |
| 14:49:22 | kashyap | efried: I'm tweaking it as a result of: https://review.openstack.org/#/q/topic:bump_min_libvirt_and_qemu+(status:open+OR+status:merged) | |
| 14:49:47 | efried | kashyap: Just trying to figure out what I need to do to repro it locally, is all. | |
| 14:50:14 | kashyap | efried: You need to apply the above series. And run this: | |
| 14:50:16 | kashyap | nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_live_migration_with_valid_target_connect_addr | |
| 14:50:29 | efried | ... | |
| 14:50:54 | gibi | mlavalle: hi! I'm back. rubasov mentioned that you might be in the process of updating the nova bandwidth spec. I got updated by rubasov about the current issues and I will start shaping up the spec for the next round of discussion but I dont want to conflict with your update | |
| 14:51:02 | kashyap | efried: Feel free to disregard me, as this is a bit time consuming, and needs context | |
| 14:51:32 | kashyap | efried: So, if you're in the middle of thing, you can just drop it on the floor. | |
| 14:51:45 | gibi | mlavalle: so I can hold my horses if you have something locally already | |
| 14:52:25 | efried | kashyap: I'm pretty green in a lot of areas, but feel pretty good about my understanding of mocks. If I can't nail it down fairly quickly, I'll leave you to your thrashing, but I gotta have a crack at it. | |
| 14:52:40 | gibi | mlavalle: please not that I will be in and out of connectivity today so I might respond slowly | |
| 14:52:48 | kashyap | efried: Excellent. The context is only around libvirt APIs. I'm horrible with unit tests and Mocks | |
| 14:52:52 | efried | kashyap: Okay, so with the series applied and your test added (I named it with a 2) both tests fail. This is what we expect as a baseline, right? | |
| 14:52:52 | gibi | mlavalle: *note | |
| 14:52:54 | mlavalle | gibi: I've been working heads down on multiple port binding, so please go ahead | |
| 14:53:07 | mlavalle | don't hold for me | |
| 14:53:14 | kashyap | efried: Sure. I'd welcome a different pair of eyes; I'm a bit burned from looking at these the whole day. Thanks for the assist! | |
| 14:53:23 | gibi | mlavalle: OK. thanks for the info | |
| 14:53:25 | mlavalle | gibi: and welcome! | |
| 14:53:36 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION https://review.openstack.org/560365 | |
| 14:53:37 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: tests: unit: Fix 'test_live_migration_update_serial_console_xml' https://review.openstack.org/561969 | |
| 14:53:38 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: tests: unit: Fix 'test_live_migration_update_graphics_xml' https://review.openstack.org/561970 | |
| 14:53:42 | mlavalle | I hope you enjoyed your trip | |
| 14:53:51 | mlavalle | and didn't think about us ;-) | |
| 14:53:57 | efried | kashyap: Interestingly, both versions of the test fail the same way. | |
| 14:54:10 | kashyap | efried: You mean, my so-called "updated" and the old one? | |
| 14:54:32 | efried | kashyap: Yes. And there's no trace to actual running code; I suspect it's blowing up at mock time. | |
| 14:54:43 | kashyap | efried: Exactly | |
| 14:55:03 | kashyap | I have no idea, my Mock knowledge is ... mockable | |
| 14:55:08 | efried | kashyap: I mean it's the decorators. | |
| 14:55:15 | stephenfin | mriedem: Is the API in nova/network/base_api.py a contract we need to maintain for external users? | |
| 14:55:31 | stephenfin | i.e. N cycles before we can remove a function | |
| 14:55:33 | efried | kashyap: which is bizarro because the original don't have no decorators. | |
| 14:55:38 | gibi | mlavalle: yes, It was really nice and I was able to forget about work :) | |
| 14:55:40 | kashyap | efried: Fantastici | |
| 14:55:44 | kashyap | efried: But you know -- | |
| 14:55:54 | gibi | mlavalle: now I'm trying to catch up | |
| 14:56:07 | mlavalle | :-) | |
| 14:56:25 | efried | kashyap: f me this test suite is huge. | |
| 14:56:45 | kashyap | efried: Tell me all about it | |
| 14:57:19 | kashyap | efried: For context, see this -- "test_live_migration_update_volume_xml", this is almost same as the other one: test_live_migration_with_valid_target_connect_addr | |
| 15:00:36 | efried | uh oh, my IRC client is freaking out. Back in a tick... | |
| 15:01:39 | openstackgerrit | Merged openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625 | |
| 15:01:47 | kashyap | mriedem: Are such unit test only patches frowned-upon? https://review.openstack.org/#/c/561969/ | |
| 15:02:26 | kashyap | mriedem: I've only got two of such, though. And two more to go in that vien -- fixing the fallout of migrateToURI{2,3} APIs | |
| 15:02:51 | openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | |
| 15:02:52 | openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | |
| 15:02:53 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | |
| 15:03:35 | openstackgerrit | sahid proposed openstack/nova master: libvirt: fix wrong driver name for vhostuser interface https://review.openstack.org/561562 | |
| 15:03:36 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | |
| 15:04:54 | mriedem | umm | |
| 15:05:07 | mriedem | kashyap: the commit message doesn't explain to me why we need those changes | |
| 15:05:16 | mriedem | if the tests aren't failing as a result of the version cap changes | |
| 15:06:22 | mriedem | -1 with words to mull | |
| 15:06:35 | kashyap | mriedem: They are of course failing due to the version cap changes. | |
| 15:06:42 | kashyap | Not fixing them out of giggles | |
| 15:06:53 | kashyap | mriedem: But yes, fair point on the commit message -- I'll write that | |
| 15:07:48 | mriedem | so these changes are coming before some future patch that changes/removes some version-dependent piece of code? | |
| 15:07:55 | mriedem | rather than just include them in that same change? | |
| 15:07:58 | kashyap | With the version bump, we get the migrateToURI3() API for gratis, and the older one is riddled with problems | |
| 15:08:20 | mriedem | if the tests start to fail b/c you remove x, then include them in the patch that removes x | |
| 15:08:22 | kashyap | mriedem: Yeah. I thought including them all in one big blob is ugly | |
| 15:08:31 | kashyap | But if that's preferred, I can squash them into that change | |
| 15:08:48 | kashyap | Because probably it *belongs* with the bump change, as that is what has caused the problem. | |
| 15:09:15 | mriedem | typically the only test only changes i see are (1) adding more test coverage to existing code or (2) a negative test to recreate a bug which is then followed up by a patch that shows the bug is fixed | |