| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-17 | |||
| 13:55:42 | sahid | i will update that point | |
| 13:55:46 | dansmith | sahid: okay, that's terribly confusing, but not your fault | |
| 13:55:56 | dansmith | sahid: also, why did you abandon the bottom patch? | |
| 13:56:45 | dansmith | sahid: I was just saying he noted it should be vhost-user not vhostuser | |
| 13:56:51 | dansmith | but he never commented on it I guess | |
| 13:56:52 | sahid | because i understood that we want only change the driver name if rx or tx queue size is updated, if not so we keep the old behavior and touch nothing | |
| 13:56:52 | openstackgerrit | Matthew Booth proposed openstack/nova master: Rename recreate to evacuate in driver signatures https://review.openstack.org/560900 | |
| 13:56:53 | openstackgerrit | Matthew Booth proposed openstack/nova master: Remove redundant _do_check_can_live_migrate_destination https://review.openstack.org/561948 | |
| 13:56:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Don't confuse CPU pinning/NUMA as Hyper-V only https://review.openstack.org/561949 | |
| 13:56:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove 'admin/numa' doc https://review.openstack.org/561950 | |
| 13:57:32 | sahid | hum so i missunderstood | |
| 13:58:12 | dansmith | sahid: okay I think that setting vhost-user when we're sure it's vhost-user is a good cleanup, unrelated to the vhost driver change at the top, which is what I was referring to | |
| 13:58:25 | dansmith | but it sounds like he's come around on that second bit anyway | |
| 13:59:23 | dansmith | sahid: if you don't mind restoring that bottom patch but s/vhostuser/vhost-user/ I'll be +2 on both | |
| 13:59:33 | dansmith | sahid: and then I'll try to get jaypipes to review it in trade for something else :) | |
| 13:59:54 | sahid | dansmith: yep actually i agreed with you about to fix that point | |
| 14:00:01 | dansmith | *gasp* :) | |
| 14:00:20 | sahid | just not sure i understand what you want with the vhost thing? do you want me to change something? | |
| 14:01:24 | dansmith | the vhost thing is in the second patch, in that you're overriding driver to vhost in more cases today than before the patch, which sean-k-mooney originally said he didn't want to change, but I think he is okay with it now, based on comments, so nothing to change | |
| 14:02:08 | sahid | ok cool but that is said I only update it if rx or tx queue size is asked | |
| 14:02:18 | sahid | anyway let me fix all of that and i will ping you | |
| 14:02:28 | sahid | thanks for your help | |
| 14:02:34 | dansmith | sahid: ah, you're right, that must be why :) | |
| 14:03:11 | sahid | :) | |
| 14:03:51 | sahid | mriedem: ok thanks i will take a look and see whether i can help sean if he does not have time to update the code | |
| 14:04:26 | bhagyashris | efried: Hi, | |
| 14:04:28 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API https://review.openstack.org/561520 | |
| 14:04:32 | efried | bhagyashris: Howdy! | |
| 14:07:02 | mriedem | bauzas: trade for you https://review.openstack.org/#/q/topic:bug/1746483+branch:stable/ocata | |
| 14:07:19 | bauzas | mriedem: roger, ack this | |
| 14:07:39 | bauzas | mriedem: you freed me from some internal blackhole, I can pay you off | |
| 14:08:39 | bauzas | oooooh I remember that nasty bug with IsolatedHosts :) | |
| 14:09:05 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Document how to disable notifications https://review.openstack.org/561954 | |
| 14:09:36 | sean-k-mooney | dansmith: ya i would prefer not to set teh driver name element if we dont need too however im fine with it for now | |
| 14:10:02 | dansmith | sean-k-mooney: yep, thanks for that review | |
| 14:17:43 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: doc: BFV instances and IsolatedHostsFilter https://review.openstack.org/543494 | |
| 14:18:07 | bauzas | mriedem: FWIW, just made the amendment you asked me 2 months ago https://review.openstack.org/#/c/543494/ | |
| 14:20:51 | openstackgerrit | Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925 | |
| 14:21:33 | mriedem | ok | |
| 14:22:06 | mriedem | bauzas: also, gerrit UI won't add the cherry-picked from line in the commit message unless the change you're cherry picking *from* is merged | |
| 14:22:39 | bauzas | I see, in case of a merge commit | |
| 14:25:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: BFV instances and IsolatedHostsFilter https://review.openstack.org/543494 | |
| 14:29:48 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: libvirt: Block swap volume attempts with encrypted volumes prior to Queens https://review.openstack.org/543569 | |
| 14:39:26 | openstackgerrit | Merged openstack/python-novaclient master: Stop printing flavor details on successful flavor-delete https://review.openstack.org/561634 | |
| 14:43:57 | kashyap | Folks, when someone gets time, can you beat some sense into my (broken) test and me: http://paste.openstack.org/show/719390/ | |
| 14:44:27 | kashyap | This is the last of the two unit test failures I need to fix for the "first batch" of the version bump clean-ups | |
| 14:44:36 | efried | kashyap: Which line is the exception hitting on? | |
| 14:45:09 | kashyap | efried: Line-56, that's what I'm messing up | |
| 14:45:21 | kashyap | efried: For context, this is the original: https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L9171,L9219 | |
| 14:46:03 | kashyap | I am replacing the usage of the migrateToURI2() with migrateToURI3() in that test, as a result of post version bump clean-up. | |
| 14:46:29 | efried | ? | |
| 14:46:29 | efried | mock_updated_guest_xml.return_value = '' | |
| 14:46:29 | efried | kashyap: Uh, the exception hits when you say | |
| 14:46:40 | kashyap | In the original: target_xml is supplied to mock object to validate return value - test_mock.XMLDesc.return_value = target_xml | |
| 14:47:30 | kashyap | efried: Can't pin-point to that, but I know that's a mistake there. Still haven't ran PDB on that to narrow down, but was duking around other bits | |
| 14:48:21 | kashyap | efried: For context, this is the other local change that I've fixed for a different test: https://kashyapc.fedorapeople.org/0001-tests-unit-Fix-test_live_migration_update_graphics_x.patch | |
| 14:48:39 | kashyap | It's (the current broken test: 'test_live_migration_with_valid_target_connect_addr') in the same vein | |
| 14:48:53 | efried | kashyap: Is there code change behind this, or are you just tweaking the test case? | |
| 14:48:56 | kashyap | We're not doing any Mox stuff in this current test, though. | |
| 14:49:22 | kashyap | efried: I'm tweaking it as a result of: https://review.openstack.org/#/q/topic:bump_min_libvirt_and_qemu+(status:open+OR+status:merged) | |
| 14:49:47 | efried | kashyap: Just trying to figure out what I need to do to repro it locally, is all. | |
| 14:50:14 | kashyap | efried: You need to apply the above series. And run this: | |
| 14:50:16 | kashyap | nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_live_migration_with_valid_target_connect_addr | |
| 14:50:29 | efried | ... | |
| 14:50:54 | gibi | mlavalle: hi! I'm back. rubasov mentioned that you might be in the process of updating the nova bandwidth spec. I got updated by rubasov about the current issues and I will start shaping up the spec for the next round of discussion but I dont want to conflict with your update | |
| 14:51:02 | kashyap | efried: Feel free to disregard me, as this is a bit time consuming, and needs context | |
| 14:51:32 | kashyap | efried: So, if you're in the middle of thing, you can just drop it on the floor. | |
| 14:51:45 | gibi | mlavalle: so I can hold my horses if you have something locally already | |
| 14:52:25 | efried | kashyap: I'm pretty green in a lot of areas, but feel pretty good about my understanding of mocks. If I can't nail it down fairly quickly, I'll leave you to your thrashing, but I gotta have a crack at it. | |
| 14:52:40 | gibi | mlavalle: please not that I will be in and out of connectivity today so I might respond slowly | |
| 14:52:48 | kashyap | efried: Excellent. The context is only around libvirt APIs. I'm horrible with unit tests and Mocks | |
| 14:52:52 | efried | kashyap: Okay, so with the series applied and your test added (I named it with a 2) both tests fail. This is what we expect as a baseline, right? | |
| 14:52:52 | gibi | mlavalle: *note | |
| 14:52:54 | mlavalle | gibi: I've been working heads down on multiple port binding, so please go ahead | |
| 14:53:07 | mlavalle | don't hold for me | |
| 14:53:14 | kashyap | efried: Sure. I'd welcome a different pair of eyes; I'm a bit burned from looking at these the whole day. Thanks for the assist! | |
| 14:53:23 | gibi | mlavalle: OK. thanks for the info | |
| 14:53:25 | mlavalle | gibi: and welcome! | |
| 14:53:36 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION https://review.openstack.org/560365 | |
| 14:53:37 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: tests: unit: Fix 'test_live_migration_update_serial_console_xml' https://review.openstack.org/561969 | |
| 14:53:38 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: tests: unit: Fix 'test_live_migration_update_graphics_xml' https://review.openstack.org/561970 | |
| 14:53:42 | mlavalle | I hope you enjoyed your trip | |
| 14:53:51 | mlavalle | and didn't think about us ;-) | |
| 14:53:57 | efried | kashyap: Interestingly, both versions of the test fail the same way. | |
| 14:54:10 | kashyap | efried: You mean, my so-called "updated" and the old one? | |
| 14:54:32 | efried | kashyap: Yes. And there's no trace to actual running code; I suspect it's blowing up at mock time. | |
| 14:54:43 | kashyap | efried: Exactly | |
| 14:55:03 | kashyap | I have no idea, my Mock knowledge is ... mockable | |
| 14:55:08 | efried | kashyap: I mean it's the decorators. | |
| 14:55:15 | stephenfin | mriedem: Is the API in nova/network/base_api.py a contract we need to maintain for external users? | |
| 14:55:31 | stephenfin | i.e. N cycles before we can remove a function | |
| 14:55:33 | efried | kashyap: which is bizarro because the original don't have no decorators. | |
| 14:55:38 | gibi | mlavalle: yes, It was really nice and I was able to forget about work :) | |
| 14:55:40 | kashyap | efried: Fantastici | |
| 14:55:44 | kashyap | efried: But you know -- | |
| 14:55:54 | gibi | mlavalle: now I'm trying to catch up | |
| 14:56:07 | mlavalle | :-) | |
| 14:56:25 | efried | kashyap: f me this test suite is huge. | |
| 14:56:45 | kashyap | efried: Tell me all about it | |
| 14:57:19 | kashyap | efried: For context, see this -- "test_live_migration_update_volume_xml", this is almost same as the other one: test_live_migration_with_valid_target_connect_addr | |