Earlier  
Posted Nick Remark
#openstack-nova - 2018-04-17
12:21:54 jaypipes jianghuaw_: still up?
12:23:43 openstackgerrit Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925
12:26:25 bauzas stable cores, looks like we break some TripleO CI, and we need https://review.openstack.org/#/q/I6717ce19f6005c8ebb7af75437a72876c5a53f34 to be accepted for helping them
12:26:48 bauzas free beers offered
12:28:44 openstackgerrit Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925
12:38:44 openstackgerrit Merged openstack/nova stable/pike: Fix wrapping of neutron forbidden error https://review.openstack.org/560087
12:41:30 lyarwood bauzas: free beer you say?
12:41:53 bauzas yup, free as in 'I pay'
12:42:05 bauzas Vancouver is in 1 month
12:42:25 bauzas and even if I have a gold fish mind, I will still remember :)
12:42:39 mdbooth lyarwood: As long as you meet in person at a specific bar in France, location to be revealed no more than 1 hour in advance.
12:43:26 bauzas well, if in France, no beer
12:43:33 bauzas Chartreuse instead
12:44:15 mdbooth bauzas: I've never had that...
12:44:53 bauzas again, https://en.wikipedia.org/wiki/Chartreuse_(liqueur)
12:45:51 mdbooth bauzas: Next time I'm in France :)
12:46:18 bauzas mdbooth: didn't you tried the Génépi last time you were there ?
12:47:15 mdbooth bauzas: Not that I specifically recall, although there were drinks I drank without necessarily knowing what they were :)
12:47:25 bauzas that's sad
12:47:36 bauzas you just had half the experience
12:47:46 bauzas skiing is one thing
12:48:00 bauzas after-skiing is another thing
12:48:39 mdbooth Apres-ski for me is mostly food and bed :(
12:48:58 openstackgerrit Merged openstack/nova stable/queens: only increment disk address unit for scsi devices https://review.openstack.org/561196
12:49:49 bauzas mdbooth: tss tss, no excuse
12:49:53 stephenfin bauzas: Alternatively, go to 🇦🇹 where the beer is plentiful and the <something decidedly PC about the opposite sex>
12:50:07 bauzas I do ski with 70-yr old people
12:50:32 bauzas actally, skiing on Fridays out of vacation periods make you consider young on the slopes...
12:50:54 mdbooth bauzas: They've all been skiing since they were 2, though
12:51:25 bauzas nah
12:51:46 bauzas some decided to retire in the mountains
12:51:57 bauzas like new-age monks
12:52:27 bauzas one good way of praying : take a 60% slope
12:53:15 openstackgerrit Artom Lifshitz proposed openstack/nova master: Add skip_latest_microversion decorator https://review.openstack.org/433585
12:53:16 openstackgerrit Artom Lifshitz proposed openstack/nova master: Run api sample tests against 2.latest https://review.openstack.org/430352
12:57:36 openstackgerrit Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861
13:04:41 mriedem gibi: question in https://review.openstack.org/#/c/460625/
13:10:15 kosamara mriedem I fixed the nitpicks and created a blueprint
13:12:55 Shilpa stephenfin: hi
13:13:11 stephenfin Shilpa: o/
13:13:33 Shilpa stephenfin: i was going through temst failure logs for https://review.openstack.org/#/c/550172
13:14:12 Shilpa stephenfin: Also checked at http://codesearch.openstack.org/?q=vnc_auto.html&i=nope&files=&repos=
13:14:49 Shilpa stephenfin: here there are multiple projects referring novncproxy_base_url
13:15:04 openstackgerrit Stephen Finucane proposed openstack/nova master: Add CPUWeigher https://review.openstack.org/379525
13:15:40 Shilpa stephenfin: do we need to inform respective projects to modify the same, or what action we need to take here?
13:15:46 gibi mriedem: the versioned notification works based on the values of the Aggregate ovo so if we want to send the update.start notification with the already updated data then we have to update the Aggregate ovo before the start notification. But that would mean the start notification is sent _after_ the actual update so it is not a start notification any more
13:16:12 gibi mriedem: a bit of chicken and egg
13:17:12 stephenfin Shilpa: We probably do, yes. However, why does that affect the Tempest job?
13:17:15 mriedem gibi: well, or add a 'new_metadata' field to the aggregate payload, something like that
13:17:21 Shilpa stephenfin: is because of any refrence we are missing and cauing temst failure for https://review.openstack.org/#/c/550172?
13:17:23 mriedem or 'metadata_updates'
13:18:46 mriedem gibi: granted, the legacy notification is a bit dumb in that it sends the start notification with the updates but it also sends the end notification with the same updates, but not the full aggregate meta, so the legacy notification is also arguably incomplete
13:19:20 mriedem since i don't know how these are consumed, i don't want to rathole on it too much and that's why i didn't -1
13:19:43 Shilpa stephenfin: i am still finding root cause of tempst failure, and it was failed for for patch set 1 too, but missing logs there since got over written because of patch set 2
13:19:44 mriedem if the consumer wants/needs to know the delta, i guess they can diff the metadata from the start/end notifications
13:20:13 stephenfin Shilpa: That configuration value definitely works if you test manually?
13:20:47 stephenfin Shilpa: Hmm, looks like we're not passing the token correctly http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/controller/logs/screen-n-novnc.txt.gz
13:22:12 gibi mriedem: I would go for the solution where any update.start notification sends information about the state _before_ the update and the update.end sends the new state in the payload. In some cases we deviated from that and added the diff directly to the payload instance.update old_task_sate new_task_state but there we don't have start and end notification to use
13:22:17 Shilpa stephenfin: i have checked these logs and here seems token value is empty
13:24:23 Shilpa stephenfin: from where we can confirm, vnc 1.0.0 get downloaded successfully? i checked http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/job-output.json.gz, but how once can confirm downloading of latest VNC version is successful?
13:24:55 mriedem gibi: yeah, +W
13:25:21 gibi mriedem: I think the proposed versioned aggregate.update_metadata is a good start. If somebody needs the explicity diff in the payload we can add that later
13:25:24 gibi mriedem: thanks
13:25:59 gibi mriedem: btw, I will have to go offline for a while this afternoon but I will be back for the notification subteam meeting
13:26:02 openstackgerrit Matthew Booth proposed openstack/nova master: Rename recreate to evacuate in driver signatures https://review.openstack.org/560900
13:26:15 stephenfin Shilpa: Not a clue, I'm afriad
13:32:52 sahid mriedem: still not convinced about https://review.openstack.org/#/c/553072/ ?
13:33:54 Shilpa stephenfin: one more findings, http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/controller/logs/screen-n-cond-cell1.txt.gz, here novncproxy_base_url is not reflected what is expected, still referring vvnc_auto.html
13:34:09 mriedem sahid: just forgot about it
13:34:42 sahid mriedem: oh ok no worries
13:37:29 Shilpa stephenfin: i have seen workflow -1, what fix in nova you are expecting here?
13:38:30 stephenfin Shilpa: I noticed all the existing examples used 'path=websockify/' (i.e. added the '/')
13:38:47 stephenfin Just curious to see if that affects things. Perhaps the urlparse module needs it
13:38:55 stephenfin I'm just poking stuff
13:41:14 Shilpa stephenfin: ok, will wiat for Zuul , thank you.
13:44:48 bauzas mriedem: any help would be appreciated for https://review.openstack.org/#/c/561923/
13:44:57 bauzas mriedem: looks like it's blocking some internal CI
13:50:07 mriedem bauzas: want to remove the note from the commit message? https://review.openstack.org/#/c/561925
13:50:41 dansmith sahid: should these be vhost-user in the config help string as well? https://review.openstack.org/#/c/484997/19/nova/conf/libvirt.py
13:51:08 mriedem sahid: left comments in https://review.openstack.org/#/c/553072/
13:52:17 dansmith sahid: or is driver vhost-user and type is vhostuser?
13:53:03 bauzas mriedem: thanks
13:55:28 sahid dansmith: right, in the config doc i'm talking of the backend which is vhost-user. the 'vhostuser' name is for the libvirt interface type only
13:55:42 sahid i will update that point
13:55:46 dansmith sahid: okay, that's terribly confusing, but not your fault
13:55:56 dansmith sahid: also, why did you abandon the bottom patch?
13:56:45 dansmith sahid: I was just saying he noted it should be vhost-user not vhostuser
13:56:51 dansmith but he never commented on it I guess
13:56:52 sahid because i understood that we want only change the driver name if rx or tx queue size is updated, if not so we keep the old behavior and touch nothing
13:56:52 openstackgerrit Matthew Booth proposed openstack/nova master: Rename recreate to evacuate in driver signatures https://review.openstack.org/560900
13:56:53 openstackgerrit Matthew Booth proposed openstack/nova master: Remove redundant _do_check_can_live_migrate_destination https://review.openstack.org/561948
13:56:54 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Don't confuse CPU pinning/NUMA as Hyper-V only https://review.openstack.org/561949
13:56:55 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Remove 'admin/numa' doc https://review.openstack.org/561950
13:57:32 sahid hum so i missunderstood
13:58:12 dansmith sahid: okay I think that setting vhost-user when we're sure it's vhost-user is a good cleanup, unrelated to the vhost driver change at the top, which is what I was referring to
13:58:25 dansmith but it sounds like he's come around on that second bit anyway
13:59:23 dansmith sahid: if you don't mind restoring that bottom patch but s/vhostuser/vhost-user/ I'll be +2 on both
13:59:33 dansmith sahid: and then I'll try to get jaypipes to review it in trade for something else :)
13:59:54 sahid dansmith: yep actually i agreed with you about to fix that point
14:00:01 dansmith *gasp* :)

Earlier   Later