| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-16 | |||
| 19:59:08 | dansmith | sean-k-mooney: oh, actually, I guess you're right | |
| 19:59:16 | dansmith | sean-k-mooney: sahid said the opposite and I looked but didn't see | |
| 19:59:19 | sean-k-mooney | dansmith: oh we did not used too | |
| 19:59:32 | dansmith | sean-k-mooney: so yeah, this does change it to be more often, which is what I was trying to avoid when we talked last week | |
| 19:59:36 | sean-k-mooney | dansmith: ya this is a normal vhost-user xml http://paste.openstack.org/show/719324/ | |
| 19:59:39 | dansmith | but I missed that we only do it for multiqueue | |
| 19:59:43 | efried | TheJulia: Sure, you can do whatever you like with it. I would be happy to keep working on it too if you prefer. (I saw you made a comment, but I haven't gotten to reading it yet.) | |
| 19:59:45 | dansmith | sean-k-mooney: so good call on that, thanks | |
| 20:00:18 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add wrinkle to FailedEvacuateStateTests https://review.openstack.org/561707 | |
| 20:00:31 | sean-k-mooney | dansmith: well i dont think it would break anything today since its ignored but if they ever stop ignoring it i dont know if that would break us | |
| 20:00:47 | dansmith | sean-k-mooney: yeah | |
| 20:01:03 | dansmith | sean-k-mooney: I figured since I don't know the details, it'd be better to just avoid changing it | |
| 20:01:16 | efried | TheJulia: Oh, it was rloo's note. Anyway, just let me know whatever you want me to do there. | |
| 20:01:20 | dansmith | sean-k-mooney: I was asking him to just set it explicitly where he knows it should be vhost or vhostuser | |
| 20:01:33 | dansmith | sean-k-mooney: did you see the cleanup patch below? | |
| 20:01:38 | efried | TheJulia: Caveat: Never used storyboard before... | |
| 20:01:43 | dansmith | that was also based on ignoring, but it's vhostuser and you said vhost-user, so is it wrong? | |
| 20:01:58 | TheJulia | efried: I can create it, its not a big deal | |
| 20:02:07 | TheJulia | efried: but your welcome to if you want | |
| 20:02:31 | TheJulia | Story clean-up is taking... many braincells. | |
| 20:02:39 | efried | TheJulia: Go for it, co-author away. | |
| 20:02:56 | sean-k-mooney | dansmith: well neighter vhostuser or vhost-user is documented explictly as an allowed value but they used vhost-user when refing to it. | |
| 20:03:13 | TheJulia | efried: don't need that :) But thanks. | |
| 20:03:16 | dansmith | sean-k-mooney: okay you wanna comment on the patch below with that info then? | |
| 20:03:18 | sean-k-mooney | dansmith: ill try and take a look at the libvirt source code tomorrow and see whent there parse has defiend | |
| 20:03:56 | dansmith | sean-k-mooney: okay | |
| 20:11:17 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add (Same|Different)HostFilter to defaults https://review.openstack.org/561651 | |
| 20:13:32 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | |
| 20:13:33 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | |
| 20:18:03 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Set scope_types for admin password policies https://review.openstack.org/553613 | |
| 20:18:05 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Add scope_types to server policies https://review.openstack.org/525772 | |
| 20:19:54 | lbragstad | johnthetubaguy_: jaypipes ^ look another shot at working a rough test structure into those | |
| 20:20:36 | lbragstad | they will fail, but i'm curious about the approach you'd like me to take with the testing | |
| 20:20:52 | lbragstad | or if what's proposed even makes sense | |
| 20:22:04 | jaypipes | lbragstad: cool, thanks | |
| 20:22:12 | jaypipes | lbragstad: will re-review shortly. | |
| 20:22:30 | lbragstad | awesome - ty | |
| 20:54:35 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: List instances performace optimization https://review.openstack.org/561715 | |
| 20:54:49 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | |
| 20:54:50 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | |
| 20:56:23 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Support forced separation of providers in granular https://review.openstack.org/561717 | |
| 21:03:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove vestigial system_metadata param from info_from_instance() https://review.openstack.org/561724 | |
| 21:27:00 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | |
| 21:27:01 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | |
| 21:32:42 | jackie-truong | mriedem dansmith jaypipes melwitt johnthetubaguy_: Thanks for reviewing the certificate validation patches. 479949 and 561262 should just need one last look. The API patch is going through Zuul now. | |
| 21:33:00 | jackie-truong | https://review.openstack.org/#/c/479949/ | |
| 21:33:05 | jackie-truong | https://review.openstack.org/#/c/561262/ | |
| 21:39:39 | melwitt | thanks jackie-truong. I've rechecked the tempest tests so we can look at that too for the latest revision of the series https://review.openstack.org/#/c/515210 | |
| 21:42:50 | jackie-truong | melwitt: Awesome, thanks | |
| 22:15:02 | mriedem | artom: gotta say, i'm not a fan of this https://review.openstack.org/#/c/561651/ | |
| 22:15:31 | cfriesen | mriedem: I reproduced the Service UUID issue with vanilla stable/pike devstack. Writing up a bug now. | |
| 22:15:31 | mriedem | if there is a problem with tempest, let's fix tempest | |
| 22:15:50 | mriedem | artom: as noted inline, those tempest tests for these filters probably shouldn't even live in tempest | |
| 22:18:57 | mriedem | jackie-truong: besides dumping on artom's patch i'm done for the day, sorry | |
| 22:19:04 | mriedem | cfriesen: ok | |
| 22:19:34 | jackie-truong | mriedem: np, thanks for all of the comments! | |
| 22:21:16 | melwitt | jackie-truong: looks like there's a problem :( http://logs.openstack.org/10/515210/31/check/barbican-simple-crypto-devstack-tempest/0ff6bcc/logs/testr_results.html.gz | |
| 22:21:23 | melwitt | Additional properties are not allowed (u'trusted_image_certificates' was unexpected)", u'code': 400 | |
| 22:21:31 | melwitt | looks like a schema validation fail? | |
| 22:24:08 | jackie-truong | melwitt: Saw that. Looking into it | |
| 22:47:56 | openstack | Launchpad bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Undecided,New] | |
| 22:47:56 | cfriesen | melwitt: mriedem: here's the Service-without-UUID exception.ServiceNotFound issue: https://bugs.launchpad.net/nova/+bug/1764556 | |
| 22:48:13 | melwitt | thanks | |
| 22:48:30 | cfriesen | reproducing is straightforward, just needs a fake DB entry in the services table | |
| 23:01:44 | cfriesen | why does "openstack server --live" require a hostname? | |
| 23:02:00 | cfriesen | make that "openstack server migrate --live" | |
| 23:09:50 | artom | mriedem, yeah, I get it | |
| 23:10:32 | artom | We were having downstream discussions about it, and the argument that sort of got me was "if every CI has to change it, shouldn't it be in defaults?" | |
| 23:11:10 | artom | Devstack enables it, downstream OSP CI needs to enable it, so... | |
| 23:11:28 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (1) https://review.openstack.org/560821 | |
| 23:11:33 | artom | But yeah, "CI needs it" isn't a massively compelling argument | |
| 23:12:15 | artom | So I threw it up, just to see what discussion would come out of it, and to be able to say "upstream said" as opposed to "I said no" :) | |
| 23:12:34 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (2) https://review.openstack.org/560829 | |
| 23:15:53 | melwitt | artom: I think it makes sense that CIs would enable most, if not all of the filters that exist, to cover the features and make sure they work with their products | |
| 23:16:56 | melwitt | for deciding whether to include certain filters in default_filters, I think that would be mostly about whether the filters are used by "most users" or are useful in a typical deployment | |
| 23:17:20 | artom | melwitt, yeah, apparently it's really complicated for them to enabled it in their thousand+ jobs? | |
| 23:17:33 | artom | melwitt, but I agree - CI and users have different needs | |
| 23:19:26 | melwitt | I didn't think it's complicated in that I thought you just set enabled_filters to the filters you want enabled in nova.conf | |
| 23:19:57 | artom | melwitt, yeah, but apparently they need to do that for *every* job? As in, there's no common deployment that covers all jobs? | |
| 23:20:31 | melwitt | that said, I don't really have an opinion about whether SameHost and DifferentHost belong in default filters because TBH I don't know if those are really commonly used by end users or not | |
| 23:20:34 | artom | https://review.gerrithub.io/#/c/407794/ is the infrared change | |
| 23:20:53 | artom | Which apparently got -2 by Arie? I have no idea what's going on | |
| 23:21:23 | artom | melwitt, heh, don't we have those sosreports we can use for insights? At least for OSP users? | |
| 23:21:36 | melwitt | yeah, we could I would think | |
| 23:21:44 | artom | Man, the effort:complexity ratio of this thing is through the roof | |
| 23:22:00 | artom | There's, like, 5 of us, just to enable a filter | |
| 23:22:22 | melwitt | well, enabling a filter is supposed to be all pluggable, like you can do it in your nova.conf | |
| 23:23:41 | melwitt | this is starting a discussion about "what belongs in defaults?" "should everything be in defaults?" "what's the downside of putting everything in defaults?" and I don't really know the answers to those questions off the top of my head | |
| 23:24:29 | artom | Right, but the original problem is still "a filter that we need isn't enabled" | |
| 23:26:06 | melwitt | by default, no. there are a lot of filters we could say that about. so to me, it's more like, should we just add all filters to defaults and is there any reason to not do that? I'd be asking scheduler subteam folk about it | |
| 23:36:05 | artom | melwitt, yeah, it might be better to rephrase this as 2 questions: 1. do we have data that justifies adding same/different hostfilter to the defaults? | |
| 23:36:23 | artom | 2. Should we just enable all filters by default? | |
| 23:36:45 | artom | I can poke around our sosreports for 1 tomorrow, for 2... I guess tomorrow as well | |
| 23:37:48 | cfriesen | melwitt: https://review.openstack.org/#/c/560690/ has been updated to address your final comment | |
| 23:37:50 | melwitt | artom: yeah. the point of the default filters is to give someone a config for a typical cloud. if same/different are typically used, then they should be in defaults I think. CI are a different beast IMHO because they're aiming to run and verify as many features and capabilities as possible | |
| 23:38:36 | melwitt | so you would expect them to enable everything they possibly could. that said, IIUC there's some mismatch between what tempest defaults to and what nova defaults to and that is what's actually causing this problem | |
| 23:39:49 | melwitt | cfriesen: thanks, will take another look | |
| 23:40:25 | cfriesen | melwitt: the default set of enabled filters is actually pretty small | |
| 23:40:42 | melwitt | cfriesen: yes. I have learned that recently | |
| 23:41:38 | melwitt | or re-learned it. I've seen default filter list in the past and eventually forgot it | |