Earlier  
Posted Nick Remark
#openstack-nova - 2018-04-09
13:33:29 efried # because while they are often useful guidelines, strict adherence to
13:33:29 efried # Most of the whitespace related rules (E12* and E131) are excluded
13:33:29 efried lyarwood: FYI, this excerpt from tox.ini explains to some extent:
13:34:07 efried If I may paraphrase: "Follow these rules unless it results in really odd code formatting or forced extra line breaks"
13:34:24 efried ...which is of course difficult without OCD reviewers (or being OCD yourself)
13:34:32 efried ...which is why the peps exist.
13:41:35 efried mikal: yt?
13:42:13 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238
13:42:14 mriedem tblakes: if jgwentworth says she can't reproduce the problem on master then i guess it's not an issue, especially if we can't recreate with a test
13:44:10 efried mriedem: Quick re-approval for lyarwood: https://review.openstack.org/#/c/544238/
13:44:29 tblakes mriedem: Thanks! I'll abandon https://review.openstack.org/#/c/559169/ and recheck https://review.openstack.org/#/c/559158/.
13:45:21 openstackgerrit Raoul Hidalgo Charman proposed openstack/nova master: Expose shutdown retry interval as config setting https://review.openstack.org/552483
13:52:37 dansmith mriedem: were you going to look at this? https://review.openstack.org/#/c/558059/
13:55:56 mriedem dansmith: yes, i now have an excellent sized queue after starting about 20 minutes ago
13:56:36 edleafe Scheduler subteam meeting in 4 minutes in #openstack-meeting-alt
13:59:09 dansmith mriedem: you're welcome
14:00:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix comments at the 'save' method of objects.Instance https://review.openstack.org/559743
14:01:31 jaypipes 4/join #openstack-meeting-alt
14:01:35 jaypipes ffs
14:13:19 mriedem efried: lyarwood: +W
14:13:55 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: [RFC] Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171
14:13:56 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783
14:14:34 openstackgerrit Jay Pipes proposed openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057
14:14:48 jaypipes mriedem: ^ done.
14:20:28 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057
14:20:54 mriedem thanks
14:20:54 mriedem jaypipes: tweaked the alternative section, but +2
14:23:40 jaypipes mriedem: thx
14:29:07 openstackgerrit Dan Smith proposed openstack/nova master: Avoid dumping stack on BuildAbortException https://review.openstack.org/559751
14:29:16 dansmith mriedem: ^
14:29:47 openstackgerrit Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435
14:29:47 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
14:29:48 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857
14:32:10 kashyap alex_xu: Hi, when you're around -- maybe you'd know the answer to my question on `enabled_pef_events`:
14:32:38 kashyap alex_xu: As it stands, seems like Nova accepts far beyond three events (cmt, mbmt, mbml). Isn't it?
14:33:07 kashyap alex_xu: Because the source for that config attributes shows it accepts a string list -- so all values that are supported by libvirt are accepted by Nova
14:33:13 kashyap (At least that's what the doc says)
14:36:42 kashyap alex_xu: Disregard me, answered my question -- yes, it supports broader set of events besides those tree
14:36:45 kashyap s/tree/three/
14:37:47 mriedem esberglu: why is https://review.openstack.org/#/c/554688/ in the runways etherpad?
14:37:57 mriedem it's not tied to a blueprint, but is just powervm driver specific,
14:38:13 mriedem if it's not a bp, please just include it in the powervm driver section of the other priority review etherpad https://etherpad.openstack.org/p/rocky-nova-priorities-tracking
14:38:26 esberglu mriedem: Will do
14:38:35 mriedem thanks
14:45:20 openstackgerrit Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262
14:46:52 mriedem sahid: bauzas: this spec tracking is really odd https://review.openstack.org/#/c/511188/ - that's for rocky, for a blueprint which is closed
14:47:29 mriedem why isn't there a "overhead-pin-set" spec for rocky?
14:48:03 bauzas mriedem: shit, you're right
14:48:09 bauzas mriedem: the URL is wrong
14:49:01 mriedem and the name of the spec is wrong
14:49:05 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300
14:49:06 bauzas I haven't looked at the related BP, my bad
14:49:13 mriedem sahid: can you fix that up please?
14:49:46 bauzas I think sahid didn't changed the spec when we asked him to create that BP
14:50:12 mriedem finucannot: you can remove the -2 on https://review.openstack.org/#/c/510897/ - the spec is approved
14:50:18 bauzas mriedem: thanks for that btw.
14:50:26 bauzas honestly, I should also look at the BP
14:58:18 sahid mriedem: at the beginning it was just an update of the already approved spec, that is why we did not have really noticed the issue
14:59:25 bauzas sahid: ping me when you're done with the new change and I'll +2
14:59:33 bauzas for renaming I mean
14:59:58 sahid yes i will
15:11:41 mriedem dansmith: replied in https://review.openstack.org/#/c/558059/
15:17:37 jaypipes cdent: ok, everyone gone
15:17:55 cdent roger
15:18:24 openstackgerrit Merged openstack/nova master: Support extending attached ScaleIO volumes https://review.openstack.org/554679
15:20:20 mriedem jaypipes: efried: -1 on tetsuro's spec https://review.openstack.org/#/c/559466/ - the bp link is wrong for one, but i'm also wondering if this is just to enable out of tree filters/weighters, or if he actually wants to add a vGPU weighter to nova
15:20:24 mriedem i'd be supportive of that if so
15:20:52 mriedem question inline about the slippery slope of including provider trees in the response also
15:21:32 mriedem bauzas: you would probably be interested in that idea ^
15:24:22 mriedem jgwentworth: dansmith: i guess we were supposed to be actively brainstorming for the forum https://etherpad.openstack.org/p/YVR-nova-brainstorming
15:25:51 mriedem efried: jaypipes: cdent: edleafe: i'm sure there are placement things that could be at the forum
15:26:02 mriedem e.g. cinder talking about maybe leveraging it in their scheduler
15:26:15 cdent mriedem: yes, it's on y list
15:26:30 cdent got a couple things, including the cinder thing
15:26:35 mriedem efried: design sessions at the summit
15:26:51 bauzas mriedem: ack, I'll look
15:27:18 bauzas -ETOOMANYPLACEMENTSPECS
15:27:51 bauzas should we stop feeding the placement mogwaï after midnight ?
15:28:11 openstackgerrit Ed Leafe proposed openstack/nova-specs master: Add Generation to Consumers https://review.openstack.org/556971
15:29:14 efried bauzas: It's water that makes 'em multiply. Feeding after midnight turns 'em evil.
15:29:19 edleafe efried: ^^ addressed your concerns
15:30:50 bauzas efried: ha, right. So, people, stop hydrating your specs
15:31:14 jaypipes mriedem: it's not to enable anything in particular. it's just to remove a restriction in the returned results of allocation candidates' provider_summaries section that wasn't necessary to restrict.
15:31:25 bauzas and don't give'em a review after midnight or they'll turn into something bad
15:31:54 bauzas efried: technically, growing mogwais is good
15:32:11 bauzas if you respect the 3 rules
15:33:15 bauzas jaypipes: what's up with the placement channel ? can I rejoin it ?
15:33:24 cdent bauzas: yes, it's ready
15:33:34 bauzas :'(
15:34:09 jaypipes bauzas: I warned you to leave the channel :)
15:34:49 bauzas jaypipes: well, you kick after the first warning, I hope your pugs behave correctly :p
15:39:12 openstackgerrit Eric Fried proposed openstack/nova-specs master: Return all resources in provider_summaries spec https://review.openstack.org/559466
15:39:20 efried mriedem, jaypipes: I went ahead and made those edits ^
15:39:26 efried tetsuro ^
15:42:24 bauzas efried: see my comment on the spec
15:42:33 bauzas efried: about interop
15:43:23 bauzas efried: if people wanna add some query related to inventories, they should add it to Placement, not by a filter
15:43:33 efried bauzas: Responding.
15:43:48 bauzas efried: because the Placement logic needs to be interoperable for the same query
15:44:49 mriedem i just don't want to spend time making this change if nothing is going to leverage it in-tree right now

Earlier   Later