| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-09 | |||
| 12:51:23 | efried | lyarwood: I theeeenk there's a bug in your test cases. | |
| 12:52:54 | ktibi | Hi nova, Anyone have already see this issue : when I add a second NIC on my instance, instance hang on reboot, just after random: crng init done :/ | |
| 12:55:50 | lyarwood | efried: do I need to reset the mock_get_encryption mock? | |
| 12:56:36 | efried | lyarwood: I'm commenting it up. But 1) .side_effects isn't a thing (it's spelled .side_effect); and 2) when you have .side_effect set, .return_value is ignored. | |
| 12:56:58 | efried | lyarwood: I confirmed by removing those two .side_effects lines (the test still passes) | |
| 12:57:09 | lyarwood | gah, nice catch | |
| 12:59:34 | efried | lyarwood: Okay, commented. Care to fix the formatting since you're respinning anyway? :) | |
| 13:01:11 | lyarwood | efried: sure if you could elaborate a little on why the current style is an issue | |
| 13:01:41 | efried | lyarwood: What I would do is set the side_effect to [{}, {}] and make sure you *don't* raise. | |
| 13:02:06 | lyarwood | efried: right, sorry I was asking about L1553 in driver.py | |
| 13:02:14 | efried | lyarwood: Oh, because a) backslashes are icky, and b) having the second line of the condition at the same indent level as the interior of the condition is icky. | |
| 13:02:31 | efried | For the latter, we have a pep rule... disabled in the nova project. (Couldn't tell you why) | |
| 13:02:57 | lyarwood | efried: kk, right I didn't know there was a pep rule for that, I'll sort that out now as well. | |
| 13:03:01 | lyarwood | efried: thanks :) | |
| 13:03:05 | efried | lyarwood: Thank you | |
| 13:13:41 | openstackgerrit | Merged openstack/nova-specs master: Fix typos in NUMA-aware live migration https://review.openstack.org/558842 | |
| 13:18:52 | sean-k-mooney | o/ | |
| 13:19:02 | sean-k-mooney | finucannot: are you about? | |
| 13:20:58 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238 | |
| 13:21:30 | lyarwood | efried: ^ sorry was interrupted, the [{}, {}] case is tested by all of the other swap_volume tests FWIW | |
| 13:21:39 | lyarwood | efried: but I can add it if you really want it in there | |
| 13:22:10 | efried | lyarwood: I figured it was; it would just be a way to make sure your mocks are doing the right thing. | |
| 13:22:25 | efried | lyarwood: Not necessary to add it here. | |
| 13:22:59 | efried | lyarwood: Just sayin, if it had been in there, with .side_effects, it wouldn't have worked as expected, and after some head scratching, you would have found the other bug that everybody missed :) | |
| 13:24:50 | tblakes | mriedem: Does https://review.openstack.org/#/c/555812/ still require the patch you suggested? The review comments at https://review.openstack.org/#/c/559169/ seem to indicate not. If it doesn't require the patch, is https://review.openstack.org/#/c/559158/ then ready to be cherry-picked in to stable/queens? | |
| 13:25:11 | lyarwood | efried: yeah true, I'd need to move this into a seperate method to make testing a little easier, otherwise I'll end up mocking all of swap_volume again. | |
| 13:25:34 | efried | lyarwood: Yeah, I figured that was probably the case. It's fine this way. | |
| 13:29:06 | efried | lyarwood: +2 (with some optional formatting nits) | |
| 13:30:30 | kholkina | Hi! Could you please explain why free_ram_mb + memory_mb_used != memory_mb? How does it calculated? | |
| 13:31:02 | kholkina | I mean values in 'nova hypervisor-show' | |
| 13:31:20 | lyarwood | efried: thanks, can't say I agree with the nit but if others also call it out I'll respin :) | |
| 13:32:03 | efried | lyarwood: Yeah, I'm sure there's a reason we've got those peps switched off - it must be because the ptb don't care. | |
| 13:32:03 | lyarwood | urgh sorry that's not good | |
| 13:33:29 | efried | # extra line breaks. Updating code to enforce these will be a hard sell. | |
| 13:33:29 | efried | # them ends up causing some really odd code formatting and forced | |
| 13:33:29 | efried | # because while they are often useful guidelines, strict adherence to | |
| 13:33:29 | efried | # Most of the whitespace related rules (E12* and E131) are excluded | |
| 13:33:29 | efried | lyarwood: FYI, this excerpt from tox.ini explains to some extent: | |
| 13:34:07 | efried | If I may paraphrase: "Follow these rules unless it results in really odd code formatting or forced extra line breaks" | |
| 13:34:24 | efried | ...which is of course difficult without OCD reviewers (or being OCD yourself) | |
| 13:34:32 | efried | ...which is why the peps exist. | |
| 13:41:35 | efried | mikal: yt? | |
| 13:42:13 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238 | |
| 13:42:14 | mriedem | tblakes: if jgwentworth says she can't reproduce the problem on master then i guess it's not an issue, especially if we can't recreate with a test | |
| 13:44:10 | efried | mriedem: Quick re-approval for lyarwood: https://review.openstack.org/#/c/544238/ | |
| 13:44:29 | tblakes | mriedem: Thanks! I'll abandon https://review.openstack.org/#/c/559169/ and recheck https://review.openstack.org/#/c/559158/. | |
| 13:45:21 | openstackgerrit | Raoul Hidalgo Charman proposed openstack/nova master: Expose shutdown retry interval as config setting https://review.openstack.org/552483 | |
| 13:52:37 | dansmith | mriedem: were you going to look at this? https://review.openstack.org/#/c/558059/ | |
| 13:55:56 | mriedem | dansmith: yes, i now have an excellent sized queue after starting about 20 minutes ago | |
| 13:56:36 | edleafe | Scheduler subteam meeting in 4 minutes in #openstack-meeting-alt | |
| 13:59:09 | dansmith | mriedem: you're welcome | |
| 14:00:33 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix comments at the 'save' method of objects.Instance https://review.openstack.org/559743 | |
| 14:01:31 | jaypipes | 4/join #openstack-meeting-alt | |
| 14:01:35 | jaypipes | ffs | |
| 14:13:19 | mriedem | efried: lyarwood: +W | |
| 14:13:55 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [RFC] Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171 | |
| 14:13:56 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | |
| 14:14:34 | openstackgerrit | Jay Pipes proposed openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057 | |
| 14:14:48 | jaypipes | mriedem: ^ done. | |
| 14:20:28 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: mirror nova host aggregates to placement API https://review.openstack.org/545057 | |
| 14:20:54 | mriedem | thanks | |
| 14:20:54 | mriedem | jaypipes: tweaked the alternative section, but +2 | |
| 14:23:40 | jaypipes | mriedem: thx | |
| 14:29:07 | openstackgerrit | Dan Smith proposed openstack/nova master: Avoid dumping stack on BuildAbortException https://review.openstack.org/559751 | |
| 14:29:16 | dansmith | mriedem: ^ | |
| 14:29:47 | openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | |
| 14:29:47 | openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | |
| 14:29:48 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | |
| 14:32:10 | kashyap | alex_xu: Hi, when you're around -- maybe you'd know the answer to my question on `enabled_pef_events`: | |
| 14:32:38 | kashyap | alex_xu: As it stands, seems like Nova accepts far beyond three events (cmt, mbmt, mbml). Isn't it? | |
| 14:33:07 | kashyap | alex_xu: Because the source for that config attributes shows it accepts a string list -- so all values that are supported by libvirt are accepted by Nova | |
| 14:33:13 | kashyap | (At least that's what the doc says) | |
| 14:36:42 | kashyap | alex_xu: Disregard me, answered my question -- yes, it supports broader set of events besides those tree | |
| 14:36:45 | kashyap | s/tree/three/ | |
| 14:37:47 | mriedem | esberglu: why is https://review.openstack.org/#/c/554688/ in the runways etherpad? | |
| 14:37:57 | mriedem | it's not tied to a blueprint, but is just powervm driver specific, | |
| 14:38:13 | mriedem | if it's not a bp, please just include it in the powervm driver section of the other priority review etherpad https://etherpad.openstack.org/p/rocky-nova-priorities-tracking | |
| 14:38:26 | esberglu | mriedem: Will do | |
| 14:38:35 | mriedem | thanks | |
| 14:45:20 | openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | |
| 14:46:52 | mriedem | sahid: bauzas: this spec tracking is really odd https://review.openstack.org/#/c/511188/ - that's for rocky, for a blueprint which is closed | |
| 14:47:29 | mriedem | why isn't there a "overhead-pin-set" spec for rocky? | |
| 14:48:03 | bauzas | mriedem: shit, you're right | |
| 14:48:09 | bauzas | mriedem: the URL is wrong | |
| 14:49:01 | mriedem | and the name of the spec is wrong | |
| 14:49:05 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 14:49:06 | bauzas | I haven't looked at the related BP, my bad | |
| 14:49:13 | mriedem | sahid: can you fix that up please? | |
| 14:49:46 | bauzas | I think sahid didn't changed the spec when we asked him to create that BP | |
| 14:50:12 | mriedem | finucannot: you can remove the -2 on https://review.openstack.org/#/c/510897/ - the spec is approved | |
| 14:50:18 | bauzas | mriedem: thanks for that btw. | |
| 14:50:26 | bauzas | honestly, I should also look at the BP | |
| 14:58:18 | sahid | mriedem: at the beginning it was just an update of the already approved spec, that is why we did not have really noticed the issue | |
| 14:59:25 | bauzas | sahid: ping me when you're done with the new change and I'll +2 | |
| 14:59:33 | bauzas | for renaming I mean | |
| 14:59:58 | sahid | yes i will | |
| 15:11:41 | mriedem | dansmith: replied in https://review.openstack.org/#/c/558059/ | |
| 15:17:37 | jaypipes | cdent: ok, everyone gone | |
| 15:17:55 | cdent | roger | |
| 15:18:24 | openstackgerrit | Merged openstack/nova master: Support extending attached ScaleIO volumes https://review.openstack.org/554679 | |