| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-04-06 | |||
| 17:27:04 | ildikov | mriedem: it looks a little like when the 'todo' extension was missing from the config | |
| 17:27:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup _get_request_spec_for_select_destinations for live migrate https://review.openstack.org/559381 | |
| 17:28:07 | mriedem | ildikov: it's something with this new PTI docs change i think, but i don't have the heart to read that thread right now | |
| 17:36:18 | sean-k-mooney | mriedem: do you need the "-" in query: >- also gr say sphinx>=1.6.2,!=1.6.6,!=1.6.7 # BSD but the test requirements in elastic-rechec is sphinx>=1.1.2,<1.2 | |
| 17:37:03 | sean-k-mooney | mriedem: so maybe just use a non achient version of sphinx? | |
| 17:38:46 | sean-k-mooney | mriedem: it does not look like the openstack requirement proposal bot keeps the repo in sync so when they bumped to new pbr on march 1st perhaps that has issues since pbr is trying to move to sphinx >1.6 | |
| 17:41:24 | sean-k-mooney | lower constratings also reqiures 1.6.5 https://github.com/openstack/requirements/blob/master/lower-constraints.txt#L359 so the 1.2 max in openstack-infra/elastic-recheck is proable the issue | |
| 17:43:44 | arvindn05 | mriedem: thanks. jaypipes said he would approve as well...will work on my next patch for the BP and also start thinking about the resize issue for rocky | |
| 17:55:21 | sean-k-mooney | mriedem: https://review.openstack.org/559390 fixes your issue. do you want me to rebase your patch on top. | |
| 18:01:18 | mriedem | sean-k-mooney: i can, was looking at the pti email and doing some stuff, but if this works, sure | |
| 18:02:40 | sean-k-mooney | mriedem: locally at least this fixes it for me. i cherry picked you patch locallly and that passed the docs job too after i bumped the version | |
| 18:03:09 | cdent | leakypipes, fried_rolls, figleaf : this might be of interest, a sort of placement test env: https://github.com/cdent/placecat (not fully fleshed out yet, just playing so far) | |
| 18:04:05 | sean-k-mooney | mriedem: by the way pti do you mean the "[openstack-dev] Following the new PTI for document build, broken local builds" thread from finucannot | |
| 18:04:18 | leakypipes | cdent: nice :) | |
| 18:06:31 | sean-k-mooney | mriedem: hum the chages for pti seam simple ill try making those instead | |
| 18:06:45 | sean-k-mooney | mriedem: then i need to go home because its 7 on a friday | |
| 18:35:28 | figleaf | cdent: sweet. Wish I had time to play with it. :) | |
| 18:43:37 | openstackgerrit | Merged openstack/python-novaclient master: Fix validation for command arguments https://review.openstack.org/558324 | |
| 18:51:16 | openstackgerrit | Merged openstack/python-novaclient master: Fix AttributeError in getting a resource ID https://review.openstack.org/558328 | |
| 18:51:17 | openstackgerrit | Merged openstack/python-novaclient master: Replace GB with GiB https://review.openstack.org/558364 | |
| 18:54:26 | openstackgerrit | sean mooney proposed openstack/os-vif master: convert os-vif docs to follow PTI https://review.openstack.org/559398 | |
| 18:54:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Log a more useful error when cinder auth isn't configured https://review.openstack.org/559399 | |
| 18:54:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: add a link in the install guides about configuring neutron https://review.openstack.org/559115 | |
| 19:00:46 | fried_rice | cdent: Neat! | |
| 19:01:30 | fried_rice | cdent: It's basically a fully functional but not-for-production placement service that you can set up to have something to test/play against? | |
| 19:01:49 | cdent | fried_rice: since you're not one with the twitters, you may not be aware of the placedock (or the blog posts associated with it) stuff, if you go to the placedock repo there's loads of links to context | |
| 19:01:57 | cdent | fried_rice: pretty much | |
| 19:02:15 | cdent | depending on the variables you pass into the container | |
| 19:02:26 | cdent | (and I recently found a bug with that) | |
| 19:03:07 | cdent | and in terms of production, you could, except that the container builds from non master code | |
| 19:07:09 | openstackgerrit | sean mooney proposed openstack/os-vif master: make legacy-tempest-dsvm-nova-os-vif voteing https://review.openstack.org/559401 | |
| 19:31:25 | sean-k-mooney | cdent: i have been following your tweets on it on and off its a cool idea | |
| 19:33:48 | sean-k-mooney | cdent: have you considerd useing any of this work as part of functional testing for placemnet | |
| 19:34:24 | cdent | sean-k-mooney: not realy: because of the way the existing gabbi tests work with wsgi-intercept, it's not really needed | |
| 19:34:32 | cdent | using it for some kind of integration tests might be useful thought | |
| 19:34:39 | sean-k-mooney | cdent: when placement has its own repo this could be an interesting way for folks to do placement dev/testing | |
| 19:34:46 | cdent | yes | |
| 19:34:56 | sean-k-mooney | cdent: well i was thinking it would be kind of like neutron fullstack tests | |
| 19:35:13 | sean-k-mooney | they are more then fuctional tests but not quite intergration tests | |
| 19:35:30 | cdent | sean-k-mooney: what do you see as the difference between using the container and what the current wsgi-intercept driven tests do? | |
| 19:36:51 | sean-k-mooney | cdent: noting really other then the fact that you are using sqlite right so i dont need to setup a db first so it would mean a smaller testing requiremtes set | |
| 19:38:19 | cdent | the container can use any database, depending on environment variables | |
| 19:38:31 | cdent | the functional tests use sqlite, yeah? | |
| 19:39:00 | sean-k-mooney | am im not sure what they use but were you not tweeting about using sqlight | |
| 19:39:43 | sean-k-mooney | i could be getting confused between what can work and what that suff is using today | |
| 19:41:01 | sean-k-mooney | anyway this time im actully going to leave since its 8:40 on a friday. enjoy your weekends o/ | |
| 19:43:40 | cdent | o/ | |
| 20:45:19 | openstack | Launchpad bug 1718512 in OpenStack Compute (nova) "migration fails if instance build failed on destination host" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | |
| 20:45:19 | mriedem | for the life of me i can't figure out why this isn't a problem anymore https://bugs.launchpad.net/nova/+bug/1718512 | |
| 20:46:01 | mriedem | or, how it was a problem to begin with - since i don't know where we save 'retry' changes to a request spec during the initial build | |
| 20:49:44 | mriedem | superdan: i think i see a fun little weirdness, we update the requestspec with a new flavor during resize before we've actually confirmed that the resize happened https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L349 | |
| 20:49:54 | mriedem | b/c at that point we've rpc cast to the dest compute to start the resize | |
| 20:50:13 | mriedem | if it fails on the compute, the request spec now says that the instance is using a new flavor | |
| 20:51:02 | superdan | mriedem: and that matters because why? if you later evacuate maybe? | |
| 20:51:12 | mriedem | it might not matter right now, | |
| 20:51:16 | mriedem | i was thinking, | |
| 20:51:33 | mriedem | if resize does a reschedule to the cell conductor, we could try saving changes to the request spec, because of the retry stuff | |
| 20:51:36 | superdan | actually, I think evac is probably fine since it likely uses the instance | |
| 20:51:39 | mriedem | which would be an upcall to the api db | |
| 20:52:14 | superdan | okay, but it shouldn't need to change the flavor | |
| 20:52:17 | superdan | on reschedule | |
| 20:52:22 | superdan | (from resize) | |
| 20:52:42 | mriedem | right the flavor in the requestspec wouldn't change on a reschedule during resize, | |
| 20:52:49 | mriedem | the RequestSpec.retry field might | |
| 20:53:44 | mriedem | although, | |
| 20:53:57 | mriedem | it looks like on a reschedule for resize, the compute doesn't send the request spec back up to the cell conductor | |
| 20:54:06 | mriedem | which is dumb, but likely the only thing saving this | |
| 20:54:22 | superdan | you mean "that's by design" right? :D | |
| 20:54:49 | mriedem | f no | |
| 20:55:05 | mriedem | god _reschedule_resize_or_reraise in the compute manager is about as convoluted as it gets | |
| 20:55:21 | mriedem | it's not a bdm turducken, but it's close | |
| 20:55:36 | superdan | are you just trying to start trouble on a friday afternoon? | |
| 20:56:15 | mriedem | no, i've had a patch up for this bug since it came up in early november, but realized i needed a functional test for it which stalled it out for awhile, and then earlier in the week i triaged a duplicate of the same bug, so started working on writing that functional test, | |
| 20:56:24 | mriedem | which now that i have the functional test written, it doesn't fail as expected... | |
| 20:57:33 | mriedem | i pulled the reqspec out of the api db and the 'retry' field isn't saved, so i'm trying to figure out wth the reqspec gets saved during a reschedule, during build | |
| 20:58:04 | superdan | yeah, never go trawling through your backlog on a friday | |
| 20:58:09 | superdan | that's like tuesday stuff | |
| 20:58:17 | mriedem | the tab has been open since thursday, if that helps | |
| 20:58:21 | superdan | hah | |
| 20:59:51 | mriedem | far as i can tell, when we're still at the top during build, we populate the filter_properties dict with the initial host we're going to try for the build here https://github.com/openstack/nova/blob/stable/pike/nova/conductor/manager.py#L1155 | |
| 21:00:23 | mriedem | but that never gets persisted back into the request_spec | |
| 21:01:08 | superdan | yeah, but it shouldn't right? | |
| 21:01:17 | superdan | because otherwise next time we went to do something we might think they requested that host specifically? | |
| 21:01:38 | mriedem | requesting the host specifically is the forced_hosts stuff, | |
| 21:01:45 | mriedem | that gets reset before all move operations | |
| 21:01:54 | mriedem | and yeah, i don't see a good reason to persist the retry hosts either | |
| 21:02:08 | mriedem | but this bug is asserting that they are/were and that causes problems with later move operations | |
| 21:02:47 | mriedem | time to get back to the irc logs from last september | |
| 21:04:58 | mriedem | oh i already found the convo http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2017-09-20.log.html#t2017-09-20T15:25:23 | |
| 21:05:28 | superdan | doesn't seem to be loading for me | |
| 21:05:39 | superdan | my browser might have fridayitus | |
| 21:05:46 | superdan | it's a real plague | |
| 21:07:00 | superdan | lol, I just read over the dazed and confused references in that log | |
| 21:07:02 | superdan | good times | |
| 21:07:47 | mriedem | heh | |
| 21:07:59 | mriedem | the creepy guy that now drives a lincoln everywhere | |
| 21:08:03 | superdan | lol | |
| 21:11:04 | mriedem | this is his original build request spec http://paste.openstack.org/show/621557/ | |
| 21:14:32 | mriedem | so, i'm wondering if either we used to save reqspec changes during reschedules back in mitaka? | |
| 21:14:38 | mriedem | otherwise, he might have special sauce | |