| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-31 | |||
| 15:25:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | |
| 15:25:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | |
| 15:25:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 15:25:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | |
| 15:25:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 16:20:49 | openstack | Launchpad bug 1760322 in OpenStack Compute (nova) "Traits not synced if first retrieval fails" [Undecided,New] | |
| 16:20:49 | fried_bunny | cdent: here's one for ya: https://bugs.launchpad.net/nova/+bug/1760322 | |
| 16:29:33 | openstackgerrit | Eric Fried proposed openstack/nova master: Test case: traits don't sync if first access fails https://review.openstack.org/558066 | |
| 16:29:44 | fried_bunny | cdent: There's the test case ^ | |
| 16:44:57 | openstackgerrit | Merged openstack/nova master: Fix allocation_candidates not to ignore shared RPs https://review.openstack.org/533396 | |
| 16:48:22 | openstackgerrit | Eric Fried proposed openstack/nova master: Don't declare traits synced if they ain't https://review.openstack.org/558068 | |
| 16:48:34 | fried_bunny | cdent: And a (wrong) fix ^ | |
| 16:48:47 | fried_bunny | leakypipes: I'm sure you know how to do this right (see commit message) | |
| 18:27:48 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | |
| 18:29:54 | openstackgerrit | Eric Fried proposed openstack/nova master: Add unrequested resources to provider_summaries https://review.openstack.org/558045 | |
| 18:29:54 | openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add test for provider summaries https://review.openstack.org/558044 | |
| 18:29:55 | openstackgerrit | Eric Fried proposed openstack/nova master: Support relay RP for allocation candidates https://review.openstack.org/533437 | |
| 18:29:55 | openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | |
| 18:29:56 | openstackgerrit | Eric Fried proposed openstack/nova master: Return anchor providers in a_r and p_s https://review.openstack.org/558014 | |
| 18:33:45 | imacdonn | fried_bunny: you around ? | |
| 18:33:53 | fried_bunny | imacdonn: Yeaux | |
| 18:34:21 | fried_bunny | you admining my placement hacking? | |
| 18:34:29 | fried_bunny | heh, admiring | |
| 18:34:37 | fried_bunny | Not sure what admining is. But it sounds profitable. | |
| 18:34:58 | imacdonn | admining is a thankless task ... if it has sys- as a prefix, at least | |
| 18:35:21 | fried_bunny | oh, as in "doing admin things". I read it as "ad mining" | |
| 18:35:43 | fried_bunny | I agree admin-ing doesn't sound as profitable | |
| 18:36:09 | imacdonn | and it may actually be a real word! https://english.stackexchange.com/questions/115422/administrating-vs-admining | |
| 18:36:47 | imacdonn | er anyway, I was poking at the unit tests for this placement-is-configured check thing | |
| 18:37:05 | imacdonn | all the tests that create a compute service as a fixture are failing | |
| 18:37:23 | imacdonn | I don't know much about fixtures | |
| 18:37:23 | fried_bunny | (article declaims NOT a real word - slang only) | |
| 18:37:46 | fried_bunny | Have you posted anything on gerrit yet that I can have a gander at? | |
| 18:38:05 | imacdonn | negative .. wanted to get it to pass tox first | |
| 18:38:40 | imacdonn | simple test case where it fails.... http://paste.openstack.org/show/718086/ | |
| 18:38:57 | imacdonn | I don't know how to mock things in a fixture, if that even makes sense | |
| 18:41:53 | fried_bunny | yeah, okay; it must be getting mocked out *somewhere* or a shit ton of the other tests would be failing previously. I wonder if we're just mocking out the report client everywhere. | |
| 18:42:06 | fried_bunny | How many failures are you seeing when you run the world? | |
| 18:42:26 | imacdonn | there are like 26 other tests that fail .. I just picked that one because it's really simple | |
| 18:43:25 | fried_bunny | How many different files/classes are the failures in? | |
| 18:43:48 | imacdonn | at least 6 | |
| 18:44:15 | imacdonn | you just sparked a thought, though ... now looking for mentions of reportclient under tests/ | |
| 18:44:23 | imacdonn | like ... nova/tests/unit/compute/test_compute_mgr.py: @mock.patch.object(self.compute, 'reportclient') | |
| 18:44:47 | imacdonn | not sure if any use fixtures, though | |
| 18:45:38 | fried_bunny | They wouldn't need to, if they all mock the reportclient. A fixture is basically a way to make a complicated mock/mock.patch. | |
| 18:45:54 | fried_bunny | Do all of the failures have self.start_service('compute') in the stack trace? | |
| 18:46:32 | imacdonn | certainly the majority of them do | |
| 18:47:48 | imacdonn | the nova.tests.unit.api.openstack.compute.test_services.ServicesTestV253 are a bit different | |
| 18:48:15 | fried_bunny | Well, just to try things out, find nova.test.TestCase.start_service | |
| 18:48:29 | imacdonn | actually scratch that .. it just looks different in the trace due to multi-line | |
| 18:48:38 | fried_bunny | and under the name == 'compute' conditional, add: | |
| 18:50:09 | fried_bunny | self.useFixture(nova_fixtures.PlacementFixture()) | |
| 18:50:45 | imacdonn | I thought about something like that ... but I also don't know where the fixture gets its config from | |
| 18:50:58 | fried_bunny | It uses the conf patcher :) | |
| 18:51:12 | fried_bunny | ...which is instantiated further down the line. | |
| 18:51:25 | imacdonn | ok, but where does that get its config from :) | |
| 18:52:13 | fried_bunny | It's *possible* it gets layered. | |
| 18:52:19 | fried_bunny | Which is kinda cool. | |
| 18:52:39 | fried_bunny | I think you make conf changes in tests via self.flags | |
| 18:54:53 | imacdonn | but that wouldn't be the config for the fixture (?) | |
| 18:56:01 | fried_bunny | It is, because the fixture is basically mocking conf entirely. I think. | |
| 18:56:01 | imacdonn | seems like it'd have to be passed through start_service() somehow | |
| 18:57:08 | fried_bunny | If you look at nova.tests.unit.conf_fixture.ConfFixture, it's setting a veritable plethora of things. | |
| 18:58:01 | imacdonn | yes, but in that case, the fixture itself is the code being tested | |
| 18:58:23 | fried_bunny | eh? | |
| 18:59:15 | fried_bunny | You mean in the case you're trying to write? | |
| 18:59:35 | imacdonn | in that case "self" is a fixture ... in the other cases, they create fixtures, but "self" is not the fixture. so "self.conf" wouldn't help .. I think | |
| 18:59:36 | fried_bunny | (no, cause you took out the conf checking) | |
| 19:00:05 | fried_bunny | Okay, let's back up. Why do you think you care about conf for this test? | |
| 19:00:54 | imacdonn | because the compute service fixture needs to have the auth_method (etc.) set, otherwise it'll throw that MissingPlugin | |
| 19:01:19 | imacdonn | MissingAuthPlugin* | |
| 19:01:42 | fried_bunny | Will it? Even with the PlacementFixture in place? | |
| 19:02:12 | imacdonn | I think so .. it's not failing because the service is not there .. it's failing because of that MissingAuthPlugin | |
| 19:02:24 | imacdonn | I assume we need to fix both | |
| 19:02:38 | fried_bunny | It's only getting that far because you're not mocking out the service. | |
| 19:03:24 | imacdonn | I guess I'm looking at it the other way around | |
| 19:04:06 | imacdonn | from my perspective, it's not getting far enough to actually try to use the service, because ksa is kicking back that MissingAuthPlugin, because it's not configured | |
| 19:05:56 | fried_bunny | okay, I think I see what you're getting at. But actually, I suspect MissingAuthPlugin is only happening *after* (and *because*) ksa already retrieved the version document. | |
| 19:07:22 | fried_bunny | Humor me and try that useFixture I mentioned above. You don't have to run the whole world with it - just try one suite | |
| 19:07:28 | imacdonn | huh .. interesting .. I guess I don't know enough about how ksa works | |
| 19:07:37 | fried_bunny | nobody does. | |
| 19:07:38 | fried_bunny | nobody. | |
| 19:07:46 | imacdonn | I already humo[u]red .. and it seems to work | |
| 19:07:52 | imacdonn | heh | |
| 19:08:39 | fried_bunny | excellent. Now, I don't think that's what we want to do here anyway; it's a bit of a big hammer. But it's good to know we're looking under the right rock. | |
| 19:09:14 | imacdonn | it does seem like the right thing to do (to have the tests need the placement service to be there) | |
| 19:09:17 | fried_bunny | or, actually... maybe it's not so bad. Let me take a closer look at that fixture. | |
| 19:09:52 | imacdonn | trying a full set of tests now .. just did that one simple one before | |
| 19:10:10 | imacdonn | so now failing on 6 .. better than 27 | |
| 19:12:27 | fried_bunny | show | |
| 19:15:23 | imacdonn | http://paste.openstack.org/show/718087/ | |
| 19:17:00 | imacdonn | in start_service(), the conditional is ... if name == 'compute' and self.USES_DB: | |
| 19:17:08 | fried_bunny | ah | |
| 19:17:20 | imacdonn | not sure what self.USES_DB is .... may need to move my fixture to aseparate conditional | |
| 19:18:26 | imacdonn | that fixed one of the 6, at least | |
| 19:18:54 | fried_bunny | The rest are in test_compute_mgr - you can just use that same line to instantiate the fixture in the setUp of that guy | |
| 19:18:55 | imacdonn | but not the second :) | |
| 19:19:11 | imacdonn | ok | |
| 19:19:50 | fried_bunny | ...which is bypassing start_service cause it actually wants to test the stuff the service fixture mocks out | |
| 19:21:32 | imacdonn | yeah, that makes sense | |