Posted	Nick	Remark
#openstack-nova - 2018-03-30
14:43:46	leakypipes	stephenfin, mriedem, dansmith, fried_bunny, melwitt: reviews on the three bottom patches of the patches here from tetsuro would be appreciated: https://review.openstack.org/#/c/533396/
14:43:59	fried_bunny	leakypipes: ack
14:44:05	leakypipes	danke
14:44:16	leakypipes	fried_bunny: 10-4 good bunny.
14:44:27	fried_bunny	leakypipes: I'm +1 on the bottom one already FYI
14:45:08	leakypipes	cool, thanks
14:45:30	fried_bunny	claudiub: have you posted the rev yet?
14:45:39	claudiub	amending
14:45:41	bhagyashris	leakypipes: for testing i will not need to update any shared resource provider entry. I will just need to add all the resource provider under one aggregate and set the traits right?
14:45:53	claudiub	there was an unclear question
14:46:07	claudiub	i hope i answered right. can you check?
14:47:57	leakypipes	bhagyashris: the traits are already set properly, AFAICT
14:48:26	leakypipes	bhagyashris: the only thing you'll need to do is change the parent_provider_id and root_provider_id on the compute node resource provider record and then remove the inventory on the compute node for the DISK_GB resource class.
14:48:44	cdent	kashyap: stein, not solar, sadly
14:49:09	leakypipes	cdent: sadly would have been a better name.
14:49:16	cdent	i wanted shellhaus
14:49:21	cdent	seemed so spot on
14:49:41	leakypipes	shellout...
14:50:56	openstackgerrit	Claudiu Belu proposed openstack/nova-specs master: Adds spec for instance live resize https://review.openstack.org/141219
14:51:12	cdent	leakypipes, fried_bunny, figleaf, bauwser : I've just published the latest placement update. It's freakin' huge man. We're probably going to need to do some rationalization.
14:53:02	bhagyashris	leakypipes: ok just confirming: the parent_provider_id will be nulland root_provider_id will be the shared resource provider right?
14:53:35	leakypipes	cdent: ack
14:54:04	leakypipes	bhagyashris: no. root_provider_id should be the same value as id column (for the compute node resource provider).
14:54:13	leakypipes	bhagyashris: and parent_provider_id should be NULL, yes
14:56:42	figleaf	cdent: I'll add that as a discussion item for Monday's scheduler meeting
14:56:53	figleaf	Or are most people off on Monday? (I'm not)
14:57:00	cdent	rad
14:57:06	cdent	oh, yeah. I'm supposed to be
14:57:09	cdent	but meh
14:57:21	bhagyashris	leakypipes: ok thank you for your inputs I will test this by applying this patch but as i am working in IST time so it's almost End of the day so i will check and will let you know once testing done
14:57:29	bhagyashris	leakypipes: thank you :)
14:57:47	leakypipes	bhagyashris: no problem at all. thanks much for your testing help!
15:06:31	mriedem	leakypipes: musing in https://review.openstack.org/#/c/553122/
15:06:38	mriedem	will hold for fried_bunny
15:11:04	leakypipes	fried_bunny: did you catch melwitt's question to you on https://review.openstack.org/#/c/533821/?
15:19:34	leakypipes	mriedem: left some notes for you on that
15:30:19	fried_bunny	sorry guys, was afk for a few. Catching up.
15:31:05	fried_bunny	mriedem: Ack
15:31:21	fried_bunny	leakypipes: Yes, was planning to dig into that today.
15:33:45	leakypipes	fried_bunny: cool, np. just checking to see if you had
15:33:57	fried_bunny	yuh, thanks.
15:34:20	leakypipes	cdent: understatement of the year in your placement update: "There's also been a _lot_ of discussion around NUMA handling"
15:34:30	fried_bunny	leakypipes: I've slowed myself way down by picking up lots of extra reviews - probably too many, need to scale back some.
15:34:46	leakypipes	fried_bunny: learn, you will, young paduan.
15:37:36	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604
15:37:37	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370
15:37:37	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423
15:37:38	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947
15:37:38	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170
15:37:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334
15:37:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333
15:37:40	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870
15:37:40	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371
15:37:41	openstackgerrit	Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537
15:39:54	openstackgerrit	Merged openstack/nova-specs master: Update the vGPU spec https://review.openstack.org/557912
16:15:55	openstackgerrit	Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795
16:16:35	openstackgerrit	Ed Leafe proposed openstack/nova master: Add handlers for consumer_generation https://review.openstack.org/557959
16:16:35	openstackgerrit	Ed Leafe proposed openstack/nova master: Add the 'generation' column to the consumers table https://review.openstack.org/557958
16:17:06	figleaf	leakypipes: fried_bunny: cdent: ^^ First crack at consumer generations. More to come
16:17:39	fried_bunny	figleaf: ack
16:17:52	leakypipes	figleaf: nice, thank you sir.
16:18:20	cdent	figleaf: I'm going to ignore that until next week please and thank you
16:19:06	fried_bunny	claudiub|2: Still around?
16:23:16	figleaf	cdent: ignore away
16:23:19	figleaf	:)
16:26:58	claudiub|2	fried_bunny: i am now
16:28:04	cdent	That's it for me today. Happy Easter if that's your thing, happy weekend otherwise.
16:28:29	claudiub|2	the autospec stuff?
16:28:37	claudiub|2	i''l take a look
16:48:43	openstackgerrit	Ed Leafe proposed openstack/nova master: Add handlers for consumer_generation https://review.openstack.org/557959
16:56:24	fried_bunny	claudiub|2: Thank you sir.
16:57:55	fried_bunny	claudiub|2: The failures are really weird. The leading '<' is stripped from the mock repr in the KeyError. Not sure if that's significant.
16:58:18	openstackgerrit	Roman Dobosz proposed openstack/nova master: Added weight for aggregate soft (anti) affinity. https://review.openstack.org/556762
17:12:48	openstackgerrit	Merged openstack/nova stable/pike: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/550555
17:12:56	openstackgerrit	Merged openstack/nova master: Fix comments in get_all_with_shared() https://review.openstack.org/533195
17:13:03	openstackgerrit	Merged openstack/nova stable/pike: Add --by-service to discover_hosts https://review.openstack.org/554603
17:13:14	openstackgerrit	Merged openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728
17:16:32	fried_bunny	claudiub|2, edmondsw: It's specifically this part that breaks us:
17:16:33	fried_bunny	When I comment out *just* that fixture, we're fine.
17:16:33	fried_bunny	https://review.openstack.org/#/c/447505/44/nova/test.py
17:16:44	fried_bunny	Which isn't surprising; that's the only part that could have possibly affected us OOT.
17:16:50	fried_bunny	So - what IS that thing?
17:20:16	claudiub|2	you mean what is that fixture?
17:20:19	fried_bunny	yeah
17:20:36	claudiub|2	it adds the autospec argument to mock.Mock and mock.MagicMock
17:21:16	claudiub|2	which is even more strange, because I don't see how it could have affected this
17:22:28	fried_bunny	claudiub|2: Well, we're inheriting nova.test.TestCase, so that's how we're picking up the change. That much is clear.
17:22:35	claudiub|2	since I don't see autospecs being used anywhere
17:23:23	fried_bunny	claudiub|2: By "it adds the autospec argument" do you mean that it just makes it available, not that it actually sets it to anything?
17:24:28	claudiub|2	yep
17:24:41	claudiub|2	if autospec is not specifically given, it is noop
17:24:51	claudiub|2	question, do you split by underscore somewhere?
17:25:00	fried_bunny	oh, I'm sure we must
17:25:15	claudiub|2	oh
17:25:18	claudiub|2	that might be it
17:25:45	claudiub|2	yeah, I think I know what's happening
17:25:46	fried_bunny	...not seeing it though.
17:25:58	fried_bunny	okay, do tell. Cause I'm stumped. Mystified. Stupefied.
17:27:48	claudiub|2	so, you're using a lot of thing.uuid, or thing.name and so on. so, if that property is not set on the mock, something like this is printed: str(mock_thing.foo) -> <_AutospecMock name='mock.foo' id='139796718268752'>
17:28:23	claudiub|2	the mock class with autospec is called _AutospecMock

Earlier   Later