Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-03-29
20:37:00 fghaas Entirely understood. But great to know that this will be an easy stop to pull, figuratively speaking
20:37:57 melwitt true that
20:44:49 fghaas ok, thanks everyone (particularly melwitt, cfriesen and kashyap), that's been extremely helpful information!
20:45:56 melwitt np
20:48:56 efried melwitt: Feel like pushing https://review.openstack.org/#/c/557508/ ? "Customer" is buggin me :)
20:50:19 efried jaypipes: Easy reviews in the upt bp (but outside the series so you mighta missed 'em): https://review.openstack.org/#/c/553475/ and (less critical) https://review.openstack.org/#/c/553476/
20:50:21 melwitt it has been tab'd
20:50:25 efried melwitt: Thanks!
20:50:30 melwitt nova meeting in 10 minutes
21:01:43 melwitt gdi my irc client is freaking out. sorry
21:14:38 fghaas whoa melwitt you beat me to the ML writeup — thanks again!
21:18:26 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: add check before adding cpus to cpuset_reserved https://review.openstack.org/557622
21:27:01 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384
21:30:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions https://review.openstack.org/557506
21:31:19 openstackgerrit Michael Still proposed openstack/nova master: Move create_tap_dev to the new utility method. https://review.openstack.org/557835
21:31:19 openstackgerrit Michael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module. https://review.openstack.org/557552
21:35:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions https://review.openstack.org/557506
21:53:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration https://review.openstack.org/527541
21:55:42 openstackgerrit Eric Fried proposed openstack/nova stable/queens: Use ksa session for cinder microversion check https://review.openstack.org/557837
21:55:51 efried mriedem, melwitt: queens cherry-pick ^
21:55:58 efried Thanks for the prompt reviews, y'all.
21:56:12 melwitt lol, I was about to say, that's a lightning fast backport proposal
21:57:31 efried melwitt: I cheated a teeny bit
21:57:44 efried but I have pressure
21:59:29 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/550555
22:00:37 edleafe efried: just for you: https://www.youtube.com/watch?v=nxxSIX3fmmo
22:00:52 mriedem https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+label:Code-Review=2 is happy, but needs a non-tony person
22:01:35 openstackgerrit Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795
22:02:32 melwitt cool, will find someone to bug for the rest. thanks
22:08:50 mriedem efried: looking at the history of that microversion check, it was added in pike, and it's used if we actually created attachments in pike, but we don't
22:08:55 mriedem so don't think we need to fix anything in pike there
22:09:19 efried mriedem: Okay, cool. Thanks for tracking that down.
22:09:49 efried mriedem: Wait, is that just the one in the attach flow? Cause we also do the microversion check when we're just creating the client from nothing.
22:10:04 mriedem is_microversion_supported isn't in pike
22:10:35 efried mriedem: But does the cinderclient() method have the _check_microversion call?
22:10:38 mriedem https://review.openstack.org/#/c/469579/3/nova/volume/cinder.py doesn't do anything unless the microversion arg is passed in
22:10:50 mriedem and the only things that pass that in, attachment create/update/delete,
22:10:54 mriedem aren't going to get used in pike
22:11:05 mriedem b/c we don't attach volumes the new way until queens
22:11:25 mriedem so there is some plumbing in pike but it's not used
22:11:28 efried mriedem: So... there was no reason for that code to go into pike?
22:11:40 mriedem well,
22:11:46 mriedem you're talking about a series of changes over 2 years
22:11:52 mriedem so we got in what we could get in when we could get it in
22:12:03 efried Hindsight, and all that.
22:12:16 mriedem my hindsight is 30/40
22:12:30 efried Anyway, cool beans. I guess if it is broke, someone will yell.
22:12:37 efried hopefully before EOL.
22:12:42 mriedem there is no more eol
22:12:43 mriedem remember
22:12:51 efried I haven't really been following that.
22:12:59 efried But great, so we have all the time in the world :)
22:13:05 melwitt EOL is EOL
22:13:09 melwitt cacao to cacao
22:13:22 mriedem http://lists.openstack.org/pipermail/openstack-dev/2018-March/128862.html
22:26:31 efried mriedem: Is series https://review.openstack.org/#/c/526753/ approved for rocky?
22:27:16 efried looks like not yet, but spec is up.
22:31:39 mriedem spec isn't approved
22:31:50 mriedem oh we nacked that at the ptg
22:32:24 mriedem if i'm thinking of the same thing
22:44:06 efried TheJulia: Sorry for the delay on https://review.openstack.org/#/c/554762/
22:44:32 efried TheJulia: I remember pawing through the client code and thinking there was a clean way to send down a microversion per request so you didn't have to clone the client objects.
22:45:01 efried TheJulia: I'm looking again. If I can't suss it, I'll remove my objections (grudgingly, because still ugly, but if that's how we have to move forward...)
22:46:03 efried jroll, dtantsur|afk: FYI ^^
22:46:04 TheJulia efried: It is one of those things that really we should just replace the guts of.... :(
22:46:11 TheJulia One day :)
22:46:28 efried TheJulia: But can't, because... too much at once?
22:46:33 efried ocean boiling, kind of thing
22:46:42 TheJulia yeah
22:47:22 TheJulia kind of at least :(
22:53:04 Spaz-Home Morning
22:53:28 TheJulia Good morning
23:01:29 efried TheJulia: So yeah, it looks like on a per-request basis you can pass in a `headers` dict.
23:01:45 efried ...with the X-OpenStack-Version-Whatever thingy.
23:02:08 efried All the layers between there and the wire appear to use setdefault correctly, so it *should* make it through.
23:02:47 efried bbiab...
23:02:53 TheJulia hmmm
23:04:22 TheJulia yeah, same problem though
23:04:28 TheJulia we bypass all of our microversion logic then
23:04:33 TheJulia at least client side
23:11:26 TheJulia Well, looks like we would also re-negotiate with what was provided upon the client being called originally
23:15:40 TheJulia and I think we would have to add code to handle that this it would be a user defined override
23:17:17 jroll not to mention, then you're leaking implementation details out to the caller
23:17:48 TheJulia yeah....
23:18:20 openstackgerrit Merged openstack/nova master: [placement] Fix bad management of _TRAITS_SYNCED flag https://review.openstack.org/557722
23:18:51 jroll TheJulia: like dmitry, I'd also commit to reviewing client changes to accept that per method, but I don't have any problems with keeping a couple copies of the client
23:19:02 jroll especially if we plan to fix that later
23:24:35 efried Let me work something up right quick. Maybe you'll fall in love with the idea when you see it in action :)
23:26:45 efried melwitt: Oh, another thought I had was putting core reviewer names next to runway slots. Volunteers & SMEs first; then...
23:31:11 efried TheJulia, jroll: Okay, never mind; the (bizarrely resolved through _multi_getattr) target methods don't even take kwargs.
23:31:49 TheJulia heh
23:32:19 TheJulia I think I looked at that a couple of weeks ago pondering something similar
23:32:34 TheJulia of of similar use I should say
23:36:51 efried TheJulia: I removed my -1. Thanks for bearing with me.
23:37:36 TheJulia efried: no, thank you for looking and thinking
23:50:24 openstackgerrit Tony Breeds proposed openstack/nova stable/ocata: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/550560
#openstack-nova - 2018-03-30
00:19:44 openstackgerrit Merged openstack/nova master: Use ksa session for cinder microversion check https://review.openstack.org/557508
00:19:50 openstackgerrit Merged openstack/nova stable/pike: docs: Disable smartquotes https://review.openstack.org/554189
01:08:36 Spaz-Home Whew new shoes.. short workout.. let's do some nova
02:34:25 openstackgerrit Merged openstack/nova stable/pike: add check before adding cpus to cpuset_reserved https://review.openstack.org/557622

Earlier   Later