| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-29 | |||
| 14:32:39 | bauzas | but the fact that we will have strings made of UUIDs and commas | |
| 14:32:58 | bauzas | so, I just want to clarify the docstring, that's it | |
| 14:34:03 | dansmith | bauzas: yeah, fair neough | |
| 14:34:20 | dansmith | bauzas: the names make it easier to reason about the example, but I can make a point of explaining what they are | |
| 14:38:29 | bhagyashris | mriedem: But giving provision through nova API to createBackup of server backup is more user friendly | |
| 14:39:07 | mriedem | bhagyashris: well, it is because that's what is available today :) | |
| 14:39:32 | mriedem | bhagyashris: to be clear, i'm not -2 on your spec, i'm just saying that the alternative to deprecate should be mentioned in there | |
| 14:42:44 | mriedem | claudiub: can you also propose a stable/queens backport for https://review.openstack.org/#/c/557377/ ? | |
| 14:42:54 | mriedem | i've got a queens 17.0.2 release patch waiting and can hold it up for this | |
| 14:43:02 | mriedem | since it was a regression in queens 17.0.1 | |
| 14:43:43 | openstackgerrit | Claudiu Belu proposed openstack/nova stable/queens: vmware: Fixes _detach_instance_volumes method https://review.openstack.org/557727 | |
| 14:44:45 | bhagyashris | mriedem: yeah... still waiting for others opinion but deprecation will lose the user friendly and that most imp IMO. | |
| 14:47:01 | bhagyashris | johnthetubaguy: Hi waiting for opinion on same ^ (https://review.openstack.org/#/c/511825/) | |
| 14:47:57 | johnthetubaguy | bhagyashris: I like the idea of documenting the alternative, even if we decide against it | |
| 14:49:31 | bhagyashris | mriedem: ok i will add this as alternative in spec and will go with proposed solution. | |
| 14:49:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use ksa session for cinder microversion check https://review.openstack.org/557508 | |
| 14:50:05 | bhagyashris | johnthetubaguy: ok i will add this as alternative in spec and will go with proposed solution. | |
| 14:52:05 | bhagyashris | johnthetubaguy: continuing implementation as per the proposed solution I will push the patch soon | |
| 14:52:43 | openstackgerrit | Mathieu Gagné proposed openstack/nova-specs master: Multiple Fixed-IPs support in network information https://review.openstack.org/312626 | |
| 14:53:34 | efried | alex_xu_, dansmith, edleafe, jaypipes, cdent, bauzas: https://etherpad.openstack.org/p/placement-dynamic-traiting for a start | |
| 14:53:43 | stephenfin | jaypipes, mriedem: Could one of you send this through? https://review.openstack.org/#/c/555000/ | |
| 14:57:35 | mriedem | stephenfin: would prefer if jaypipes or bauzas did that since i didn't review that series | |
| 14:57:50 | stephenfin | ack | |
| 14:58:10 | jaypipes | stephenfin: would you mind updating the commit message summary as cdent requests? | |
| 14:58:18 | mriedem | if someone is looking for what appears to be a low-hanging fruit bug that just needs a rev of the patch, https://review.openstack.org/#/c/541660/ | |
| 14:58:42 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Update 'share-pci-between-numa-nodes' spec to reflect reality https://review.openstack.org/555000 | |
| 14:58:46 | stephenfin | jaypipes: done | |
| 15:00:00 | jaypipes | stephenfin: done | |
| 15:00:12 | stephenfin | ta :) | |
| 15:02:05 | dansmith | efried: I added a few notes, I gotta jump on a call now | |
| 15:02:10 | jaypipes | cdent: btw, have you started on an os-resource-classes lib? if not, I was going to hop on that... | |
| 15:02:24 | efried | dansmith: ack | |
| 15:03:03 | cdent | jaypipes: go for it. I'd been trying to lay it out as bait for $random_person, but if you're keen go for it | |
| 15:03:17 | jaypipes | alex_xu_: see my question to Intel folks on line 13 of the etherpad... | |
| 15:06:32 | alex_xu_ | jaypipes: yes, I think we should say it is 'pre-programmed' or 'static' compare to 'fully dynamic' | |
| 15:08:29 | cdent | jaypipes, efried, others: watching that etherpad it appears that the conversation from the hangout is continuing rather than being summarized? | |
| 15:09:09 | edleafe | cdent: exactly. IOW, we can't summarize our conclusions if we didn't reach consensus | |
| 15:09:24 | efried | cdent: Sorry, got pulled away as soon as I posted that. Will look in a couple minutes. | |
| 15:10:43 | jaypipes | cdent: yes :( | |
| 15:11:35 | efried | mriedem: The fix https://review.openstack.org/#/c/557508/ works. But I think the hacking check fix isn't right just yet. I will revise. | |
| 15:12:12 | efried | mriedem: (The assertion that it works is based on internal discussions - I've asked them to update the bug accordingly to make it official.) | |
| 15:12:13 | mriedem | efried: pep8 passes | |
| 15:12:21 | efried | mriedem: But pyXX won't. | |
| 15:12:31 | mriedem | oh, i didn't run those... | |
| 15:12:51 | mriedem | if you change the hacking check, it likely should be a separate patch before that cinder fix | |
| 15:12:51 | efried | I didn't either, just assuming based on how mock.patch works... | |
| 15:13:06 | mriedem | i was just being lazy and expediant | |
| 15:13:53 | efried | mriedem: Yeah, I'll fix the hacking check totally separately. I'll tweak the fix you did on this patch cause we want it quickish. | |
| 15:14:10 | alex_xu_ | jaypipes: dansmith to avoid program a pre-programmed device, we need 'OR' logic in allocation candidates, I commented at line 30 | |
| 15:15:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa session for cinder microversion check https://review.openstack.org/557508 | |
| 15:15:07 | efried | mriedem: ^ | |
| 15:17:18 | mriedem | oh right i screwed up the order of the args to the test metohd | |
| 15:17:19 | mriedem | oops | |
| 15:18:22 | mriedem | ok i see "@efried, patch seems to be working fine with vm deploy/delete, volume attach/delete flows" in the bug | |
| 15:18:42 | efried | mriedem: Oh, yeah, they did comment on the bug. Cool. | |
| 15:19:22 | mriedem | +2 | |
| 15:19:36 | mriedem | i know this has to go back to queens but not sure if it's also needed in pike, will have to check | |
| 15:21:15 | openstackgerrit | Merged openstack/nova-specs master: Update 'share-pci-between-numa-nodes' spec to reflect reality https://review.openstack.org/555000 | |
| 15:23:36 | kashyap | mriedem: I changed the exception here to a warning (locally) & fixed all the other things you pointed out; is _another_ test still required here: https://review.openstack.org/#/c/534384/20/nova/virt/libvirt/driver.py@3875 | |
| 15:25:49 | efried | sdague: You seem like a likely candidate to +A https://review.openstack.org/#/c/557508/ -- got a minute for that? | |
| 15:28:09 | mriedem | kashyap: you asked dansmith that question yesterday | |
| 15:28:13 | mriedem | i remember the answer | |
| 15:28:31 | kashyap | mriedem: Heh, not trying to "circumvent" anything! | |
| 15:28:43 | kashyap | Wanted to double-confirm. Something about "assume good intent"? | |
| 15:29:05 | bauzas | to the audience, keep in mind that if you tell to a French folk "I like you, but you're bad", there is a very strong meaning https://review.openstack.org/#/c/547990/16/nova/scheduler/client/report.py@341 | |
| 15:29:37 | bauzas | tl;dr: the "but" litterally cancels what you just said before | |
| 15:29:58 | mriedem | that means the same thing in english | |
| 15:30:08 | mriedem | "i like you, but we're breaking up" | |
| 15:30:27 | mriedem | "you're a valuable member of the team, but...." | |
| 15:31:16 | dansmith | kashyap: keeping the patch small is good, but not generally at the expense of tests | |
| 15:31:29 | dansmith | kashyap: when in doubt, cut down the four-page release notes :) | |
| 15:31:30 | kashyap | dansmith: Okido; I'll shut up and get that going. :-) | |
| 15:31:49 | kashyap | dansmith: Actually, most of that info belongs in the config option help text | |
| 15:31:59 | kashyap | dansmith: But, yes. I trimmed it | |
| 15:32:26 | kashyap | dansmith: Wonder if you could cut some slack, English is my 3rd language, much as I love it :P | |
| 15:32:40 | bauzas | mriedem: what's interesting is that 'but' in english can mean "except that one" | |
| 15:32:50 | bauzas | mriedem: while we don't have that one in French | |
| 15:33:02 | bauzas | it's another word | |
| 15:33:03 | edleafe | alex_xu_: jaypipes: sorry, meeting time. Would love to continue our etherpad conversation, but... | |
| 15:33:11 | bauzas | hah | |
| 15:33:15 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix N332 api_version decorator hacking check https://review.openstack.org/557743 | |
| 15:33:17 | efried | mriedem: ^ | |
| 15:33:20 | bauzas | edleafe: good usage of "but" :p | |
| 15:33:24 | kashyap | bauzas: Speaking of French and English; do you know this: "How a Mistake Gave Us the Word 'Cherry'" -- https://www.merriam-webster.com/words-at-play/cherry-history-origin | |
| 15:33:25 | bauzas | right on time | |
| 15:33:38 | alex_xu_ | edleafe: np, my brain doesn't work also | |
| 15:34:21 | jaypipes | alex_xu_, edleafe: do we have something that can be standardized in os-traits that represents the things that an FPGA is *capable* of programming? For example, in vGPU land, we have the VGPU_RESOLUTION_XXX traits and VGPU_MAX_DISPLAY_HEAD traits etc. | |
| 15:34:55 | edleafe | jaypipes: dunno - that would be a good question for the FPGA vendors | |
| 15:36:05 | efried | bauzas: Would you mind casting your eye upon https://review.openstack.org/#/c/557508/ ? | |
| 15:36:17 | bauzas | if that's only one eye | |
| 15:36:20 | bauzas | I can blink | |
| 15:37:02 | bauzas | efried: CC'd | |
| 15:37:04 | efried | acceptable | |
| 15:37:12 | bauzas | efried: just focusing on dansmith's series | |
| 15:37:18 | bauzas | but then I can help | |
| 15:37:21 | efried | thanks | |
| 15:37:24 | mriedem | bauzas: ever word in english has at least 3 different meanings | |
| 15:37:45 | mriedem | *every even | |
| 15:37:47 | efried | holy shit, I just looked back at that etherpad. | |
| 15:37:48 | bauzas | efried: food for thoughts too https://review.openstack.org/#/c/557065/ | |