| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-28 | |||
| 09:56:35 | openstackgerrit | jichenjc proposed openstack/nova master: Move update_task_state out of try/except https://review.openstack.org/557152 | |
| 09:57:00 | jianghuaw_ | Should we just update the queens spec or should make a new spec in Rocky? | |
| 10:43:00 | openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | |
| 11:03:28 | openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | |
| 11:22:02 | openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | |
| 11:38:20 | priya__ | Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike? | |
| 11:55:45 | Kevin_Zheng | priya__ seems related with cells v2 structure, | |
| 11:58:11 | Kevin_Zheng | pike reads api_db for flavor, mitaka reads nova db, so it will work with mitaka but cannot work with pike | |
| 11:58:19 | Kevin_Zheng | should perform data migration | |
| 12:00:06 | priya__ | Kevin_Zheng flavor = db.flavor_get(context, inst_type_id) is the call which breaks. how do i perform data migration? | |
| 12:02:26 | Kevin_Zheng | priya__ how did you install your nova? | |
| 12:02:44 | Kevin_Zheng | with source code or packages? | |
| 12:03:20 | Kevin_Zheng | or devstack | |
| 12:03:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Speed things up and document them https://review.openstack.org/534382 | |
| 12:03:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Make everything work with Python 3 https://review.openstack.org/556894 | |
| 12:03:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383 | |
| 12:03:44 | Kevin_Zheng | another thing is that the default flavors are removed after mitaka | |
| 12:03:55 | Kevin_Zheng | so you have to create your own flavor before use | |
| 12:25:23 | priya__ | Kevin_Zheng through package | |
| 12:25:49 | Kevin_Zheng | Then I guess you should create your own flavor before use | |
| 12:26:07 | Kevin_Zheng | because there will be no default flavors after mitaka | |
| 12:28:05 | priya__ | Kevin_Zheng yes i have created a flavor, and that shows up in nova_api,flavors table. But it is not updated in instance_types. | |
| 12:28:35 | priya__ | Kevin_Zheng flavor = db.flavor_get(context, inst_type_id) refers to instance_types table and my code breaks here..i dont understand why | |
| 12:30:09 | Kevin_Zheng | where is this code? | |
| 12:31:00 | priya__ | this is my custom code | |
| 12:31:07 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | |
| 12:31:22 | kashyap | alex_xu_: Thanks for the eagle eyes; I think '20' is the lucky number :-) | |
| 12:31:35 | Kevin_Zheng | OK then you access the wrong db | |
| 12:31:57 | Kevin_Zheng | because in Pike the flavor is not in that table anymore | |
| 12:32:17 | Kevin_Zheng | it moved to flavors in api_db | |
| 12:32:32 | Kevin_Zheng | you should query that | |
| 12:32:57 | alex_xu_ | kashyap: hah | |
| 12:33:22 | priya__ | Kevin_Zheng how do i change the database to access? because db.flavor_get is in nova api code | |
| 12:33:35 | kashyap | alex_xu_: Thank you! | |
| 12:33:52 | Kevin_Zheng | but you said it is your cutom code? | |
| 12:35:30 | priya__ | Kevin_Zheng The call is in my custom code, howevr the db.flavor_get method def refers to nova/db/api.py(1579)flavor_get() | |
| 12:37:06 | Kevin_Zheng | which nova api did your code call? | |
| 12:38:06 | openstackgerrit | Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | |
| 12:40:47 | Kevin_Zheng | priya__ sorry I have to go | |
| 12:41:17 | priya__ | Kevin_Zheng thank you for the help. | |
| 12:41:40 | priya__ | Kevin_Zheng i have used the db api | |
| 12:41:51 | gibi | stephenfin: I left some questions in the numa aware switches spec https://review.openstack.org/#/c/541290 | |
| 12:50:46 | cdent | jaypipes, stephenfin: quick test coverage win in placement one +2 already: https://review.openstack.org/#/c/513264/ | |
| 12:50:58 | jaypipes | cdent: cool. | |
| 12:52:33 | cdent | thanks jaypipes | |
| 12:58:04 | efried | mikal: I do not accept your admonishment. I may have been mistaken or talked out of the more substantive issues, but taken at face value, those would have justified further work on the patch. | |
| 12:58:14 | efried | mikal: Thank you for the updates. Hugs! | |
| 13:00:40 | jaypipes | efried: so... | |
| 13:01:20 | jaypipes | efried: on https://review.openstack.org/#/c/557187/ I'm torn | |
| 13:01:40 | jaypipes | efried: we don't have a good set of unit tests for the placement HTTP handlers | |
| 13:01:56 | cdent | (on purpose) | |
| 13:02:13 | jaypipes | efried: and asking Johannes to create one from scratch is a bit much for a one-byte patch | |
| 13:02:32 | jaypipes | efried: I would just as much say let's merge the thing | |
| 13:02:53 | efried | That's fair, I didn't realize we didn't have a framework in place that would make it trivial (I didn't look). | |
| 13:03:13 | jaypipes | efried: yeah, we don't have unit tests for this stuff really. | |
| 13:03:34 | jaypipes | efried: that said, we could ask for a gabbit to be added that would force this code path | |
| 13:03:35 | cdent | Just so it is clear, the lack of unit tests is supposed to reflect that anything that ought to have a unit test is in a different file | |
| 13:03:39 | jaypipes | I think.. | |
| 13:03:51 | cdent | jaypipes: it won't work without multiple processes | |
| 13:04:03 | efried | But in any case, not in this patch. | |
| 13:04:10 | jaypipes | cdent: right. | |
| 13:04:11 | efried | jaypipes, cdent: I flipped to +1. | |
| 13:04:11 | cdent | delicately controlled multiple processes | |
| 13:04:29 | efried | thanks for setting me straight there. | |
| 13:05:17 | jaypipes | efried: like I said, I'm a bit torn, but I think I land on the "just merge this" side. | |
| 13:05:39 | efried | jaypipes: I'm fine with that, especially given it's a clearly correct fix to a clear mistake in the code. | |
| 13:05:50 | efried | If writing the test were trivial, that would be one thing. | |
| 13:07:05 | jaypipes | efried: right, agreed. | |
| 13:09:59 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler) https://review.openstack.org/550527 | |
| 13:10:00 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update the cells FAQs and scheduler maintenance docs. https://review.openstack.org/556459 | |
| 13:10:00 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add --enable and --disable options to nova-manage update_cell https://review.openstack.org/555416 | |
| 13:17:57 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | |
| 13:25:08 | efried | jaypipes, edleafe: turns out we're not restricting characters on RP names. I just created RPs with names chr(0)-chr(127). Do we have a SQL injection hole, or is sqla providing the necessary escaping security blanket so we don't have to worry about it? | |
| 13:29:22 | jaypipes | efried: sqlalchemy (and in fact the Python DB API) provides the protection against SQL injection attacks. | |
| 13:31:43 | mriedem | dansmith: regarding that [database]/connection setting in nova.conf for the api / controller services, i just noticed that the install guide for the controller tells you to set the [database]/connection to the 'nova' db, rather than nova_cell0 https://docs.openstack.org/nova/latest/install/controller-install-ubuntu.html#install-and-configure-components | |
| 13:32:06 | mriedem | which, if you're not doing 'superconductor' mode, isn't a big deal | |
| 13:32:15 | dansmith | mriedem: probably from pre-cells switchover though | |
| 13:32:25 | dansmith | like we never updated it | |
| 13:33:51 | mriedem | yeah, https://docs.openstack.org/nova/latest/user/cells.html#first-time-setup says, "If your databases are on separate hosts then you should specify --database_connection or make certain that the nova.conf being used has the [database]/connection value pointing to the same user/password/host that will work for the cell0 database." | |
| 13:34:31 | mriedem | with the current install guide instructions, i don't think cell0 db sync ever runs | |
| 13:35:27 | dansmith | ack, we should probably audit all that stuff in modern times | |
| 13:37:29 | mriedem | oh nvm, db sync defaults to find the cell0 mapping and sync it | |
| 13:37:51 | olivenwk | Hello, I try to add aliases in nova. Why alias ={ "vendor_id":"1002", "product_id":"6938", "device_type":"type-PCI", "name":"R9-380X" } followed by alias ={ "vendor_id":"10de", "product_id":"1b06", "device_type":"type-PCI", "name":"GTX1080Ti" } works and not alias=[{ "vendor_id":"1002", "product_id":"6938", "device_type":"type-PCI", "name":"R9-380X" },{ "vendor_id":"10de", "product_id":"1b06", "device_type":"type-PCI", "name":"GTX1080Ti" }] | |
| 13:38:36 | olivenwk | but if I write my alias in the array fashion ONLY on the compute node it works | |
| 13:38:55 | olivenwk | seems to be controller node related, any ideas? | |
| 13:45:42 | openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | |
| 13:52:17 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | |
| 13:52:56 | gibi | jaypipes: I left two questions in the nested a_c spec https://review.openstack.org/#/c/556873/ | |
| 13:55:24 | mriedem | eric-young: https://review.openstack.org/#/c/554679/ is now released in os-brick 2.4.0, you should push a change to the openstack/requirements repo to bump the minimum required version to 2.4.0 in global-requirements | |
| 13:55:38 | mriedem | and then make https://review.openstack.org/#/c/554679/ depend on it | |
| 13:58:47 | dansmith | hmm, someone removed the placement-req series from the runways etherpad queue | |
| 13:59:07 | dansmith | oh, nevermind, it got moved down apparently | |
| 14:00:03 | mriedem | heh, the glory of etherpads | |
| 14:00:11 | mriedem | pre-emptible runways | |
| 14:00:47 | mriedem | so uh, do we wait for melwitt to move things from the queue into the actual slots? | |
| 14:01:20 | dansmith | yeah I went to look because I expected she moved things into the slots after yesterday | |
| 14:01:36 | dansmith | we have a meeting at 8 so she should be around then-ish I think | |
| 14:01:57 | mriedem | there is a procedure on L24 so i guess anyone could just follow that | |
| 14:02:15 | openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | |
| 14:02:30 | bauzas | do we really need slots for priority series ? | |