| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-26 | |||
| 13:05:29 | stephenfin | yeah, there won't be anything in the html directory because the build failed | |
| 13:06:08 | kashyap | Right; I'll check w/ the #openstack-release folks | |
| 13:11:30 | openstackgerrit | Merged openstack/nova master: Modify nova-manage cell_v2 list_cells to display "disabled" column https://review.openstack.org/555415 | |
| 13:16:24 | stephenfin | sahid: Done https://review.openstack.org/#/c/511188/ | |
| 13:17:26 | sahid | stephenfin: thanks, i will address your comments | |
| 13:26:37 | openstackgerrit | Merged openstack/nova master: Add disabled option to create_cell command https://review.openstack.org/555417 | |
| 13:39:14 | jaypipes | morning supernovas | |
| 13:39:25 | gibi | jaypipes: good morning | |
| 13:39:38 | Spazmotic | morning jay | |
| 13:41:12 | gibi | jaypipes: I added reasoning about the need of the vnic_type in https://review.openstack.org/#/c/502306/20/specs/rocky/approved/bandwidth-resource-provider.rst@396 please let me know what you think | |
| 13:41:30 | bauzas | jaypipes: morning | |
| 13:41:36 | bauzas | still working on updating my spec | |
| 13:41:52 | jaypipes | gibi: cool, will do right now. | |
| 13:42:22 | gibi | jaypipes: thanks | |
| 13:43:57 | stephenfin | kashyap: What was the fix? | |
| 13:44:18 | kashyap | stephenfin: I'm embarassed to tell | |
| 13:44:29 | kashyap | stephenfin: But I will tell | |
| 13:44:50 | kashyap | stephenfin: A mis-quoting a CPU model like this: "'Foo" | |
| 13:45:32 | kashyap | stephenfin: (s/mis-quoting a/mis-quoting of a/) And another spurious "::" | |
| 13:46:51 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | |
| 13:47:34 | stephenfin | kashyap: aha. Good to hear you got it sorted :) | |
| 13:48:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add CPUWeigher https://review.openstack.org/379525 | |
| 13:49:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Standardize '_get_XXX_constraint' functions https://review.openstack.org/385071 | |
| 13:50:23 | kashyap | sean-k-mooney: Do you spot anything else here: https://review.openstack.org/#/c/534384/ | |
| 13:50:39 | openstackgerrit | sahid proposed openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188 | |
| 13:50:40 | kashyap | sean-k-mooney: I think it's ready for "prime time". I restricted the options for now to only PCID. | |
| 13:51:15 | kashyap | sean-k-mooney: (To keep it backportable; and in a future patch, remove that restriction, thus making way for other useful stuff.) | |
| 14:03:14 | jaypipes | gibi: done | |
| 14:03:23 | edleafe | Scheduler subteam meeting running now in #openstack-meeting-alt | |
| 14:04:34 | gibi | jaypipes: thanks, I will check after the scheduler meeting | |
| 14:17:02 | openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | |
| 14:23:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Speed things up and document them https://review.openstack.org/534382 | |
| 14:23:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Fix indentation https://review.openstack.org/556543 | |
| 14:23:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383 | |
| 14:23:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Remove unnecessary configuration https://review.openstack.org/556544 | |
| 14:34:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Use new-style choice values https://review.openstack.org/530924 | |
| 14:35:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Add mypy target https://review.openstack.org/538221 | |
| 14:35:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Store list of converted files https://review.openstack.org/538222 | |
| 14:35:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.openstack.org/538224 | |
| 14:35:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Add 'mypy' job https://review.openstack.org/539168 | |
| 14:36:31 | mriedem | tssurya: this was merged out of order imo https://review.openstack.org/#/c/555417/ | |
| 14:36:37 | mriedem | since the scheduler patch to filter disabled cells isn't merged yet | |
| 14:39:16 | mriedem | i guess if we get https://review.openstack.org/#/c/550527/ in soon then it's not a big deal | |
| 14:39:57 | dansmith | I think these got re-ordered at some point, | |
| 14:40:06 | dansmith | because the doc patch is before the update_cell patch it talks about | |
| 14:40:12 | dansmith | so maybe just an accident | |
| 14:41:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove duplicate 'vnc' config opt descriptions https://review.openstack.org/534724 | |
| 14:41:35 | stephenfin | mriedem: Fancy hitting that? ^ | |
| 14:41:46 | stephenfin | there's a couple of those in the old admin guide (as you've seen) | |
| 14:41:55 | mriedem | stephenfin: yeah after the scheduler meeting | |
| 14:41:59 | stephenfin | (y) | |
| 14:42:05 | mriedem | dansmith: ok that series should probably be rebased then, and the docs patch should come at the end | |
| 14:42:11 | mriedem | i'll look at the scheduler patch after the scheduling meeting | |
| 14:42:21 | dansmith | mriedem: I -1d the docs patch so it should be okay until after, | |
| 14:42:40 | dansmith | mriedem: it's actually not a linear set anymore | |
| 14:42:56 | mriedem | yeah i see that now, which is why the create_cell change merged probably | |
| 14:43:00 | mriedem | anywho | |
| 14:43:09 | dansmith | yeah, not a huge deal to me, but whatever you want | |
| 14:43:20 | mriedem | johnthetubaguy: can i get you to come back on this nova-status ironic flavor migratoin patch? https://review.openstack.org/#/c/527541/ | |
| 14:43:24 | kashyap | Dan / Matt, when you get a moment, does this look better? https://review.openstack.org/#/c/534384/15/nova/virt/libvirt/driver.py | |
| 14:43:31 | mriedem | i don't think we can drop the ironic flavor migration stuff in the driver until nova-status has a check for it | |
| 14:43:31 | kashyap | (Tests pass, and also release note builds.) | |
| 14:43:55 | mriedem | kashyap: what happened to putting a 'choices' or hard-coding the only option to pcie for the backport? | |
| 14:44:16 | mriedem | not a different option, but restricting the single choice for the backport and then opening it up on master | |
| 14:44:18 | kashyap | mriedem: Yep, that's what I did. But, the check is in driver.py | |
| 14:44:22 | mriedem | oh | |
| 14:44:27 | kashyap | mriedem: That's exactly what I did :-) | |
| 14:44:36 | mriedem | why not 'choices' kwarg on the config option itself? | |
| 14:44:41 | kashyap | Because, there's no 'choices' for ListOpt() for Oslo class | |
| 14:44:47 | kashyap | Only for StrOpt(0 | |
| 14:44:47 | efried | see dev ML :) | |
| 14:44:55 | efried | kashyap: Propose it! | |
| 14:45:05 | mriedem | ok, i guess that doesn't surprise me | |
| 14:45:23 | dansmith | man the queues are deep | |
| 14:45:30 | kashyap | efried: Heh :-) Haven't checked the list responses yet, still ploughing through other stuff | |
| 14:45:47 | efried | I don't know if anyone responded thusly. That was off the cuff. | |
| 14:46:08 | kashyap | dansmith: Hey, since you're a stickler for words, I'd love if you see any grammatical mistakes in the release note (I spent 3 hours writing it) | |
| 14:46:37 | kashyap | dansmith: 'Grr'it is slow for me; but here's a quick-loading file: https://review.openstack.org/#/c/534384/15/nova/virt/libvirt/driver.py | |
| 14:46:46 | kashyap | Err, "wrong" URL :P -- https://kashyapc.fedorapeople.org/libvirt-cpu-model-extra-flags-a23085f58bd22d27.yaml.txt | |
| 14:46:50 | tssurya | mriedem: oops | |
| 14:47:32 | tssurya | mriedem: I guess they did get merged out of order | |
| 14:48:32 | dansmith | kashyap: in a bit | |
| 14:48:34 | tssurya | dansmith, mriedem: dansmith has a comment on the debug stuff in the main filter patch, | |
| 14:48:44 | tssurya | I will fix it and we can merge that soon | |
| 14:49:05 | kashyap | dansmith: No rush at all. In an hour-ish, I'll be disappearing to my Dutch class, so I'll respond to questions on the review (if you have them) | |
| 14:53:14 | openstackgerrit | Eric Fried proposed openstack/nova master: Unit test framework: common FakeResponse https://review.openstack.org/556551 | |
| 14:53:20 | efried | mriedem: You are interested in this ^ | |
| 14:54:23 | mriedem | i am interested in that yes | |
| 14:55:06 | efried | mriedem: (While I was reviewing https://review.openstack.org/#/c/556334/1/nova/tests/unit/network/test_neutronv2.py) | |
| 14:55:28 | mriedem | yeah i figured | |
| 14:55:39 | mriedem | i was going to get there eventually | |
| 14:55:49 | efried | mriedem: But note that I implemented it differently than the one in test_identity. | |
| 14:56:43 | openstackgerrit | Tyler Blakeslee proposed openstack/nova master: Add __repr__ for NovaException https://review.openstack.org/555812 | |
| 14:58:18 | mriedem | fix the typo and i'm +2 | |
| 15:00:00 | openstackgerrit | Eric Fried proposed openstack/nova master: Unit test framework: common FakeResponse https://review.openstack.org/556551 | |
| 15:00:11 | efried | mriedem: Done. Though I kinda like 'evalue'. | |
| 15:00:16 | gibi | jaypipes: do you have a minute for discussing the vnic_type issue or you prefer to have my reply in the review? | |
| 15:03:28 | tssurya | dansmith, mriedem: do you guys have some time now for a question ? | |
| 15:03:49 | dansmith | tssurya: shoot | |
| 15:04:03 | mriedem | efried: i lied | |