| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-26 | |||
| 12:54:33 | bauzas | I guess some relnote had a problem | |
| 12:54:41 | bauzas | hence the sphinx build error | |
| 12:54:47 | bauzas | but the rst page itself is empty | |
| 12:55:04 | bauzas | that's only reno which generates that file using the sphinx ext | |
| 12:55:25 | stephenfin | kashyap: This is what I did for oslo.config. The reno extension works the same way so the fix should be similar https://review.openstack.org/#/c/554632/ | |
| 12:55:53 | gibi | efried: thanks, looking... | |
| 12:56:44 | stephenfin | kashyap: tl;dr: you need to keep an offset counter as you emit rST lines, and it's worth writing what you generate to temporary file so you can view it | |
| 12:57:01 | kashyap | Yeah, was reading this change: https://review.openstack.org/#/c/554632/1/oslo_config/sphinxext.py | |
| 12:57:04 | stephenfin | kashyap: I'm pretty sure there's a better way to do it (maybe dumping the offending lines to the terminal) but I haven't figure it out | |
| 12:57:11 | kashyap | Thanks for the summary. | |
| 12:57:53 | gibi | efried: thanks for the namespacing alternative. Will it mean that Neutron can say in the port that 'resources-neutron-1': {'BW': 10000} ? | |
| 12:58:11 | efried | gibi: Yeah, something like that. | |
| 12:58:25 | kashyap | stephenfin: Right now I don't have time to fix 'reno', I wonder what I can do to figure out what needs to be fixed in this:https://review.openstack.org/#/c/534384/14/releasenotes/notes/libvirt-cpu-model-extra-flags-a23085f58bd22d27.yaml | |
| 12:58:53 | efried | gibi: Since we haven't connected the final dots on granular even for intra-nova cases, we probably still have the flexibility to flip to using resources-nova-N there. | |
| 12:59:15 | edleafe | efried: Looks like you got your answer. I'm just dragging myself to start working at 8am. | |
| 12:59:20 | gibi | efried: so to keep ports separate it should look more like resources-neutron-<port-uuid> | |
| 12:59:23 | efried | or resources-flavor-N / resources-image-N | |
| 12:59:43 | gibi | or resources-port-<port-uuid> | |
| 13:00:01 | stephenfin | kashyap: It's ugly, but I'd strip it down and start adding parts until it stops working :/ | |
| 13:01:00 | kashyap | stephenfin: Hmm, is there a way locally verify that? Because, 'reno lint .` isn't catching what I need | |
| 13:01:34 | kashyap | (Lest I'll be stuck with this yak) | |
| 13:01:42 | stephenfin | 'tox -e releasenotes' should do the trick | |
| 13:01:47 | kashyap | stephenfin: But did I do anything "fancy" there? I'll see what I can "trip down" | |
| 13:01:50 | kashyap | stephenfin: I did run that | |
| 13:01:56 | kashyap | The _only_ thing that gave me was: | |
| 13:01:57 | stephenfin | and it worked? | |
| 13:02:50 | kashyap | stephenfin: This is what I see: http://paste.openstack.org/show/714071/ | |
| 13:03:06 | kashyap | stephenfin: The same warning I see in the Gate. | |
| 13:03:13 | kashyap | But it doesn't show any problems with my own file | |
| 13:04:50 | stephenfin | It probably is your file that's causing the issue though | |
| 13:04:54 | stephenfin | It's saying the error is in 'unreleased.rst', but that's just because that file contains the 'release-notes' directive | |
| 13:04:58 | kashyap | stephenfin: I see my content in the releasenotes/build/doctrees/unreleased.doctree | |
| 13:05:06 | kashyap | But nothing in the 'html' dir | |
| 13:05:14 | kashyap | Right | |
| 13:05:29 | stephenfin | yeah, there won't be anything in the html directory because the build failed | |
| 13:06:08 | kashyap | Right; I'll check w/ the #openstack-release folks | |
| 13:11:30 | openstackgerrit | Merged openstack/nova master: Modify nova-manage cell_v2 list_cells to display "disabled" column https://review.openstack.org/555415 | |
| 13:16:24 | stephenfin | sahid: Done https://review.openstack.org/#/c/511188/ | |
| 13:17:26 | sahid | stephenfin: thanks, i will address your comments | |
| 13:26:37 | openstackgerrit | Merged openstack/nova master: Add disabled option to create_cell command https://review.openstack.org/555417 | |
| 13:39:14 | jaypipes | morning supernovas | |
| 13:39:25 | gibi | jaypipes: good morning | |
| 13:39:38 | Spazmotic | morning jay | |
| 13:41:12 | gibi | jaypipes: I added reasoning about the need of the vnic_type in https://review.openstack.org/#/c/502306/20/specs/rocky/approved/bandwidth-resource-provider.rst@396 please let me know what you think | |
| 13:41:30 | bauzas | jaypipes: morning | |
| 13:41:36 | bauzas | still working on updating my spec | |
| 13:41:52 | jaypipes | gibi: cool, will do right now. | |
| 13:42:22 | gibi | jaypipes: thanks | |
| 13:43:57 | stephenfin | kashyap: What was the fix? | |
| 13:44:18 | kashyap | stephenfin: I'm embarassed to tell | |
| 13:44:29 | kashyap | stephenfin: But I will tell | |
| 13:44:50 | kashyap | stephenfin: A mis-quoting a CPU model like this: "'Foo" | |
| 13:45:32 | kashyap | stephenfin: (s/mis-quoting a/mis-quoting of a/) And another spurious "::" | |
| 13:46:51 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | |
| 13:47:34 | stephenfin | kashyap: aha. Good to hear you got it sorted :) | |
| 13:48:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add CPUWeigher https://review.openstack.org/379525 | |
| 13:49:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Standardize '_get_XXX_constraint' functions https://review.openstack.org/385071 | |
| 13:50:23 | kashyap | sean-k-mooney: Do you spot anything else here: https://review.openstack.org/#/c/534384/ | |
| 13:50:39 | openstackgerrit | sahid proposed openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set https://review.openstack.org/511188 | |
| 13:50:40 | kashyap | sean-k-mooney: I think it's ready for "prime time". I restricted the options for now to only PCID. | |
| 13:51:15 | kashyap | sean-k-mooney: (To keep it backportable; and in a future patch, remove that restriction, thus making way for other useful stuff.) | |
| 14:03:14 | jaypipes | gibi: done | |
| 14:03:23 | edleafe | Scheduler subteam meeting running now in #openstack-meeting-alt | |
| 14:04:34 | gibi | jaypipes: thanks, I will check after the scheduler meeting | |
| 14:17:02 | openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | |
| 14:23:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Speed things up and document them https://review.openstack.org/534382 | |
| 14:23:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Fix indentation https://review.openstack.org/556543 | |
| 14:23:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383 | |
| 14:23:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Remove unnecessary configuration https://review.openstack.org/556544 | |
| 14:34:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Use new-style choice values https://review.openstack.org/530924 | |
| 14:35:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Add mypy target https://review.openstack.org/538221 | |
| 14:35:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Store list of converted files https://review.openstack.org/538222 | |
| 14:35:42 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.openstack.org/538224 | |
| 14:35:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Add 'mypy' job https://review.openstack.org/539168 | |
| 14:36:31 | mriedem | tssurya: this was merged out of order imo https://review.openstack.org/#/c/555417/ | |
| 14:36:37 | mriedem | since the scheduler patch to filter disabled cells isn't merged yet | |
| 14:39:16 | mriedem | i guess if we get https://review.openstack.org/#/c/550527/ in soon then it's not a big deal | |
| 14:39:57 | dansmith | I think these got re-ordered at some point, | |
| 14:40:06 | dansmith | because the doc patch is before the update_cell patch it talks about | |
| 14:40:12 | dansmith | so maybe just an accident | |
| 14:41:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove duplicate 'vnc' config opt descriptions https://review.openstack.org/534724 | |
| 14:41:35 | stephenfin | mriedem: Fancy hitting that? ^ | |
| 14:41:46 | stephenfin | there's a couple of those in the old admin guide (as you've seen) | |
| 14:41:55 | mriedem | stephenfin: yeah after the scheduler meeting | |
| 14:41:59 | stephenfin | (y) | |
| 14:42:05 | mriedem | dansmith: ok that series should probably be rebased then, and the docs patch should come at the end | |
| 14:42:11 | mriedem | i'll look at the scheduler patch after the scheduling meeting | |
| 14:42:21 | dansmith | mriedem: I -1d the docs patch so it should be okay until after, | |
| 14:42:40 | dansmith | mriedem: it's actually not a linear set anymore | |
| 14:42:56 | mriedem | yeah i see that now, which is why the create_cell change merged probably | |
| 14:43:00 | mriedem | anywho | |
| 14:43:09 | dansmith | yeah, not a huge deal to me, but whatever you want | |
| 14:43:20 | mriedem | johnthetubaguy: can i get you to come back on this nova-status ironic flavor migratoin patch? https://review.openstack.org/#/c/527541/ | |
| 14:43:24 | kashyap | Dan / Matt, when you get a moment, does this look better? https://review.openstack.org/#/c/534384/15/nova/virt/libvirt/driver.py | |
| 14:43:31 | mriedem | i don't think we can drop the ironic flavor migration stuff in the driver until nova-status has a check for it | |
| 14:43:31 | kashyap | (Tests pass, and also release note builds.) | |
| 14:43:55 | mriedem | kashyap: what happened to putting a 'choices' or hard-coding the only option to pcie for the backport? | |
| 14:44:16 | mriedem | not a different option, but restricting the single choice for the backport and then opening it up on master | |
| 14:44:18 | kashyap | mriedem: Yep, that's what I did. But, the check is in driver.py | |
| 14:44:22 | mriedem | oh | |