| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-22 | |||
| 21:02:53 | dansmith | efried: excellent use of proper ITU phonetics | |
| 21:02:53 | cfriesen | sean-k-mooney: not really technical debt. logically the guest shouldn't need to be constantly checking which guest cpus are shared/dedicated. should only need to happen at boot time, or ideally on creation/rebuild | |
| 21:04:06 | sean-k-mooney | cfriesen: yes but it does mean that this is yes another thing the fit_instance_to_host function needs to enforce | |
| 21:04:38 | cfriesen | sean-k-mooney: yes, but it's required as soon as you allow mixed shared/dedicated in one instance. | |
| 21:05:40 | sean-k-mooney | cfriesen: yes which we dont allow today so once its added that fucntion need to be extended to allow passing in a set of mappings and the validate that the would still be correct for the new host. | |
| 21:08:41 | sean-k-mooney | cfriesen: again its doable but https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4364-L4510 is not exactly the most plesant code to debug currently. anyway this time im really leaving | |
| 21:08:44 | sean-k-mooney | o/ | |
| 21:17:50 | cfriesen | jaypipes: so is your overall goal to get rid of the current hw:numa_mem.X=Y, hw:numa_cpu.X=Y, hw:mem_page_size=2048, etc. and specify it all explicitly as placement resources? | |
| 21:18:23 | cfriesen | jaypipes: because the alternative would be to keep them as-is and have nova calculate the allocation | |
| 21:18:43 | dansmith | cfriesen: fwiw, I have't been following all of this today, | |
| 21:19:00 | dansmith | but I'm highly allergic to plans for us trying to automate that fitting of things onto numa nodes | |
| 21:19:13 | dansmith | I don't like that it's manual, but it's a headache I don't really want to own | |
| 21:19:34 | dansmith | so convincing me is going to take some damn fine, simple code and a lot of tests | |
| 21:20:05 | cfriesen | dansmith: so are you suggesting we keep what we have now or require explicit resource specification in the flavor? | |
| 21:20:55 | dansmith | I would expect we'd take the thing we have now and turn it into a granular resource request based on the total, and the pieces you specified per node | |
| 21:21:29 | dansmith | cfriesen: I don't really have a suggestion, I'm just saying, every time I think I could genericify that someone brings up a case they want to support which is hard | |
| 21:22:21 | dansmith | and I expect people that need/use that level of fine-grained control over what the system looks like are doing it for suuuuper specific reasons | |
| 21:22:54 | openstackgerrit | Patricia Domingues proposed openstack/nova master: load up the volume drivers by checking architecture https://review.openstack.org/541393 | |
| 21:23:17 | dansmith | like "I have a custom irreplaceable application that only runs on windows nt 4.0 which has a never-going-to-be-fixed bug where it requires 2MB of memory on the same node as the cdrom's IDE controller or my application fails to read from the light pen" | |
| 21:25:17 | cfriesen | dansmith: nice. | |
| 21:28:59 | cfriesen | If we're going to allow shared/dedicated CPUs within a single instance then we'll need to add some way of specifying at a minimum how many "shared" or "dedicated" vcpus we want in each virtual numa node. Whether that's explicitly via resources or via some other thing that nova factors into the resource allocation request is sort of up in the air. | |
| 21:30:32 | cfriesen | But if we keep the existing fields we have now (which would be nice to avoid breaking people) nova will need to translate that into allocation requests for VCPUS or PCPUS (to use jay's terminology) | |
| 21:31:36 | melwitt | bug possibilities for stable branches | |
| 21:31:36 | melwitt | dansmith, mriedem: I was just looking at https://blueprints.launchpad.net/nova/+spec/libvirt-cpu-model-extra-flags again. is the ability to enable various cpu flags a feature that we would want anyway regardless of the meltdown mitigation? wondering why one of the choices isn't just "enable_pcid = True/False" and leave it at that, for the backport and going forward? that way there's no migration path nor concern about opening up more | |
| 21:31:44 | melwitt | sigh | |
| 21:32:04 | dansmith | melwitt: yeah I think people have wanted that for other reasons | |
| 21:32:17 | dansmith | melwitt: like, choose a lower base cpu but add in avx2 | |
| 21:32:22 | dansmith | or something like that | |
| 21:32:31 | melwitt | okay, I see | |
| 21:32:55 | rybridges | mlavalle: We are not seeing any stacktraces in neutron-server.log or in nova-api.log or in nova-placement-api.log. It looks like the association is not working on this line: https://github.com/openstack/neutron/blob/stable/ocata/neutron/services/segments/plugin.py#L225 Nothing after that line is being executed. But we dont see errors or stack traces. When we look at the resource_providers in | |
| 21:32:57 | rybridges | placement, the segment is there and registered as a resource provider, but the aggregate is not associated with it. | |
| 21:33:05 | dansmith | melwitt: you can already configure your cpu model to be different and break live migration, so this wouldn't be any different | |
| 21:35:23 | melwitt | okay. if it's a feature that has utility going forward (specifying various flags) then I'm inclined to favor the idea of backporting it as the full-fledged feature being that the risk is lower than the upgrade pain for operators to go from a [workarounds] option -> cpu_model_extra_flags | |
| 21:35:58 | dansmith | melwitt: did you see my latest suggestion on the patch? | |
| 21:36:12 | melwitt | no, looking now | |
| 21:36:39 | dansmith | melwitt: backporting it with a restriction that pcid is the only thing you can put in that option would eliminate the general-purpose use of it without causing the deployment pain | |
| 21:36:53 | melwitt | ah, I see. that's a nice idea | |
| 21:37:42 | melwitt | I think that addresses all of the concerns | |
| 21:37:46 | dansmith | me too | |
| 21:37:55 | melwitt | noice | |
| 21:38:22 | melwitt | what do you think of that mriedem? | |
| 21:39:40 | mriedem | so the backport has the choices kwarg with a single item? | |
| 21:39:52 | mriedem | and we drop choices in master? | |
| 21:39:56 | dansmith | that's one way yeah | |
| 21:40:05 | dansmith | well, I'm asking right now if we want a list anyway | |
| 21:40:25 | dansmith | or some sort of reasonable validation | |
| 21:40:26 | dansmith | if we can get the list of all options from libvirt or something | |
| 21:41:23 | mriedem | cpu_map.xml comes back in the libvirt host capabilities stuff we already have i think | |
| 21:41:26 | mriedem | we dump it on startup to the logs | |
| 21:41:31 | melwitt | yeah, I was thinking maybe we have choices and there's only one choice in the backport and going forward there will be a set of choices we know are good? or are there just too many to reasonable do it that way | |
| 21:41:42 | dansmith | yeah, so I would think we should validate what they give us anyway, so we don't just generate broken xml | |
| 21:41:48 | dansmith | but that would be later than in conf choices | |
| 21:42:33 | mriedem | http://logs.openstack.org/84/534384/9/check/tempest-full/a66bf1a/controller/logs/screen-n-cpu.txt.gz#_Mar_22_13_34_01_146931 | |
| 21:43:07 | mriedem | i would say, (1) backportable version has just a single choice, pcied or whatever, and then (2) another patch, master-only, drops choices and we validate on startup of the driver based on the host capabilities | |
| 21:43:09 | mriedem | not in config | |
| 21:43:23 | dansmith | that's cool, | |
| 21:43:38 | dansmith | although I think just landing it with the validation and restricted choice would be fine too | |
| 21:43:48 | dansmith | but if you like it being smaller with no validation then that's cool | |
| 21:44:21 | mriedem | oh i don't care if we add the validation in the backport change too | |
| 21:44:30 | mriedem | if that's reliable | |
| 21:44:41 | mriedem | i'm not sure what in ^ is the thing we would use to validate | |
| 21:44:53 | mriedem | the cpu features? | |
| 21:45:07 | mriedem | http://logs.openstack.org/84/534384/9/check/tempest-full/a66bf1a/controller/logs/screen-n-cpu.txt.gz#_Mar_22_13_34_01_148516 | |
| 21:45:09 | melwitt | yeah, if there's a chance that pcid could fail validation, then it would be good to validate it before going ahead | |
| 21:45:14 | dansmith | I think, but kashyap did say at one point it wasn't obvious and we couldn't automate the enabling of this too, | |
| 21:45:20 | dansmith | so we might be barking up the wrong tree | |
| 21:45:31 | dansmith | either way it doesn't matter.. if we can, we should, if we can't, then we won't :) | |
| 21:45:50 | dansmith | I already asked on the review so we'll see what he says | |
| 21:45:58 | mriedem | good luck | |
| 21:46:15 | melwitt | okay, I'll approve the bp with a summary of what we agreed on the approach | |
| 21:46:31 | dansmith | oh I thought we had already agreed to approve it | |
| 21:46:52 | melwitt | we did, I meant more the approach part | |
| 21:47:08 | melwitt | I hadn't approved it yet while we were debating how to go forward | |
| 21:47:23 | dansmith | alright | |
| 21:53:25 | sean-k-mooney | discussing https://review.openstack.org/#/c/534384/ ? | |
| 21:53:35 | mlavalle | rybridges: that's odd. I have a meeting in 5 min and then I have to run. can I ping you tomorrow? | |
| 21:55:32 | rybridges | mlavalle: sure dude! Thanks for the help today | |
| 21:56:12 | mlavalle | rybridges: :-) what's your time zone? I'm in US Central (Austin) | |
| 22:02:42 | openstackgerrit | Julia Kreger proposed openstack/nova master: WIP: Add microversion to ironic client wrapper call https://review.openstack.org/554762 | |
| 22:08:53 | rybridges | mlavalle PST (California) | |
| 22:09:18 | rybridges | I'll be in 8am-7pm PST | |
| 22:09:24 | mlavalle | ok cool | |
| 22:32:22 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Teardown networking when rolling back live migration even if shared disk https://review.openstack.org/555481 | |
| 22:34:12 | openstackgerrit | Patricia Domingues proposed openstack/nova master: load up the volume drivers by checking architecture https://review.openstack.org/541393 | |
| 22:44:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Teardown networking when rolling back live migration even if shared disk https://review.openstack.org/555481 | |
| 22:44:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DRY up test_rollback_live_migration_set_migration_status https://review.openstack.org/555489 | |
| 23:45:52 | Spazmotic | Morning folks | |
| #openstack-nova - 2018-03-23 | |||
| 00:18:13 | openstackgerrit | melissaml proposed openstack/nova-specs master: fix typos in documentation https://review.openstack.org/545528 | |
| 00:24:47 | openstackgerrit | Merged openstack/nova master: Add disabled field to CellMapping object https://review.openstack.org/550090 | |
| 00:24:59 | openstackgerrit | Merged openstack/nova master: Add CellMappingList.get_by_disabled() query method https://review.openstack.org/550188 | |
| 00:42:34 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Parse placement forbidden traits query string https://review.openstack.org/554665 | |
| 01:07:44 | openstackgerrit | Merged openstack/nova stable/queens: Make archive_deleted_rows handle a missing CONF.api_database.connection https://review.openstack.org/553742 | |
| 01:25:29 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/555576 | |
| 01:50:11 | openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/555590 | |
| 02:11:48 | openstackgerrit | Merged openstack/nova stable/ocata: Don't try to delete build request during a reschedule https://review.openstack.org/529703 | |
| 02:21:28 | openstackgerrit | Patricia Domingues proposed openstack/nova master: load up the volume drivers by checking architecture https://review.openstack.org/541393 | |
| 03:28:25 | openstackgerrit | jichenjc proposed openstack/nova master: remove a comment about ec2 https://review.openstack.org/555615 | |
| 03:29:35 | openstackgerrit | Merged openstack/nova master: Migrate tempest-dsvm-cells job to an in-tree job definition https://review.openstack.org/549780 | |
| 03:42:49 | openstackgerrit | licanwei proposed openstack/nova master: Make nova-manage capable of syncing all cell databases https://review.openstack.org/519275 | |
| 04:44:35 | neha_alhat_ | Hi All, I just want to know which ubuntu version supports libvirt version >= 3.10? | |