| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-15 | |||
| 14:13:44 | alex_xu_ | mriedem: does make sense to move the get_compute_nodes before the state change https://review.openstack.org/#/c/401009/9/nova/compute/api.py@4222 ? | |
| 14:13:57 | alex_xu_ | it pretty looks like an API layer check. | |
| 14:14:05 | belmoreira | thanks | |
| 14:14:43 | mriedem | alex_xu_: i wouldn't be opposed to that, replied | |
| 14:14:55 | alex_xu_ | mriedem: ok | |
| 14:15:18 | mriedem | belmoreira: https://github.com/openstack/nova/commit/c99fc64271f41a028c75e96348813f673d04e245 | |
| 14:16:26 | mriedem | NUMATopologyFilter isn't enabled by default, but i know a lot of people use it | |
| 14:17:19 | mriedem | if we had someone that was familiar enough with both nova and ironic (cough jroll johnthetubaguy mgoddard_ cough) we could have them play around with updating an ironic CI job to not use the ironic host manager and baremetal filters and see what breaks | |
| 14:18:20 | mgoddard_ | mriedem can I offer you a throat sweet? | |
| 14:18:31 | mriedem | wtf | |
| 14:18:39 | mgoddard_ | for your cough | |
| 14:18:40 | mriedem | is that british for "i'm going to slit your throat?" | |
| 14:18:42 | mriedem | oh | |
| 14:19:08 | mgoddard_ | oh wow, crossed wires there | |
| 14:19:26 | mriedem | i consider phlegm a feature so no thanks | |
| 14:19:41 | dansmith | PaaS - Phlegm as a Service? | |
| 14:19:42 | mgoddard_ | I could take a look at this | |
| 14:20:12 | mriedem | i'm having trouble remembering off the top of my head what it was about the NUMATopologyFilter that makes it not work with ironic | |
| 14:20:23 | dansmith | mriedem: that needs fixing if so | |
| 14:20:54 | dansmith | maybe we could get stephenfin or someone to look at that once we know it's really a problem | |
| 14:21:13 | stephenfin | I didn't do it | |
| 14:22:16 | stephenfin | I've never used ironic so I'm probably not your guy | |
| 14:22:28 | mriedem | apparently ironic has a CI job (or defalut?) to use resource classes so they don't use the ironic hos tmanager https://review.openstack.org/#/c/499106/ | |
| 14:23:08 | mgoddard_ | yes, ironic devstack plugin uses resource classes by default | |
| 14:23:18 | mriedem | good news, mogan does too http://codesearch.openstack.org/?q=IRONIC_USE_RESOURCE_CLASSES&i=nope&files=&repos= | |
| 14:23:33 | dansmith | stephenfin: we need someone that understands the numa filter not necessarily ironic | |
| 14:23:44 | stephenfin | Oh, that I can do | |
| 14:23:53 | dansmith | mriedem: but no numafilter presumably | |
| 14:24:22 | mriedem | nope, so i think i can just hack up devstack and say don't use the baremetal filters and add numatopologyfilter to the list of default enabled filters and see what blows up | |
| 14:24:30 | dansmith | ack | |
| 14:24:46 | mriedem | and then report a bug to stephenfin | |
| 14:24:53 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: WIP: VMware: implement get_serial_console https://review.openstack.org/553411 | |
| 14:25:00 | stephenfin | 🎉 | |
| 14:25:11 | mriedem | is that a lego brick? a touch tone phone? | |
| 14:25:27 | dansmith | party horn? | |
| 14:25:31 | stephenfin | https://emojipedia.org/party-popper/ | |
| 14:25:46 | mriedem | oh, doesn't render for me | |
| 14:25:49 | mriedem | pidgin | |
| 14:25:57 | stephenfin | Windows? | |
| 14:26:01 | mriedem | yeah | |
| 14:26:47 | stephenfin | But yeah, assign me to that. Soon as I get my server back, I can take a look | |
| 14:26:54 | stephenfin | I'm on spec review duty all day today | |
| 14:33:52 | mriedem | test patch https://review.openstack.org/553412 | |
| 14:33:56 | mriedem | mgoddard_: ^ | |
| 14:35:33 | mgoddard_ | mriedem: nice, I'll keep an eye on it | |
| 14:40:15 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Get resource provider by uuid or name https://review.openstack.org/527791 | |
| 14:41:43 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Few correction in the server filter/sort spec https://review.openstack.org/527019 | |
| 14:44:29 | Spaz-Home | dansmith, I confirmed either Jianghua or Niachuan will be at the meeting later today, sir. You should be good to go on reviewing that spec with them. | |
| 14:44:50 | Spaz-Home | Time for me to head to bed.. have a good day folks. | |
| 14:45:16 | dansmith | Spaz-Home: niachuan asked us to do the meeting for him because he can't join | |
| 14:45:18 | dansmith | which I will | |
| 14:45:22 | dansmith | but yeah | |
| 14:45:25 | Spaz-Home | Ahh that's unfortunate | |
| 14:45:27 | Spaz-Home | It's hard on our hours | |
| 14:47:32 | mriedem | bhagyashri_s: i've abandoned your spec since it looks, well, abandoned https://review.openstack.org/#/c/511825/ | |
| 14:47:51 | mriedem | needs to be moved to the rocky directory structure and incorporate the direction from the PTG | |
| 14:51:45 | mriedem | simondodsley: are you going to move this to rocky? https://review.openstack.org/#/c/340168/ it's proposed against pike | |
| 14:54:06 | mriedem | sean-k-mooney: does anyone care about this anymore? https://review.openstack.org/#/c/471815/ | |
| 14:54:20 | mriedem | i don't know if baoli is around anymore re: cisco | |
| 14:54:40 | mriedem | mgagne: ^ seems like something that would be up your alley | |
| 14:56:03 | mriedem | or vdrok ^ i.e. vlan trunk port metadata bliss | |
| 14:56:44 | openstackgerrit | Nguyen Hai proposed openstack/python-novaclient master: Fix local test fails with pypy https://review.openstack.org/553426 | |
| 14:57:24 | openstackgerrit | Nguyen Hai proposed openstack/python-novaclient master: Fix local test fails with pypy https://review.openstack.org/553426 | |
| 15:00:00 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add disabled field to CellMapping object https://review.openstack.org/550090 | |
| 15:00:20 | mgagne | mriedem: thanks for the heads-up | |
| 15:00:22 | dansmith | mriedem: comments in that rebuild-bfv spec | |
| 15:00:27 | mriedem | mgagne: do you still plan on pushing this spec? https://review.openstack.org/#/c/312626/ it's targeted at pike and would need to be moved to rocky and address reviewer feedback | |
| 15:00:49 | dansmith | mriedem: I might be the only one, but doing a create, delete and re-pointing at a new volume seems like not a great experience to me | |
| 15:01:58 | efried | I assume (because I've not seen it done) that it's Wrong to point to specs from comments/docstrings. | |
| 15:03:26 | efried | Reason I ask: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/update-provider-tree.html#computedriver-update-provider-tree contains a lot more information than I want to put into https://github.com/openstack/nova/blob/master/nova/virt/driver.py#L833 | |
| 15:03:40 | efried | But that information sure would be useful for people implementing that method. | |
| 15:03:59 | mriedem | efried: just say "see the update_provider_tree spec for more details" | |
| 15:04:01 | mriedem | or something | |
| 15:04:21 | efried | Can I say "rocky" too? | |
| 15:04:33 | efried | That'd give them enough info to find it in one shot. | |
| 15:04:36 | mriedem | sure | |
| 15:04:46 | mriedem | or, move the dev details of that spec into devref | |
| 15:05:16 | mriedem | https://docs.openstack.org/nova/latest/reference/index.html | |
| 15:06:57 | dansmith | mriedem: tested by a real live person: https://review.openstack.org/#/c/552691 | |
| 15:06:59 | dansmith | per your ask | |
| 15:08:04 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add disabled field to CellMapping object https://review.openstack.org/550090 | |
| 15:08:51 | openstackgerrit | Claudiu Belu proposed openstack/nova-specs master: Adds spec for instance live resize https://review.openstack.org/141219 | |
| 15:08:51 | efried | mriedem: And then can I link to the devref, or do I still have to say, "See the [name] section of the devref for details" ? | |
| 15:12:23 | mriedem | efried: idk, choose your own adventure | |
| 15:12:48 | mriedem | linking to a devref is probably ok, the spec URL is long as hell | |
| 15:16:15 | mriedem | dansmith: agree the create/delete volume thing sucks | |
| 15:16:27 | mriedem | don't know how easy it would be for cinder to add an api to re-image a volume | |
| 15:16:30 | mriedem | smcginnis: ^? | |
| 15:17:23 | smcginnis | So detach, re-lay down an image on the vol, reattach? | |
| 15:17:27 | openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/553255 | |
| 15:17:46 | mriedem | not sure if we'd need the detach/re-attach part | |
| 15:17:50 | dansmith | smcginnis: yeah | |
| 15:17:51 | mriedem | but that's what happens during rebuild anyway yeah | |
| 15:17:54 | dansmith | mriedem: I assume we would for some backends | |
| 15:17:55 | mdbooth | mriedem: Would you mind taking a look at https://review.openstack.org/#/c/551302/ ? I think it's your bailiwick. | |
| 15:18:34 | mriedem | is a bailiwick related to a throat sweet? | |
| 15:18:51 | smcginnis | mriedem: I think we would need the detach reattach. | |
| 15:19:03 | smcginnis | We need to attach it to a cinder node to reimage it. | |
| 15:19:04 | mriedem | smcginnis: that's fine probably b/c we do it anyway for rebuild | |
| 15:19:14 | smcginnis | Unless nova wants to take care of that part and leave cinder out of it. | |