Earlier  
Posted Nick Remark
#openstack-nova - 2018-03-15
13:54:30 jaypipes efried: no biggie though, really
13:55:01 efried cdent: Okay. Note that there's places we don't do that, elsewhere in the report client. A big enough deal to put up a patch to fill those in?
13:55:08 cdent no
13:55:33 cdent It's, as jay says, no biggie, but if you're adding something new may as well make the version explicit, even if it is the base
13:55:59 alex_xu_ that method is only used for create root rp?
13:56:02 edleafe It also looks consistent in that block to have a version in both
13:56:30 cdent that will help make things more clear if at some point you do need to add a parent or something there and it doesn't work and you're all wtf, why is this not taking my parent, oh the versin
13:57:10 efried fixing.
13:57:13 efried alex_xu_: yes
13:57:26 efried oh
13:57:29 efried maybe not. Stand by.
13:58:05 efried Hah, you're right, it can assign a parent. So my change was blatantly wrong on that point. Good catch, alex_xu_. Fixing...
13:58:59 openstackgerrit Eric Fried proposed openstack/nova master: Stop assuming initial provider generation is 0 https://review.openstack.org/548975
13:59:01 efried alex_xu_, jaypipes, cdent: Done ^
13:59:50 ratailor alex_xu_, jaypipes could you pl have a look at https://review.openstack.org/#/c/401009/
14:03:07 belmoreira dansmith, mriedem in my cellsV1/V2 migration plan I have some issues that I would like to discuss you. Let me know when you are available
14:08:23 openstackgerrit Rajesh Tailor proposed openstack/nova master: Reset instance status on invalid host https://review.openstack.org/401009
14:08:27 dansmith belmoreira: go for it
14:08:57 belmoreira thanks dansmith
14:09:03 belmoreira We use the same cloud to deploy VMs and baremetal. Baremetal is dedicated to few cells.
14:09:22 belmoreira When consolidating the scheduler at top level (not per cell as in cellsV1) not seeing how can dedicate schedulers to ironic cells because they need the baremetal_filters enabled.
14:09:45 dansmith belmoreira: the baremetal filters are deprecated
14:10:27 dansmith belmoreira: the way of the light is custom resource classes for the ironic nodes, and flavors configured to give you the right thing when you ask, which makes scheduling uniform
14:11:04 belmoreira I missed that
14:11:07 mriedem there was a caveat with dropping the ironic host manager for the scheduler, would have to dig it back up,
14:11:32 mriedem but i think it's that not all filter scheduler filters will be able to handle baremetal instances, numatopologyfilter specifically i think
14:12:42 belmoreira I'm finding the release notes about this. thanks
14:12:54 mriedem i'll be damned if i can find the way to those docs in ironic via their homepage
14:13:15 belmoreira :)
14:13:18 mriedem belmoreira: https://docs.openstack.org/ironic/latest/install/configure-nova-flavors.html#scheduling-based-on-resource-classes
14:13:21 mriedem search box ftw
14:13:44 alex_xu_ mriedem: does make sense to move the get_compute_nodes before the state change https://review.openstack.org/#/c/401009/9/nova/compute/api.py@4222 ?
14:13:57 alex_xu_ it pretty looks like an API layer check.
14:14:05 belmoreira thanks
14:14:43 mriedem alex_xu_: i wouldn't be opposed to that, replied
14:14:55 alex_xu_ mriedem: ok
14:15:18 mriedem belmoreira: https://github.com/openstack/nova/commit/c99fc64271f41a028c75e96348813f673d04e245
14:16:26 mriedem NUMATopologyFilter isn't enabled by default, but i know a lot of people use it
14:17:19 mriedem if we had someone that was familiar enough with both nova and ironic (cough jroll johnthetubaguy mgoddard_ cough) we could have them play around with updating an ironic CI job to not use the ironic host manager and baremetal filters and see what breaks
14:18:20 mgoddard_ mriedem can I offer you a throat sweet?
14:18:31 mriedem wtf
14:18:39 mgoddard_ for your cough
14:18:40 mriedem is that british for "i'm going to slit your throat?"
14:18:42 mriedem oh
14:19:08 mgoddard_ oh wow, crossed wires there
14:19:26 mriedem i consider phlegm a feature so no thanks
14:19:41 dansmith PaaS - Phlegm as a Service?
14:19:42 mgoddard_ I could take a look at this
14:20:12 mriedem i'm having trouble remembering off the top of my head what it was about the NUMATopologyFilter that makes it not work with ironic
14:20:23 dansmith mriedem: that needs fixing if so
14:20:54 dansmith maybe we could get stephenfin or someone to look at that once we know it's really a problem
14:21:13 stephenfin I didn't do it
14:22:16 stephenfin I've never used ironic so I'm probably not your guy
14:22:28 mriedem apparently ironic has a CI job (or defalut?) to use resource classes so they don't use the ironic hos tmanager https://review.openstack.org/#/c/499106/
14:23:08 mgoddard_ yes, ironic devstack plugin uses resource classes by default
14:23:18 mriedem good news, mogan does too http://codesearch.openstack.org/?q=IRONIC_USE_RESOURCE_CLASSES&i=nope&files=&repos=
14:23:33 dansmith stephenfin: we need someone that understands the numa filter not necessarily ironic
14:23:44 stephenfin Oh, that I can do
14:23:53 dansmith mriedem: but no numafilter presumably
14:24:22 mriedem nope, so i think i can just hack up devstack and say don't use the baremetal filters and add numatopologyfilter to the list of default enabled filters and see what blows up
14:24:30 dansmith ack
14:24:46 mriedem and then report a bug to stephenfin
14:24:53 openstackgerrit Radoslav Gerganov proposed openstack/nova master: WIP: VMware: implement get_serial_console https://review.openstack.org/553411
14:25:00 stephenfin 🎉
14:25:11 mriedem is that a lego brick? a touch tone phone?
14:25:27 dansmith party horn?
14:25:31 stephenfin https://emojipedia.org/party-popper/
14:25:46 mriedem oh, doesn't render for me
14:25:49 mriedem pidgin
14:25:57 stephenfin Windows?
14:26:01 mriedem yeah
14:26:47 stephenfin But yeah, assign me to that. Soon as I get my server back, I can take a look
14:26:54 stephenfin I'm on spec review duty all day today
14:33:52 mriedem test patch https://review.openstack.org/553412
14:33:56 mriedem mgoddard_: ^
14:35:33 mgoddard_ mriedem: nice, I'll keep an eye on it
14:40:15 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: Get resource provider by uuid or name https://review.openstack.org/527791
14:41:43 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Few correction in the server filter/sort spec https://review.openstack.org/527019
14:44:29 Spaz-Home dansmith, I confirmed either Jianghua or Niachuan will be at the meeting later today, sir. You should be good to go on reviewing that spec with them.
14:44:50 Spaz-Home Time for me to head to bed.. have a good day folks.
14:45:16 dansmith Spaz-Home: niachuan asked us to do the meeting for him because he can't join
14:45:18 dansmith which I will
14:45:22 dansmith but yeah
14:45:25 Spaz-Home Ahh that's unfortunate
14:45:27 Spaz-Home It's hard on our hours
14:47:32 mriedem bhagyashri_s: i've abandoned your spec since it looks, well, abandoned https://review.openstack.org/#/c/511825/
14:47:51 mriedem needs to be moved to the rocky directory structure and incorporate the direction from the PTG
14:51:45 mriedem simondodsley: are you going to move this to rocky? https://review.openstack.org/#/c/340168/ it's proposed against pike
14:54:06 mriedem sean-k-mooney: does anyone care about this anymore? https://review.openstack.org/#/c/471815/
14:54:20 mriedem i don't know if baoli is around anymore re: cisco
14:54:40 mriedem mgagne: ^ seems like something that would be up your alley
14:56:03 mriedem or vdrok ^ i.e. vlan trunk port metadata bliss
14:56:44 openstackgerrit Nguyen Hai proposed openstack/python-novaclient master: Fix local test fails with pypy https://review.openstack.org/553426
14:57:24 openstackgerrit Nguyen Hai proposed openstack/python-novaclient master: Fix local test fails with pypy https://review.openstack.org/553426
15:00:00 openstackgerrit Surya Seetharaman proposed openstack/nova master: Add disabled field to CellMapping object https://review.openstack.org/550090
15:00:20 mgagne mriedem: thanks for the heads-up
15:00:22 dansmith mriedem: comments in that rebuild-bfv spec
15:00:27 mriedem mgagne: do you still plan on pushing this spec? https://review.openstack.org/#/c/312626/ it's targeted at pike and would need to be moved to rocky and address reviewer feedback
15:00:49 dansmith mriedem: I might be the only one, but doing a create, delete and re-pointing at a new volume seems like not a great experience to me
15:01:58 efried I assume (because I've not seen it done) that it's Wrong to point to specs from comments/docstrings.

Earlier   Later