| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-14 | |||
| 20:42:37 | edleafe | maybe it's on hulu? | |
| 20:42:52 | mriedem | idk, but i wouldn't advice trying to find it | |
| 20:42:55 | dansmith | I bet it's on hulu, | |
| 20:43:03 | dansmith | but we're not serious about watching/liking it | |
| 20:43:27 | edleafe | oh sure | |
| 20:43:38 | edleafe | you're just probably embarrassed to admit it | |
| 20:43:47 | dansmith | heh | |
| 20:44:06 | edleafe | it *is* on hulu | |
| 20:44:15 | edleafe | wait - season 22?? | |
| 20:44:17 | dansmith | oh boy, edleafe is in for a treat tonight | |
| 20:44:24 | dansmith | oh yeah man, it's a major deal | |
| 20:44:42 | dansmith | that's why I figured it'd be on hulu.. they couldn't have a subscriber base without it | |
| 20:45:12 | edleafe | oh, they have all sorts of trashy TV: the voice, top model, the kardashians | |
| 20:45:29 | edleafe | I'm so culturally deprived | |
| 20:46:50 | efried | culturally depraved if you watch that crap. Take your pick | |
| 20:47:21 | edleafe | efried: good point | |
| 20:51:00 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: handle DiskNotFound during update_available_resource https://review.openstack.org/553067 | |
| 20:54:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: handle DiskNotFound during update_available_resource https://review.openstack.org/553067 | |
| 20:58:41 | cfriesen | got something wierd, looking for ideas. With libvirt, when you power off a node it calls _destroy() which will loop over the serial ports and call serial_console.release_port(). Then in power_on() we end up calling _destroy() again, which could end up releasing serial ports that are now in use by another instance. | |
| 21:00:11 | cfriesen | (I think these are basically TCP ports on the host.) | |
| 21:01:56 | mriedem | mnaser: left a comment in https://review.openstack.org/#/c/553035/ - how do you feel about working that into the commit message before we start a revert party | |
| 21:03:52 | mnaser | mriedem: are you okay with me copypasta-ing that comment and adding co-authored because you seem to have summarized it well | |
| 21:04:06 | mriedem | that's fine | |
| 21:04:12 | mriedem | don't really need the co-author | |
| 21:04:26 | mnaser | okay cool, let me see | |
| 21:07:08 | openstackgerrit | sean mooney proposed openstack/nova master: WIP add mtu to libvirt xml for ethernet and bridge types https://review.openstack.org/553072 | |
| 21:07:22 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553035 | |
| 21:07:36 | mnaser | mriedem: is that ok? if thats okay ill update the other ones | |
| 21:08:02 | mriedem | yeah lgtm | |
| 21:08:09 | mriedem | use the same change id in the stable branch ones too | |
| 21:08:09 | sean-k-mooney | i have not tested the mtu ptach so ignore it for now. ill test it tomorrow and remove the WIP once i add unit test and check it actully works. | |
| 21:08:10 | mriedem | please | |
| 21:08:17 | mnaser | will do | |
| 21:10:15 | arvindn05 | mriedem: jaypipes: updated the spec based on comments Patch set 9 should address the issues https://review.openstack.org/#/c/541507/9 | |
| 21:10:18 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553037 | |
| 21:10:29 | openstackgerrit | Eric Fried proposed openstack/nova master: Stop assuming initial provider generation is 0 https://review.openstack.org/548975 | |
| 21:10:39 | efried | cdent: jaypipes: That 'un is ready now too ^ | |
| 21:10:53 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553038 | |
| 21:10:54 | cdent | rad | |
| 21:11:43 | mnaser | mriedem: apparently changing the id in change-id: <foo> doesn't do it? | |
| 21:12:24 | mnaser | maybe i need to recommit or rebase (i did edited with the ui) | |
| 21:17:25 | mriedem | i figured you could use the ui | |
| 21:21:39 | sean-k-mooney | jaypipes: just on the nic feature based schduling spec https://review.openstack.org/#/c/545951/ | |
| 21:22:43 | sean-k-mooney | i just responed to you comments . i can resping if you want but many of the nits you raised are due to the fact that half of this feature merged in pike since it was feature complete since then | |
| 21:23:42 | sean-k-mooney | moving the nic feature to placement would be cool but they have been stored in the nova db for 2 release now so i would like to finish the use fo them first then port to placement | |
| 21:30:03 | jaypipes | sean-k-mooney: I'm already +2 on that. no need. | |
| 21:33:02 | arvindn05 | jaypipes: quick question on one of your comments | |
| 21:33:21 | arvindn05 | https://review.openstack.org/#/c/541507/ - Don't forget you will need to modify the existing ImageExtraSpecsFilter to ignore keys that start with "trait:", since clearly the placement API will have already filtered out hosts without the required traits... | |
| 21:33:53 | arvindn05 | for the comment mriedem pointed out there is no ImageExtraSpecsFilter. Was there a different filter you had in mind? | |
| 21:34:49 | jaypipes | arvindn05: yeah, it's ImagePropertiesFilter, sorry about that | |
| 21:35:04 | jaypipes | arvindn05: I always forget that it's named differently. | |
| 21:35:08 | mriedem | ImagePropertiesFilter only cares about 3 specific image props | |
| 21:35:23 | mriedem | should probably be renamed | |
| 21:35:30 | jaypipes | orly? | |
| 21:35:31 | mriedem | SuperSpecificImagePropertiesFilter | |
| 21:35:34 | jaypipes | lol | |
| 21:35:37 | jaypipes | TIL... | |
| 21:35:39 | arvindn05 | ^what mriedem said | |
| 21:35:52 | melwitt | ThreeSpecificImagePropertiesFilter | |
| 21:35:57 | mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L46 | |
| 21:36:07 | arvindn05 | actually 4 properties looks like.. | |
| 21:36:09 | jaypipes | efried: "bogosity". well played. | |
| 21:36:15 | arvindn05 | if i trust the documentation :) | |
| 21:36:17 | melwitt | FourSpecificImagePropertiesFilter | |
| 21:36:25 | jaypipes | lol | |
| 21:36:31 | arvindn05 | architecture,hypervisor_type,hypervisor_version_requires,vm_mode | |
| 21:36:38 | efried | jaypipes: I calls 'em like I sees 'em | |
| 21:38:15 | jaypipes | arvindn05: don't forget the illustrative "i_am_nfv_and_do_what_want" property. | |
| 21:38:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Change TestNewtonCellsCheck to not rely on objects https://review.openstack.org/553082 | |
| 21:38:30 | mriedem | the value is a wildcard right? | |
| 21:38:52 | mriedem | dansmith: melwitt: ^ is the thing tssurya needed | |
| 21:39:02 | jaypipes | mriedem: on Tuesdays. on Wednesdays it's a reverse wildcard. On Thursday it's a regex and on Friday it's all whitespace. | |
| 21:39:04 | melwitt | jaypipes: been meaning to ask you, were you gonna update this unit test to do the BFV thing? or I can try to help with that if you want. if possible, I want to backport that all the way to ocata where it broke https://review.openstack.org/#/c/538310/2/nova/tests/unit/virt/libvirt/test_driver.py@3722 | |
| 21:39:04 | arvindn05 | lol | |
| 21:39:49 | jaypipes | melwitt: I'd definitely appreciate a hand on that one. | |
| 21:40:03 | melwitt | jaypipes: cool, I'll take a stab at it | |
| 21:40:09 | jaypipes | melwitt: tyvm | |
| 21:49:54 | jaypipes | efried: issue in https://review.openstack.org/#/c/548249/ | |
| 21:50:05 | efried | ack | |
| 21:50:49 | efried | jaypipes: Oh - cdent and I discussed this at the ptg | |
| 21:50:57 | jaypipes | efried: oh? | |
| 21:51:09 | jaypipes | heh | |
| 21:51:15 | efried | he assured me the exception wasn't possible anymore | |
| 21:51:27 | cdent | https://review.openstack.org/#/c/548249/2/nova/objects/resource_provider.py@493 | |
| 21:51:41 | mriedem | arvindn05: +2 on https://review.openstack.org/#/c/541507/ now, thanks | |
| 21:51:44 | cdent | I did not assure you! I said I couldn't see how it could happen. | |
| 21:51:55 | cdent | Entirely different, sirrah. | |
| 21:51:58 | cdent | I may be blind | |
| 21:52:27 | jaypipes | efried, cdent: pretty sure it's still possible. | |
| 21:52:30 | efried | You totally assured me | |
| 21:52:38 | efried | listen to the tape | |
| 21:52:54 | jaypipes | efried, cdent: plus, defensive coding and all that... | |
| 21:53:10 | efried | shrug, okay | |
| 21:53:45 | arvindn05 | mriedem: thanks for the +2 :) | |
| 21:53:54 | cdent | it was conversation that would have been nice to have jaypipes at because we were both struggling to conceptualize how the transaction was operating | |
| 21:54:10 | cdent | and that without that it was all speculation and we didn't know how/if to even test it | |
| 21:54:12 | arvindn05 | now just need to bother jaypipes for his original +2 :) | |
| 21:55:31 | jaypipes | cdent: it's not necessarily about the transaction itself (or how it operates). it's about the consistent read view. another process could have modified the same resource provider in between the time when we originally began the transaction and when we go to incremenet the generation. | |
| 21:55:32 | cdent | so, jaypipes, if we ever get a clear moment to talk through that, it would be cool. probably wants a whiteboard though, so perhaps vancouver | |
| 21:56:15 | cdent | well that's exactly the part we couldn't conceptualize how/when does the read view change? | |