| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-12 | |||
| 20:23:02 | dansmith | efried: consider me suitably thrown under the bus for my method naming | |
| 20:24:57 | efried | dansmith: You're not held accountable for sample code in pastebin. Else I would have griped at you about having the + case first and the - case the default. | |
| 20:25:56 | dansmith | else should have raised | |
| 20:26:37 | mriedem | efried: with ^ how can i integrate that with https://review.openstack.org/#/c/538498/ where i'm not in a virt driver with a provider tree - or will that RT code eventually have the provider tree object so i can call add_traits there? | |
| 20:28:05 | mriedem | alternatively, if the RT isn't the place to do that and the virt driver is, i could add a generic method in the base ComputeDriver class that handles adding traits from the capabilities dict | |
| 20:28:29 | dansmith | mriedem: virt driver can do that from u_p_t he's describing here | |
| 20:28:45 | mriedem | right, but i don't want to copy the same thing in all virt drivers | |
| 20:28:49 | dansmith | but better for compute to do it right where it's calling into the virt driver | |
| 20:28:51 | mriedem | so RT or base class, i'm ok with either | |
| 20:28:52 | dansmith | call the capabilities compute-owned | |
| 20:29:03 | efried | mriedem: I'm glad you asked. I believe you should get the traits from placement and add in those you got from _get_traits (which is the union of those from virt & capabilities). | |
| 20:29:06 | mriedem | the compute isn't calling this, the RT is | |
| 20:29:10 | dansmith | yeah, wherever we call that in the virt driver from | |
| 20:29:22 | mriedem | i don't know what the RT will have the UPT | |
| 20:29:25 | dansmith | efried: eh? | |
| 20:29:29 | mriedem | maybe it will and i'm just behind | |
| 20:29:49 | mriedem | efried: i'm not sure why i need to call placement, | |
| 20:29:53 | dansmith | efried: we get them from the virt driver structure, we can just generate the traits that go with them and tack them onto the provider tree for the compute node RP | |
| 20:29:56 | mriedem | i want to *always* report these capabilities | |
| 20:29:58 | dansmith | mriedem: you wouldn't | |
| 20:29:59 | dansmith | right | |
| 20:30:09 | dansmith | these are compute-asserted traits, IMHO | |
| 20:30:56 | mriedem | telling me, "go look at the UPT series of changes and figure it out" is acceptable also | |
| 20:31:42 | efried | mriedem: If we can slot your change into the UPT series, that would make things easier to reason about. Having to decide what it would look like in all three possible permutations is harder. | |
| 20:32:04 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Network interface attach/detach https://review.openstack.org/546813 | |
| 20:32:10 | dansmith | mriedem: https://review.openstack.org/#/c/520246/52/nova/compute/resource_tracker.py L884 there I think | |
| 20:32:43 | dansmith | logically it's compute, but mechanically it's RT because that's what owns the compute node RP | |
| 20:32:52 | mriedem | ok that works for me, i can rebase on top of that | |
| 20:32:55 | efried | mriedem: If we do your change *after* https://review.openstack.org/#/c/520246/ then you can use the prov_tree to merge in the capability traits and then call update_from_provider_tree. | |
| 20:33:49 | mriedem | yeah i'll plan on that, | |
| 20:33:50 | mriedem | no rush | |
| 20:35:51 | efried | mriedem: I'm about to do some ka-shuffle-fu. Want me to fold that in? | |
| 20:36:26 | mriedem | no leave it to me | |
| 20:36:28 | mriedem | please | |
| 20:37:04 | mriedem | that also leaves you on the hook for reviewing it when i do it | |
| 20:38:21 | mikal | Deleted nova-net yet? | |
| 20:48:18 | mriedem | no | |
| 20:48:23 | mriedem | working on it | |
| 20:48:46 | mriedem | need to get https://review.openstack.org/#/c/549789/ going | |
| 20:49:02 | mriedem | but i have to go through the test failures there and figure out what (and how) to blacklist | |
| 20:49:12 | mriedem | mikal: ^ | |
| 20:49:38 | mriedem | the failures are mostly just due to stuff like not supporting security groups in the cells v1 api | |
| 20:50:16 | mriedem | https://review.openstack.org/#/c/225199/ would have handled that nicely but it got bogged down in committee | |
| 21:06:27 | edmondsw | does tagged_attach require the metadata service? Because cloud-init would only be an option during boot, not after, right? | |
| 21:10:05 | ameeda | Hi, I try to call heat template by rest api, when I try to do GET http:// |
|
| 21:10:28 | edmondsw | and by cloud-init I should have said config drive... | |
| 21:21:35 | mriedem | edmondsw: tagged attach does not require the metadata service, the tagged devices will show up in the metadata blob in the config drive | |
| 21:21:52 | mriedem | the config drive will only have the create-time tagged devices, correct | |
| 21:22:07 | edmondsw | mriedem config drive is available beyond the first boot? | |
| 21:22:07 | mriedem | if you need on-the-fly changes to tagged devices then you'd need the metadata service | |
| 21:22:15 | mriedem | no it's not | |
| 21:22:25 | edmondsw | ok, that's what I was thinking | |
| 21:23:29 | edmondsw | boo... but tx for confirming | |
| 21:23:57 | mriedem | now if you're using configuration strategy, | |
| 21:23:59 | mriedem | who knows | |
| 21:24:00 | mriedem | :) | |
| 21:24:35 | edmondsw | "configuration strategy"? | |
| 21:27:48 | mriedem | https://www.ibm.com/developerworks/community/forums/html/topic?id=1918efbc-ae12-44a3-8075-a6023831d334&ps=100 | |
| 21:28:49 | mriedem | https://www.ibm.com/support/knowledgecenter/en/SST55W_4.2.0/liaca/liacaimportingstrategy.html is better | |
| 21:29:43 | mriedem | i.e. config-drive for ibm i and aix images right? | |
| 21:30:41 | mriedem | boot me an ibm i guest with 500 volumes attached in a single call please | |
| 21:39:29 | openstackgerrit | Merged openstack/nova-specs master: Report CPU features to placement service by traits API https://review.openstack.org/497733 | |
| 21:41:42 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot https://review.openstack.org/543023 | |
| 22:03:13 | openstackgerrit | Merged openstack/nova-specs master: Express forbidden traits in placement API https://review.openstack.org/548915 | |
| 22:12:39 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Fix spec name for "report CPU features to as traits" https://review.openstack.org/552159 | |
| 22:12:58 | tasker | trying to instruct tox to run "nova.tests.unit.compute.test_compute_api" and it fails, complaining about being unable to import "nova.tests.unit.network.test_neutronv2", "nova.tests.unit.virt.test_block_device", and "nova.tests.unit.virt.test_imagecache". any quick thoughts on what I've done wrong? | |
| 22:13:00 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Fix spec name for "report CPU features as traits" https://review.openstack.org/552159 | |
| 22:13:16 | tasker | I've rebased my work on master a few minutes ago and still getting the above. | |
| 22:13:36 | mriedem | tasker: did you rebuild the tox venv? | |
| 22:13:40 | mriedem | tox -r -e py27 | |
| 22:13:55 | tasker | no. i was unaware of that. doing so now. | |
| 22:14:02 | mriedem | tox -r -e py27 -- nova.tests.unit.compute.test_compute_api | |
| 22:14:23 | edleafe | /away evening | |
| 22:14:26 | edleafe | doh! | |
| 22:26:54 | tasker | mriedem: that did the trick. thanks! | |
| 22:27:59 | tasker | now I just need to fix my test. | |
| 22:38:45 | openstackgerrit | Merged openstack/nova master: Make the nova-next job voting and gating https://review.openstack.org/549893 | |
| 22:50:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 22:50:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | |
| 22:50:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 22:50:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: compute: use port binding extended API during live migration https://review.openstack.org/551371 | |
| 22:50:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_bindings" network API method https://review.openstack.org/552170 | |
| 22:59:05 | openstackgerrit | Merged openstack/nova master: setup.cfg: Explicitly set [build_sphinx] builder https://review.openstack.org/508483 | |
| 22:59:17 | openstackgerrit | Merged openstack/nova master: Check the return code when forcing TCG mode with libguestfs https://review.openstack.org/524727 | |
| 22:59:28 | openstackgerrit | Merged openstack/nova master: Remove vestigial extra_info update in PciDevice.save() https://review.openstack.org/523919 | |
| 22:59:39 | openstackgerrit | Merged openstack/nova master: conf: Deprecate 'keymap' options https://review.openstack.org/483994 | |
| 23:01:21 | openstackgerrit | Eric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance after quiesce failure https://review.openstack.org/550865 | |
| 23:02:12 | tasker | with tests this time! | |
| 23:08:50 | openstackgerrit | Giridhar Jayavelu proposed openstack/nova-specs master: VMware: place instances on resource pool https://review.openstack.org/549067 | |
| 23:10:25 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Allow for merging traits and aggregates https://review.openstack.org/552122 | |
| 23:10:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Turn on new port binding extended live migrate flow https://review.openstack.org/552173 | |
| 23:20:00 | cfriesen | is it possible to query reviews that haven't been merged based on Change-Id? | |
| 23:20:57 | cfriesen | never mind, figured it out. works every time, post a question after digging for a while, then find it immediately after posting. | |
| 23:45:56 | Spazmotic | Morning friends | |
| 23:46:18 | Spazmotic | jianghuaw_, you home? :D I'm going to head to the gym, would like to talk to ya later! Has been too long! | |
| 23:47:04 | Spazmotic | cfriesen, you figure everything out? i've been digging Gerritt api all week so I feel pretty strong it lol | |
| 23:47:06 | Spazmotic | on it* | |
| #openstack-nova - 2018-03-13 | |||
| 00:11:19 | tasker | I just got through looking at my history via stackalytics and it has me associated with "*independent". the "how to change?" pop-out explains the rules of determining my association, but not really how to change it. on my launchpad.net profile, I don't see any field to change my company. am I missing something? | |
| 00:22:22 | openstackgerrit | Eric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance after quiesce failure https://review.openstack.org/550865 | |
| 00:27:24 | tasker | I guess I need to add my info to https://github.com/openstack/stackalytics/blob/master/etc/default_data.json and submit for review? | |