| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-09 | |||
| 12:09:01 | openstackgerrit | Merged openstack/nova master: hardware: Rework get_number_of_serial_ports https://review.openstack.org/407174 | |
| 12:16:23 | openstackgerrit | Thomas Goirand proposed openstack/nova master: Make nova build reproducible https://review.openstack.org/551269 | |
| 12:42:25 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | |
| 12:58:42 | Spaz-Work | This must be the most disgusting functional code i've ever written | |
| 13:34:34 | finucannot | bauwser, jaypipes: If you've time today, there's another two of those "clean up and document libvirt stuff" patches here that I'd really like to close out https://review.openstack.org/#/q/topic:feat/numa-refactor+status:open | |
| 13:38:57 | finucannot | zigo: If you can hang around a while longer, someone like dansmith might be able to help you out | |
| 13:39:24 | finucannot | If you'd a question on the libvirt driver, I'd be your guy. This stuff though...ummm... :) | |
| 13:40:38 | kashyap | Hi folks, can anyone double-confirm if this requires a spec? I hope not, it's a single change that introduces a config attribute: https://bugs.launchpad.net/nova/+bug/1750829 | |
| 13:40:39 | openstack | Launchpad bug 1750829 in OpenStack Compute (nova) "RFE: libvirt: Add ability to configure extra CPU flags for named CPU models" [Undecided,In progress] - Assigned to Kashyap Chamarthy (kashyapc) | |
| 13:41:34 | zigo | finucannot: Cheers ! | |
| 13:41:38 | zigo | I'll ask him then. | |
| 13:41:47 | zigo | Maybe late tonight after dinner. | |
| 13:42:08 | zigo | I may have something that works though, I've restarted my integration script, let's see ... | |
| 13:42:54 | finucannot | kashyap: I'd say a specless blueprint would be fine, but I can't make that call. Perhaps you could add it to open items section of the the agenda for next weeks meeting? | |
| 13:43:16 | finucannot | as apparently that's what you need to do to bring up a specless blueprint for review | |
| 13:43:30 | kashyap | finucannot: Hmm, okay. I'll look for the agenda etherpad | |
| 13:43:40 | finucannot | It's a wiki. Let me find the link | |
| 13:43:42 | kashyap | I'll just go & file the BluePrint, it doesn't hurt anyway | |
| 13:43:55 | finucannot | kashyap: https://wiki.openstack.org/w/index.php?title=Meetings/Nova | |
| 13:44:39 | kashyap | finucannot: Sláinte. | |
| 13:45:34 | finucannot | kashyap: I think 'go raibh maith agat' would be more appropriate. Sláinte is what you'd say when clinking drinks together ;) | |
| 13:45:47 | kashyap | finucannot: I know very much. I consciously chose "cheers" | |
| 13:45:48 | kashyap | :D | |
| 13:46:16 | kashyap | I was first writing the "Go...", but it was a bit wordy :D | |
| 13:47:03 | kashyap | finucannot: LOL, I barely drink. E.g. you can count on 2 fingers the numbers of beers I had in Dublin | |
| 13:47:17 | kashyap | (Or at most, count on one hand.) | |
| 13:47:52 | finucannot | I cannot say the same, heh. When in Dublin... | |
| 13:48:28 | kashyap | finucannot: Aside -- I take it that next meeting is on 15th | |
| 13:48:57 | finucannot | I think so but that will be the US timezone one | |
| 13:48:58 | finucannot | I think | |
| 13:49:15 | leakypipes | finucannot: I'm on it. | |
| 13:49:31 | finucannot | leakypipes: 🎉 | |
| 13:50:02 | finucannot | (Colourful emojis are hands down my favourite Fedora 27 feature) | |
| 13:50:04 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Don't wait for VNIC_TYPE_DIRECT plugged events during a hard reboot https://review.openstack.org/550046 | |
| 13:51:05 | kashyap | finucannot: Like these? ☁→❄→⛄→🌞→😃→☔→😢→⚰️ | |
| 13:51:39 | finucannot | That got dark real quick | |
| 13:51:40 | kashyap | ("Sad Story of the Snowman") | |
| 13:51:49 | finucannot | Poor Frosty | |
| 13:52:10 | leakypipes | lol | |
| 13:52:14 | kashyap | finucannot: Do you know you can even _name_ your virtual machine with the above unicode story? | |
| 13:52:20 | kashyap | (And libvirt will handle it just fine :D) | |
| 13:52:27 | leakypipes | thank god IRC can now compete with slack. | |
| 13:52:52 | kashyap | leakypipes: Don't get me started on Slack. They recently even ripped off IRC gateways. | |
| 13:53:12 | kashyap | :D | |
| 13:53:57 | leakypipes | giblet: mornin. hey, on that provider yaml spec thing... yeah, I've been working on a followup spec that shows the usage of it. I haven't publicized the provider yaml spec since it's just early thinking right now :) | |
| 13:58:28 | giblet | leakypipes: cool. I will read the follow up spec as soon as it is available :) | |
| 13:59:58 | giblet | leakypipes: if my -1 makes others not to read your spec then I have no problem going back to 0 | |
| 14:01:25 | leakypipes | giblet: oh no, not at all. was just letting you know there's a dependent spec in the works that should answer some of your questions | |
| 14:02:02 | giblet | leakypipes: OK | |
| 14:09:57 | openstackgerrit | Lee Yarwood proposed openstack/nova master: trivial: Rename reboot kwarg to hard_reboot https://review.openstack.org/551289 | |
| 14:10:34 | lyaaaaaaaarwood | sahid: ^ the s/reboot/hard_reboot/g follow up if you have time | |
| 14:12:26 | rabel | could someone please have a look at https://review.openstack.org/#/c/549166/ ? it is frustrating to put work in a commit, recieve a -1 (which imho does not make sense) and then do not get an answer afterwards | |
| 14:13:55 | rabel | i meant to post this one: https://review.openstack.org/#/c/549180/ | |
| 14:13:59 | rabel | the other one is for nova | |
| 14:14:25 | rabel | i no, i am in openstack-nova... sorry, messed up the irc channels | |
| 14:14:55 | rabel | ignore everything that i wrote after my first post | |
| 14:19:15 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add missing encryption_secret_uuid tests https://review.openstack.org/540679 | |
| 14:19:52 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/544238 | |
| 14:23:16 | mriedem | rabel: sounds like he was just asking for more information, probably didn't deserve a -1, but at the same time we've had a rash of random docs type changes where the intent isn't clear, like people changing http to https and just random shuffling of stuff to pad stats; | |
| 14:23:25 | mriedem | not saying you're doing that, i think i know what you're fixing and why, | |
| 14:23:29 | mriedem | but might have been why he asked | |
| 14:24:47 | Spazmotic | leakypipes thanks for the kidn words and the awesome review :) | |
| 14:25:03 | mriedem | rabel: rebase and i'll fast approve it | |
| 14:25:20 | rabel | mriedem: I understand that, although a lot of smilar changes I made already have been merged in the past. That's why I answered immediately a week ago. | |
| 14:25:35 | rabel | mriedem: thanks, i will do thi | |
| 14:26:03 | leakypipes | finucannot: reviews done. | |
| 14:26:08 | leakypipes | Spazmotic: no problemo. :) | |
| 14:27:49 | openstack | Launchpad bug 1751349 in OpenStack Compute (nova) pike "Keystone auth parameters cannot be configured in [keystone] section" [Undecided,Invalid] | |
| 14:27:49 | evrardjp | mriedem: It would be great if you could write why https://bugs.launchpad.net/nova/+bug/1751349 is invalid in your bug. | |
| 14:28:05 | finucannot | leakypipes: Thank you sir | |
| 14:28:09 | evrardjp | It's not mine, but ppl are asking for the why now, and they can't find evidence on the bug. | |
| 14:38:28 | mriedem | evrardjp: because it's fixed in queens | |
| 14:39:24 | mriedem | evrardjp: done | |
| 14:40:05 | evrardjp | thanks | |
| 14:42:14 | mriedem | evrardjp: np, thanks for saying something | |
| 14:44:03 | finucannot | leakypipes: So I'm clear, that's what y'all were suggesting when it came to the mypy integration, right? | |
| 14:44:11 | finucannot | add it as I wander around the codebase | |
| 14:46:13 | openstackgerrit | David Rabel proposed openstack/nova master: Fix indentation in doc/source/cli/* https://review.openstack.org/549166 | |
| 14:49:07 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Skip VNIC_TYPE_DIRECT port vif-plugged events during a hard reboot https://review.openstack.org/550046 | |
| 14:49:08 | openstackgerrit | Lee Yarwood proposed openstack/nova master: trivial: Rename reboot kwarg to hard_reboot https://review.openstack.org/551289 | |
| 14:51:00 | leakypipes | finucannot: yep. :) | |
| 14:51:06 | leakypipes | finucannot: I personally don't mind it. | |
| 14:51:09 | finucannot | Shhhhound | |
| 14:51:23 | openstackgerrit | Matthew Booth proposed openstack/nova master: WIP: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302 | |
| 14:51:48 | leakypipes | finucannot: but I didn't want to get in a situation where we were setting ourselves up for a bunch of busywork patches/reviews from folks and leading to rebase/merge hell | |
| 14:52:58 | finucannot | leakypipes: +1. This is something I want to use to help me understand the code. Adding it as I read said code makes sense | |
| 14:53:12 | leakypipes | yep | |
| 14:58:04 | openstackgerrit | Matthew Booth proposed openstack/nova master: WIP: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302 | |
| 15:01:04 | mriedem | finucannot: rabel: i think https://review.openstack.org/#/c/549166/ is good to go | |
| 15:03:08 | finucannot | mriedem: This doesn't make sense though. You need some form of hierarchy to illustrate these are different sections https://review.openstack.org/#/c/549166/2/doc/source/cli/nova-status.rst | |
| 15:03:24 | finucannot | At the very leas, the command names should be made into headers | |
| 15:03:26 | finucannot | *least | |
| 15:04:05 | finucannot | ditto for here https://review.openstack.org/#/c/549166/2/doc/source/cli/nova-manage.rst | |
| 15:12:57 | mriedem | finucannot: he's not completely re-writing the doc, and you don't *have* to have headers for these commands, they are separated by the formatting, | |
| 15:13:03 | mriedem | if you want to follow up with your own cleanup, then i think that's fine, | |
| 15:13:16 | mriedem | but i don't think we should block rabel's patch b/c of your opinion on how the doc should be formatted | |
| 15:13:56 | mriedem | as i recall, you were in the camp of "let's be fast and lenient on casual docs contributors" | |
| 15:14:37 | finucannot | Right, but not when they're regressions, which I consider this (in it's current form) to be | |
| 15:16:18 | finucannot | Eh, it's a -1, not a -2. That's my take on it. If someone else disagrees with me, I'm sure I'll deal with that. | |
| 15:16:28 | mriedem | what is this regressing? | |