| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-06 | |||
| 17:14:21 | mriedem | but only for multiattach volumes | |
| 17:14:28 | bauzas | yeah I understand that | |
| 17:14:29 | mriedem | this patch is also written to be backportable | |
| 17:14:37 | bauzas | but wow, it's a big call, right? | |
| 17:14:42 | mriedem | what is? | |
| 17:15:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'keymap' options https://review.openstack.org/483994 | |
| 17:15:14 | bauzas | every time we would disconnect the volume, we would have to call Cinder *and* verify all the instances | |
| 17:15:19 | stephenfin | mriedem: Done, good sir ^ | |
| 17:15:20 | bauzas | for the host | |
| 17:15:26 | mriedem | bauzas: for multiattach volumes yes | |
| 17:15:55 | mriedem | bauzas: the attached host for the volumes is in the cinder API, | |
| 17:16:15 | mriedem | but as discussed in the nova/cinder session last thursday, cinder is going to add an admin-only policy rule to not return that attached host information | |
| 17:16:17 | mriedem | so we can't rely on it here | |
| 17:16:33 | cfriesen | mnaser: write up a bug and poke mriedem to look at it since he's the neutron contact in the wiki. | |
| 17:16:44 | mriedem | if we did a kind of admin client thing for cinder, like we do for neutron port binding, we could get that information from cinder w/o going to the nova db to get the instances on this host | |
| 17:16:55 | mriedem | cfriesen: mnaser: it's not a bug | |
| 17:17:12 | mriedem | there was a spec from someone at some point about adding a delete_on_termination like flag for ports like we have for bdms | |
| 17:17:18 | mriedem | i can't find it anymore | |
| 17:17:20 | bauzas | mriedem: yeah I was thinking of that | |
| 17:17:22 | bauzas | but anyway | |
| 17:17:37 | bauzas | if you want to backport it, then it could be a problem if we ask Cinder to modify their API | |
| 17:17:48 | bauzas | so I think I'm +1, just need to verify the tests | |
| 17:17:54 | mnaser | the use-case is: user A booted an instance A, user A wants to move the port from instance A and instance B, they can't do it because a detach destroys the port and they need admin api to create ports with specific ips | |
| 17:18:57 | cfriesen | mnaser: currently I think you'd have to create the port first and hand it to nova when booting the instance. Then the detach should leave it around. | |
| 17:19:14 | mriedem | bauzas: if you want to read through the back and forth comments earlier in the review, there are several options here, but not backportable ones | |
| 17:19:17 | mnaser | cfriesen: yeah, but if you created an instance 2 years ago and never thought about this, it gets a bit hectic but yeah | |
| 17:19:28 | mriedem | bauzas: so we have this to backport to queens, it will work out of the box, no operator config needed to fix the bug, | |
| 17:19:28 | bauzas | mriedem: yeah, okay, anyway | |
| 17:19:37 | bauzas | yeah, I'm just writing that comment | |
| 17:19:46 | mriedem | we could optimize in the future if we can rely on cinder admin creds in nova.conf and can escalate our volume api calls like we do for neutron | |
| 17:20:12 | mriedem | that InstanceList.get_uuids_on_host() can also be optimized | |
| 17:20:46 | bauzas | ++ | |
| 17:21:41 | bauzas | mriedem: +Wd | |
| 17:22:30 | bauzas | we need another core for the dependent change https://review.openstack.org/#/c/549411/1 | |
| 17:23:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Update docs, API samples for noVNC 1.0.0 https://review.openstack.org/550173 | |
| 17:23:37 | openstackgerrit | Dan Smith proposed openstack/nova master: Add simple db purge command https://review.openstack.org/550171 | |
| 17:28:51 | mriedem | bauzas: thanks | |
| 17:31:04 | mriedem | dansmith: heh a bit of prior art https://blueprints.launchpad.net/nova/?searchtext=purge | |
| 17:31:29 | dansmith | heh | |
| 17:32:47 | mriedem | dansmith: is what you're doing different from what we had merged (in a spec) back in mitaka? https://review.openstack.org/#/c/200224/9/specs/mitaka/approved/purge-deleted-instances-cmd.rst | |
| 17:33:45 | dansmith | mriedem: it's similar although simpler | |
| 17:38:10 | openstackgerrit | git-harry proposed openstack/nova master: Fix version cap when no nova-compute started https://review.openstack.org/549737 | |
| 17:39:57 | mriedem | ok i marked 4 other blueprints as superseded against yours | |
| 17:40:35 | dansmith | I think that's pretty good evidence that we should do this thing :) | |
| 17:40:39 | mriedem | dansmith: we should throw it on the nova meeting agenda for thursday, per the process for specless blueprints; i don't expect issues, but thems the rules | |
| 17:40:50 | mriedem | yeah i know | |
| 17:40:59 | dansmith | aye | |
| 17:41:24 | jaypipes | melwitt, mriedem, dansmith: attempting to summarize scheduler/placement decisions and priorities here: https://etherpad.openstack.org/p/rocky-ptg-scheduler-placement-summary. Your feedback welcome. | |
| 17:41:29 | mriedem | dansmith: are there going to be more than 1 patch? in dublin i thought you were talking about a series | |
| 17:42:08 | dansmith | mriedem: that one patch is the meat.. I have at least one other little glue patch to make archive purge when it's done, which I'll have up in a few | |
| 17:46:01 | openstackgerrit | Dan Smith proposed openstack/nova master: Add --purge helper flag to archive_deleted_rows https://review.openstack.org/550182 | |
| 17:46:07 | dansmith | mriedem: that ^ | |
| 17:46:19 | mriedem | ok that's what i was thinking of | |
| 17:46:25 | mriedem | otherwise you have the 2 step dance | |
| 17:46:28 | dansmith | yeah | |
| 17:54:48 | dansmith | mriedem: this week's meeting is early so I won't be there, but I put it on the agenda | |
| 17:59:20 | mriedem | dansmith: yeah i can proxy | |
| 17:59:22 | mriedem | assuming i'm there | |
| 17:59:28 | dansmith | sweet | |
| 17:59:58 | mriedem | jaypipes: ok - mel is out this week, and i'm not sure about the relative priority of all of those things (or doability) | |
| 18:00:11 | mriedem | efried reviewing that would be good too but he's also on vacation this week | |
| 18:00:13 | mriedem | lazy bums | |
| 18:00:46 | mriedem | the only thing on the 'merge update_provider_tree' stuff is the whole explosion on friday about merging traits and who owns what and all that | |
| 18:01:03 | jaypipes | mriedem: totes... the priority was totally a "just dump these out from my brain" thing | |
| 18:01:21 | mriedem | re numa, it seems like there were 10 different things for numa in the etherpads | |
| 18:01:26 | mriedem | i blacked out during the numa disussions | |
| 18:01:34 | jaypipes | mriedem: and ack on the merge traits dilemma. I've got a proposal coming around handling that | |
| 18:10:05 | dansmith | mriedem: which jobs does the post_test_hook.sh get run on? | |
| 18:11:09 | mriedem | dansmith: nova-next | |
| 18:11:17 | dansmith | oh only that one? | |
| 18:11:19 | mriedem | dansmith: comments in your bottom patch | |
| 18:11:21 | mriedem | dansmith: yeah | |
| 18:11:36 | dansmith | okay, I was assuming it'd be all tempest/devstack jobs | |
| 18:11:40 | mriedem | dansmith: we could run it on more, but likely just the jobs we define in-tree for now | |
| 18:12:14 | mriedem | btw, i have a patch up to make nova-next voting/gating | |
| 18:12:30 | mriedem | https://review.openstack.org/#/c/549893/ | |
| 18:12:36 | dansmith | it's not a big deal I guess, but the more configs we run it on, the more likely we are to notice some weird piece of data that fails | |
| 18:12:54 | mriedem | so if archive fails or we leak allocations in placement, we're likely to not notice that unless the job fails | |
| 18:16:07 | sean-k-mooney | jaypipes: on the placement/scheduler topic for rocky. we did not really discuss it but i assume finishing sharing resouce providers is on the list somewhere? | |
| 18:17:36 | sean-k-mooney | jaypipes: i know that was started on for queens but not sure whate was done/outstanding | |
| 18:28:30 | mriedem | jaypipes: ok left some notes; looking over the ptg etherpad for placement, i think you got all of the AGREE/TODO/ACTION items except for stephenfin's item about writing a spec for live migratoin for cpu-pinned instances (i added that to your etherpad) | |
| 18:29:33 | artom | mriedem, after secret Red Hat discussions, that one's mine, actually | |
| 18:29:47 | mriedem | ack | |
| 18:34:26 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP] Add CellMappingList.get_all_enabled() query method https://review.openstack.org/550188 | |
| 18:35:08 | mriedem | dansmith: jaypipes: can one of you +W this so i can get these fixes merged and start backports? https://review.openstack.org/#/c/549411/ | |
| 18:35:58 | dansmith | mriedem: I want to argue about that one | |
| 18:44:36 | dansmith | mriedem: hmm, I wonder if that archive test isn't working anymore after the superconductor layout change | |
| 18:44:37 | dansmith | it's archiving only a few rows | |
| 18:44:38 | dansmith | probably from cell0 | |
| 18:46:08 | jaypipes | sean-k-mooney: I'll add something about the sharing providers stuff if I can deduce something actionable from the notes | |
| 18:51:06 | openstackgerrit | Dan Smith proposed openstack/nova master: Add --purge helper flag to archive_deleted_rows https://review.openstack.org/550182 | |
| 18:51:06 | openstackgerrit | Dan Smith proposed openstack/nova master: Add simple db purge command https://review.openstack.org/550171 | |
| 18:51:07 | openstackgerrit | Dan Smith proposed openstack/nova master: Run post-test archive against cell1 https://review.openstack.org/550194 | |
| 18:59:48 | jgriffith | mriedem: gahh... sorry, was tied up, but thanks for fixing up those tests and such | |
| 19:07:33 | mriedem | dansmith: yeah probably, we could use https://review.openstack.org/#/c/507486/ | |
| 19:08:00 | dansmith | mriedem: okay well I put up a patch ^ to call it with the proper config | |
| 19:10:36 | mriedem | dansmith: i don't think that's going to work, | |
| 19:10:42 | mriedem | we don't set [database] in nova-cpu.conf | |
| 19:10:44 | mriedem | on purpose | |
| 19:10:54 | dansmith | oh, right | |